| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Because of this I'm also refactoring some code that before
was using wstring to build command lines by hand instead of
using the CommandLine class. Now we use CommandLine.
To get this to work correctly, I also needed to fix CommandLine::AppendArguments so I added a little test for it.
TEST=There should be no changes in functionality. Run all installer tests.
BUG=61609
Review URL: http://codereview.chromium.org/4928002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66088 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
const NSString* -> NSString* const.
TBR=thakis@chromium.org
BUG=24462, 62597, 62763
TEST=none
Review URL: http://codereview.chromium.org/4979002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66087 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Exception name |NSInternalInconsistencyException| reason "Invalid
parameter not satisfying: (index >= 0) && (index < [_Itemarray
count])" is seen in many crashes, and has become more prevalent in
9.0. It appears corrlated with bug 62597. This change causes that
exception to CHECK() and generate a crash dump immediately.
BUG=24462, 62597, 62763
TEST=none
Review URL: http://codereview.chromium.org/4752007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66086 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66077 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=trybots
Review URL: http://codereview.chromium.org/4976001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66070 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
I hit this DCHECK and didn't know if it was telling me that initialization
failed or that initialization had already happened.
TEST=compiles
Review URL: http://codereview.chromium.org/4882005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66067 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This regressed in r59021. I think I can fix it in a cleaner way
with some refactoring, but for now since I want to cherry-pick this
onto older branches let's revert some of r59021 to fix this in
the simplest way possible.
BUG=59824
TEST=manual (will write a test in my followup that refactors it)
Review URL: http://codereview.chromium.org/4911002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66066 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66065 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1) Fix our heuristics to not be terribly wrong, while discouraging their use. If the theme author doesn't specify colors in the form of ChromeGtkFrame::frame-color, use the old MetaFrames/selection color fallback (tinting slightly darker).
2) Give the ChromeGtkFrame several optional widget style properties allowing theme authors to explicitly specify colors for the frame and scrollbars, and control the gradient on top of the chrome frame.
TODO: Do we want to let theme authors override the close/min/max button images?
BUG=62377, 35317
TEST=for now, compiles, as the needed data hasn't been added by theme authors.
Review URL: http://codereview.chromium.org/4715005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66064 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Welcome screen uses different style of buttons.
BUG=chromium-os:8468
TEST=none
Review URL: http://codereview.chromium.org/4402001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66061 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Implemented left margin. Also implemented fade out in the end of the
label.
BUG=chromeos:7896
TEST=Compare with the mocks from the issue.
Review URL: http://codereview.chromium.org/4708010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66060 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Employ BubbleWindow with throbber for proxy settings dialog.
BUG=http://crosbug.com/7322
TEST=Manual
Review URL: http://codereview.chromium.org/4841005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66057 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66055 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Use 'Sing in' label instead of the long one.
BUG=chromium-os:9084
TEST=manual
Review URL: http://codereview.chromium.org/4817002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66053 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
demonstating the feature.
Also fixed some lint issues.
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/4855004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66052 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=62341
TEST=None
Review URL: http://codereview.chromium.org/4898001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66051 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=63045
TEST=none
TBR=darin
Review URL: http://codereview.chromium.org/4964001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66049 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
mocks.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/4943001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66042 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
to properly
redirect to partner payment portal when we run out of plan. Changed usage notification
to display "More info..." instead of "Buy plan".
BUG=chromium-os:8745, chromium-os:8724, chromium-os:8853, chromium-os:8685
TEST=see listed bugs for details
Review URL: http://codereview.chromium.org/4699004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66039 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=darin
Review URL: http://codereview.chromium.org/4951001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66038 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=darin
Review URL: http://codereview.chromium.org/4949002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66037 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Otherwise they hit a base::ThreadRestrictions::AssertIOAllowed() assertion.
Introduced MimeRegistryDispatcherHost for code sharing among renderer_host and worker_host.
BUG=62601
TEST=none
Review URL: http://codereview.chromium.org/4857001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66035 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=57053
TEST=None.
TBR=nrettw@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66034 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=60632
TEST=trybots
Review URL: http://codereview.chromium.org/4893001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66033 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Need to fix RequestPause/RequestResume before turning this back on, else we
run into data races checking the model type information.
BUG=62880
TEST=none
TBR=tim
Review URL: http://codereview.chromium.org/4810003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66032 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This adds the screen locker window to its own window group,
preventing GTK widgets from other windows from grabbing the
focus from it. (Otherwise, we intentionally crash when we
see the focus get stolen to prevent Chrome from accepting
input into other windows while the screen is locked.)
BUG=chromium-os:8999
TEST=ran "setTimeout(function() { alert(); }, 2000)" in a JS console, locked the screen, and checked that we no longer crash
Review URL: http://codereview.chromium.org/4908001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66029 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=37891
TEST=trybots
Review URL: http://codereview.chromium.org/4825002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66028 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
button.
BUG=61500
TEST=none
Review URL: http://codereview.chromium.org/4922001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66025 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
immediately after creating a new window need to wait for it to be "ready" on
linux.
**remake of issue4838001 (nuked client, long story)
BUG=62783,44203
Review URL: http://codereview.chromium.org/4931001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66024 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
to not crash anymore.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/4869001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66023 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
It requires flash 10.1.103.19 or better, the current
flash in trunk is 10.1.103.20 so we are fine.
BUG=50796
TEST=see bug
Review URL: http://codereview.chromium.org/4870001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66022 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/4884003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66020 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66019 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/4923001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66013 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/4900003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66011 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Creates an enumeration histogram called Extensions.AppsPromo with the following buckets:
0: launched an application from the promo
1: launched the web store from the promo
2: manually closed the promo (and uninstalled the applications)
3: promo expired
BUG=61017
TEST=
Review URL: http://codereview.chromium.org/4708002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66006 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* CopyBackground that copies the background from other view.
* Updated NewUserView to use CopyBackground.
I couldn't use this for existing_user_view as surrounding area is rendered by another window.
BUG=chromium-os:8101
TEST=Check username/password fields on new user pods and password field on screen locker have the same background as surrounding area.
Review URL: http://codereview.chromium.org/4882003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66004 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Remove the hack we used for checking that plugins didn't
regress, as this is a generalization of that idea.
Review URL: http://codereview.chromium.org/4161004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66003 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:9019
TEST=manual
Review URL: http://codereview.chromium.org/4842002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66001 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3358019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65999 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
(http://src.chromium.org/viewvc/chrome?view=rev&revision=65869).
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/4877003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65998 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=62991
TEST=unit and sync integration
Review URL: http://codereview.chromium.org/4905001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65991 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=62611
TEST=man chrome/app/resources/manpage.1.in
Review URL: http://codereview.chromium.org/4875001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65990 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
blocked plugins, which it hasn't done since r62146, and there are no firm plans to do so in the future.
This is important because http://codereview.chromium.org/4767001/ is going to make calling RemoveInfoBar() with a non-showing delegate an error, and it seems better to just remove all this code if it's not doing anything than to neuter parts of it.
BUG=62154
TEST=none
Review URL: http://codereview.chromium.org/4863001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65984 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:8780
TEST=manual
Review URL: http://codereview.chromium.org/4907002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65983 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This speeds up the resizing portion of thumbnailing from 40ms->15ms on my linux z600 at nearly fullscreen resolution. Thumbnail resizing times on weaker hardware (like netbooks) has been observed in the 150ms+ range, so hopefully this is a proportional speedup there as well.
TEST=none
BUG=62820
Review URL: http://codereview.chromium.org/4846002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65982 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=63009
TEST=None.
Review URL: http://codereview.chromium.org/4909001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65980 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=62850
TEST=web store promo should never appear on Chrome OS
Review URL: http://codereview.chromium.org/4901001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65978 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=61998
TEST=ExtensionApiTest.Messaging
Review URL: http://codereview.chromium.org/4708006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65977 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/4852001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65975 0039d316-1c4b-4281-b951-d872f2087c98
|