| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
| |
BUG=46797
TEST=Mac valgrind stays green
Review URL: http://codereview.chromium.org/2849020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50675 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Use the same algorithm for rewriting the window open disposition as we use for link clicking.
BUG=47190
TEST=manual; unit tests
Review URL: http://codereview.chromium.org/2807016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50674 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This ties up that loose end I mentioned in http://codereview.chromium.org/2747011 (I had put this off because I expected it would require slightly more effort).
BUG=29281
TEST=manual
Review URL: http://codereview.chromium.org/2844017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50673 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2848012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50672 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
PepperPluginRegistry and pepper::PluginModule.
Used Chromoting's plugin as the first attempt at using this interface.
BUG=none
TEST=compiles
Review URL: http://codereview.chromium.org/2843018
TBR=ajwong@chromium.org
Review URL: http://codereview.chromium.org/2834021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50671 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
just stdout.
Review URL: http://codereview.chromium.org/2826014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50668 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
pepper::PluginModule.
Used Chromoting's plugin as the first attempt at using this interface.
BUG=none
TEST=compiles
Review URL: http://codereview.chromium.org/2843018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50667 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=38736
TEST=none
Review URL: http://codereview.chromium.org/2860016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50666 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=643
TEST=none
Review URL: http://codereview.chromium.org/2799029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50665 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Rename Canvas to CanvasSkia.
- Create a subclass Canvas that inherits from CanvasSkia for compatibility.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2862025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50664 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
functionality, if it is ever added.
This placeholder is needed in the meantime so that some specific builds can have this preference pre-set before the feature(s) ever exist.
R=cpu
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2827020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50663 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Helpful when the browser itself is a child process (e.g. of pyauto).
BUG=none
TEST=Run Chrome with --wait-for-debugger. Make sure it waits for debugger.
Review URL: http://codereview.chromium.org/2826015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50662 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
installed.
Review URL: http://codereview.chromium.org/2831020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50656 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
These URLs are handled by a plugin that is registered to the
chrome-internal-plugin/remoting MIME type.
BUG=none
TEST=verify plugin is loaded when navigating to chrome://remoting
Review URL: http://codereview.chromium.org/2812017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50655 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50653 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Rather than scattering init calls through the code, just inititialize
it once. (In particular, the gnome-keyring support also needs this
function called, and I didn't want to copy it one more time.)
TEST=no threading-related crash during gnome-keyring startup
Review URL: http://codereview.chromium.org/2873015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50652 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=No behavioral change; plugins should continue to work.
Review URL: http://codereview.chromium.org/2866014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50650 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
It was using the context made current with ggl::MakeCurrent before. The new design is more consistent with other SwapBuffers implementations.
Already reviewed in a previous CL:
http://codereview.chromium.org/2802007/show
TEST=try
BUG=none
TBR=vangelis@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50649 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Attempting to resubmit this change. It looks like the reason for the build break on linux was a missing dependency (nss) in the interactive_ui_test target.
BUG=32410
TEST=unittests
Review URL: http://codereview.chromium.org/2828021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50646 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
the test plugins. (TTF)
BUG=29900
TEST=none
Review URL: http://codereview.chromium.org/2864019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50644 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
is clicked so wm knows which one to select.
BUG=cros:2318
TEST=With new wm tooltips should appear above user image and label on
unselected user pod.
Review URL: http://codereview.chromium.org/2856014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50643 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Breaks it up into 4 different classes instead of 1 class full of switches and if
statements.
BUG=none
TEST=unit_tests.TranslationInfoBarTest
Review URL: http://codereview.chromium.org/2815013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50641 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
This way, the code is standards-compliant _and_ makes clang happy.
Review URL: http://codereview.chromium.org/2870023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50640 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=did a clean compile of syncapi
TBR=mark
Review URL: http://codereview.chromium.org/2853013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50638 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
between runs."
This reverts commit f98a0891c5baa2bc173fd93f22c18d5686d2c810 / revision 50623.
Review URL: http://codereview.chromium.org/2856015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50627 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=44688
Review URL: http://codereview.chromium.org/2841013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50623 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL fixes following issues:
BUG=23219 IME should be disabled in password box.
BUG=41876 Chinese IME is still active when current focus is not a text input control
BUG=44529 Clause segmentation information of composition text is not honored when using CJK input methods.
BUG=46326 Clicking during a composition cancels it
TEST=See individual bug report.
This CL is blocked on webkit bug: https://bugs.webkit.org/show_bug.cgi?id=40608
Review URL: http://codereview.chromium.org/2824015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50622 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
for every time I hated a CR LF, I'd buy fancy overpriced cupcakes for everyone on Chrome.
BUG=45869
TEST=none
Review URL: http://codereview.chromium.org/2831025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50621 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50619 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
"!" that reversed the logic of the code.
Review URL: http://codereview.chromium.org/2825017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50616 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Found by clang.
Review URL: http://codereview.chromium.org/2840017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50614 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
that I wasn't setting a field in a default: of a switch where I have
a NOTREACHED.
Moves cut/copy/paste and increment/descrement/fullscreen into buttons
on views.
BUG=45734
TEST=none
TBR=jcivelli@chromium.org
Review URL: http://codereview.chromium.org/2868029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50613 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=TopSitesTest, HistoryBackendTest, ThumbnailDatabaseTest, HistoryTest
Review URL: http://codereview.chromium.org/2869018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50610 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
buttons
on views.
BUG=45734
TEST=none
Review URL: http://codereview.chromium.org/2803013
TBR=sky@chromium.org
Review URL: http://codereview.chromium.org/2829021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50608 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Parameterize tab strip layout so it can be vertical in addition to horizontal without breaking up the code too much. Abstracted some of the side tab knowledge into TabWindowController with overrides in BrowserWindowController.
Nib change: added a SideTabStripView custom view to BrowserWindow and hooked it to an outlet. Renamed the outlets to better reflect both views.
BUG=44773
TEST=Tab layout, full screen, dragging tabs within and to other windows to make sure they reflow and draw correctly. Side tabs themselves are still behind a flag, but this cl touches many normal codepaths.
Review URL: http://codereview.chromium.org/2846028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50606 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
on views.
BUG=45734
TEST=none
Review URL: http://codereview.chromium.org/2803013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50604 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50603 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Fixes problem introduced in http://codereview.chromium.org/2659004/show.
BUG=46710
TEST=Bring up a regular window, and an incognito window. Install theme from incognito window. Note that loading bubble disappears at the proper time.
Review URL: http://codereview.chromium.org/2823025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50602 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Added initial_timezone=Asia/Tokyo attribute to the test manifest.
BUG=http://crosbug.com/1761
TEST=Run out/Debug/chrome --login-manager --startup-manifest=chrome/browser/chromeos/testdata/startup_manifest.json. Press Ctrl+Alt+U to switch to update screen. Clock in status area should display Tokyo time.
Review URL: http://codereview.chromium.org/2834018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50601 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=47199
TEST=none
Review URL: http://codereview.chromium.org/2866015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50600 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Fix bookmark editor size regression because the controls on it are
not visible and caused gtk_util::ShowDialog get the wrong size;
- Host hung monitor dialog in a Chrome window as other dialogs;
BUG=none
TEST=Verify "Add Page" or "Edit" bookmark dialog shows up correctly and verify that hung monitor shows up in a chrome window instead of full screen.
Review URL: http://codereview.chromium.org/2808021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50599 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
in history is for bookmark-related stuff (the bookmarks system is still wstring-based).
The substantial change here is in RTL to make a string16 variant of the functions and in changing the WordIterator to use string16 (this cleaned up some weird utf-32 code).
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/2808017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50597 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=none
TEST=this is it
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50596 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
MesssageBubble was propagating event to the parent,
which caused problem in screen locker. This change is
harmless in login screen.
Fix a cut&paste error in CHECK in grab broke handler.
BUG=chromium-os:4213
TEST=see bug for intstruction to reproduce the crash. This should fix the crash.
Review URL: http://codereview.chromium.org/2811022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50595 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/2876002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50590 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
On the Linux platform policies are read from a configuration file directory. Depending whether the chromium build is branded or not the configuration file directory is:
/etc/opt/chromium or
/etc/opt/chrome
The configuration file directory will contain two sub-subdirectories: policies/managed
policies/recommended
The sub-directory policies/managed will contain all managed policies that are enforced on the user.
The sub-directory policies/recommended will contain policies for recommended setting that can be changed by a user.
BUG=47278
TEST=manual
Review URL: http://codereview.chromium.org/2854005
Patch from Markus Heintz <markusheintz@google.com>.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50589 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50583 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=DevToolsSanityTest.TestHeapProfiler
BUG=none
Review URL: http://codereview.chromium.org/2846019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50581 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=finnur
Review URL: http://codereview.chromium.org/2842020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50580 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
r50577 (WebKit roll) changed parsing behavior.
BUG=none
TEST=This is a test.
TBR=finnur
Review URL: http://codereview.chromium.org/2835016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50579 0039d316-1c4b-4281-b951-d872f2087c98
|