summaryrefslogtreecommitdiffstats
path: root/chrome
Commit message (Collapse)AuthorAgeFilesLines
* windows: Theme the popup window with the incognito theme when we are in the ↵jhawkins@chromium.org2010-02-241-4/+8
| | | | | | | | | | | | | | incognito mode. BUG=20373 TEST=see bug Patch by Thiago Farina <thiago.farina@gmail.com> Original review at http://codereview.chromium.org/606060 Review URL: http://codereview.chromium.org/657042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39844 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Fix themes for fullscreen windows.rohitrao@chromium.org2010-02-241-0/+9
| | | | | | | | BUG=None TEST=Omnibox focus ring for fullscreen windows should not be black. Review URL: http://codereview.chromium.org/657053 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39842 0039d316-1c4b-4281-b951-d872f2087c98
* Preparation for mac content confirmation dialog. More tidy in general as well.thakis@chromium.org2010-02-242-2/+20
| | | | | | | | | | Patch mostly by sky. BUG=34894 Review URL: http://codereview.chromium.org/652178 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39840 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting the revert, reinstating 39825. ↵avi@chromium.org2010-02-247-53/+81
| | | | | | FindBarTextFieldCellTest.FocusedDisplay is flaky. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39834 0039d316-1c4b-4281-b951-d872f2087c98
* Don't report the language if the CLD reports it as unreliable or if the text ↵jcampan@chromium.org2010-02-243-3/+26
| | | | | | | | | | | | | is too short. That might trigger a translate infobar with the wrong language, it is better to show none. BUG=36593 TEST=Open the pages reported in the bug. No translate infobar should be shown. Review URL: http://codereview.chromium.org/652144 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39833 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting r39825.avi@chromium.org2010-02-247-81/+53
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39830 0039d316-1c4b-4281-b951-d872f2087c98
* Update TOSlaforge@chromium.org2010-02-2442-2906/+2862
| | | | | | Review URL: http://codereview.chromium.org/657039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39829 0039d316-1c4b-4281-b951-d872f2087c98
* Landing Chris Guillory CL.jcampan@chromium.org2010-02-243-30/+38
| | | | | | | | | | | | See original review at: http://codereview.chromium.org/626014/show BUG=None TEST=None Review URL: http://codereview.chromium.org/657020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39828 0039d316-1c4b-4281-b951-d872f2087c98
* Next batch of changes to kill GTMTheme.avi@chromium.org2010-02-247-53/+81
| | | | | | | | | | BUG=http://crbug.com/35554 TEST=no visible change in normal mode; incognito mode still being worked on Review URL: http://codereview.chromium.org/652179 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39825 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Register for screen changed notifications and resize the fullscreen ↵rohitrao@chromium.org2010-02-244-29/+77
| | | | | | | | | | window appropriately. Also register for main status notifications, allowing us to move some code out of BWC and into FSC. BUG=None TEST=Fullscreen a window on a 1024x768 monitor. Go into display preferences and change the monitor resolution to something higher. The fullscreen window should continue to fill the whole screen. Review URL: http://codereview.chromium.org/656020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39820 0039d316-1c4b-4281-b951-d872f2087c98
* ProxyConfig behaved like a struct, but was defined as a class.eroman@chromium.org2010-02-244-39/+35
| | | | | | | | | Changed it to be a proper class with hidden implementation variables, setters etc. Also seized this opportunity to move the bypass list from being a member of ProxyConfig, to being a member of ProxyRules. This is a more correct hiearchy, since the bypass rules only apply to the manual settings. Lastly, this makes it possible to have the manual rules evaluation be a method on ProxyRules, and shift some more code out of proxy_service. Review URL: http://codereview.chromium.org/651070 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39818 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: handle dom_ui-generated download drag events.estade@chromium.org2010-02-246-29/+135
| | | | | | | | | BUG=36512 TEST=drag a file out of the downloads page Review URL: http://codereview.chromium.org/657026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39815 0039d316-1c4b-4281-b951-d872f2087c98
* Fix wrapping on extensions page (for locale nl).finnur@chromium.org2010-02-231-0/+2
| | | | | | | | | BUG=32402 TEST=See bug. Review URL: http://codereview.chromium.org/657024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39806 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes Issue 34722: Meaningless value in 'Save as type' combobox of 'Save ↵georgey@chromium.org2010-02-233-8/+133
| | | | | | | | | | | | page as...' dialog Adds extension base don MIME type of the page. Adds capability of the complete save of the "application/xhtml+xml" pages BUG=34722 TEST=In the bug + try pages with other MIME types, such as "text/xml", "text/plain" or "text/css" Review URL: http://codereview.chromium.org/650176 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39804 0039d316-1c4b-4281-b951-d872f2087c98
* linux: Show an icon to the right indicating if the host is valid or not.erg@chromium.org2010-02-232-18/+39
| | | | | | | | | | BUG=34181 TEST=open the exceptions editor, type some text in the host textfield, see the indication. Review URL: http://codereview.chromium.org/650122 Patch from thiago.farina@gmail.com. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39802 0039d316-1c4b-4281-b951-d872f2087c98
* Remove FormField::priority as it's not used by AutoFill++.jhawkins@chromium.org2010-02-236-19/+0
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/657015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39799 0039d316-1c4b-4281-b951-d872f2087c98
* Remove dead code from AutoFill++ that are vestiges of the toolbar autofill.jhawkins@chromium.org2010-02-233-10/+1
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/652165 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39798 0039d316-1c4b-4281-b951-d872f2087c98
* When building the accept-language list for translation, exclude Englishjshin@chromium.org2010-02-231-2/+13
| | | | | | | | | | | | | | | | unless the UI language is English. This is a temporary measure until we're sure that removing English from the default value of A-L for most non-English locale is safe in terms of web compatibility. BUG=36182 TEST=1. Run Chrome in English and go to any English page. Translation info-bar does not show up. 2. Run a non-English version of Chrome and go to any English page. Translation info-bar does show up. Review URL: http://codereview.chromium.org/652138 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39794 0039d316-1c4b-4281-b951-d872f2087c98
* Rename constants to be consistent with the names used inagl@chromium.org2010-02-231-4/+4
| | | | | | | | | | | | | | sandbox/linux/suid/sandbox.c, in order to make the source more greppable. With inconsistent constant names it was harder to find who sends the message that sandbox.c receives. http://codereview.chromium.org/652108 (Patch from mseaborn@chromium.org) git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39793 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 39779 - Part of http://codereview.chromium.org/650206thakis@chromium.org2010-02-231-3/+1
| | | | | | | | | Review URL: http://codereview.chromium.org/657004 TBR=thakis@chromium.org Review URL: http://codereview.chromium.org/657022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39790 0039d316-1c4b-4281-b951-d872f2087c98
* These changes connect the AutoFill UI on the Mac with the back-end data ↵dhollowa@chromium.org2010-02-2326-214/+1279
| | | | | | | | | | | | | | | | | | | | | | | | store. Changes to a user's address and credit card information are now persisted. Other changes are: - Selectively disables the preferences "Setup autofill..." button when the PersonalDataManager is not available. - Allows the user to add or remove address or credit card entries in the AutoFill dialog. - The billing and shipping popup menus in the credit card entries now properly reflect the list of addresses. Notes on nib changes: - AutoFillAddressFormView.xib : added Delete button, wired to trigger |deleteAddress:| action. - AutoFillDialog.xib changed window size to encompass new controls. Added "Add Address" and "Add Credit Card" buttons. Wired them up to |addNewAddress:| and |addNewCreditCard:| actions, respectively. - Preferences.xib : |autoFillSettingsButton_| outlet wired up to facilitate disabling when no |PersonalDataManager| is available. - AutoFillCreditCardFormView.xib : added "Delete" button and wired up to |deleteCreditCard:| action. Removed outlets to menus that were only there for temporary disablement reasons. Set up bindings for billing and shipping address menu items and for their selected item. BUG=33029 TEST=unit_tests --gtest_filter=AutoFillDialogControllerTest.* Note new: Google Test filter = AutoFillDialogControllerTest.*:AutoFillAddressModelTest.*:AutoFillAddressViewControllerTest.*:AutoFillCreditCardModelTest.*:AutoFillCreditCardViewControllerTest.*:DisclosureViewControllerTest.*:SectionSeparatorViewTest.*:VerticalLayoutViewTest.* Review URL: http://codereview.chromium.org/650163 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39787 0039d316-1c4b-4281-b951-d872f2087c98
* Adjust Page Load Time histograms in A/B testsjar@chromium.org2010-02-231-59/+21
| | | | | | | | | | | | | | We're focusing on StartToFinish rather than StartToFinishDoc for PLT tests. I pulled out teh StartToFinishDoc histograms, and added one more modulated histogram to look at ratios of forward to back in various test scenarios. I also removed the A/B tests for delayed binding. r=willchan Review URL: http://codereview.chromium.org/657006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39786 0039d316-1c4b-4281-b951-d872f2087c98
* New status bar images for ChromeOS.chocobo@chromium.org2010-02-2325-19/+99
| | | | | | | | | Added icons to network options page. TEST=none BUG=none Review URL: http://codereview.chromium.org/657001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39784 0039d316-1c4b-4281-b951-d872f2087c98
* Archive and upload pyauto artifacts for Linuxnirnimesh@chromium.org2010-02-231-0/+2
| | | | | | | | | BUG=36498 TEST=Should see _pyautolib.so & pyautolib.py in http://build.chromium.org/buildbot/continuous/linux/LATEST/chrome-linux.test/ Review URL: http://codereview.chromium.org/652155 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39782 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 39732 due to reliability bot failures.darin@chromium.org2010-02-233-24/+3
| | | | | | | | | | | | Sometimes there is not a current context. TBR=jochen BUG=36600 TEST=none Review URL: http://codereview.chromium.org/652158 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39780 0039d316-1c4b-4281-b951-d872f2087c98
* Part of http://codereview.chromium.org/650206thakis@chromium.org2010-02-231-1/+3
| | | | | | Review URL: http://codereview.chromium.org/657004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39779 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a crash in FormStructure when parsing a form with zero fields. Use ↵jhawkins@chromium.org2010-02-231-4/+5
| | | | | | | | | | field_count() instead of directly accessing the size of |fields_| because we NULL-terminate the field vector. BUG=none TEST=fox.com/24 doesn't crash the browser. Review URL: http://codereview.chromium.org/657010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39778 0039d316-1c4b-4281-b951-d872f2087c98
* Make unit_tests NSMenuItemAdditionsTest.TestMOnDifferentLayouts pass on Macmark@chromium.org2010-02-231-17/+13
| | | | | | | | | | | | OS X 10.6. 10.6 adds two new keyboard layouts where the "m" key has a different key code than expected. These layouts are "Dvorak - Left" and "Dvorak - Right". TEST=unit_tests '--gtest_filter=NSMenuItemAdditionsTest.*' on 10.6 BUG=34784 Review URL: http://codereview.chromium.org/652151 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39776 0039d316-1c4b-4281-b951-d872f2087c98
* Enable building pyauto for linuxnirnimesh@chromium.org2010-02-231-1/+2
| | | | | | Review URL: http://codereview.chromium.org/656018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39772 0039d316-1c4b-4281-b951-d872f2087c98
* Move cookie handling to login successdavemoore@chromium.org2010-02-232-5/+2
| | | | | | | | | BUG=chromium-os:1625 TEST=Login and go to gmail and confirm you don't need to login again. Review URL: http://codereview.chromium.org/657005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39771 0039d316-1c4b-4281-b951-d872f2087c98
* Displaying a JavaScript message box (such as an alert) fromjcampan@chromium.org2010-02-233-6/+9
| | | | | | | | | | | | | | | | | | | | | an extension popup was causing the popup to lose focus and be dismissed, causing other problems. This CL fixes it on Windows with the following: - the message box is now parented to the popup, not the tab - the popup is not disimissed when losing focus to a window for which it is the owner. BUG=29147 TEST=Create an extension with a popup that contains a combo-box and a button to show an alert and confirm box. Click on the combobox and select an item. Click the button to show the alert and confirm message box. The popup should not be closed when you do that. Review URL: http://codereview.chromium.org/650045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39770 0039d316-1c4b-4281-b951-d872f2087c98
* generate needed resources on *BSDpvalchev@google.com2010-02-232-3/+3
| | | | | | Review URL: http://codereview.chromium.org/652135 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39769 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 39756 - Mac: Cookie confirmation dialog.thakis@chromium.org2010-02-237-157/+9
| | | | | | | | | | | | | | This is not the final UI (the "more info" disclosure triangle is missing), but it's pretty close and, more importantly, functional. BUG=34894 TEST=Go to Preferences>under the hood>content settings>cookies and select "ask me every time". Then browser around and note that a message box pops up all the time. All the buttons on the message box should do what they claim. Review URL: http://codereview.chromium.org/650206 TBR=thakis@chromium.org Review URL: http://codereview.chromium.org/652150 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39766 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Skip the failing test on 10.6 so we can spin up bots as green while ↵thomasvl@chromium.org2010-02-231-0/+14
| | | | | | | | | | the code is fixed. BUG=34784 TEST=test still runs on mac 10.5 bots Review URL: http://codereview.chromium.org/652134 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39761 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] skip a test that fails on 10.6 so we can spin up the 10.6 tester bots.thomasvl@chromium.org2010-02-231-3/+24
| | | | | | | | BUG=34785 TEST=tests still run on the 10.5 bots and passes. Review URL: http://codereview.chromium.org/652131 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39760 0039d316-1c4b-4281-b951-d872f2087c98
* Speculatve fix for a chrome crash caused in a chrome frame instance while ↵ananta@chromium.org2010-02-231-4/+9
| | | | | | | | | | | | | | | | | | | processing an automation message to focus through an external tab. Based on the crash dump, it appears that the tab_contents_ member is destroyed and set to NULL in the context of a call to TabContents::Focus which calls the Windows API SetFocus on the native HWND, which could dispatch messages like WM_DESTROY for the external tab. Fix is to add a second NULL check for tab_contents_ after the call to TabContents::Focus. Added a comment describing this scenario in the code. Fixes bug http://code.google.com/p/chromium/issues/detail?id=29246 Bug=29246 Review URL: http://codereview.chromium.org/653005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39757 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: Cookie confirmation dialog.thakis@chromium.org2010-02-237-9/+157
| | | | | | | | | | | This is not the final UI (the "more info" disclosure triangle is missing), but it's pretty close and, more importantly, functional. BUG=34894 TEST=Go to Preferences->under the hood->content settings->cookies and select "ask me every time". Then browser around and note that a message box pops up all the time. All the buttons on the message box should do what they claim. Review URL: http://codereview.chromium.org/650206 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39756 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the --enable-new-autofill switch. This enables the AutoFillManager ↵jhawkins@chromium.org2010-02-236-20/+25
| | | | | | | | | | to show the infobar asking the user to enable/disable AutoFill++. BUG=18201 TEST=none Review URL: http://codereview.chromium.org/650169 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39755 0039d316-1c4b-4281-b951-d872f2087c98
* Add '-ldl' to Linux targets that use dynamic loader functions.mmoss@google.com2010-02-231-0/+6
| | | | | | | | | | | | | This fixes compilation errors on Karmic, where dlopen() and friends were undefined: http://chrome-buildbot.corp.google.com:8016/builders/Chromium%20Linux%20Builder%20(dbg-shlib)/builds/7777/steps/compile/logs/stdio The missing '-ldl' is papered over on Hardy because pretty much everything depends on gtk, which brings that in through pkg-config, but pkg-config gtk no longer includes '-ldl' on Karmic. Review URL: http://codereview.chromium.org/656014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39754 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a crash when 2 extension uninstall dialogs were open and then confirmed.mpcomplete@chromium.org2010-02-231-1/+7
| | | | | | | | BUG=36456 Review URL: http://codereview.chromium.org/656010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39753 0039d316-1c4b-4281-b951-d872f2087c98
* Change find bar close button to use the standard hover close buttonfeldstein@chromium.org2010-02-231-34/+706
| | | | | | Review URL: http://codereview.chromium.org/652086 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39750 0039d316-1c4b-4281-b951-d872f2087c98
* Another pass at removal of GTMTheme. Also fixes unreadability of bookmark ↵avi@chromium.org2010-02-2319-96/+146
| | | | | | | | | | | | bar/status bubble in unthemed incognito mode. BUG=http://crbug.com/35554 ; http://crbug.com/29845 TEST=no visible change in normal mode; themed incognito windows should look ugly still but in a different way Review URL: http://codereview.chromium.org/650092 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39749 0039d316-1c4b-4281-b951-d872f2087c98
* Bookmark Manager: Set the direction and the font size based on the language.arv@chromium.org2010-02-232-6/+10
| | | | | | | | | BUG=36457 TEST=Change the language to Hebrew (for example) and notice the RTL UI. Review URL: http://codereview.chromium.org/652079 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39748 0039d316-1c4b-4281-b951-d872f2087c98
* do not mention other browsers in about:memory for chromeoskuan@chromium.org2010-02-234-1/+10
| | | | | | | | | BUG=34839 TEST=verify per bug report Review URL: http://codereview.chromium.org/650161 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39746 0039d316-1c4b-4281-b951-d872f2087c98
* PyAuto: Fix some methods that assume that they're working on the first window.nirnimesh@chromium.org2010-02-235-62/+151
| | | | | | | | | | - Provide args to specifiy tab_index or window_index. - Re-order the methods to group by functionality, rather than from where they are implemented. Review URL: http://codereview.chromium.org/650106 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39745 0039d316-1c4b-4281-b951-d872f2087c98
* Add 3D support for the Mac on Leopard (OS X 10.5) and earlier. This CL usesdspringer@google.com2010-02-2315-18/+194
| | | | | | | | | | | | | | | | | FBO rendering with glGetTexImage() into a TransportDIB that is then used as a texture for rendering the final image in the render view in the browser. While not optimal, it works and can be optimized later, after the new GPU process work is completed. This CL also enables stencil buffer support on the Mac. All the Pepper3D demos run on the Mac with these changes. BUG=none TEST=3D rendering unit tests. Review URL: http://codereview.chromium.org/647043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39744 0039d316-1c4b-4281-b951-d872f2087c98
* Fix mac builder bustageskrul@chromium.org2010-02-231-2/+2
| | | | | | Review URL: http://codereview.chromium.org/656003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39743 0039d316-1c4b-4281-b951-d872f2087c98
* Landing this patch on behalf of Mark Hahnenberg <mhahnenb(at)gmail.com>skrul@chromium.org2010-02-234-50/+230
| | | | | | | | | | | | | | Added a vector of Time objects to the AutofillEntry object for storingthe results retrieved from the date_created field of the autofill_datestable corresponding to the AutofillKey retrieved from the autofill table. Also modified the old GetAllAutofillEntries test to account for this newlystored data. BUG=35230 TEST=WebDatabaseTest.GetAllAutofillEntries Review URL: http://codereview.chromium.org/600070 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39742 0039d316-1c4b-4281-b951-d872f2087c98
* Whitespace!mark@chromium.org2010-02-231-1/+4
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/652127 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39740 0039d316-1c4b-4281-b951-d872f2087c98
* Add support for more types of controls and events to GTK implementation ofdmazzoni@chromium.org2010-02-2327-111/+528
| | | | | | | | | | | | accessibility extension API. Enable accessibility API for all subdialogs of the main Options dialog. BUG=none TEST=none Review URL: http://codereview.chromium.org/651037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39738 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-19 09:54:46 +0000