summaryrefslogtreecommitdiffstats
path: root/chrome
Commit message (Collapse)AuthorAgeFilesLines
* Revert r18641: "Linux: Enable metrics_service_uitest.cc."willchan@chromium.org2009-06-176-97/+24
| | | | | | | | Broke ui_tests. Review URL: http://codereview.chromium.org/125268 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18646 0039d316-1c4b-4281-b951-d872f2087c98
* Add a port disconnect event for when one side of an extension message portmpcomplete@google.com2009-06-1712-103/+222
| | | | | | | | | | | | | goes away. Combine the various ExtensionMessageService IPC message into a single "Invoke" message. BUG=12686 TEST=no Review URL: http://codereview.chromium.org/126234 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18645 0039d316-1c4b-4281-b951-d872f2087c98
* Implements the Page Info window on Mac.mark@chromium.org2009-06-1714-155/+1463
| | | | | | | | | | | | | | | | | | | | | | | - Splits out the code that was in chrome/browser/views/page_info_window.{cc,h} into a platform-independent class PageInfoWindow in chrome/browser/page_info_window.{cc,h} - The Windows implementation now lives in chrome/browser/views/page_info_window_win.{cc,h} - Created a Mac implemenation PageInfoWindowMac in chrome/browser/cocoa/page_info_window_mac.{h,mm} to bridge to a Cocoa NSWindowController - Created a new NSWindowController subclass PageInfoWindowController that is in chrome/browser/cocoa/page_info_window_controller.{h,mm} - Created a XIB for the page info window in chrome/app/nibs/en.lproj/PageInfo.xib Patch by Robert Sesek <rsesek@bluestatic.org> Review URL: http://codereview.chromium.org/115116 Review URL: http://codereview.chromium.org/125266 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18643 0039d316-1c4b-4281-b951-d872f2087c98
* Remove tooltip from page_action and just use the name as the tooltip. We ↵finnur@chromium.org2009-06-175-26/+3
| | | | | | | | don't seem to have a need for having the name and the tooltip be separate. Review URL: http://codereview.chromium.org/125264 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18642 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: Enable metrics_service_uitest.cc.willchan@chromium.org2009-06-176-24/+97
| | | | | | | | | Add support for zygotes to call DidProcessCrash on renderers. TEST=metrics_server_uitest.cc Review URL: http://codereview.chromium.org/126264 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18641 0039d316-1c4b-4281-b951-d872f2087c98
* Add experiment support in setupcpu@google.com2009-06-179-5/+124
| | | | | | | | | | | | - Adds the inactive user toast logic - Some refactoring of helper functions BUG=b/1484308 TEST=see the bug Review URL: http://codereview.chromium.org/125234 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18640 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor platform-independent stuff out of EditKeywordController.mattm@chromium.org2009-06-177-160/+271
| | | | | | | | | | | Preparation for adding GTK implementation. BUG=13326 TEST=Edit existing search engine, add new search engine, add engine by clicking on OpenSearch description file. Review URL: http://codereview.chromium.org/125161 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18636 0039d316-1c4b-4281-b951-d872f2087c98
* Add a helper on mac for collecting memory size info from a list of processes.thomasvl@chromium.org2009-06-173-0/+101
| | | | | | | | | | | Spawn PS to collect the data and parse the output. Add ifdef checks in the page cyclers so on mac we can use the other helper since base methods can't ever be made to work. BUG=none TEST=memory info should now show in the waterfall and on the perf graphs for the page cycler tests. Review URL: http://codereview.chromium.org/125254 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18635 0039d316-1c4b-4281-b951-d872f2087c98
* Use LZX compression that takes a little more time but reduceskuchhal@chromium.org2009-06-171-2/+2
| | | | | | | | | | | compressed setup.exe size by another 10-20%. BUG=none TEST=Make sure mini_installer stills installs Chromium Review URL: http://codereview.chromium.org/126233 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18631 0039d316-1c4b-4281-b951-d872f2087c98
* Consistently use int64 for integers holding number of milliseconds.phajdan.jr@chromium.org2009-06-176-9/+7
| | | | | | | | | | This applies only to things which use TimeDelta::InMilliseconds, because it returns int64. Before this patch callers static_casted that to int, and after this patch they use the returned value as int64. Review URL: http://codereview.chromium.org/126279 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18626 0039d316-1c4b-4281-b951-d872f2087c98
* Exit Chrome and show FRUI again on the next run, if user clicks on Cancel.kuchhal@chromium.org2009-06-175-6/+15
| | | | | | | | BUG=10825 Review URL: http://codereview.chromium.org/118528 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18624 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the windows specific bits from login_prompt.cc and make ↵erg@chromium.org2009-06-1710-314/+340
| | | | | | | | | | LoginPromptWin conform to a general cross platform interface. (Also tightens the interface for ConstrainedWindows a bit more) Review URL: http://codereview.chromium.org/125217 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18623 0039d316-1c4b-4281-b951-d872f2087c98
* Fix bug where the autocomplete text was being overridden by the user-entered ↵shess@chromium.org2009-06-172-14/+38
| | | | | | | | | | | | | | | | | text. During the course of this, I gave in and implemented EmphasizeURLComponents() for consistency with Windows and GTK. Since modifying the text changes the selection, added SetTextAndSelectedRange() to make operations doing both easier to get right. Renamed UpdateAndStyleText() to SetText() for consistency. http://crbug.com/14122 TEST=See bug. Review URL: http://codereview.chromium.org/125201 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18621 0039d316-1c4b-4281-b951-d872f2087c98
* Removing a method unecessary in FindBarWin.jcampan@chromium.org2009-06-172-42/+9
| | | | | | | | BUG=None TEST=Bring up the find box. Press Esc (the box should close). Hit a URL that takes a long time to load. While it is loading, press ESC, the load should stop. Review URL: http://codereview.chromium.org/126230 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18605 0039d316-1c4b-4281-b951-d872f2087c98
* Fix build break in ui_tests because of a missing dependancy on debugger from ↵jam@chromium.org2009-06-171-0/+1
| | | | | | | | ui_tests. Review URL: http://codereview.chromium.org/126251 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18597 0039d316-1c4b-4281-b951-d872f2087c98
* Add the mini_installer.exe.manifest to AdditionalManifestFiles for Vistasgk@chromium.org2009-06-171-0/+10
| | | | | | | | | execution of installer_util_unittests.exe and mini_installer_tests.exe. BUG=none TEST=none Review URL: http://codereview.chromium.org/126263 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18596 0039d316-1c4b-4281-b951-d872f2087c98
* Convert setup.exe to gyp.sgk@chromium.org2009-06-171-1/+0
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/126261 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18593 0039d316-1c4b-4281-b951-d872f2087c98
* Capture additional gyp settings for setup.exe:sgk@chromium.org2009-06-171-2/+9
| | | | | | | | | | | * Consistent use of <(SHARED_INTERMEDIATE_DIR)/setup for the output directory of the generated setup_exe_version.rc file. * Add setup/setup_util.{cc,h}. BUG=none TEST=none Review URL: http://codereview.chromium.org/125237 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18592 0039d316-1c4b-4281-b951-d872f2087c98
* Convert mini_installer_test to gyp.sgk@chromium.org2009-06-171-1/+0
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/125236 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18590 0039d316-1c4b-4281-b951-d872f2087c98
* Convert installer_util_unittests to gyp.sgk@chromium.org2009-06-171-1/+0
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/126259 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18589 0039d316-1c4b-4281-b951-d872f2087c98
* Fix build bustage by removing another dependency on browser/gtk by creating ↵ben@chromium.org2009-06-174-1/+426
| | | | | | | | | | | a new TabContentsViewGtk specifically for views. This subclasses WidgetGtk similar to how TabContentsViewWin subclasses WidgetWin. There was a bug in NativeViewHostGtk - reparenting needs to be done atomically using gtk_widget_reparent since GtkWidgets are refcounted and when removed from a container are released, causing a crash when a TabContents is reparented. The code now compiles thanks to a stubbed BlockedPopupContainer, however there is one remaining issue - the browser window no longer paints and the app instantly hangs. However this is better than the current state so I figured I'd send the code review. Review URL: http://codereview.chromium.org/126107 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18588 0039d316-1c4b-4281-b951-d872f2087c98
* Do not write a profile path on a BookmarkDragData object since a dragged url ↵yusukes@google.com2009-06-171-0/+617
| | | | | | | | | | | | | | | | | | | | | (javascript:...) on a web page does not belong to (the profile's) bookmark model. Currently the following function returns DRAG_NONE and thus the drop operation is not accepted. The reason for the return value is because ops becomes DragDropTypes::DRAG_MOVE (since data.profile_path_ is not empty()) but event.GetSourceOperations() returns DragDropTypes::DRAG_COPY | DragDropTypes::DRAG_LINK. int BookmarkBarView::CalculateDropOperation(const DropTargetEvent& event, ... int ops = data.GetFirstNode(profile_) ? DragDropTypes::DRAG_MOVE : DragDropTypes::DRAG_COPY | DragDropTypes::DRAG_LINK; return bookmark_utils::PreferredDropOperation(event.GetSourceOperations(), ops); BUG=12290 TEST=Open http://delicious.com/help/bookmarklets page and drag the "Bookmark on Delicious" link on "Google Chrome" section to the bookmark bar. Review URL: http://codereview.chromium.org/125111 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18584 0039d316-1c4b-4281-b951-d872f2087c98
* gtk fullscreen fixes.estade@chromium.org2009-06-172-9/+31
| | | | | | | | | http://crbug.com/13999 TEST=when you fullscreen, it should be impossible to see any of the following: frame, tabstrip, tool bar, bookmark bar. Review URL: http://codereview.chromium.org/125230 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18582 0039d316-1c4b-4281-b951-d872f2087c98
* Re-land another subset of r18520.ericroman@google.com2009-06-171-5/+21
| | | | | | | | | | | | This particular subset should be a no-op: It adds an unused interface method (OnResolutionCancelled), and an unused test (CancelObserver), and lastly renames Cancel --> MarkAsCanceled(). The code in "dns_global.cc" is also unused since it is unreachable. The original code review that this belongs to is:<http://codereview.chromium.org/125171>. (BUG=14138) The original was backed out because of a valgrind linux error (BUG=14218), so I am now re-landing in smaller chunks to identify where the problem resides. Review URL: http://codereview.chromium.org/126253 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18581 0039d316-1c4b-4281-b951-d872f2087c98
* gtk bookmark bar: Initialize a member variable.estade@chromium.org2009-06-171-0/+1
| | | | | | | | | http://crbug.com/14067 TEST=open browser, click on other bookmarks button. It should work on the first try. Review URL: http://codereview.chromium.org/126249 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18578 0039d316-1c4b-4281-b951-d872f2087c98
* Enable extensions without UI davemoore@chromium.org2009-06-171-1/+5
| | | | | | Review URL: http://codereview.chromium.org/125031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18576 0039d316-1c4b-4281-b951-d872f2087c98
* gtk: Make sure icon is right size in download item.estade@chromium.org2009-06-172-9/+22
| | | | | | | | | | This results in kind of an ugly icon sometimes. When we get SVG support the number of ugly cases should go down. http://crbug.com/13791 Review URL: http://codereview.chromium.org/126245 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18575 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 18520.ericroman@google.com2009-06-171-21/+5
| | | | | | | | | | | | | | The original code review for this change was: <http://codereview.chromium.org/125171> It is being reverted because it seems to have caused a valgrind on linux regression: <http://crbug.com14218> BUG=14218,14138,14188 Review URL: http://codereview.chromium.org/126248 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18574 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a crash when the ThumbnailGenerator.brettw@chromium.org2009-06-178-25/+55
| | | | | | | | | | This happens when the ThumbnailGenerator is initialized because the NotificationService doesn't exist yet. This patch adds a function that TabContentscalls to make sure it is registered to avoid this problem. Review URL: http://codereview.chromium.org/126239 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18572 0039d316-1c4b-4281-b951-d872f2087c98
* Disable MediaTest.VideoBearH264hclam@chromium.org2009-06-171-1/+1
| | | | | | | | TBR=scherkus Review URL: http://codereview.chromium.org/126246 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18568 0039d316-1c4b-4281-b951-d872f2087c98
* Updating trunk VERSION build from 189.0 to 190.0laforge@chromium.org2009-06-171-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18567 0039d316-1c4b-4281-b951-d872f2087c98
* Fix Gears crash after making PluginThread::current() only work on that thread.jam@chromium.org2009-06-171-5/+6
| | | | | | Review URL: http://codereview.chromium.org/126244 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18563 0039d316-1c4b-4281-b951-d872f2087c98
* Disable MediaTest.VideoBearH264 because it failshclam@chromium.org2009-06-161-1/+1
| | | | | | | | TBR=finnur, scherkus Review URL: http://codereview.chromium.org/126242 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18562 0039d316-1c4b-4281-b951-d872f2087c98
* GTK bookmark bar: only animate when user changes the pref (not, for example, ↵estade@chromium.org2009-06-164-13/+24
| | | | | | | | | | | on startup). TEST=set bookmark bar open, restart chrome, bookmark bar should just be open (no animation) BUG=none Review URL: http://codereview.chromium.org/125223 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18560 0039d316-1c4b-4281-b951-d872f2087c98
* Raise the rlimit in the page cycler so we don't have to adapt a new ↵thomasvl@chromium.org2009-06-161-7/+59
| | | | | | | | | | | | reference build which would change the baseline on lot of tests and not just the page cycler. Enable the intl* tests on mac. TEST=the intl page cycler tests will run and also the reference version will. BUG=8390 Review URL: http://codereview.chromium.org/125210 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18558 0039d316-1c4b-4281-b951-d872f2087c98
* submitted on behalf of rogerta (Roger Tawa).rafaelw@chromium.org2009-06-167-2/+323
| | | | | | | | | | Original issue: http://codereview.chromium.org/119325 r=rafaelw,Jói,stoyan,aa Review URL: http://codereview.chromium.org/125206 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18555 0039d316-1c4b-4281-b951-d872f2087c98
* Bug 14202: Support relative paths when installing external extensions ↵finnur@chromium.org2009-06-161-1/+25
| | | | | | | | | | | | | | | through prefs. First we try the path as absolute path. If the file is not found, we try a relative path: [installation path]\extensions This will make installing extensions easier from pre-installed prefs, since we can drop them into an extensions directory under the program directory. BUG=14202 TEST=Specify relative path when installing extensions through prefs. Best to test this with an installer that supports deploying extensions (blocked on 14201) Review URL: http://codereview.chromium.org/125219 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18554 0039d316-1c4b-4281-b951-d872f2087c98
* Make LocalStrings work without manipulating the DOM.arv@google.com2009-06-166-102/+20
| | | | | | | | | | | BUG=None TEST=Make sure that localized text on NTP, History and Downloads still look the same. Review URL: http://codereview.chromium.org/125076 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18551 0039d316-1c4b-4281-b951-d872f2087c98
* UI test for <video>hclam@chromium.org2009-06-164-0/+100
| | | | | | | | | | Simple ui test that goes through some test clips. TEST=MediaTest.* Review URL: http://codereview.chromium.org/125173 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18550 0039d316-1c4b-4281-b951-d872f2087c98
* Gtk bookmark manager: add search + recently added nodes.estade@chromium.org2009-06-162-56/+251
| | | | | | Review URL: http://codereview.chromium.org/125220 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18546 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the mac build by removing extra object namebrettw@chromium.org2009-06-161-1/+2
| | | | | | Review URL: http://codereview.chromium.org/125222 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18544 0039d316-1c4b-4281-b951-d872f2087c98
* Adds a couple of images.sky@chromium.org2009-06-164-0/+10
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/126226 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18541 0039d316-1c4b-4281-b951-d872f2087c98
* Adds kind-of-live thumbnail generation for a potential tab switcher.brettw@chromium.org2009-06-1634-138/+872
| | | | | | | | | | | | | | | | | | | | This listens to tab events and tries to keep thumbnails ready to go. See thumbnail_generator.cc for a more detailed design. This adds a painting observer to the RenderWidgetHost to enable this new behavior, as well as a notification to allow the thumbnail generator to hook its observer in. There is also a new notification that a backing store has been disabled, which required making the backing stores know about their owning widget hosts. This component is currently disabled. We just need to uncomment the member in Profile and it will start to work. Original review: http://codereview.chromium.org/118420 Review URL: http://codereview.chromium.org/126101 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18540 0039d316-1c4b-4281-b951-d872f2087c98
* Properly cleanup state after synchronous DNS resolutionjar@chromium.org2009-06-162-13/+28
| | | | | | | | | | | | | | | Pre-resoultion system was not cleaning up its state when the resolver returned asynchronously. This regression probably landed when we shifted to using an internal resolver class, rather than running on worker threads. The impact was made detectable by the recent introudction of a micro-cache, which often returns with a synchronous result. BUG=14212 r=eroman Review URL: http://codereview.chromium.org/125209 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18537 0039d316-1c4b-4281-b951-d872f2087c98
* Since the introduction of PushSource, there are two buffering layers in thehclam@chromium.org2009-06-168-215/+338
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | browser process, the hardware buffer used in AudioOutputStream and transportation buffer in PushSource. Together with the latency in the IPC audio layer we have a serious AV sync problem. To compensate the delay and latency introduced by these three factors two parameters are added in RequestAudioPacket message that include the buffer fill level and timestamp of the request. These two parameters are used to determine the playback delay to be used by the audio renderer to update the pipeline with the time delta. So we have three parameters we need to care about: 1. Hardware buffer in AudioOutputStream 2. Buffered data in PushSource 3. IPC latency We have accurate values for 2 and 3 but not 1. We currently don't have the API in AudioOutputStream to query the remaining buffer in the hardware buffer. But usually there is a large amount of data in it, e.g. on Windows 400ms worth of data. Since we now detached the hardware buffer request of OnMoreData() from the actual packet request of IPC (by the introduction of PushSource), it is really critical to know the buffer level in the hardware. I made a guess of this buffer level by using the amount of last buffer copy. Review URL: http://codereview.chromium.org/122020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18536 0039d316-1c4b-4281-b951-d872f2087c98
* Add a UI test for downloading in incognito mode.paul@chromium.org2009-06-161-1/+43
| | | | | | | | | | | | | This test opens an incognito window and verifies that downloads work and that closing the incognito window does not crash (see bug http://crbug.com/13983). TEST=Test should run and not crash. BUG=none Review URL: http://codereview.chromium.org/126181 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18534 0039d316-1c4b-4281-b951-d872f2087c98
* Speculative fix for a chromebot crash since I can't reproduce itpaul@chromium.org2009-06-162-0/+5
| | | | | | | | | | | | | | | | | | locally. When shutting down the browser with a download shelf, we first release the shelf (see BUG=13681 for details) but we are still part of the view hierarchy. A little later in the shutdown, the shelf's parent (BrowserView) will dereference the already deleted shelf through its View base class, which I believe is the source of the Chromebot crash. BUG=14171 (http://crbug.com/14171) TEST=Chromebot should not crash Review URL: http://codereview.chromium.org/126228 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18532 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup Personal Stuff options tab pagemhm@chromium.org2009-06-161-5/+0
| | | | | | | | | | | The popup variable declarations are not needed anymore since they were removed . BUG=none TEST=page functions correctly Review URL: http://codereview.chromium.org/126102 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18530 0039d316-1c4b-4281-b951-d872f2087c98
* Add missing headers to gyp files.jam@chromium.org2009-06-161-0/+2
| | | | | | Review URL: http://codereview.chromium.org/125204 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18526 0039d316-1c4b-4281-b951-d872f2087c98
* Initial stub for the support library, gyp file and targets. Chrome.exe and ↵slightlyoff@chromium.org2009-06-161-0/+4
| | | | | | | | chrome.dll will depend on them. Review URL: http://codereview.chromium.org/125155 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18525 0039d316-1c4b-4281-b951-d872f2087c98