| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
| |
http://crbug.com/2324
Review URL: http://codereview.chromium.org/10265
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5130 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=4264
Review URL: http://codereview.chromium.org/9749
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5129 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
menu is invoked from the keyboard.
BUG=4029
TEST=In the bookmark manager bring up the context menu of the
tree/table via the menu key and make sure the menu appears at a
reasonable location.
Review URL: http://codereview.chromium.org/10256
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5125 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
DraggedTabController.
Review URL: http://codereview.chromium.org/10263
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5124 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
better.
BUG=4271
Review URL: http://codereview.chromium.org/10262
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5121 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/9748
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5118 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Delegates should be NULLed more aggressively.
Review URL: http://codereview.chromium.org/10235
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5117 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
EnableSuddenTermination, unforking a bunch of code.
BUG=http://crbug.com/4064
Review URL: http://codereview.chromium.org/9746
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5116 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
a blocked popup notification.
Review URL: http://codereview.chromium.org/9709
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5115 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=4185
Review URL: http://codereview.chromium.org/9484
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5106 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
GlobalInit() wasn't successful.
Review URL: http://codereview.chromium.org/10247
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5104 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
making "not found" noises or jumping within the page."
This issue is caued by the TextField::Edit class which start searching a page with a string retrieved with the GetWindowText() function every time when a user presses a key. A string retrived with the GetWindowText() function contains a composition string, a string being composed by an IME. This string changes too often and users do not like to start searching a page with the string.
To fix this issue, this change removes a composition string from a search string to emulate Firefox.
BUG=3096 "Issue 3096: [Find in page] responds each IME composition, making "not found" noises or jumping within the page."
Review URL: http://codereview.chromium.org/9634
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5096 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
A change r2266 removed fake scroll bars used to handle WM_MOUSEWHEEL messages. This change prevents Windows from sending WM_HSCROLL messages when tilting a mouse wheel (Windows sends WM_HSCROLL messages only to a window which has scroll bars.) and this causes a regression problem that we cannot use tilt-wheel to scroll horizontally.
To solve this problem, this change implements a WM_MOUSEHWHEEL (0x020E) message handler to dispatch tilt-wheel events to the RenderWidgetHostViewWin::OnWheelEvents() function. Also, It changes scroll direction in creating a WebMouseWheelEvent instance.
Review URL: http://codereview.chromium.org/9319
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5095 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Push breakpad initialization until chrome.dll has already been loaded. This basically currently happens anyway, since loading chrome.dll in the main thread will beat the threaded breakpad initialization.
Retrieving the file version information goes from ~4ms to ~1ms if chrome.dll is already loaded. Also move the file version code to the initialization thread.
Review URL: http://codereview.chromium.org/10242
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5069 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5059 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
pop-up menu talk to each other. Pop-up menu appears containing suggestions.
Review URL: http://codereview.chromium.org/9462
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5058 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
so that we can detect Chrome instances across user sessions.
Review URL: http://codereview.chromium.org/10234
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5057 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
default button.
When the focus is not a button, then the default button should be the one the delegate specifies.
BUG=4132
TEST=Open the option dialog. OK should be the default and focused button. Move the focus around by pressing tab. When a button is selected, it should be the default button.
Review URL: http://codereview.chromium.org/10230
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5056 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/9719
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5052 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/9503
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5050 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
chrome\browser\net\referrer.cc to the SCons build (on Windows).
Review URL: http://codereview.chromium.org/9710
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5048 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/10231
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5047 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5046 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Voodoo lesson: don't use the slow dsymutil utility; instead, make a "fake"
.dSYM that contains the original unstripped Mach-O file.
Review URL: http://codereview.chromium.org/9659
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5042 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/10224
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5038 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
to the SCons build.
Review URL: http://codereview.chromium.org/9705
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5037 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/10214
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5035 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/10219
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5031 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Everywhere else in this class we look to see
if view_ is NULL before dereferencing it, except
in this case.
This would fix a crash found in the distributed tests.
BUG: 1074508
Review URL: http://codereview.chromium.org/9674
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5030 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
- Zero sized chunks
- Redirect URL format changes
http://crbug.com/3418
Review URL: http://codereview.chromium.org/10222
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5028 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
that we only restore the page info window position, but not the size.
Plus some dead code removal in options_window_view.
BUG=3509
Review URL: http://codereview.chromium.org/10218
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5027 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
showing garbage in files types combobox.
BUG=4211
TEST=bring up bookmark manager, click on import, click on 'files of
type' and make sure you only see *.html.
Review URL: http://codereview.chromium.org/10225
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5026 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
ipc channel and sending the last message. Sometimes that last
write is cancelled so there will be a channel error at the other end.
Review URL: http://codereview.chromium.org/9629
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5022 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Cleanup the separation between MessagePumpForUI and
MessagePumpForIO, and convert the latter to use Completion
Ports instead of MsgWaitForMultipleobjects to sleep
when idle.
Remove all traces of Windows messages from MessagePumpForIO,
remove the transitional API of completion port notifications
and remove WatchObject API.
Modify all callers of RegisterIOHandler so that they are no
longer using RegisterIOContext, and also handle properly
the new semantics of completion ports (notifications even when
the IO completes immediately).
Add a new interface to allow proper cleanup of disk cache (to
replace code that was waiting for pending APCs from the destructor).
Add a way for the message pump to perform cleanup of abandoned IO.
BUG=B/1344358, 3497, 3630
TESt=unit tests
R=darin
Review URL: http://codereview.chromium.org/8156
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5021 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Will investigate on the bot.
TBR=nsylvain
Review URL: http://codereview.chromium.org/9700
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5018 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
graphics mode of a ADVANCED doesn't work with a RTL layout for this
code.
BUG=4175
TEST=bring up the bookmark manager in the hebrew locale, make sure the
text isn't mirrored.
Review URL: http://codereview.chromium.org/10216
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5017 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
messages directly to the targeted window.
http://crbug.com/4067
Review URL: http://codereview.chromium.org/9485
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5014 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This probably needs some bigger adjustments. Some things need to be decided,
like where to store profile files on Linux/Mac.
BUG=3649
Review URL: http://codereview.chromium.org/8059
Patch from Paweł Hajdan jr <phajdan.jr@gmail.com>.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5012 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/10206
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5005 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/10209
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5003 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
indexers which are interested in indexing Chrome's web history. These should
register their CLSID in HKCU\Software\Google\Google Chrome\IndexerPlugins and
this is be used by Chrome to publish its index.
Added code to publish the index too.
Checked in for Vijay Thadkal <veejay.t.s@gmail.com> (Google). Reitveld #9007.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5002 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
context menus.
BUG=4186
TEST=try cut/copy/paste from table/tree in the bookmark manager as
well as context menus in bookmark manager.
Review URL: http://codereview.chromium.org/9481
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4993 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
dereferenced in specific cases. We would have to create the failed icon twice,
so that it would think the icon was already in the cache, when in fact a NULL
value was being cached.
BUG=1259695
Review URL: http://codereview.chromium.org/9672
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4988 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4986 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=1649
TEST=bring up bookmark manager and try out import/export from the
tools menu. Note that import ALWAYS creates a new folder under
the 'Other bookmarks folder' with the name of Imported (x). This
is by design.
Review URL: http://codereview.chromium.org/9471
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4968 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Select the highest FF version, not just the the HCKU one.
- I don't have a repro case, it is a blind fix
Seems like leftovers of old FF installs in HCKU are tripping us, that
is my guess, now we would find FF3 in HKLM.
BUG=3109
Review URL: http://codereview.chromium.org/9675
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4960 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
while it is in use. This should work for per user as well as system level
installs (after some additional changes once Google Update changes are ready).
The following scenarios should work now:
- If Chromium is using two different profiles at the same time we do not switch
chrome executables until all of them are closed.
- The old version of Chromium can be run after a restart if the renaming of
executables fails.
- We will not use environment variable any more but we need to keep it until all
the users get this change on their machines.
- opv/rename registry keys and new_chrome.exe should always together. If one
exist all three should exist because they are created and deleted as one atomic
operation (as much as possible given laws of physics).
BUG=1463346
Review URL: http://codereview.chromium.org/9436
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4949 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/9479
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4946 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
by the time the download item is created, you have the download tab opened and you press on the discard button.
This is because such downloads gets added to a vector that is used to unregister the DownloadTabView as an observer.
We were deleting the download item before notifying the DownloadTabView, which would cause it to access the deleted download item.
BUG=4134
TEST=Open the download tab, start the download of a short exe. Click the discard button in the dangerous download prompt.
Review URL: http://codereview.chromium.org/9435
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4940 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
waterfall.
BUG=4173
TEST=look at page-cycler step on waterfall
Review URL: http://codereview.chromium.org/9658
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4936 0039d316-1c4b-4281-b951-d872f2087c98
|