summaryrefslogtreecommitdiffstats
path: root/chrome
Commit message (Collapse)AuthorAgeFilesLines
* Try and make some spellcheck code more obvious by using typedefs.pkasting@chromium.org2008-12-115-49/+48
| | | | | | | I am not convinced this patch is a net win. Please share your thoughts on if using a Language/Languages set of types is better or worse than what we're doing now. Review URL: http://codereview.chromium.org/13367 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6807 0039d316-1c4b-4281-b951-d872f2087c98
* Clean up about box for unofficial builds.phajdan.jr@chromium.org2008-12-111-0/+6
| | | | | | | | | | Currently unofficial builds (Chromium) display there an error message that update server is unavailable. This is obvious (there is no update server for trunk builds), but looks bad. This patch removes the message for unofficial builds. Review URL: http://codereview.chromium.org/13352 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6806 0039d316-1c4b-4281-b951-d872f2087c98
* Remove a stale comment. net::ERR_CERT_UNABLE_TO_CHECK_REVOCATIONwtc@google.com2008-12-111-1/+1
| | | | | | | | | | | | now causes the security style to be set to authentication broken. (The security style is set elsewhere, not here, but this comment is still confusing.) R=jcampan BUG=4749 Review URL: http://codereview.chromium.org/13371 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6805 0039d316-1c4b-4281-b951-d872f2087c98
* Fix extensions_service_unittest on Linux.phajdan.jr@chromium.org2008-12-111-3/+17
| | | | | | | | | | I was getting failures which are not present on buildbot, I don't know why. But with these changes it should be more solid. This also prevents a segfault which I got (out of bounds array access). Review URL: http://codereview.chromium.org/13258 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6792 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 6787. inteded to commit other changelist.phajdan.jr@chromium.org2008-12-111-17/+3
| | | | | | Review URL: http://codereview.chromium.org/13387 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6789 0039d316-1c4b-4281-b951-d872f2087c98
* Fix extensions_service_unittest on Linux.phajdan.jr@chromium.org2008-12-111-3/+17
| | | | | | | | | | I was getting failures which are not present on buildbot, I don't know why. But with these changes it should be more solid. This also prevents a segfault which I got (out of bounds array access). Review URL: http://codereview.chromium.org/13258 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6787 0039d316-1c4b-4281-b951-d872f2087c98
* Update a few targets to the condition they should be in. Eliminate redundantmark@chromium.org2008-12-111-89/+92
| | | | | | | | build settings. Make sure all executable targets have the proper "strip if needed" phase. Fix dependencies. Review URL: http://codereview.chromium.org/13374 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6785 0039d316-1c4b-4281-b951-d872f2087c98
* Move file enumeration to filepaths.avi@google.com2008-12-118-32/+37
| | | | | | Review URL: http://codereview.chromium.org/13315 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6784 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes a handful of related bookmark manager bugs/requests:sky@google.com2008-12-118-11/+116
| | | | | | | | | | | | | | | . Adds a search field before the text field. . When the search node is selected and there are no results or no search text, a descriptive label is drawn on top of the table telling the user what's happening. . In the bookmark menus Edit... is now Rename... for folders. BUG=5272 5319 5273 4165 TEST=see individual bugs Review URL: http://codereview.chromium.org/13724 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6777 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes two session restore bugs:sky@google.com2008-12-112-2/+17
| | | | | | | | | | | | | | | | . If the user launches incognito we don't attempt to restore last session and instead just do default launch behavior (new tab page). . Don't show the session restore info bar when launched incognito. I'm assuming that if the user launched in incognito they were previously running incognito so that there is nothing to restore. BUG=4381 5119 TEST=turn on session restore and launch with --incognito, make sure the incognito window comes up. Review URL: http://codereview.chromium.org/13368 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6776 0039d316-1c4b-4281-b951-d872f2087c98
* Missed this file in my previous cleanup patch.pkasting@chromium.org2008-12-111-2/+2
| | | | | | Review URL: http://codereview.chromium.org/13729 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6766 0039d316-1c4b-4281-b951-d872f2087c98
* Only allow bookmark keyboard shortcut for tabbed browsers.sky@google.com2008-12-111-1/+9
| | | | | | | | | BUG=5055 TEST=make sure control-d does nothing for apps and popup windows Review URL: http://codereview.chromium.org/13363 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6764 0039d316-1c4b-4281-b951-d872f2087c98
* Build ipc_tests on linux.tc@google.com2008-12-113-12/+36
| | | | | | | Review URL: http://codereview.chromium.org/13366 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6762 0039d316-1c4b-4281-b951-d872f2087c98
* Better build bustage fix: Commit the rest of the original patch. Rolls back ↵pkasting@chromium.org2008-12-114-29/+33
| | | | | | the previous blind fix I tried. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6760 0039d316-1c4b-4281-b951-d872f2087c98
* Blind attempt at build fix. I don't know why this should be necessary.pkasting@chromium.org2008-12-111-0/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6759 0039d316-1c4b-4281-b951-d872f2087c98
* Make the autocomplete system and various other connected bits of code use ↵pkasting@chromium.org2008-12-1027-273/+296
| | | | | | | | GURL instead of wstring where appropriate. Original patch by phajdan.jr@gmail.com, r=me,sky. See http://codereview.chromium.org/13205 . BUG=715234 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6758 0039d316-1c4b-4281-b951-d872f2087c98
* Another attempted, untested build fix.pkasting@chromium.org2008-12-101-0/+2
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6753 0039d316-1c4b-4281-b951-d872f2087c98
* Untested fix for build failures.pkasting@chromium.org2008-12-101-0/+2
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6752 0039d316-1c4b-4281-b951-d872f2087c98
* A simple script to create an extension package and to verify its contents.erikkay@google.com2008-12-101-0/+108
| | | | | | Review URL: http://codereview.chromium.org/13351 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6749 0039d316-1c4b-4281-b951-d872f2087c98
* Fix regression with Find in page focus on trunk. finnur@google.com2008-12-104-8/+66
| | | | | | | | | | | | Basically, if the Find box is open, pressing Ctrl+F should set focus to the text field. This regressed when the Find box moved into web_contents_view. I have added a UI test to catch this in the future. Review URL: http://codereview.chromium.org/13721 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6748 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the unneeded CHECKs. Add a CHECK to determinewtc@google.com2008-12-102-10/+15
| | | | | | | | | | | whether the recursive call to RemovePendingRequest is removing the same or a different request. R=eroman BUG=4749 Review URL: http://codereview.chromium.org/13329 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6746 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup part 6.pkasting@chromium.org2008-12-107-110/+99
| | | | | | | | | | | | | | | | | | | | | Lots of small things (mostly in spellcheck code), e.g.: * L"" -> std::wstring() * type *var; -> type* var; * Fix parameter line-wrapping to comply with style guide * Remove unnecessary classname scoping inside class delcaration * Remove empty declaration * Add/remove blank lines in hopes of increasing readability * Add block ("{", "}") around local use of a temporary that is later redefined * Fold temps into other statements where obvious * Use std::find() instead of hand-rolling the same functionality * Combine distinct cases in switch statements when they all do the same thing * Range-check to avoid some algorithmic work when it's not needed * at() -> [] ...and various others. Pretty much every change stands on its own. Do not hesitate to complain about changes you think are unhelpful to the code, this change is something of a dumping ground. (I did try to avoid the sort of gratuitous "const"-adding that has gotten me in trouble before :). ) Review URL: http://codereview.chromium.org/13688 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6745 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor IPC::Channel to have a common header.jeremy@chromium.org2008-12-1012-158/+297
| | | | | | Review URL: http://codereview.chromium.org/11024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6743 0039d316-1c4b-4281-b951-d872f2087c98
* Updating the All target to include test_shell_tests and ipc_tests, and to ↵mark@chromium.org2008-12-101-3/+32
| | | | | | | | add the strip-if-needed phase to these executables Review URL: http://codereview.chromium.org/13357 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6739 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes bug where context menu for table/tree in rtl was showing up onsky@google.com2008-12-102-0/+4
| | | | | | | | | | | the wrong side. BUG=5067 TEST=see bug Review URL: http://codereview.chromium.org/13353 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6734 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup part 5.pkasting@chromium.org2008-12-104-498/+551
| | | | | | | | | | | Reorder identifiers, functions, initalization statements, etc. to all match. This preserves the original groups Ben created but makes a couple of changes: * Within each group, the order is now "by GUI order" instead of random. This can be subjective, but when I tried doing alphabetical order, it resulted in related functionality being separated pretty arbitrarily. * I moved the "window management" functions next to (but above) the "page-related" functions (this seemed a little more logical, but maybe not) I also renamed UpdateNavigationCommands() to try and reflect that it updates a lot more than navigation commands, and moved some unconditionally-initialized commands (profile stuff) in there over to InitCommandState() where they belong. Review URL: http://codereview.chromium.org/13681 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6721 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes regression in info bubble that caused crash on clicking star onsky@google.com2008-12-102-18/+6
| | | | | | | | | | | | history page. BUG=4397 TEST=go to history page, click on a star and make sure star bubble pops up. Review URL: http://codereview.chromium.org/13349 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6717 0039d316-1c4b-4281-b951-d872f2087c98
* Changes bookmark manager search to use contains vs starts with and tosky@google.com2008-12-106-25/+112
| | | | | | | | | | | | search urls. BUG=4065 TEST=create the URL foo.com and type 'foo.com' in the bookmark manager search box. Make sure the url you just typed shows up in the table. Review URL: http://codereview.chromium.org/13679 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6714 0039d316-1c4b-4281-b951-d872f2087c98
* Adds NULL checks for LoadLibrary and GetProcAddress calls insky@google.com2008-12-101-0/+6
| | | | | | | | | | | | IEImporter. As far as I could tell the crash was because LoadLibrary returned null. BUG=3897 TEST=none Review URL: http://codereview.chromium.org/13319 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6713 0039d316-1c4b-4281-b951-d872f2087c98
* run ipc unit tests in release mode (was running other unit tests). port code ↵pinkerton@google.com2008-12-102-3/+3
| | | | | | | | wrapped in NDEBUG to get release mode compiling and running Review URL: http://codereview.chromium.org/13346 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6712 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 6709,6708,6706.brettw@google.com2008-12-106-15/+15
| | | | | | Review URL: http://codereview.chromium.org/13345 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6710 0039d316-1c4b-4281-b951-d872f2087c98
* Remove base dependency from image_operations and associated unittests. I ↵brettw@google.com2008-12-106-15/+15
| | | | | | | | | also renamed the namespace from "gfx" to "skia". This also adds back the image_operations_unittest to a project (this had gotten lost in my move). Review URL: http://codereview.chromium.org/13143 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6706 0039d316-1c4b-4281-b951-d872f2087c98
* Misc proxy service changes.ericroman@google.com2008-12-104-4/+91
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | (1) Changed the proxy service ownership model -- rather than being a detail of the HTTP stack, it is now a dependency owned by UrlRequestContext. - ProxyService is owned by UrlRequestContext (before was HttpNetworkSession) - ProxyResolver is owned by ProxyService (before was HttpNetworkSession) Being able to share the proxy service is needed in several places, including incognito mode http context (http://crbug.com/3564), and for proxy resolving in the new FTP stack. (2) Added an IPC for getting of the ProxyResolverWinHttp dependency in the plugin process. Not hooked up yet, but intent is to route the proxy resolve requests through the browser process. (3) Changed some unit tests which were depending on the system proxy settings (this was a sideffect of their calling HttpNetworkLayer::CreateFactory(NULL)). (4) Moved the first-time ProxyService::UpdateConfig out of the constructor and into the initial request. Done to avoid startup perf regressions, since the ProxyService construction is now done earlier (on the startup critical path). BUG=3564 Review URL: http://codereview.chromium.org/12938 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6693 0039d316-1c4b-4281-b951-d872f2087c98
* Fix style fro last CL. I had extra space to prevent >> at the end of the ↵brettw@google.com2008-12-101-1/+1
| | | | | | | | template, but didn't remove them when I removed the innter template argument. Review URL: http://codereview.chromium.org/13700 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6692 0039d316-1c4b-4281-b951-d872f2087c98
* Fox more gcc template errors.brettw@google.com2008-12-101-3/+3
| | | | | | Review URL: http://codereview.chromium.org/13699 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6691 0039d316-1c4b-4281-b951-d872f2087c98
* Fix gcc compilation issue. The inner class doesn't need a template decl.brettw@google.com2008-12-101-1/+0
| | | | | | Review URL: http://codereview.chromium.org/13698 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6690 0039d316-1c4b-4281-b951-d872f2087c98
* Add property bag to the build.brettw@google.com2008-12-104-0/+18
| | | | | | Review URL: http://codereview.chromium.org/13320 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6689 0039d316-1c4b-4281-b951-d872f2087c98
* Fixing 4687: Enter in FirstRun UI starts import when Customize link is focued.finnur@google.com2008-12-103-11/+8
| | | | | | | We now properly handle Enter when links are focused. I also made it so that links navigate on KeyDown (when you press Enter or Space) instead of on KeyUp. This matches WebKit and native Windows behavior. Review URL: http://codereview.chromium.org/13321 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6670 0039d316-1c4b-4281-b951-d872f2087c98
* * Write installer result to ClientState key instead of Clients key.kuchhal@chromium.org2008-12-095-1/+16
| | | | | | Review URL: http://codereview.chromium.org/13685 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6655 0039d316-1c4b-4281-b951-d872f2087c98
* Add a property bag which is a typesafe list of arbitrary data that can bebrettw@google.com2008-12-093-0/+275
| | | | | | | associated with any object. Review URL: http://codereview.chromium.org/13676 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6654 0039d316-1c4b-4281-b951-d872f2087c98
* First run is going into infinite recursion if started from master prefscpu@google.com2008-12-091-1/+6
| | | | | | | | | | | | - keeps creating importer processes - the issue is the creation of the first run sentinel file needs to happen before starting the new process. BUG=1535947 Review URL: http://codereview.chromium.org/13312 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6651 0039d316-1c4b-4281-b951-d872f2087c98
* Changes DefaultNonClientView to show the min/max buttons if thesky@google.com2008-12-091-0/+2
| | | | | | | | | | | delegate says it can be minimized. BUG=4083 TEST=none Review URL: http://codereview.chromium.org/13683 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6649 0039d316-1c4b-4281-b951-d872f2087c98
* Bring up ipc tests on POSIX.jeremy@chromium.org2008-12-093-90/+91
| | | | | | Review URL: http://codereview.chromium.org/13158 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6634 0039d316-1c4b-4281-b951-d872f2087c98
* Fixed a link in the about_credits.htmllaforge@chromium.org2008-12-091-1/+1
| | | | | | | Bug: 4793: about:credits LIBXSLT bad homepage link TBR=laforge@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6633 0039d316-1c4b-4281-b951-d872f2087c98
* fix link errorspinkerton@google.com2008-12-091-0/+4
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6629 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup part 4.pkasting@chromium.org2008-12-0912-159/+80
| | | | | | | | | Remove dead/unnecessary resources/identifiers/code. The trickiest bit of this to review are the browser.cc changes, where various commands are no longer initialized multiple times. Review URL: http://codereview.chromium.org/13648 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6628 0039d316-1c4b-4281-b951-d872f2087c98
* step one of some refactoring to allow other platforms to re-use the app ↵pinkerton@google.com2008-12-098-207/+508
| | | | | | | | initialization code. Review URL: http://codereview.chromium.org/13295 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6627 0039d316-1c4b-4281-b951-d872f2087c98
* Disabling a flacky UI test.jcampan@chromium.org2008-12-091-1/+2
| | | | | | | | BUG=5134 TBR=nsylvain Review URL: http://codereview.chromium.org/13303 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6625 0039d316-1c4b-4281-b951-d872f2087c98
* Now we know the delete iter->second call inwtc@google.com2008-12-092-1/+12
| | | | | | | | | | | | RemovePendingRequest causes a request to be removed from pending_requests_. Add the removing_pending_request_ member and some DCHECKS to catch that in action. R=eroman BUG=4749 Review URL: http://codereview.chromium.org/13270 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6622 0039d316-1c4b-4281-b951-d872f2087c98
* Adding a unit test for the AppendExtensionIfNeeded partfinnur@google.com2008-12-093-14/+81
| | | | | | | | | of the SaveFileAsWithFilter function (after splitting it out to a separate function). Review URL: http://codereview.chromium.org/13637 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6618 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-11 20:26:57 +0000