summaryrefslogtreecommitdiffstats
path: root/chrome
Commit message (Collapse)AuthorAgeFilesLines
* Fix crash reporting on Windows.aa@chromium.org2009-12-021-1/+3
| | | | | | | | BUG=29217 Review URL: http://codereview.chromium.org/460028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33614 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 33611 - Fix leaking ExtensionMessageService in ProfileManagerTest.mattm@chromium.org2009-12-023-5/+10
| | | | | | | | | | | | BUG=28824 TEST=tools/valgrind/chrome_tests.sh t unit gtest_filter=ProfileManagerTest.CreateProfile Review URL: http://codereview.chromium.org/455031 TBR=mattm@chromium.org Review URL: http://codereview.chromium.org/458012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33613 0039d316-1c4b-4281-b951-d872f2087c98
* Fix leaking ExtensionMessageService in ProfileManagerTest.mattm@chromium.org2009-12-023-10/+5
| | | | | | | | | BUG=28824 TEST=tools/valgrind/chrome_tests.sh -t unit --gtest_filter=ProfileManagerTest.CreateProfile Review URL: http://codereview.chromium.org/455031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33611 0039d316-1c4b-4281-b951-d872f2087c98
* Put in a "knock it off" checkbox in Mac alerts, to prevent web pages from ↵avi@chromium.org2009-12-021-5/+17
| | | | | | | | | | | locking the user out. Matches existing UI in Linux/Windows. BUG=http://crbug.com/26800 TEST=as in bug Review URL: http://codereview.chromium.org/460025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33610 0039d316-1c4b-4281-b951-d872f2087c98
* Put "make this my home page" link into the tip section.mirandac@chromium.org2009-12-026-51/+65
| | | | | | | | | | | BUG= 28196 TEST= "make this my home page" should show up as a tip. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=33527 Review URL: http://codereview.chromium.org/449073 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33609 0039d316-1c4b-4281-b951-d872f2087c98
* Kill holdback for Http Prioritization experiment. Turn on to 100%.willchan@chromium.org2009-12-023-40/+16
| | | | | | Review URL: http://codereview.chromium.org/458010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33608 0039d316-1c4b-4281-b951-d872f2087c98
* Makes 'Cancel' the default button for extension install/uninstall ↵andybons@chromium.org2009-12-021-2/+9
| | | | | | | | | | confirmation dialogs. BUG=26357 TEST=try to install any extension on Mac, verify that the default (blue) button with the key equivalent of 'Return' is the abort action, NOT the install action. Review URL: http://codereview.chromium.org/463008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33607 0039d316-1c4b-4281-b951-d872f2087c98
* sync: clean up a little bit the character_set_converters code.nick@chromium.org2009-12-022-10/+0
| | | | | | | | | | | Patch from Thiago Farina <thiago.farina@gmail.com> BUG=None TEST=None Review URL: http://codereview.chromium.org/442014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33604 0039d316-1c4b-4281-b951-d872f2087c98
* Gtk: theme certain close buttons:estade@chromium.org2009-12-023-0/+19
| | | | | | | | | | | | | | | | - download shelf - find bar - blocked popup container Notably, don't theme the infobar close button. In a follow up patch, I will fix the findbar and blocked popup container of Windows. BUG=29101 Review URL: http://codereview.chromium.org/454024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33600 0039d316-1c4b-4281-b951-d872f2087c98
* Unload the entire extension when any part of it crashes.phajdan.jr@chromium.org2009-12-023-3/+35
| | | | | | | | | | | Also enable the task_manager_browsertest.cc (where I added the new test) on Linux. TEST=Covered by browser_tests. BUG=21635 Review URL: http://codereview.chromium.org/465007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33599 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes two problems caused by core animation race conditions. One involves ↵andybons@chromium.org2009-12-021-11/+24
| | | | | | | | | | clicking a browser action multiple times very quickly. The other has to do with the frame of the popup changing mid-animation. BUG=none TEST=none Review URL: http://codereview.chromium.org/464004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33598 0039d316-1c4b-4281-b951-d872f2087c98
* linux_view: implement learn-more link in crash pagekuan@chromium.org2009-12-025-33/+64
| | | | | | | | | | | | | | | | | - enable mouse-over event to show hand-cursor - enable mouse-click event, which launches help url win and linux_view: use TabContents to launch url for link in crash page - was using BrowserList::GetLastActive, but in chrome frame, this is null, so url can't launch. - now, TabcontentsView passes its TabContents when creating SadTabView. - SadTabView only creates learn-more link if TabContents is not null. BUG=27298,29034 TEST=chromeos: verify that link in crash page shows hand cursor on mouse over, and launches help url when clicked. win, chromeos: link in crash page can be launched successfully in chrome-frame release. Review URL: http://codereview.chromium.org/460021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33595 0039d316-1c4b-4281-b951-d872f2087c98
* Misc. formatting and editing.kathyw@google.com2009-12-024-24/+24
| | | | | | | | | | TBR=aa BUG=none TEST=none Review URL: http://codereview.chromium.org/455034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33591 0039d316-1c4b-4281-b951-d872f2087c98
* Disable TabRestoreUITest.* under valgrind on Macstuartmorgan@chromium.org2009-12-021-0/+4
| | | | | | | | | BUG=29208 TEST=Happier Mac UI valgrind bots Review URL: http://codereview.chromium.org/465010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33590 0039d316-1c4b-4281-b951-d872f2087c98
* Updating the extensions sample page, part 2.finnur@chromium.org2009-12-021-0/+1
| | | | | | | | | | | | | | Adding the newly created Email this page extension. (this time updating the docs page, not just the static page). BUG=None TEST=None Review URL: http://codereview.chromium.org/466008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33587 0039d316-1c4b-4281-b951-d872f2087c98
* Extensions: stop using font:menu on a couple of extensions examples.estade@chromium.org2009-12-022-3/+5
| | | | | | | | | | Changing to font-family: sans-serif; (at least on my system) does not seem to actually change the font that is selected, however, font-size: 0.8em; does change the size of the font. BUG=29095 Review URL: http://codereview.chromium.org/450040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33581 0039d316-1c4b-4281-b951-d872f2087c98
* Updating the extensions sample page.finnur@chromium.org2009-12-021-0/+1
| | | | | | | | | | | Adding the newly created Email this page extension. BUG=None TEST=None Review URL: http://codereview.chromium.org/466005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33579 0039d316-1c4b-4281-b951-d872f2087c98
* Minor polish to the EmailThisPage extension. finnur@chromium.org2009-12-024-26/+54
| | | | | | | | | | | | Add the page selection to the body of the email, if something is selected. BUG=None TEST=None Review URL: http://codereview.chromium.org/460002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33576 0039d316-1c4b-4281-b951-d872f2087c98
* Validate privacy blacklist format when validating an extensionphajdan.jr@chromium.org2009-12-025-5/+69
| | | | | | | | | | | containing a privacy blacklist. TEST=Covered by unit_tests. BUG=21541 Review URL: http://codereview.chromium.org/453016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33573 0039d316-1c4b-4281-b951-d872f2087c98
* Tweak how we force the locale from the browser, this allow browser_tests to ↵thomasvl@chromium.org2009-12-021-6/+8
| | | | | | | | | | startup without doing the cocoa locale force (since it isn't valid there). BUG=none TEST=ntp tips, history times stamps, etc. all still in the right locale Review URL: http://codereview.chromium.org/449076 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33571 0039d316-1c4b-4281-b951-d872f2087c98
* Remove DOMWindow event accessor crash from known crashes. A v8ager@chromium.org2009-12-021-3/+0
| | | | | | | | | | bindings patch has been landed that should take care of this one. BUG=29041 TEST=none Review URL: http://codereview.chromium.org/459014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33567 0039d316-1c4b-4281-b951-d872f2087c98
* Move some XDG code from chrome to base, make DIR_USER_CACHE generic rather ↵thestig@chromium.org2009-12-0210-362/+37
| | | | | | | | | | than Chromium specific, and clean up a few headers. BUG=none TEST=none Review URL: http://codereview.chromium.org/449048 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33565 0039d316-1c4b-4281-b951-d872f2087c98
* Still fixing ChromiumOS build.phajdan.jr@chromium.org2009-12-021-0/+1
| | | | | | | | TBR=thestig Review URL: http://codereview.chromium.org/459013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33564 0039d316-1c4b-4281-b951-d872f2087c98
* Fix Windows build by #including needed header.phajdan.jr@chromium.org2009-12-021-0/+1
| | | | | | | | TBR=sky Review URL: http://codereview.chromium.org/463003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33563 0039d316-1c4b-4281-b951-d872f2087c98
* Fix ChromeOS build by #including needed header.phajdan.jr@chromium.org2009-12-021-0/+1
| | | | | | | | TBR=sky Review URL: http://codereview.chromium.org/459012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33562 0039d316-1c4b-4281-b951-d872f2087c98
* [GTTF] Reduce header dependencies in chrome.phajdan.jr@chromium.org2009-12-0242-107/+168
| | | | | | Review URL: http://codereview.chromium.org/457025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33561 0039d316-1c4b-4281-b951-d872f2087c98
* Splitting off tests in chrome.gyp into a separate gypi.bradnelson@google.com2009-12-022-1673/+1698
| | | | | | | | | | BUG=None TEST=None TBR=gregoryd Review URL: http://codereview.chromium.org/459011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33553 0039d316-1c4b-4281-b951-d872f2087c98
* Splitting out browser into a separate gypi file.bradnelson@google.com2009-12-022-2357/+2376
| | | | | | | | | | | BUG=None TEST=None TBR=gregoryd Review URL: http://codereview.chromium.org/455028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33550 0039d316-1c4b-4281-b951-d872f2087c98
* Update network priorities to support better granularitymbelshe@google.com2009-12-021-4/+13
| | | | | | | | | | | | | | of resource loading from WebKit into the network stack. In order to fully make these work, webkit changes are needed as well. BUG=none TEST=none Review URL: http://codereview.chromium.org/452033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33546 0039d316-1c4b-4281-b951-d872f2087c98
* Make the safe_browsing_util.cc function definition order match the ↵pkasting@chromium.org2009-12-022-243/+257
| | | | | | | | | | declaration order. BUG=none TEST=none Review URL: http://codereview.chromium.org/460008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33545 0039d316-1c4b-4281-b951-d872f2087c98
* Removed TabContentsDelegate::ShouldDisplayURLField() which is unused anywhere.akalin@chromium.org2009-12-021-5/+0
| | | | | | | | | BUG= TEST=trybots Review URL: http://codereview.chromium.org/462001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33543 0039d316-1c4b-4281-b951-d872f2087c98
* Ok, here is a different approach at this change.aa@chromium.org2009-12-0211-65/+194
| | | | | | | | | | | | Instead of storing pointers into a vector, store offsets. That way, if the vector resizes, we should still be OK. Also, add a DCHECK that we only enter this method once, which is my current assumption. Review URL: http://codereview.chromium.org/457028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33541 0039d316-1c4b-4281-b951-d872f2087c98
* Updating trunk VERSION from 261.0 to 262.0chrome-bot@google.com2009-12-021-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33540 0039d316-1c4b-4281-b951-d872f2087c98
* Added protected destructor to BrowserWindow.akalin@chromium.org2009-12-021-0/+2
| | | | | | | | | BUG= TEST=trybots Review URL: http://codereview.chromium.org/460006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33539 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 33527 - Put "make this my home page" link into the tip section.mirandac@chromium.org2009-12-025-54/+43
| | | | | | | | | | | | BUG= 28196 TEST= "make this my home page" should show up as a tip. Review URL: http://codereview.chromium.org/449073 TBR=mirandac@chromium.org Review URL: http://codereview.chromium.org/460007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33538 0039d316-1c4b-4281-b951-d872f2087c98
* Add new flash crash to known_crashes.txtwillchan@chromium.org2009-12-021-0/+3
| | | | | | | | BUG=29149 Review URL: http://codereview.chromium.org/460005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33537 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: Use upstream google-breakpad instead of our fork.thestig@chromium.org2009-12-023-8/+9
| | | | | | | | BUG=28276 TEST=dump_syms works with ToT Chrome. Review URL: http://codereview.chromium.org/414049 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33534 0039d316-1c4b-4281-b951-d872f2087c98
* Make sure we don't dismiss extension popups when the focusjcampan@chromium.org2009-12-028-10/+35
| | | | | | | | | | | | | | | changes for a child window of the popup, as it is the case with select popups. BUG=28110 TEST=Make sure extension popups are still working as expected. Open an extension popup with a select popup (combo box) in it. Click on the select to bring up its popup, the extension popup should stay opened. Review URL: http://codereview.chromium.org/459005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33533 0039d316-1c4b-4281-b951-d872f2087c98
* Delete old version directories of installed extensions during garbagempcomplete@chromium.org2009-12-023-8/+43
| | | | | | | | | | collection. BUG=28884 Review URL: http://codereview.chromium.org/455026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33530 0039d316-1c4b-4281-b951-d872f2087c98
* Take 2 at: Fix the opacity of titlebars on the NTP page.tony@chromium.org2009-12-022-5/+5
| | | | | | | | | | | | We were accidentally setting the opacity to 1/255. This bug was introduced in r32643. Fix the unittest too. BUG=29107 Review URL: http://codereview.chromium.org/461003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33529 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 33526 - Fix the opacity of titlebars on the NTP page. We were ↵tony@chromium.org2009-12-021-2/+2
| | | | | | | | | | | | | | | | | accidentally setting the opacity to 1/255. This bug was introduced in r32643. BUG=29107 Review URL: http://codereview.chromium.org/452040 TBR=tony@chromium.org Review URL: http://codereview.chromium.org/460004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33528 0039d316-1c4b-4281-b951-d872f2087c98
* Put "make this my home page" link into the tip section.mirandac@chromium.org2009-12-025-43/+54
| | | | | | | | | BUG= 28196 TEST= "make this my home page" should show up as a tip. Review URL: http://codereview.chromium.org/449073 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33527 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the opacity of titlebars on the NTP page. We were accidentallytony@chromium.org2009-12-021-2/+2
| | | | | | | | | | | | setting the opacity to 1/255. This bug was introduced in r32643. BUG=29107 Review URL: http://codereview.chromium.org/452040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33526 0039d316-1c4b-4281-b951-d872f2087c98
* Speculative fix for ChromeFrame crash in bug ↵ananta@chromium.org2009-12-024-8/+11
| | | | | | | | | | | | | | | | | | | | http://code.google.com/p/chromium/issues/detail?id=29025 The crash occurs while dereferencing the automation channel to send out the SetCookie IPC message on the automation channel to the host browser. Based on what I could see from the crash dump and the code it seems like there could be a scenario where the AutomationResourceContext object could be destroyed while the AutomationCookieStore object is still around and thus ends up with a stale pointer which crashes when dereferenced. Fix is to ensure that all related code paths hold on to a refcounted AutomationResourceContext instance. I will look into whether it is possible to come up with a unit test for this. Bug=29025 Review URL: http://codereview.chromium.org/450020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33524 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: don't apply gtk theme to the info bubble for the extension popup.estade@chromium.org2009-12-025-5/+17
| | | | | | | | BUG=29096 Review URL: http://codereview.chromium.org/450043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33523 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Support plain text target as source for bookmark drags initiated from ↵estade@chromium.org2009-12-023-5/+15
| | | | | | | | | | | bookmark manager and bookmark bar. BUG=29029 TEST=drag a bookmark into an <input> field Review URL: http://codereview.chromium.org/449067 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33522 0039d316-1c4b-4281-b951-d872f2087c98
* Windows/Linux: remove useless SetProfile() on tab selection.viettrungluu@chromium.org2009-12-022-2/+0
| | | | | | | | | | (We have a fixed profile per browser.) The Mac code never had this SetProfile(). BUG=none TEST=none Review URL: http://codereview.chromium.org/450038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33519 0039d316-1c4b-4281-b951-d872f2087c98
* Remove emtpy lists and empty dictionaries from Preferences andtony@chromium.org2009-12-021-1/+2
| | | | | | | | | | Local State when writing to disk. BUG=28836 Review URL: http://codereview.chromium.org/449074 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33518 0039d316-1c4b-4281-b951-d872f2087c98
* Hold a reference to object returned by GetGlobalHostResolver().eroman@chromium.org2009-12-011-11/+16
| | | | | | | | | | This change is to help diagnose bug 29038. BUG=29038 Review URL: http://codereview.chromium.org/455025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33510 0039d316-1c4b-4281-b951-d872f2087c98
* Build fix for Linux perf bot.pkasting@chromium.org2009-12-011-0/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33509 0039d316-1c4b-4281-b951-d872f2087c98