| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
and caused a crash spike in ChromeBot.
Original change description:
Close browser window synchronously during UI test
tear down. This is an effor to reduce random
failure due to browser crash with multiple window
open during shutdown.
Review URL: http://codereview.chromium.org/113171
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15693 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
from src\third_party\courgette
to src\courgette and src\courgette\third_party
Fixed #includes
Added properties to ignore generated files:
C:\c5\src>svn pg svn:ignore courgette
courgette.xcodeproj
courgette.sln
courgette_fuzz.vcproj
courgette_lib.vcproj
courgette_minimal_tool.vcproj
courgette_tool.vcproj
courgette.vcproj
courgette_unittests.vcproj
SConstruct
courgette_fuzz.scons
courgette_lib.scons
courgette_main.scons
courgette_minimal_tool.scons
courgette.scons
courgette_tool.scons
courgette_unittests.scons
Review URL: http://codereview.chromium.org/115062
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15692 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
for RTL Chrome.
The fix is to position the 'pop-ups blocked' bar at the bottom left for RTL chrome.
Test:
1. Launch Hebrew Chrome
2. load http://www.brg8.com/
3. Observe the 'pop-up blocked' bar after the page load.
Review URL: http://codereview.chromium.org/89004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15691 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
The reference build is a scons Release build cut at r15674.
Review URL: http://codereview.chromium.org/116002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15689 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15688 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
standard_layout to new locations in app/ and views/
http://crbug.com/11387
Review URL: http://codereview.chromium.org/113143
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15687 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
frame.
BUG=11661
Review URL: http://codereview.chromium.org/115144
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15686 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patch fixes an assertion failure that occurs when Windows is back
from sleep.
BUG=11141
Original changelist is http://codereview.chromium.org/109034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15685 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
a browser window is closed.
BUG=http://crbug.com/11659
Review URL: http://codereview.chromium.org/113155
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15682 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=8604
Review URL: http://codereview.chromium.org/113166
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15681 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
that they'd really like another layout.R=skyTEST=none
Review URL: http://codereview.chromium.org/113133
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15680 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
http://crbug.com/11387
Review URL: http://codereview.chromium.org/115143
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15678 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/113164
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15677 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
locale UI tests on windows and linux.
Not sure if this will work on mac with resource bundles, so leaving
this disabled for now.
BUG=9758
Review URL: http://codereview.chromium.org/113158
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15676 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Add a target to build a dmg out of the app.
Add a target to all that will build everything and the dmg (since we don't include the dmg in all since developers really don't need to wait for that).
Review URL: http://codereview.chromium.org/113152
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15672 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Sato (see http://codereview.chromium.org/115050 ), r=me.
BUG=8071,11559
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15671 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Remove "show popup notification" option, pref, and all associated machinery.
* Toggling whitelisting on for a site no longer hides the "manage" button.
* Toggling whitelisting off for a site re-blocks (not closes) its popups, and does not hide the "manage" button.
Also rips the whitelist hooks out of TabContents in preparation for getting the whitelist values directly from the BlockedPopupContainer, since there was no reason to plumb everything through TabContents.
BUG=11440
Review URL: http://codereview.chromium.org/115112
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15670 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
on linux to make sure the chrome.pak file is generated and I think
it's needed on windows as well (see http://codereview.chromium.org/19432 ).
BUG=11645
Review URL: http://codereview.chromium.org/113159
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15669 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/113145
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15668 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The line height for titles in the warning interstitials is too small.
In English, a second line starts to abut the line above it if the
browser is narrow.
In languages with ligatures above the line, a second line bleeds
into the first, impairing readability. This is compounded in languages
like Tamil and Marathi, where the title of the interstitial warning
is quite long and likely to break on two lines.
My solution is to set the line height to 140% in the .title.
TEST= Navigate to ianfette.org with Chrome's lang set to ta or mr. The title
lines in the anti-malware blocking page should not bleed together.
BUG= 1837411
Review URL: http://codereview.chromium.org/113140
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15667 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
- Set focus to render view after finishing find.
- Make all custom buttons unfocusable. (matches windows chrome)
- Let the GtkWindow's default keyhandler run when the child widget fails to handle the key press event. Previously I optimized this out, but it turns out to be necessary because when a tab is pressed while focus is at the boundary of a child widget (e.g. the last button in an infobar) the focus has to traverse to the next child widget (e.g. the render view), and this is handled by the GtkWindow's key handler (and not the infobar's key handler).
BUG=8604,11560
Review URL: http://codereview.chromium.org/115113
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15666 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Define a platform specific type IconGroupID which helps with caching multiple requests for the same icon. Previously we just used the file path (or the extension), but on POSIX we use mime types rather than extensions.
Review URL: http://codereview.chromium.org/113120
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15665 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
automation interface.
Review URL: http://codereview.chromium.org/115134
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15663 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15657 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/113148
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15651 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/114016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15650 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
assert.
I tried using a debugger to repro, but was unable to.
BUG=9914
Review URL: http://codereview.chromium.org/115111
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15649 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
http://crbug.com/11628
Review URL: http://codereview.chromium.org/113134
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15642 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Patch contributed by Robert Sesek <rsesek@bluestatic.org>
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15640 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
hiding/showing. Record default browser metric.
Review URL: http://codereview.chromium.org/115129
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15638 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also made BookmarkStorage completely responsible for
migration of bookmark data from history database.
Previously the logic crossed file and class boundaries a few
times. This made it a bit hard to follow. Now it should be
a bit more clear.
Made ImportantFileWriter also batch data serializations.
TEST=Make sure that bookmarks still work. Also test migrating bookmarks from history database.
http://crbug.com/10618
Review URL: http://codereview.chromium.org/99192
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15635 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/115124
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15633 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/113100
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15632 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/115122
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15631 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
which means it tries to do the copy before the target is built
and we therefore can't attach the copy of npapi_layout_test_plugin.dll
to the target that builds it. Work around this problem by
attaching the 'copies' setting to 'test_shell_common', which is
the one target that depends on the 'npapi_layout_test_plugin' target.
Review URL: http://codereview.chromium.org/115120
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15628 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15625 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
the checked-in chrome.sln configuration.
Review URL: http://codereview.chromium.org/115118
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15623 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* build\all.gyp now uses webkit\webkit.gyp and
webkit\tools\test_shell\test_shell.gyp.
* 'svn remove' checked-in .sln and .vcproj files that will now
become gyp-generated files. (We'll leave the other old ones
in place, uncalled, and remove them with a later CL.)
* Add generated *.sln and *.vcproj files to svn:ignore on
the relevant directories.
* Update various chrome\**.vcproj files with the new gyp directory
in which various generated webkit files will now appear.
* Update the checked-in chrome\chrome.sln with all (?) the changes
necessary to reflect the new gyp generation.
Review URL: http://codereview.chromium.org/115115
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15618 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
- Change async ApplyAccelerator to sync RunCommand.
- Renable disabled tests.
Review URL: http://codereview.chromium.org/113129
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15612 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
http://codereview.chromium.org/100195
The effective changes were:
1) Adding av_register_protocol into the def file for ffmpeg in windows.
2) Commenting out the drawing glue code for non-skia platforms.
3) Fixing some mac compilation error caused by code drift.
Review URL: http://codereview.chromium.org/99306
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15611 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
r15607 broke the build
TBR=brg, thestig
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15608 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
base::DIR_EXE could be a very long path, which causes socket creation to fail because socket paths have a limited length. Let's use a temp directory instead. We should also clean up the temp dir when we're done.
Also abort if the socket path is too long.
Review URL: http://codereview.chromium.org/115107
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15607 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15606 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15605 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15604 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
windows view code and do the same thing.
BUG=11083
Review URL: http://codereview.chromium.org/115109
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15602 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
rough, but makes things work a bit more.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/113123
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15598 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=creis
Review URL: http://codereview.chromium.org/115110
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15596 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- BrowserInit is now a instanciable class
- The 'bag of static functions' part is mostly unchanged
- unused members in the interface moved to the cc file
TEST= no visible change. interactive UI tests sufice
BUG=9706
Review URL: http://codereview.chromium.org/113113
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15595 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Changed ExtensionHost so that it returns NULL if it doesn't have
a browser, instead of getting the last active one. The problem
is that if ExtensionHost returns the last active browser at the
time it's constructed, it might be garbage by the time it is
used.
Changed tab functions to use more consistent logic to determine
the 'current' browser to operate on.
Review URL: http://codereview.chromium.org/115071
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15587 0039d316-1c4b-4281-b951-d872f2087c98
|