| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(1) Adds the ability to specify the address family on a per-request basis.
(2) Exposes a --disable-ipv6 flag to chrome that changes the default address family from AF_UNSPEC to AF_INET (same sort of thing Firefox does).
(3) Changes the backing datastructure for HostCache:EntryMap and HostResolverImpl::JobMap from a "hash_map" to a "std::map". This was for consistency with other code (when I went to add a custom hash trait, I couldn't find any existing code which was using hashmap for custom keys).
(4) Updates about:net-internals to display an address family for the hostcache dump (since it is now a part of the key).
This change is in anticipation of turning off IPv6 host resolving in the PAC utility functions (see bug 24641). But it is also a feature addition.
BUG=24641
TEST=HostCacheTest.AddressFamilyIsPartOfKey
Review URL: http://codereview.chromium.org/302010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29686 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Before:
current_locale->default_locale
Now:
current_locale->chain_of_parent_locales->default_locale
If default_locale is de, and current locale en_US, we follow:
en_US -> en -> de
en is not a Chrome locale (only en_US, en_GB are), but we fake it to allow this kind of fallback.
Developers can implement common locale root with most of the messages (like en) and put locale specifics in en_GB (color->colour) or en_US. You can even symlink en and en_US and save on work.
I am planning on fixing loading local resources too, to use this child->parent fallback.
BUG=12131
Review URL: http://codereview.chromium.org/293037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29684 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
The test was still failing
Review URL: http://codereview.chromium.org/314001
TBR=yurys@google.com
Review URL: http://codereview.chromium.org/292051
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29683 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
functions that are now public. Fix a few style errors. Make some functions shorter. Remove "using" directives since most of the file ignored them anyways. Remove unneeded #includes.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/292041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29681 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Windows only change.
This is basically landing jschuh change http://codereview.chromium.org/293040
TEST=none
BUG=25366
Review URL: http://codereview.chromium.org/313009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29677 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
test and for permitting the tests to be run regardless of underlying platform. Also some minor fixes and cleanup.
BUG=none
TEST=none
REVIEW=http://codereview.chromium.org/269016/
TBR=kkania@chromium.org
Review URL: http://codereview.chromium.org/293054
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29674 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Also fix canvas text drawing bugs for certain vertical alignments.
BUG=25267
TEST=about:crash
Review URL: http://codereview.chromium.org/307015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29673 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/292038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29672 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
and allow remembering the "Do Nothing" choice.
BUG=none
TEST=Verify that "Do Nothing" is the left button, and that clicking the "Remember" checkbox remembers the "Do Nothing" state.
Review URL: http://codereview.chromium.org/314003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29671 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
RenderViewHostDelegate::FormFieldHistory to better reflect the purpose of the interface.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/294030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29669 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
permitting the tests to be run regardless of underlying platform. Also some minor fixes and cleanup.
BUG=none
TEST=none
REVIEW=http://codereview.chromium.org/269016/
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29668 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/295039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29667 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
otherwise the profile pointer may go stale if it was opened from an Incognito
window.
Simplify the check that already does this on Mac. GetOriginalProfile() returns
the profile it's called on, if it isn't incognito.
BUG=23359
TEST=open Incognito window, right-click in omnibox, Edit Search Engines,
close Incog window, edit an engine
Review URL: http://codereview.chromium.org/307010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29666 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The extension team's plan is to get rid of extension shelf entirely.
This is also going to fix a crash.
TEST=none
BUG=25106
Review URL: http://codereview.chromium.org/313006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29665 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
TBR=aa
Review URL: http://codereview.chromium.org/313008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29661 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This surfaced because I moved global shortcut handling before menu dispatch recently, and global keyboard handling didn't look at the opt button, so it thought cmd-opt-left meant cmd-left and swallowed the event.
BUG=25396
TEST=Focus text box in web. cmd-opt-left/right should switch tabs, cmd-left/right should move cursor in text box. Focus web background. cmd-opt-left/right should switch tabs, cmd-left/right should do history navigation. Focus omnibox. cmd-opt-left/right should still switch tabs, cmd-left/right should move cursor. cmd-1/2 should switch tabs in all three places, cmd-opt-1/2 should not do anything.
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=29646
Reverted: http://src.chromium.org/viewvc/chrome?view=rev&revision=29648
Review URL: http://codereview.chromium.org/313004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29660 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
We expand it to $HOME or the appropriate /home/foobar.
BUG=18200
TEST=Extended the unit test with test cases.
Review URL: http://codereview.chromium.org/300026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29657 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/293050
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29656 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
(r29315 was http://codereview.chromium.org/273063.) r29315 incorrectly changed the code for the Text Encoding menu entry to IDC_ENCODING_AUTO_DETECT (from IDC_ENCODING_MENU), which caused it to be incorrectly recognized as the auto detect menu item....
BUG=25397
TEST=Check the View->Text Encoding menu under various circumstances.
Review URL: http://codereview.chromium.org/292047
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29652 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
that they can be highlighted / depressed independently.
Got alignment of buttons right.
Support hover and pushed in StatusAreaButton.
Share status area button code.
New icons for battery and wifi.
New images.
Review URL: http://codereview.chromium.org/300018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29651 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This surfaced because I moved global shortcut handling before menu dispatch recently, and global keyboard handling didn't look at the opt button, so it thought cmdoptleft meant cmdleft and swallowed the event.
BUG=25396
TEST=Focus text box in web. cmdoptleft/right should switch tabs, cmdleft/right should move cursor in text box. Focus web background. cmdoptleft/right should switch tabs, cmdleft/right should do history navigation. Focus omnibox. cmdoptleft/right should still switch tabs, cmdleft/right should move cursor. cmd1/2 should switch tabs in all three places, cmdopt1/2 should not do anything.
Review URL: http://codereview.chromium.org/313004
TBR=thakis@chromium.org
Review URL: http://codereview.chromium.org/306025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29648 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This surfaced because I moved global shortcut handling before menu dispatch recently, and global keyboard handling didn't look at the opt button, so it thought cmd-opt-left meant cmd-left and swallowed the event.
BUG=25396
TEST=Focus text box in web. cmd-opt-left/right should switch tabs, cmd-left/right should move cursor in text box. Focus web background. cmd-opt-left/right should switch tabs, cmd-left/right should do history navigation. Focus omnibox. cmd-opt-left/right should still switch tabs, cmd-left/right should move cursor. cmd-1/2 should switch tabs in all three places, cmd-opt-1/2 should not do anything.
Review URL: http://codereview.chromium.org/313004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29646 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG:None, since there is already multiple similar stacks in this file.
TBR
Review URL: http://codereview.chromium.org/307019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29645 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29642 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Move security related methods out of WebKit.h into its own class WebSecurityPolicy. This involves these functions:
- registerURLSchemeAsLocal
- registerURLSchemeAsNoAccess
- whiteListAccessFromOrigin
- resetOriginAccessWhiteLists
BUG=24601
TEST=Compiled locally, try bot'ed.
Review URL: http://codereview.chromium.org/293021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29639 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/314001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29635 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=apavlov
Review URL: http://codereview.chromium.org/313002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29630 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29629 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=12497,24756
TEST=LayoutTests/fast/websockets success
Review URL: http://codereview.chromium.org/243108
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29626 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=25294,24214
TEST=DevToolsExtensionDebugTest.TestContentScriptIsPresent
Review URL: http://codereview.chromium.org/295020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29623 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
OnKillFocus() is being called during destruction, and tries to access a render_widget_host_ which has already been NULLed.
BUG=25290, 24248
TBR=jcampan
Review URL: http://codereview.chromium.org/308014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29607 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Introduce a flag --noclearprofile to instruct reliability test to not clear
profile before firing off the browser. This is so avoid unnecessary disk
writes. (The default value of this flag is OFF, so win reliability bot should
continue to behave as is). Mac Chromebot would fire several instances of
Chrome at a time, and I want to minimize the load it generates. I understand
that I should begin with a clean profile, so I clean-up the user-data-dir
after every few runs, rather than cleaning every single time.
BUG=25271
TEST=reliability_tests should work as is on Win
Review URL: http://codereview.chromium.org/300014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29598 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
John says the DB thread always gets shut down by the IO thread, so the change is unnecessary, also, it caused valgrind leaks.
BUG=25245
Review URL: http://codereview.chromium.org/293039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29596 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
be replaced with 'and' in the target language unless it's good to use '&' to mean 'and' in the language.
BUG=24705
TEST=NONE
Review URL: http://codereview.chromium.org/307008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29589 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=25245
TEST=?
Review URL: http://codereview.chromium.org/295032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29588 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Also apply the default border for non-gtk themes.
BUG=23390
TEST=none
Review URL: http://codereview.chromium.org/304012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29587 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=None
BUG=0
Review URL: http://codereview.chromium.org/274076
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29586 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
see the bug details.
This gets us most of the way there. We have made minor
course corrections since the mocks were introduced (no
date will be shown, no "Get more extensions" link is
visible and the name is not linked).
Known issues:
The only thing missing is the fact that we show a default
plugin icon for each extension (as opposed to the icon for
the extension).
BUG=12119
TEST=Open chrome://extensions and all the buttons and
links should work (Developer Tools, Enable, Disable,
Reload, Uninstall, Load, Pack, Update, etc).
Review URL: http://codereview.chromium.org/293028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29584 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Regenerated all the doc to include these styles.
Also added static/pageAction.html, which was missing
from an earlier CL.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/292021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29583 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/306018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29582 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
The badge can now extend beyond the boundary of the image.
BUG=24644
Review URL: http://codereview.chromium.org/297014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29581 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
data structure.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/306014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29580 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/292001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29579 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
By overriding SkipDefaultKeyEventProcessing in View, it will ensure that the current hackish implementation of Toolbar request focus will be dealt before any other focus related actions and accelerators.
BUG=8239
TEST=Press ESC while in accessibility mode.
Review URL: http://codereview.chromium.org/272024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29572 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
The theme work caused a check that had been included to see if the frame view should be painted as active even if it was inactive. This reintroduces that check.
http://crbug.com/20966
TEST=see bug
Review URL: http://codereview.chromium.org/303012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29571 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
existed). Add unit tests for both behaviors. Add metrics to match windows code.
BUG=24466
TEST=if bookmark existed prior to clicking star, esc should leave it. if clicking star added bookmark, esc should remove it.
Review URL: http://codereview.chromium.org/300022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29562 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
the net/ module.
This CL also tweaks some existing WebFrameClient methods:
1) to ensure that they have a WebFrame pointer for context
2) to rename cannotShowURLError to cannotHandleRequestError
to better match the canHandleRequest method.
R=yaar
BUG=24606
TEST=none
Review URL: http://codereview.chromium.org/306011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29561 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
crash on Vista"
Original description:
Implement badges for page actions. Also add badge text color API.
Also change color APIs from wanting ARGB to RGBA.
BUG=24635
BUG=24644
BUG=25215
Review URL: http://codereview.chromium.org/293031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29556 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=11547
Review URL: http://codereview.chromium.org/302011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29555 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
http://crbug.com/24734
TEST=Start Chrome, Command-o, Command-q, should quit cleanly.
TEST=download a file. Should be able to Quit the browser cleanly.
TEST=Open two windows with one tab apiece. Drag one to the other. Should not crash.
Review URL: http://codereview.chromium.org/295028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29554 0039d316-1c4b-4281-b951-d872f2087c98
|