summaryrefslogtreecommitdiffstats
path: root/chrome
Commit message (Collapse)AuthorAgeFilesLines
* linux plugins: eliminate GtkWidget* from plugin processevan@chromium.org2009-06-263-4/+31
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | [retry with mac hopefully fixed this time] GtkWidget* (and its wrapper, gfx::NativeView) only work within a single process. Plugins already work with a lower-level type that works across processes -- an X Window id. The parent of a plugin is an HWND on windows, but it's an X Window id on X. So we introduce a new typedef wrapping that and push it through all the places in the code that needs it. Since we no longer have a GtkSocket in the WebPluginDelegateImpl, we need to do a bit more work in the WebViewDelegate (aka the browser process in the multiproc world). We also need the plugin host (the browser) to track the GtkSockets that are hosting the plugin, as well as destroy them when necessary. To do this we require the plugin owner to grab the plug-removed signal rather than putting its handler in GtkPluginContainer; this is the way it worked before I'd refactored into GtkPluginContainer so it shouldn't be so bad. This change still only works in test_shell, but the refactoring should translate to the multiprocess case pretty easily. Review URL: http://codereview.chromium.org/146009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19387 0039d316-1c4b-4281-b951-d872f2087c98
* Fix crash 15371finnur@chromium.org2009-06-261-1/+2
| | | | | | | | | | | We need to null check the return from GetActiveEntry. BUG=15371 TEST=Watch the crash data from the field and make sure the crash is gone. Review URL: http://codereview.chromium.org/147214 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19386 0039d316-1c4b-4281-b951-d872f2087c98
* fix windows build break.kuchhal@chromium.org2009-06-261-0/+2
| | | | | | Review URL: http://codereview.chromium.org/147222 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19385 0039d316-1c4b-4281-b951-d872f2087c98
* Given the results of Rohit's investigation, I think that the times that we'remark@chromium.org2009-06-265-34/+49
| | | | | | | | | | | | | getting out of the pageload tests right now are highly suspect because we're not actually getting the bits from each page to the screen. As such, I'm much less inclined to treat the "regression" in these tests as a problem. BUG=15232 TEST=throbber changes between waiting (gray) and loading (blue) at appropriate times; animation still disabled Review URL: http://codereview.chromium.org/147211 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19383 0039d316-1c4b-4281-b951-d872f2087c98
* Enable Firefox import on OS X. No UI yet.kuchhal@chromium.org2009-06-2611-201/+352
| | | | | | Review URL: http://codereview.chromium.org/143001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19381 0039d316-1c4b-4281-b951-d872f2087c98
* Remove WebFrame::CaptureImage in favor of having consumers call Layoutdarin@chromium.org2009-06-262-8/+16
| | | | | | | | | | | | and Paint manually on the WebView. BUG=10034 TEST=none R=brettw Review URL: http://codereview.chromium.org/147212 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19379 0039d316-1c4b-4281-b951-d872f2087c98
* Enable back the test disabled in r19348,r19345 since dank disabled them fromnirnimesh@chromium.org2009-06-261-3/+0
| | | | | | | | valgrind itself. Review URL: http://codereview.chromium.org/147213 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19378 0039d316-1c4b-4281-b951-d872f2087c98
* Adding chrome start-up parameters to information passed back in breakpad crashcpu@google.com2009-06-261-20/+42
| | | | | | | | | | | | | - we collect the first two params : switch-1 and switch-2 - up to 64 chars, then it truncates BUG=b/1910452 TEST=starting chrome should work as usual, otherwise see the bug Review URL: http://codereview.chromium.org/149034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19376 0039d316-1c4b-4281-b951-d872f2087c98
* Fix bug when launching chromecpu@google.com2009-06-262-5/+4
| | | | | | | | | | | | - Toast experiment was missing a space before "--" - Quote the first param (exe path) because it can contain spaces BUG= none TEST=chrome should uninstall as usual (launches chrome to confirm user action) Review URL: http://codereview.chromium.org/149048 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19373 0039d316-1c4b-4281-b951-d872f2087c98
* Change ExtensionHost to use notificationserikkay@chromium.org2009-06-269-60/+36
| | | | | | | | | | | rather than direct communication with ExtensionProcessManager. This simplifies ownership and lifetime issues which allows me to also revert the change that made ExtensionProcessManager owned by ExtensionsService. Review URL: http://codereview.chromium.org/147208 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19370 0039d316-1c4b-4281-b951-d872f2087c98
* Remove dependency on NavigationEntry from RenderViewHost. The code forbrettw@chromium.org2009-06-263-66/+47
| | | | | | | | | | converting a NavigationEntry to a Navigate message is now in TabContents and it will send the params rather than the NavigationEntry to the RenderViewHost. I also removed "virtual" fron a bunch of functions that were never overridden. Review URL: http://codereview.chromium.org/147128 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19369 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 19361.davemoore@chromium.org2009-06-266-89/+38
| | | | | | | tbr=darin Review URL: http://codereview.chromium.org/149081 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19368 0039d316-1c4b-4281-b951-d872f2087c98
* Disable BookmarkEditorGtkTest.* instead of just one, sincedkegel@google.com2009-06-261-1/+1
| | | | | | | | | | they all run the init code that makes Valgrind unhappy. BUG=http://crbug.com/15445 TEST=none Review URL: http://codereview.chromium.org/149078 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19365 0039d316-1c4b-4281-b951-d872f2087c98
* Revert cl 19359 due to browser_tests timeout.tim@chromium.org2009-06-2621-207/+157
| | | | | | | TBR=nsylvain Review URL: http://codereview.chromium.org/147206 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19363 0039d316-1c4b-4281-b951-d872f2087c98
* Restrict how often javascript can annoy the user with the print dialog. If ↵sverrir@google.com2009-06-264-15/+62
| | | | | | | | | | | | | a page continuously calls print() through javascript and the user cancels the printing no other printer dialog will be shown for 15 seconds. Also removed "Print failed" notification when the user cancels printing (since this should be obvious to the user). BUG=http://crbug.com/7880 TEST=See bug. Review URL: http://codereview.chromium.org/146052 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19362 0039d316-1c4b-4281-b951-d872f2087c98
* A recent change broke the load times. It also revealed some deficiencies.davemoore@chromium.org2009-06-266-38/+89
| | | | | | | | | | | | This adds a new time marker for when a load is committed, which is a more interesting value than the start of the load (which we still keep). Also, the first layout time wasn't an interesting time to keep, instead we keep the time of the first paint. The histograms were modified to use the new values when appropriate. Review URL: http://codereview.chromium.org/147123 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19361 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools Profiler: add sanity test.mnaganov@chromium.org2009-06-262-8/+29
| | | | | | | | | | | Add a test that opens a page which executes JS, profiles it, and checks the result displayed. BUG=none TEST=chrome\browser\debugger\devtools_sanity_unittest.cc Review URL: http://codereview.chromium.org/147204 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19360 0039d316-1c4b-4281-b951-d872f2087c98
* Add a 'RegisterMessages' function to DOMMessageHandler to make it easy to ↵tim@chromium.org2009-06-2621-157/+207
| | | | | | | | | | | | | | construct these objects by deferring the DOMUI dependency to the init / "Attach" step. Add GetMessageHandlers to HtmlDialogUIDelegate to allow sending/receiving messages to the page hosted in the dialog as opposed to only on open/close. BUG=none TEST=none Review URL: http://codereview.chromium.org/131094 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19359 0039d316-1c4b-4281-b951-d872f2087c98
* Don't valgrind BookmarkEditorGtkTest.EditTitleKeepsPosition,dkegel@google.com2009-06-261-0/+3
| | | | | | | | | | | | since it seems to hit an uninitialized variable in gtk 2.12.9 on the bot (but not on my desktop...?) BUG=http://crbug.com/pr15445 TEST=none Review URL: http://codereview.chromium.org/149072 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19355 0039d316-1c4b-4281-b951-d872f2087c98
* Fix breakagenirnimesh@chromium.org2009-06-261-1/+3
| | | | | | Review URL: http://codereview.chromium.org/147196 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19348 0039d316-1c4b-4281-b951-d872f2087c98
* Disabling BookmarkEditorGtkTest::ModelsMatch_Testnirnimesh@chromium.org2009-06-261-1/+2
| | | | | | | | | | http://crbug.com/15436 TBR=nsylvain Review URL: http://codereview.chromium.org/147195 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19345 0039d316-1c4b-4281-b951-d872f2087c98
* Tweaks to tab overview to get it performant:sky@chromium.org2009-06-265-6/+71
| | | | | | | | | | | | | | | | . Delay getting thumnbails until 300ms after the window is shown. This is necessary as getting the thumnbails is very expensive. . Configure the thumnbail for one cell at a time. For same reason as last one. . Don't show new tab window widget as we don't yet have the type set up. BUG=none TEST=none Review URL: http://codereview.chromium.org/147174 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19340 0039d316-1c4b-4281-b951-d872f2087c98
* Changes the image used for the new tab button.sky@chromium.org2009-06-263-0/+9
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/146056 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19339 0039d316-1c4b-4281-b951-d872f2087c98
* The following 3 ui tests have been flaky on Linux.jshin@chromium.org2009-06-262-4/+12
| | | | | | | | | | | | | | | | | DownloadTest.DownloadMimeType DownlaodTest.ContentDisposition SavePageTest.FilenameFromPageTitle BUG=15416,15244 http://crbug.com/15416 http://crbug.com/15244 TEST=Linux UI test bots do not fail due to these tests TBR=estade Original review: http://codereview.chromium.org/147179 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19334 0039d316-1c4b-4281-b951-d872f2087c98
* More BIDI support:estade@chromium.org2009-06-263-6/+18
| | | | | | | | | | | | | - mirror nine boxes - mirror menu positioning - mirror download item show/hide logic http://crbug.com/15406 is relevant, although I'm not sure this 100% fixes it. TEST=use download shelf in Hebrew chrome. Things should be mirrored. Use it in English and nothing should be borked. Review URL: http://codereview.chromium.org/147176 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19333 0039d316-1c4b-4281-b951-d872f2087c98
* Fix proper MACOSX exlussion.rvargas@google.com2009-06-261-3/+3
| | | | | | | | | | TBR=rafaelw BUG=none TEST=none Review URL: http://codereview.chromium.org/149051 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19332 0039d316-1c4b-4281-b951-d872f2087c98
* Revert cl 19315 to see if it fixes the builds.rvargas@google.com2009-06-2617-213/+2625
| | | | | | | | | TBR=klink BUG=none Review URL: http://codereview.chromium.org/149049 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19331 0039d316-1c4b-4281-b951-d872f2087c98
* Revert all of my patches from today.evan@chromium.org2009-06-263-29/+4
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19328 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r19318. Seems we're blocking some UI thread though I thought we ↵thestig@chromium.org2009-06-261-1/+1
| | | | | | | | | | didn't here. BUG=15342 TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19326 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: fix font fallback for charactors missing from the primary font.agl@chromium.org2009-06-265-5/+67
| | | | | | | | | | | | | | | We are using the sandbox host for font fallback now via the WebKit API. However, a patch landed in WebKit which added an assertion about being on the correct thread. Since the sandbox host was using WebString::fromUTF8, we hit the assertion and died. So, we have to implement a WebKitClient for the sandbox host. We cannot just pass in NULL because there's an assertion that it's non-NULL. Also, we cannot pass in a bogus pointer because it actually ends up getting called back. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19324 0039d316-1c4b-4281-b951-d872f2087c98
* linux plugins: eliminate GtkWidget* from plugin processevan@chromium.org2009-06-263-4/+29
| | | | | | | | | | | | | | | | | | | | | | | | | | | GtkWidget* (and its wrapper, gfx::NativeView) only work within a single process. Plugins already work with a lower-level type that works across processes -- an X Window id. The parent of a plugin is an HWND on windows, but it's an X Window id on X. So we introduce a new typedef wrapping that and push it through all the places in the code that needs it. Since we no longer have a GtkSocket in the WebPluginDelegateImpl, we need to do a bit more work in the WebViewDelegate (aka the browser process in the multiproc world). We also need the plugin host (the browser) to track the GtkSockets that are hosting the plugin, as well as destroy them when necessary. To do this we require the plugin owner to grab the plug-removed signal rather than putting its handler in GtkPluginContainer; this is the way it worked before I'd refactored into GtkPluginContainer so it shouldn't be so bad. This change still only works in test_shell, but the refactoring should translate to the multiprocess case pretty easily. Review URL: http://codereview.chromium.org/146009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19320 0039d316-1c4b-4281-b951-d872f2087c98
* Reap dead xdg-open processes so they don't turn into zombies.thestig@chromium.org2009-06-261-1/+1
| | | | | | | | BUG=15342 TEST=Click show in folder for a download, close the file manager that opens up, run ps and make sure the xdg-open process didn't turn into a zombie. Review URL: http://codereview.chromium.org/147167 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19318 0039d316-1c4b-4281-b951-d872f2087c98
* Make omnibox2 dropdown not flash during result set transitions...ben@chromium.org2009-06-262-59/+170
| | | | | | | | | | | | | - Animate smoothly between decreasing popup heights. Increasing popup heights are instantaneous. - Don't start a size adjustment until a few ms after the result set is updated to avoid jumping the height of the omnibox popup during typing as results from async providers stream in. - The result row carries a copy of the match data so it always has something to paint even if the match that corresponded to those results is now gone. These rows aren't actually actionable by the user and only appear during the animation. The result views are retained even if they are not visible (clipped). BUG=none TEST=type slowly in the omnibox, note the height of the popup doesn't jump between characters. Review URL: http://codereview.chromium.org/149030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19317 0039d316-1c4b-4281-b951-d872f2087c98
* Disable ExtensionsService.ExternalInstallPref unittest on mac.rafaelw@chromium.org2009-06-261-0/+6
| | | | | | | | | | Broke with: http://codereview.chromium.org/140018. R=rvargas Review URL: http://codereview.chromium.org/147183 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19316 0039d316-1c4b-4281-b951-d872f2087c98
* Removes the outdated and flaky UI tests, and introduces a whole new set of ↵klink@chromium.org2009-06-2617-2625/+213
| | | | | | | | shiny unit tests instead.BUG=2242,2243 Review URL: http://codereview.chromium.org/146124 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19315 0039d316-1c4b-4281-b951-d872f2087c98
* Remove unused num_rows argument to OptionsLayoutBuilderGtkmattm@chromium.org2009-06-254-4/+4
| | | | | | | | BUG=none Review URL: http://codereview.chromium.org/149037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19312 0039d316-1c4b-4281-b951-d872f2087c98
* render view: Clear the text selection cache when we get an empty selection.estade@chromium.org2009-06-251-0/+2
| | | | | | | | | BUG=15126 TEST=see bug Review URL: http://codereview.chromium.org/147175 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19311 0039d316-1c4b-4281-b951-d872f2087c98
* Fix another bookmark manager crasher.estade@chromium.org2009-06-252-4/+35
| | | | | | | | | | | Also, don't allow drags to originate from parts of the table view that don't have rows. BUG=http://crbug.com/15388 TEST=try to drag from the white space below the lowest row of the bookmark manager right pane onto the bookmark bar (nothing should happen) Review URL: http://codereview.chromium.org/149024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19310 0039d316-1c4b-4281-b951-d872f2087c98
* Add a function to ResourceBundle to allow loading images that will mirror in ↵estade@chromium.org2009-06-254-59/+23
| | | | | | | | | | RTL. Use this function for custom buttons and for the Off the Record avatar. for reference, this will be a bit different than Views, which does it per class rather than per image: http://dev.chromium.org/developers/design-documents/ui-mirroring-infrastructure Review URL: http://codereview.chromium.org/147157 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19309 0039d316-1c4b-4281-b951-d872f2087c98
* Hooks backend tip service into new tab page. Also changes tip service to ↵mirandac@chromium.org2009-06-2513-175/+162
| | | | | | | | | | | load tips from popgadget, at http://www.google.com/labs/popgadget/world. BUG= http://crbug.com/14962 TEST= Enable new tab page. See welcome message. On reload afterwards (and always after that, as long as preferences file isn't removed), see browsing recommendations appear in bottom right corner. Review URL: http://codereview.chromium.org/147109 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19306 0039d316-1c4b-4281-b951-d872f2087c98
* Two tab dragging fixes for various window managers:jhawkins@chromium.org2009-06-253-16/+58
| | | | | | | | | | | * Reverse the order of enumeration when enumerating all top-level windows. XQueryTree returns the list of windows in bottom-to-top order, while DockInfo expects the windows in top-to-bottom order (ratpoison WM, Awesome WM). * Extend the enumeration one level deeper for window managers that parent top-level windows into an unnamed real top-level window (ion WM). BUG=14004 TEST=Extensive tab dragging in the following WMs: Metacity, Compiz, kwm, ion3, xmonad, ratpoison, awesome. Review URL: http://codereview.chromium.org/149028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19303 0039d316-1c4b-4281-b951-d872f2087c98
* Move extension delimiters to the right.cira@chromium.org2009-06-251-0/+1
| | | | | | | | | BUG=http://crbug.com/11880 TEST=Load Chrome with --lang=he, and add 1+ extension. Delimiters should be on the right. Review URL: http://codereview.chromium.org/147132 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19302 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: add Alt-n keys for switching tabs.agl@chromium.org2009-06-251-0/+12
| | | | | | | | | | | The UI decision was to have both Alt-n and Ctrl-n switch tabs. Ctrl-n to match Windows Chrome and Alt-n to match Firefox on Linux. Pages which try to grab either sets of keys will succeed. BUG=13395 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19301 0039d316-1c4b-4281-b951-d872f2087c98
* two more unit_test fixes for: http://codereview.chromium.org/140018rafaelw@chromium.org2009-06-252-2/+5
| | | | | | | | R=rvargas Review URL: http://codereview.chromium.org/147171 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19294 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 19271.ericroman@google.com2009-06-252-12/+9
| | | | | | | Revert 19271, since it caused crash in reliability test. (dns prefetcher may still cancel requests on the host resolver during shutdown). Review URL: http://codereview.chromium.org/149026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19289 0039d316-1c4b-4281-b951-d872f2087c98
* Fix unit_test breakage from http://codereview.chromium.org/140018rafaelw@chromium.org2009-06-251-0/+3
| | | | | | | | R=sky Review URL: http://codereview.chromium.org/147169 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19288 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: plumb fontconfig call out to the sandbox host.agl@chromium.org2009-06-257-2/+171
| | | | | | | | | | | | | | | | | | | | | | | This is hopefully the last step before our renderers can run cleanly in a chroot. WebKit needs to be able to ask for the correct font to use in the case that the current font doesn't include glyphs for certain code points. Currently we make a fontconfig call in our WebKit port to handle this. This patch changes this so that the call is sent our via ChromiumBridge. Since we are at ChromiumBridge, we could make a sync IPC to the browser. However, fontconfig is a single threaded library and we are already using it on the UI thread in the browser, so the sync IPC would have to terminate on the UI thread. Even if this doesn't deadlock, it causes huge spikes in latency. So, instead, we send the IPC to the sandbox host process which is already setup to handle fontconfig requests from Skia. See: http://code.google.com/p/chromium/wiki/LinuxSandboxIPC git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19287 0039d316-1c4b-4281-b951-d872f2087c98
* Refactored ExtensionsPrefs to store paths relative to the extensions install ↵rafaelw@chromium.org2009-06-2533-91/+333
| | | | | | | | | | | directory. Fix & reenabled two extensions_service unit_tests. R=erikkay BUG=14714 Review URL: http://codereview.chromium.org/140018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19285 0039d316-1c4b-4281-b951-d872f2087c98
* Add a gyp "buildtype" variable to differentiate official release builds.mmoss@chromium.org2009-06-251-1/+4
| | | | | | | | | | | | | | | | This notion was previously overloaded on "branding", but as implied, that variable should really just control the "Google Chrome" vs. "Chromium" branding. We need a separate setting to distinguish between "release" builds (which get special handling, like breakpad symbol processing), and "everyday" builds, like the buildbot continuous builds or personal developer builds. This fixes a problem where the "Google Chrome" continuous builder was unnecessarily trying to upload breakpad symbols for every single build. Review URL: http://codereview.chromium.org/132038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19283 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Another attempt at fixing gtk_floating_container_forall() crasher.erg@google.com2009-06-252-10/+12
| | | | | | | | | | | | Tie the lifetime of the GtkFloatingContainer to TabContentsContainerGtk. Working theory is that we're leaking that reference, which is causing the crash. http://crbug.com/14485 Review URL: http://codereview.chromium.org/147163 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19282 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-08 13:16:09 +0000