| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
correct icon (http://cl.ly/97c1b5e22eb32075d497).
Still to be done:
o there should be a much smaller overlap of app tabs with other tabs.
o The toolbar should hide when necessary.
o The context menu for the tab should have the option of hiding/showing the toolbar on a per-app basis.
TEST=none
BUG=45539
Review URL: http://codereview.chromium.org/2847052
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51737 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
These changes merge popup menu suggestions for Autocomplete and AutoFill. Suggestions are collected from both sources and returned to the renderer as a single list. This combined list is given to WebKit to display in the suggestions popup. When the user selects an item in the popup the appropriate result gets filled in the fields.
BUG=41328
TEST=AutoFillManagerTest.*
Review URL: http://codereview.chromium.org/2878020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51736 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/2800035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51733 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
PanelController::TitleMousePressed.
http://code.google.com/p/chromium-os/issues/detail?id=4255
BUG=chromium-os:4255
TEST=See Issue for repro
Review URL: http://codereview.chromium.org/2834037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51732 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=44602
Based on a patch from Giuseppe Iuculano <giuseppe@iuculano.it>.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51730 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
be registered (and thus used) if the installer is run with the --chrome-frame flag.
Remove a bunch of CF-specific code in the process.
BUG=46818
TEST=Can use the same mini_installer.exe to install either Chrome or Chrome Frame.
Review URL: http://codereview.chromium.org/2839009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51729 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=open New Tab page, see thumbnails. Same with chrome --top-sites.
Review URL: http://codereview.chromium.org/2815045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51728 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=48227
TEST=none
Review URL: http://codereview.chromium.org/2888005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51725 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
perfect yet).
Trigger OnBackendInitialized when the syncable::Directory is opened, and cue the DataTypeManager when that happens.
Fix a bug where entering the wrong password on re-login UI results in inability to log in to sync forever, as the UI gets stuck in the "Authenticating...' state.
Overhaul the tests to
1) actually use the abstract superclass and not copy/paste the same code (and redefine the same variables, shadowing protected ones in the super!),
2) to not use two SyncBackendHost objects, which makes it really confusing to follow what's happening,
3) not rely on anonymous OnStateChanged() notifications to perform crucial init tasks (which was also really confusing and brittle) by either a) removing the need to listen altogether, or b) listen for specific notifications.
4) unify root node creation, and
5) kill verbose and self proclaimed "uninteresting" gmock output.
BUG=47957
TEST=unit_tests (ProfileSync*)
Review URL: http://codereview.chromium.org/2834032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51724 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
tab is already closing it's possible for the tab to no longer contain
the coordinates of the release event. I've changed it so that if the
tab is closing and the tab doesn't contain the mouse on the release
event we see if another tab does and if so close it.
BUG=48209
TEST=none
Review URL: http://codereview.chromium.org/2841038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51723 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
nested tasks as in some situations the menu may be shown when the
message loop is processing a task. If the message loop is processing a
taskand we don't set nested tasks allowed to true then none of the
tasks scheduled by the menu (paints, delays...) are processed and the
menu appears totally broken.
BUG=48102
TEST=give focus to the page, press alt-f, press arrow keys and make
sure the menu updates appropriately.
Review URL: http://codereview.chromium.org/2836044
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51719 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2813045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51718 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
of a setting.
BUG=none
TEST=none.
Review URL: http://codereview.chromium.org/2858048
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51716 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=45230
TEST=none
Review URL: http://codereview.chromium.org/2818046
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51714 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Also, re-enable DefaultPluginUITest.DefaultPluginLoadTest.
BUG=48388,46662
TEST=DefaultPluginUITest.DefaultPluginLoadTest
Review URL: http://codereview.chromium.org/2854041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51713 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
in order to fully support Windows screenreaders.
Note: it makes sense to check these files into third_party
directly (rather than pull from Mozilla's repository) because
(1) they're very small (under 500 lines total), and
(2) they're stable and unlikely to change frequently.
BUG=48185
TEST=none
Review URL: http://codereview.chromium.org/2802031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51710 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=39813
TEST=translate infobars should have a very light gray gradient background.
Review URL: http://codereview.chromium.org/2814049
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51707 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51702 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
function.
BUG=chromium-os:4575
TEST=see the bug
Review URL: http://codereview.chromium.org/2884017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51700 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Obviously we don't have to write an error log when |type| is kKeyboardLayoutsOnly.
BUG=none
TEST=manual
Review URL: http://codereview.chromium.org/2871037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51699 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:4570
TEST=started ibus-chewing, toggled properties, then verified there were no errors in /home/chronos/chrome_log.
Review URL: http://codereview.chromium.org/2836049
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51698 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/2805074
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51696 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:4565
TEST=none
Review URL: http://codereview.chromium.org/2888002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51694 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
In particular, we should not show shortcut labels when ibus-mozc
shows suggestions.
BUG=chromium-os:4563
TEST=manually with ibus-mozc
Review URL: http://codereview.chromium.org/2855033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51693 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Second try, first try at http://codereview.chromium.org/2803035 . Also contains http://codereview.chromium.org/2838044 , changes to DEPS files (mostly cleanups), and a change to webkit/glue/plugins/webplugin_delegate_impl_win.cc .
BUG= 48419
TEST=everything still builds
Review URL: http://codereview.chromium.org/2813047
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51692 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
The LOG() is too verbose now since it is ensured that the call succeeds.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2803038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51689 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Get rid of Init() method from LanguageConfigModel,
and add a call to NotifyPrefChanged() in the constructor.
Along the way, fix a sytle issue in LanguageConfigView.
Per the style guide, model should look like model_, as it's a member variable.
TEST=manually on the netbook.
BUG=none
Review URL: http://codereview.chromium.org/2872031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51688 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=48419
Review URL: http://codereview.chromium.org/2803035
TBR=thakis@chromium.org
Review URL: http://codereview.chromium.org/2819043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51684 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Parts by hbono.
TBR=tony^work
Review URL: http://codereview.chromium.org/2838044
TBR=thakis@chromium.org
Review URL: http://codereview.chromium.org/2822050
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51683 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Parts by hbono.
TBR=tony^work
Review URL: http://codereview.chromium.org/2838044
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51682 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=48419
Review URL: http://codereview.chromium.org/2803035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51681 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=41195
TEST=Download file with long name. Dangerous download view shouldn't have tooltip, normal download button should.
Review URL: http://codereview.chromium.org/2835036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51680 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
GaiaAuthConsumer pure virtuals now optional since you can choose to not listen to ClientLogin subscriptions.
Renamed ClientLoginError to a general GaiaAuthError.
BUG=47093
TEST=Unit tests included
Review URL: http://codereview.chromium.org/2834042
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51678 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
from fts2 to fts3.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2825037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51677 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Eliminated resizing the image upon receiving each frame.
BUG=None
TEST=Test that video image from camera is the same as the selected image on
image screen and positioned at the same level.
Review URL: http://codereview.chromium.org/2817050
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51674 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
THIS CHANGES THE BEHAVIOR OF HOW PERMISSIONS WORK:
Previosly an infobar was shown every time an application requested notification permissions.
Now, this is shown only the first time an application requests permissions, and the choice is remembered thereafter. If the kDesktopNotificationDefaultContentSetting preference is set, no infobar is shown at all.
This CL also adds content settings UI to manage the exceptions list on mac, win, and linux.
xib changes: Add a new pane to the content settings tab view, with the right title, radio box strings, actions, and bindings.
BUG=45547
TEST=Go to a site that shows notifications. It should only ask for permissions once, and remember the user choice after that. Content Settings->Notifications->Exceptions should show the exceptions list. The content settings pane should be fully functional, and the radio button options ("don't ask") should have an effect on pages that weren't visited before.
Review URL: http://codereview.chromium.org/2825028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51673 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
NotificationExceptionsTableModel is now functional, and DesktopNotificationService::GetContentSetting contains the new permission behavior. Both aren't used anywhere yet, so still no functionality change (but this is the last CL without functionality changes).
Also add a ton of tests.
BUG=45547
TEST=unit tests
Review URL: http://codereview.chromium.org/2868042
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51669 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=viettrungluu@chromium.org
Review URL: http://codereview.chromium.org/2630003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51668 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/2850044
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51667 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2847023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51666 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/2808047
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51662 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/2802032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51661 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51659 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This change just adds [shadow release] to release the NSShadow object used in the function. (I'm not totally sure if it is a correct fix, though.)
BUG=48361
TEST=make the "Chromium Mac UI (valgrind)(2)" bot greener.
Review URL: http://codereview.chromium.org/2859044
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51657 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The link will pop up a dialog that displays the cookies blocked and accessed by the current page.
The XIB change adds a link-styled button (cell type HyperlinkButtonCell) below the title and above the horizontal line on the bubble with the text IDS_BLOCKED_COOKIES_INFO. The button action is hooked up to showMoreInfo: in the File's Owner.
BUG=45230
TEST=none
Review URL: http://codereview.chromium.org/2799012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51656 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=43423
TEST=box_layout_unittest.cc, manual UI tests.
Review URL: http://codereview.chromium.org/2738002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51655 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Since F9 is reserved by the window manager on Chrome OS.
BUG=chromium-os:4319
TEST=manually
Review URL: http://codereview.chromium.org/2800039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51654 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=manually on netbook
BUG=chromium-os:2625
Review URL: http://codereview.chromium.org/2815049
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51653 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG= http://crosbug.com/323
TEST=Manual. Change password for the account that was previously logged on the device. Observe dialog box.
Review URL: http://codereview.chromium.org/2834041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51644 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51642 0039d316-1c4b-4281-b951-d872f2087c98
|