| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
| |
unneeded methods from NativeTabContentsContainerWin.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/115903
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17159 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This is a quick hack, that will be replaced once we have the rest of prefs
implemented.
BUG=12736
Review URL: http://codereview.chromium.org/113977
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17158 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
accept the user's text.
Review URL: http://codereview.chromium.org/114058
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17157 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
vista without hebrew support
the bug reason is documented in the source for all to see and the bug=12093 (http://code.google.com/p/chromium/issues/detail?id=12093)
the code has been tested with and without a debugger but i have to admit, the unit_tests rarely pass on my machine (the ui ones never do)but this code i changed leaves the state EXACTLY like it was and solves this issue at least
BUG=12093
TEST=run unit_tests.exe on Hebrew Windows; run Chrome; open a page which contains a <textarea dir="ltr"></textarea> element; press control+right-shift key, and; verify its "dir" attribute becomes "rtl".
Review URL: http://codereview.chromium.org/115849
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17156 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This makes the buildbot archive hermetic for package building, rather than
pulling files from the package builder's source tree (e.g. BRANDING) and system
(e.g. lib32 stuff).
Note, this currently only applies to official builds since that's all we package.
This depends on:
http://codereview.chromium.org/115842
http://codereview.chromium.org/113966
Review URL: http://codereview.chromium.org/115843
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17151 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
page. This allows faster prototyping (F5) of the NNTP.
TEST=Start Chrome with --new-new-tab-page=path/to/file.html. The NTP should
show the file. Make a visible change in the file and reload the tab page and
the change should be visible immidiately.
BUG=None
Review URL: http://codereview.chromium.org/113927
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17150 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
One visible change: new tab page has Google icon, not Chromium.
Gyp doesn't have a set environment variable facility; hence the
addition of a command line option to grit.
Review URL: http://codereview.chromium.org/113974
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17148 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/115879
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17146 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Make use of this in HistoryContentsProvider so results from it get their schemes trimmed appropriately.
BUG=10558
Review URL: http://codereview.chromium.org/115885
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17145 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
ignore these keypresses.
BUG=6992
TEST=Type a letter so the omnibox dropdown shows. Press alt-down. If you used the numpad down arrow, nothing should happen (until you release both keys, then a special character might appear). If you used the standalone arrow keys, the selection should move down one row.
Review URL: http://codereview.chromium.org/115891
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17144 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
It mostly confuses the press.
Review URL: http://codereview.chromium.org/113978
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17137 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=12174
Review URL: http://codereview.chromium.org/115893
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17136 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=12844
TEST=Install Chromium and make sure gears.dll is present.
Review URL: http://codereview.chromium.org/113976
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17135 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
too.
BUG=5372
TEST=Navigate somewhere, focus the omnibox, and hit alt+numpad 7. You should navigate to your home page (by default, the new tab page).
Review URL: http://codereview.chromium.org/113971
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17134 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also, rearrange helper code for centering things in hboxes so they don't expand to take up the full vertical space.
Also, don't allow focus on gtk_chrome_button buttons. This is to prevent the "Other bookmarks" button from getting focus (which matches windows) and is in line with disallowing focus on all custom chrome buttons (see CustomDrawButton).
BUG=12829
TEST=everything should look the same. Also if you tab to focus on a link button (e.g. download shelf's "show all downloads"), it should have a dotted line around the exterior.
Review URL: http://codereview.chromium.org/113970
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17132 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This should have been in my earlier CL, but I had a gcl fail.
TBR=darin
BUG=None
TEST=No behavior change
Review URL: http://codereview.chromium.org/112067
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17131 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=Linux first run dialog should be properly styled?
Review URL: http://codereview.chromium.org/115890
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17130 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This replaces the current time based approach (chrome is given N seconds
to upload all renederer histograms) with an asynch callback approach
that waits until all renderers have responded (with their updates). It
uses a fall-back timer to ensure that a hung renderer won't delay things
forever as well.
This causes faster (and complete) updates in about:histograms as well
as generally assuring complete updates during UMA gatherings.
This code was contributed by Raman Tenneti in CL 42496
http://codereview.chromium.org/42496
bug=12850
r=raman
Review URL: http://codereview.chromium.org/113473
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17123 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/115878
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17121 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/115869
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17117 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Custom start urls and default search options widgets aren't hooked up.
Home page settings work, but are overridden by the linux start page settings.
Default browser checking/setting functions are not implemented, so the option
isn't useful yet.
Refactors some common code out of browser/views/options/options_page_view.*
into browser/options_page_base.{cc,h}
BUG=11507
Patch by Matt Mueller (mattm@google.com).
Review URL: http://codereview.chromium.org/113967
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17115 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/113965
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17113 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Split off Windows bits into NativeTextfieldWin class obscured behind NativeTextfieldWrapper interface.
The APIs aren't perfectly tidy yet but this is a good first pass.
BUG=none
TEST=make sure you can still edit text fields, run the view unit tests.
Review URL: http://codereview.chromium.org/113940
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17112 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/115876
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17111 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
check the HWND.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/115852
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17110 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
_views.foo.
BUG=none
TEST=none
TBR=brettw
Review URL: http://codereview.chromium.org/115875
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17109 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/115873
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17108 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=12299
TEST=1) right click/save as on some image. Clicking on the download item's filename area should launch it in some image viewer (assuming xdg-open works for you---as it happens, ubuntu broke xdg-open for desktops that are not gnome, kde, or xfce). 2) Download a large file. Click on the download item before it is finished. The text should change to "opening in..." and the checkbox in the dropdown menu should show as checked. 3) completed downloads should have the "open when finished" menu item replaced by the "open" menu item. Selecting that should also open the download.
Review URL: http://codereview.chromium.org/112064
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17106 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
or when the file is detected to be changed externally.
Review URL: http://codereview.chromium.org/114055
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17105 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This involves implementing GoogleUpdateSettings::[GS]etCollectStatsConsent, and a whole lot of refactoring.
BUG=none
TEST=delete config dir, run official Linux build, don't enable crash reporting, crash browser -> no crash reporting.
Review URL: http://codereview.chromium.org/115808
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17104 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
other gtk popups (e.g., gtkmenu). Always allow Esc to close the
popup so a hung renderer doesn't require mouse usage.
Review URL: http://codereview.chromium.org/113959
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17103 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/112063
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17102 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
ported.
BUG=none
TEST=none
TBR=brettw
Review URL: http://codereview.chromium.org/113963
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17101 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/115872
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17098 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=http://crbug.com/12550
TEST=as described in bug report
Review URL: http://codereview.chromium.org/113960
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17097 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This is useful for getting general build version information, such as needed
for Linux packaging.
Review URL: http://codereview.chromium.org/115842
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17096 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This introduces a hybrid GtkBin/GtkFixed container which exposes a signal to absolutely position widgets. This also fixes the current flickering issues with the status bubble.
http://crbug.com/11635
TEST=Goto a site with a long list of links (I used reddit.com) and move the mouse cursor up and down the list quickly. There shouldn't be flickering in the top left corner.
Review URL: http://codereview.chromium.org/115835
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17095 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
we're hitting it.
BUG=12684
Review URL: http://codereview.chromium.org/113958
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17094 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
notifications directly in channel background thread. Add support for listener-less ChannelProxy.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/113722
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17093 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
on all platforms.
Also, on linux, assume the user denies every download which we would have prompted him with.
BUG=12709
TEST=windows is still carpet-bombing resilient and linux can download from the same page more than once.
Review URL: http://codereview.chromium.org/113925
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17089 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Changed so debug writes next to the executable, and release writes to userdata dir. It was the reverse.
Drop two paths that aren't used any more.
BUG=12834
TEST=run app, make sure we don't create a log file inside the MacOS folder.
Review URL: http://codereview.chromium.org/115868
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17087 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=8317
TEST=make sure we don't create a dictionary directory within the app.
Review URL: http://codereview.chromium.org/115863
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17079 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
a bug 10699.
Not sure what is causing the crasher.
Hopefully after this clean-up we'll get a different stack-trace that might help.
BUG=10699
TEST=Make sure alert/confirm boxes work properly. make sure a background tab that shows a (delayed) alert box works. Same with a background browser.
Review URL: http://codereview.chromium.org/113932
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17078 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=12413
TEST=Focus the omnibox. Press Shift-Ctrl-Delete, the Clear Browsing Data dialog should show.
Make sure cut/copy/paste shortcuts still work as expected (Ctrl/x, Ctrl/c, Ctrl/v, Shift/Delete, Shift/Insert).
Review URL: http://codereview.chromium.org/113872
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17077 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
side.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/114054
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17076 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/113951
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17073 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Initially these will be drop in replacements for the existing projects.
These were generated mechanically in lieu of a looping syntax.
Review URL: http://codereview.chromium.org/115853
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17070 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This checkin adds gmock, and a small example of how to write a gmock-based unittest.
Original Review URL: http://codereview.chromium.org/113807
Review URL: http://codereview.chromium.org/115846
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17066 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* test/ui/sandbox_uitest.cc
* test/ui/v8_benchmark_uitest.cc
* worker/worker_uitest.cc
* browser/autocomplete/search_provider_unittest.cc
* browser/extensions/extension_process_manager_unittest.cc
* browser/extensions/extension_view_unittest.cc
* browser/find_backend_unittest.cc
* browser/safe_browsing/safe_browsing_blocking_page_unittest.cc
* browser/search_engines/template_url_scraper_unittest.cc
Also the utility module:
* test/ui/javascript_test_util.cc
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/115844
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17065 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17063 0039d316-1c4b-4281-b951-d872f2087c98
|