| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
| |
reasons.
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/2444005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48843 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
the ExtensionFunctionDispatcher/RenderViewHost that launched the popup. This is a problem, for example, when Chrome is closed while a popup is still displayed.
I also removed the code that delayed sending the onClosed popup notification. I modified the ExtensionPopup::Obeserver interface to add methods for about-to-close, and fully-closed notifications.
BUG=None
TEST=ExtensionApiTest.Popup
Review URL: http://codereview.chromium.org/2092020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48841 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
where the user
chooses to sync, but the window is already open and obscured by another window. For now
this only works on Mac due to how browser dialogs are handled on different platforms.
BUG=30649
TEST=Choose to 'Sync' when the sync window is already open behind a browser window.
Review URL: http://codereview.chromium.org/2121017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48840 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Attempt to flush out more use-after-free cases in the wild. Right now messages to freed ObjC objects are binned by the object's address, with this change they should aggregate into a bigger bin. Additionally, the treadmill should slightly increase the number of cases caught.
BUG=35590,24987,45676
TEST=none
Review URL: http://codereview.chromium.org/2478004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48838 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=34644
TEST=Try moving the preferences window and confirm it works.
Patch from Mingmin Xie <melvinxie@gmail.com>
Review URL: http://codereview.chromium.org/2592001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48834 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Use the page title as the print job title for cloud printing.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2438004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48833 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
language/site'.
BUG=39222
TEST=see bug
Review URL: http://codereview.chromium.org/2400001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48831 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=dpolukhin
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2564003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48830 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
new user screen). If user takes snapshot and hits OK on image screen, the
snapshot becomes user image. If user presses Cancel, his image is downloaded
via Contacts API.
BUG=cros:3175
TEST=Login via new user login window. Verify that both use cases work if you logout after the browser is shown.
Review URL: http://codereview.chromium.org/2578001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48828 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=crosbug.com/3757
TEST=none
Review URL: http://codereview.chromium.org/2575001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48827 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=38575
TBR=glider
Review URL: http://codereview.chromium.org/2573001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48823 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
This adds IDBIndex support. The majority of this CL was boilerplate type code in indexed_db_dispatcher_host so I did my best to factor it into template functions and split things into multiple sub-dispatcher hosts.
Review URL: http://codereview.chromium.org/2449005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48822 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48819 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2558001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48817 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=Chrome Sync works
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=48798
Review URL: http://codereview.chromium.org/2255007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48811 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This change just pulls the hunspell dictionaries moved by my r48011.
TBR=estade
BUG=44543
TEST=none
Review URL: http://codereview.chromium.org/2074023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48807 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:2624
TEST=Open the IME settings window. Add Traditional Chinese. Open the options dialog, and check that the integer prefs are there
Review URL: http://codereview.chromium.org/2457001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48806 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
UTF16ToUTF8 conversions.
BUG=41862
TEST=trybots
Review URL: http://codereview.chromium.org/2481003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48805 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=Chrome Sync works
Review URL: http://codereview.chromium.org/2255007
TBR=sergeyu@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48800 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=Chrome Sync works
Review URL: http://codereview.chromium.org/2255007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48798 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In particular, make it work better when using backup jobs / late binding (the display was very confused before because of how these asynchronous events would nest).
Also changed the paradigm for how PassiveLogCollector preserves these async associations -- this fixes how it replays the events to net-internals. (Before we would collapse the event streams into the SOURCE_URL_REQUEST which lost some hiearchy.. now I keep the separate streams).
Some of the particular changes to the event streams:
* ConnectJobs now create their own source stream internally.
* Sockets are now bounded by +SOCKET_ALIVE / -SOCKET_ALIVE events (removed the one-off SOCKET_DONE event).
* The socket log streams contains +SOCKET_IN_USE / -SOCKET_IN_USE event blocks to show which URLRequest was controlling it at various points in time (this makes it much easier to understand which read/writes belonged to a particular network transaction when a socket gets re-used).
* ConnectJobs are bounded by +SOCKET_POOL_CONNECT_JOB / - SOCKET_POOL_CONNECT_JOB events.
* ConnectJobs log the net error they failed with.
* Removed the SOCKET_BACKUP_TIMER_EXTENDED event.
Review URL: http://codereview.chromium.org/2363003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48797 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=dhg
TEST=green chromeos compile
Review URL: http://codereview.chromium.org/2544002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48796 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=45148
TEST=compile chrome with PRODUCT_VERSION manually set to something higher than the current version (e.g. 7.0.0.0), and manually set the upgrade detector time to something short (like 10 seconds). Launch chrome and wait a short time for the update notification to appear. The update notification should pulse every few seconds, and should stop pulsing when the user opens the wrench menu. The about menu item should launch a dialog that allows the user to restart chrome, restoring the current session.
Review URL: http://codereview.chromium.org/2365003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48795 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
preparation for using Chrome sockets.
Made TalkMediator explicitly non-thread-safe.
BUG=45612
TEST=manual testing of notifications
Review URL: http://codereview.chromium.org/2471006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48791 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:3715
TEST=none
Review URL: http://codereview.chromium.org/2496002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48790 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=something
Review URL: http://codereview.chromium.org/2507001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48785 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=aa
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/2516001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48783 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=30710,30706
TEST=Invoke a contextual menu in the Sync sign-in dialog, navigation items
should not appear.
Review URL: http://codereview.chromium.org/2487002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48781 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Don't connect to the drag events more than once.
BUG=45270
TEST=dragging that box in debug mode, no backtrace
Review URL: http://codereview.chromium.org/2514001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48780 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
2. Store the thumbnail score in the database.
BUG=None
TEST=TopSitesTest
Review URL: http://codereview.chromium.org/2499003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48777 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Retry up to 30 seconds (1 sec x 30) even if it fails to grab inputs.
BUG=none
TEST=manual: scree lock should work after chrome crash.
Review URL: http://codereview.chromium.org/2458002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48776 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Use real transient parent for hosted native dialogs since window manager
supports transient of transient now;
- Use last active normal browser window as parent for option dialogs since
we don't want to use panel popups as parent;
BUG=chromium-os:3708
TEST=none. This CL gives real transent parent for dialogs but we still need to way to show the dialogs, either exit fullscreen or put them on top of fullscreen.
Review URL: http://codereview.chromium.org/2501001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48773 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
an app tab to a regular tab.
BUG=45480
TEST=None
Review URL: http://codereview.chromium.org/2425004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48768 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=39250
TEST=Select a folder with no items. The sort command should be disabled.
Review URL: http://codereview.chromium.org/2467007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48767 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Currently, two (2) overloaded versions of Histogram::FactoryGet() exist. Google's C++ style guide discourages such implementations. I refactored the methods into Histogram::FactoryGet() (no name change), which takes 'Sample' types as arguments, and Histogram::FactoryTimeGet(), which takes base::TimeDelta types as arguments.
r = jar
Review URL: http://codereview.chromium.org/2423004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48766 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
without --enable-vertical-tabs, and even then, don't expect it to work.
BUG=44773
TEST=infobars, bookmark bar, tab strip, etc should all behave correctly when showing, hiding, and widnow resizing. This cl should have no visible impact without the above flag on the command line.
Review URL: http://codereview.chromium.org/2475002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48765 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
logging in through"
This reverts commit 4ffcb495af72106fe243c6982119d799325d86ba.
The following tests were failing with this change.
NetworkScreenTest.Basic
NetworkScreenTest.NetworksConnectedNotSelected
NetworkScreenTest.EthernetSelected
NetworkScreenTest.WifiSelected
NetworkScreenTest.CellularSelected
NetworkScreenTest.WifiWaiting
LoginScreenTest.TestBasic
LoginScreenTest.AuthenticationFailed
LoginScreenTest.IncognitoLogin
grd files are excluded from revert to avoid build failures.
TBR=avayvod@chromium.org
BUG=none
TEST=chromeos build bot should cycle green
Review URL: http://codereview.chromium.org/2498003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48761 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=39057
TEST=tree greener
TBR=dhg
Review URL: http://codereview.chromium.org/2502001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48760 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=32615,45675
TEST=tree greener
TBR=creis
Review URL: http://codereview.chromium.org/2450006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48759 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
longer failing or to gather more data on the crashes since I cannot get them to fail on my local machine.
BUG=40002,40133
TEST=ExtensionBrowserTest, BrowserActionApiTest
Review URL: http://codereview.chromium.org/2495002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48756 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This CL cannot be checked in until the patch for:
https://bugs.webkit.org/show_bug.cgi?id=39917
has landed.
BUG=45373
Review URL: http://codereview.chromium.org/2330004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48754 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
on Linux cause crashes.
BUG=45002
TEST=none
Review URL: http://codereview.chromium.org/2486003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48751 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
enqueueing an item is available from the menu.
Review URL: http://codereview.chromium.org/2436008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48749 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
selection. Refactor form field enumeration into ForEachMatchingFormField().
BUG=38582
TEST=FormManagerTest.PreviewForm
Review URL: http://codereview.chromium.org/2138005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48746 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=41234
TEST=none
Review URL: http://codereview.chromium.org/2464002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48745 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
If a signal is delivered to a child process in between forking and
execing then it will trigger Chrome's signal handlers. This will
likely result in sadness.
BUG=44953
http://codereview.chromium.org/2452003/show
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48744 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
We used to assume that all bookmark imports were adding a folder to "Other bookmarks". This is not always the case so now we reload the tree and the list instead.
BUG=39893
TEST=Start with an empty profile. Click "Import bookmarks" on the bookmarks toolbar. The imported bookmarks and bookmarks folders should show up.
Review URL: http://codereview.chromium.org/2485002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48743 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Some generated files changed (cookies, extension, history),
but those seem to be random reordering by the API generator.
TBR=aa
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/2498002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48739 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Windows. This
code needs to be move to Interactive Ui Tests.
BUG:45581
Review URL: http://codereview.chromium.org/2428003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48737 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
xib change: Hook up button to new outlet and action, bind its "enabled" property to fileHandlerUIEnabled.
BUG=41794
TEST=Download a pdf and a doc file, open prefs in second window. In the download shelf, check pdf files to auto-open. Button in prefs should become active. Let doc files auto-open. Button should stay active. Disable auto-opening for both types in shelf, button should become inactive. Let pdfs auto-open, click button. Button should become inactive, pdfs should show up as non-autoopening in shelf.
Review URL: http://codereview.chromium.org/2473002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48736 0039d316-1c4b-4281-b951-d872f2087c98
|