| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
reverted: 49016, 47119, 47177, 46930, 46775, and the UI changes for
45566. If you see anything missing, please let me know.
Also, there are some grd strings no longer necessary. I'll nuke those
separately.
BUG=49013
TEST=none
Review URL: http://codereview.chromium.org/2888020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53062 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:4375
TEST=manual: login using local account,lock scren using ctrl-alt-l then unlock. no password required.
Review URL: http://codereview.chromium.org/3010015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53058 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3013018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53055 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
extension, show the option to disable the extension rather than revoke permission. Also give a link to the notifications content settings panel.OB
BUG=49019
TEST=create notification from page & extension, open the menu
Review URL: http://codereview.chromium.org/3034015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53054 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- choose better names for some helper methods
- move code to less random places
This change also adds bigger tuples support, up to Tuple8 in base/tuple.h.
The plan is to stop using such big number of parameters, but for now it's not
trivial.
This change also fixes some UI tests, not sure why it is so.
TEST=unit_tests, browser_tests, ui_tests
BUG=48913
Review URL: http://codereview.chromium.org/2805091
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53053 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=49560
TEST=none (no user-visible changes)
Review URL: http://codereview.chromium.org/3022013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53051 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Update top_sites_ right away, then request an update from the HistoryService.
TEST=TopSitesTest
BUG=none
Review URL: http://codereview.chromium.org/2964009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53048 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This avoids racing on the initialization of the statics usually declared
when doing histogram accumulation.
BUG=49142
TEST=net_unittests --gtest_filter=CookieMonsterTest.*:ParsedCookieTest.* (to confirm I didn't break anyting; this doesn't reproduce the race.)
Review URL: http://codereview.chromium.org/2832061
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53042 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Input dialog.
Before this change, we used to get the list of preferred languages based on
the active input methods. This is tricky. Having a preference for the value
is simpler, and makes it easier for us to implement the DOM UI version.
BUG=none
TEST=manually
Review URL: http://codereview.chromium.org/3012012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53035 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53033 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
webkit r63517.
BUG=none
TEST=BrowserEncodingTest.FLAKY_TestEncodingAutoDetec passes.
TBR=abarth
Review URL: http://codereview.chromium.org/3047003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53031 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=Valgrind UI gets greener.
Review URL: http://codereview.chromium.org/3050006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53028 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
We need to do it to cause advapi32.dll to load the sandbox is turned on.
Otherwise rand_s() will fail in the sandbox.
BUG=47390
TEST=Run "ui_tests --gtest_filter=WorkerTest.WorkerWebSocketLayoutTests".
Review URL: http://codereview.chromium.org/2799047
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53027 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
webkit r63517.
BUG=none
TEST=BrowserEncodingTest.FLAKY_TestOverrideEncoding passes.
TBR=abarth
Review URL: http://codereview.chromium.org/2861066
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53026 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
instead of something mac-specific.
BUG=none
TEST=create notification on mac, the options menu should work normally
Review URL: http://codereview.chromium.org/3020015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53024 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
If the user configures data types before the sync backend is initialized,
we wind up trying to associate models before a Directory exists, which is
badness.
BUG=48502
TEST=none
Review URL: http://codereview.chromium.org/3028013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53023 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3033009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53021 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=49541
TEST=manual
Review URL: http://codereview.chromium.org/2884028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53020 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
New versions of that script may get pushed from time to time.
Fetching the script again ensures people that don't restart their browser for long periods of time still get the new versions.
Also renamed the enum from constant style to macro-style, as it is the Chromium way to go from the Chromium style guide (which is in that regard different than the Google style guide).
BUG=None
TEST=Run the unit-tests.
Original review:
http://codereview.chromium.org/3034013/show
Review URL: http://codereview.chromium.org/3041010
TBR=jcivelli@chromium.org
Review URL: http://codereview.chromium.org/2881024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53019 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1. Adjust the width and the height of the dialog to work both with
Windows Classic and Windows Vista theme.
2. Make the width of list box in the dialog localizable
and adjust them per locale if necessary.
Original Review: http://codereview.chromium.org/2974009/show
BUG=48202
TEST=Go to Options | Under the Hood | Content Settings in locales listed in the bug and make sure that there's no truncation and all the UI elements can be
selected/visible/clickable both on XP (or Windows Classic them on Vista)
and Vista.
Review URL: http://codereview.chromium.org/2836061
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53017 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
New versions of that script may get pushed from time to time.
Fetching the script again ensures people that don't restart their browser for long periods of time still get the new versions.
Also renamed the enum from constant style to macro-style, as it is the Chromium way to go from the Chromium style guide (which is in that regard different than the Google style guide).
BUG=None
TEST=Run the unit-tests.
Original review:
http://codereview.chromium.org/3034013/show
Review URL: http://codereview.chromium.org/3041010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53016 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=49274
TEST=manual testing with code to trigger bug repro
Review URL: http://codereview.chromium.org/3034016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53014 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/3011013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53010 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
The server no longer properly enforces this. In the event of a clash, pay attention only to the item with the lexically least ID. The lookup must be done at
ProcessUpdate time; Verify is too early (clashes within a batch can't be handled). Add unit tests for hopefully all the corner cases.
BUG=41696,48158,36599
TEST=new sync_unit_tests
Review URL: http://codereview.chromium.org/3038008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53009 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Still no logic implemented, but it's nice to have something looking pretty. :)
The current screenshot can be found at:
http://chromium-os.googlecode.com/issues/attachment?aid=6893314955718114103&name=domui.png&token=09541fa12341c817ca5b2ecff2e5d463&inline=1
BUG=chromium-os:4573
TEST=manually
Review URL: http://codereview.chromium.org/2836052
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53008 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=http://crbug.com/48832
TEST=Move window all the way to the right of screen so a folder would spill off.
Open bookmark bar folder in question --> see it "pushed left" to get back on screen.
Review URL: http://codereview.chromium.org/2884026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53007 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is the Mac side of http://codereview.chromium.org/2808053 .
Looks like this: http://imgur.com/leY4C.png
To provide user feedback, after an exception has been added, the exceptions window is shown.
XIB changes:
Add a button to the allowed cookies outline views to block cookies and two to the blocked cookies one to allow them; set the NSSplitView delegate to File's Owner.
Review URL: http://codereview.chromium.org/2884024
Patch from Bernhard Bauer <bauerb@chromium.org>.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53005 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
(suspect test harness issues).
TBR=arv
Review URL: http://codereview.chromium.org/3040009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53003 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
We should check whether breakpad is initialized before
setting custom entries.
BUG=49368
TEST=Chrome.exe --disable-breakpad
Review URL: http://codereview.chromium.org/3010013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53001 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=30661,49576
TEST=none
Review URL: http://codereview.chromium.org/3035008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52999 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1. If no apps are installed we add an item for the store to the most visited section.
2. No longer hide the most visited by default.
3. This removes the default apps on non ChromeOS
BUG=46028, 47700
TEST=With a clean profile without any apps installed you should see the store thumbnail unless you blacklist it or pin 8 ohter pages.
Review URL: http://codereview.chromium.org/3001003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52998 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2805090
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52996 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This shows up as
Suppression:
{
<insert_a_suppression_name_here>
Memcheck:Leak
fun:_Znw*
fun:_ZNSt8_Rb_treeISsSt4pairIKSsSt3setIiSt4lessIiESaIiEEESt10_Select1stIS7_ES3_ISsESaIS7_EE11_M_get_nodeEv
fun:_ZNSt8_Rb_treeISsSt4pairIKSsSt3setIiSt4lessIiESaIiEEESt10_Select1stIS7_ES3_ISsESaIS7_EE14_M_create_nodeERKS7_
fun:_ZNSt8_Rb_treeISsSt4pairIKSsSt3setIiSt4lessIiESaIiEEESt10_Select1stIS7_ES3_ISsESaIS7_EE9_M_insertEPSt18_Rb_tree_node_baseSE_RKS7_
fun:_ZNSt8_Rb_treeISsSt4pairIKSsSt3setIiSt4lessIiESaIiEEESt10_Select1stIS7_ES3_ISsESaIS7_EE13insert_uniqueESt17_Rb_tree_iteratorIS7_ERKS7_
fun:_ZNSt3mapISsSt3setIiSt4lessIiESaIiEES1_ISsESaISt4pairIKSsS4_EEE6insertESt17_Rb_tree_iteratorIS8_ERKS8_
fun:_ZNSt3mapISsSt3setIiSt4lessIiESaIiEES1_ISsESaISt4pairIKSsS4_EEEixERS7_
fun:_ZN23ExtensionMessageService24DispatchEventToRenderersERKSsS1_bRK4GURL
fun:_ZL13DispatchEventP7ProfilePKcSs
fun:_ZL26DispatchSimpleBrowserEventP7ProfileiPKc
fun:_ZN27ExtensionBrowserEventRouter17OnBrowserRemovingEPK7Browser
fun:_ZN11BrowserList13RemoveBrowserEP7Browser
fun:_ZN7BrowserD0Ev
fun:object_cxxDestructFromClass
fun:_ZN12_GLOBAL__N_113ZombieDeallocEP11objc_objectP13objc_selector
fun:-[NSResponder dealloc]
fun:-[NSWindowController dealloc]
fun:-[BrowserWindowController dealloc]
fun:-[NSWindowController release]
fun:__delayedPerformCleanup
fun:CFRunLoopTimerInvalidate
fun:CFRunLoopRunSpecific
}
, with
c++filt __ZNSt3mapISsSt3setIiSt4lessIiESaIiEES1_ISsESaISt4pairIKSsS4_EEEixERS7_ being map::operator[] and the symbol above it being map::insert().
(e.g. http://build.chromium.org/buildbot/memory/builders/Chromium%20Mac%20UI%20(valgrind)(3)/builds/3538/steps/memory%20test:%20ui/logs/stdio ).
Seems to happen only on mac.
This shouldn't leak, but maybe we're hitting an STL leak (I tried to build a reduced test case for a few minutes and failed). Maybe it goes away with this.
BUG=none
TEST=One fewer "Suppression:" line on mac ui_tests valgrind bots (2 instead of 3 atm).
TBR=mpcomplete
Review URL: http://codereview.chromium.org/2870060
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52995 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=49328
TEST=First tip seen on import to empty profile is import bookmarks promo. This promo appears on the first 5 browser restarts, unless bookmarks are imported.
Review URL: http://codereview.chromium.org/2805089
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52993 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Changes the AutoFill dialog on Mac to support multi-select and delete of items
in the address and credit card table. The "Edit..." button disables when multiple
items are selected.
Nib changes in AutoFillDialog.xib: (1) Enables multi-select for the table view, (2) binds
the enabled state of the "Edit..." button to the new |multipleSelected| property, (3) connects edit button to outlet.
BUG=49344
TEST=AutoFillDialogControllerTest.DeleteMultiple.
Review URL: http://codereview.chromium.org/3039014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52989 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=33033
TEST=Run chrome on POSIX plaforms without explicitly turning on Negotiate.
Review URL: http://codereview.chromium.org/3014013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52987 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3033007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52985 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=48424
TEST=copying from the chrome bookmark manager into firefox should save the bookmark's title as well as url
TEST=copying the address from the omnibox into evolution copies text, and doesn't create an attachment
Review URL: http://codereview.chromium.org/3022004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52983 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=ui_tests don't crash
Review URL: http://codereview.chromium.org/3005018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52982 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
was in focus on the mac.
BUG=32932
TEST=check bug.
Review URL: http://codereview.chromium.org/2847062
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52981 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Don't fill CC data on non-HTTPS pages.
* Don't display non-unique suggestions in the popup.
* Fix displaying the 'AutoFill Options' suggestion (was a regression).
BUG=48499
TEST=none
Review URL: http://codereview.chromium.org/3040004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52980 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
1. GetBrowserInfo() uses a method which was supposed to run on IO thread only, so fails in Debug
2. Fix AutomationJsonReply usage in SaveTabContents()
TEST=python chrome/test/functional/pyauto_functional.py in Debug mode
Review URL: http://codereview.chromium.org/3022012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52979 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
NotificationOptionsMenuModel.
This is the second part of the implementation of the cross platform model that makes use of the implementation
in the views side and get rid of the duplicated coded.
BUG=None
TEST=Go to http://0xfe.muthanna.com/notifyme.html, request permission for notifications, notify it. Click on the wrench menu in the notification balloon, the menu should work as before.
Signed-off-by: Thiago Farina <tfarina@chromium.org>
Review URL: http://codereview.chromium.org/3023004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52978 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Note: this won't go green until issue 2857035 goes in.
BUG=38736
TEST=none (suggestions welcome)
Review URL: http://codereview.chromium.org/2895014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52977 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
once it compiles for multi dll build.
R=maruel
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3050003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52976 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=49193
TEST=none
TBR=oshima
Review URL: http://codereview.chromium.org/3037009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52975 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Default to Allow file permissions for unpacked extensions.
- Fix incognito warning display when extensions are reshuffled.
- Remove SCHEMES_ALL
BUG=48124
BUG=48526
BUG=49243
TEST=no
Review URL: http://codereview.chromium.org/3039005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52974 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
process. This is used for rendering PDFs to a metafile in a sandbox for the Cloud Print proxy on Windows.
BUG=None
TEST=Test Windows Cloud Print proxy
Review URL: http://codereview.chromium.org/2917013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52970 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Added ScreenLockerBackgroundView to re-layout lock_widget on resize.
For 4399, we'll update WM to make lock window fullscreen,
and update chrome to use window but not popup.
BUG=chromium-os:4078, chromium-os:4399
TEST=none
Review URL: http://codereview.chromium.org/3034012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52969 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Removed OpenTanMode (confirmed with cole)
Removed ToolbarView::SetAppMenuModel
BUG=49229
TEST=none.
Review URL: http://codereview.chromium.org/2832058
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52968 0039d316-1c4b-4281-b951-d872f2087c98
|