summaryrefslogtreecommitdiffstats
path: root/chrome
Commit message (Collapse)AuthorAgeFilesLines
* Null out member so that it will be properly reset in StartLogging()jar@google.com2008-09-241-0/+1
| | | | | | | r=petersont Review URL: http://codereview.chromium.org/4242 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2536 0039d316-1c4b-4281-b951-d872f2087c98
* A crasher happens when restoring the focus as a result of switching tab, ↵jcampan@chromium.org2008-09-231-1/+5
| | | | | | | | | | | because the browser window does not have a focus manager. I am not sure how this could happen, this CL just bullet-proofs the code. BUG=1384044 Review URL: http://codereview.chromium.org/4054 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2529 0039d316-1c4b-4281-b951-d872f2087c98
* Add an accessor to get the CPAPI main plugin thread's MessageLoop. Use thatmpcomplete@google.com2008-09-233-1/+12
| | | | | | | to fix a crash in renderer/chrome_plugin_host.cc. Review URL: http://codereview.chromium.org/4050 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2528 0039d316-1c4b-4281-b951-d872f2087c98
* Try to re-land issue 3200cpu@google.com2008-09-231-7/+13
| | | | | | | | | - it was causing trouble in the distributed tests - now does not try to load the dll in headless configs Review URL: http://codereview.chromium.org/4233 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2520 0039d316-1c4b-4281-b951-d872f2087c98
* Removing the check for creation time on favorites when importing with IE.jcampan@chromium.org2008-09-232-18/+1
| | | | | | | | We were comparing the creation date of the favorite with the profile dir creation date, and ignoring the favorite if they were created around the same time (in an effort to get rid of IE defaults favorites). This was causing problems as some users seem to import their profile and have profile dir and favorites created at the same time. Review URL: http://codereview.chromium.org/4207 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2518 0039d316-1c4b-4281-b951-d872f2087c98
* This CL enables the Page info menu when right-clicking on a page/frame.jcampan@chromium.org2008-09-237-41/+118
| | | | | | | | | | For the frame case, the SSL info had to be added to the show menu message (as the navigation entry contains the top frame SSL info). BUG=2467 TEST=Open a page over HTTPS with multiple frames. Right-click and select shot page info. Review URL: http://codereview.chromium.org/4034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2504 0039d316-1c4b-4281-b951-d872f2087c98
* Update chromium strings.tc@google.com2008-09-235-8/+8
| | | | | | | TBR=mal Review URL: http://codereview.chromium.org/4228 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2503 0039d316-1c4b-4281-b951-d872f2087c98
* Fix bottom right resize corner flicker during size.joshia@google.com2008-09-232-0/+6
| | | | | | | | | | | | | Handle WM_NCPAINT and handle it (do nothing) instead of passing it down to DefWindowProc. B=2577 TEST=resizing window using botom right corner and watch for any odd GUI effects. Review URL: http://codereview.chromium.org/3192 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2501 0039d316-1c4b-4281-b951-d872f2087c98
* Fix for windowed painting regression.jam@chromium.org2008-09-231-3/+3
| | | | | | Review URL: http://codereview.chromium.org/4221 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2499 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes crasher that occurs when using keyboard to navigate focus andsky@google.com2008-09-231-0/+4
| | | | | | | | | | | enter triggers a focus change. BUG=2554 TEST=see bug Review URL: http://codereview.chromium.org/4014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2487 0039d316-1c4b-4281-b951-d872f2087c98
* Remove io.h from google.patch and fix EOLs. Lack of EOLs is a fatal error ↵deanm@google.com2008-09-233-20/+2
| | | | | | on GCC. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2486 0039d316-1c4b-4281-b951-d872f2087c98
* Build hunspell on Linux.deanm@google.com2008-09-234-11/+22
| | | | | | Patch from Pawel Hajdan Jr. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2483 0039d316-1c4b-4281-b951-d872f2087c98
* Roll the icu38 revision in the DEPS file to change the name ofsgk@google.com2008-09-232-2/+2
| | | | | | | | | our combined-build icuuc.lib to icu.lib. Change solution file references accordingly. Also change libxml patch and Makefile references Review URL: http://codereview.chromium.org/4027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2480 0039d316-1c4b-4281-b951-d872f2087c98
* Bump the version for the next dev cycle.mal@chromium.org2008-09-231-2/+2
| | | | | | | | | | | Since we're already working toward 0.3 as the next Beta update, I bumped the minor to 0.3. R= nsylvain@chromium.org Review URL: http://codereview.chromium.org/4204 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2476 0039d316-1c4b-4281-b951-d872f2087c98
* Once again for a mysterious reason all sites are crashing in nsylvain@chromium.org2008-09-231-7/+3
| | | | | | | | | | | | the distributed test at this location: chrome_23e0000!v8::internal::Builtins::Setup+0x2bb Revert this change because it seems to be the culprit. Review URL: http://codereview.chromium.org/4206 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2475 0039d316-1c4b-4281-b951-d872f2087c98
* Issue 2509: Duplicate tab should not create a new window.finnur@google.com2008-09-233-29/+34
| | | | | | Review URL: http://codereview.chromium.org/3147 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2474 0039d316-1c4b-4281-b951-d872f2087c98
* Re-land SDCH filter support experimentjar@google.com2008-09-238-0/+183
| | | | | | | | | | | Fix up solution files for webkit and net Add one line keyword change to help linux build r=hunanr,openvcdiff,nsylvain Review URL: http://codereview.chromium.org/4026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2469 0039d316-1c4b-4281-b951-d872f2087c98
* Load RLZ in 20 seconds instead of 100 seconds.cpu@google.com2008-09-231-3/+7
| | | | | | | | | | | | | | | - And have a way to set the initial events even if chrome was shut down before it was able to initialize and thus we have an empty rlz. Apparently a sizeable % of our users have an empty rlz string and it looks like this can be the cause. BUG= 1372961 Review URL: http://codereview.chromium.org/3200 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2467 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r2253 to turn off magic_browzR by default and restore themal@chromium.org2008-09-232-7/+1
| | | | | | | | | --magic_browzR command line switch. R= ben@chromium.org Review URL: http://codereview.chromium.org/4031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2465 0039d316-1c4b-4281-b951-d872f2087c98
* Disable tests while I investigatejam@chromium.org2008-09-231-2/+2
| | | | | | | TBR=nsylvain Review URL: http://codereview.chromium.org/4202 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2464 0039d316-1c4b-4281-b951-d872f2087c98
* Desynchronize windowless plugin painting. This greatly improves the paintingjam@chromium.org2008-09-228-325/+260
| | | | | | | | performance when there are multiple plugins, or when scrolling. Review URL: http://codereview.chromium.org/3133 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2459 0039d316-1c4b-4281-b951-d872f2087c98
* I'm going to try and land this again. This is exactly the same change as you ↵sky@google.com2008-09-224-13/+31
| | | | | | | | | | | | | | | | reviewed earlier. Fixes mnemonic bug in chrome menus. After this change you can indicate whether menus have mnemonics. Mnemonics are shown if the menus have mnemonics, and the OS says we should show them. BUG=1355952 TEST=add a bookmark and change the title to &foo. Move the bookmark to a folder, click on the folder and make sure the title shows the &. Review URL: http://codereview.chromium.org/4021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2458 0039d316-1c4b-4281-b951-d872f2087c98
* Fix for issue 2617: After using Ctrl+O to open a local file the directory is ↵finnur@google.com2008-09-221-5/+7
| | | | | | | | locked. Review URL: http://codereview.chromium.org/3194 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2457 0039d316-1c4b-4281-b951-d872f2087c98
* Rollback 2444 and 2443 to get linux and mac prepjar@google.com2008-09-228-170/+0
| | | | | | | | | Also need to augment sln dependencies tbr Review URL: http://codereview.chromium.org/3188 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2446 0039d316-1c4b-4281-b951-d872f2087c98
* Reverts fix for 2554.sky@google.com2008-09-224-31/+13
| | | | | | Review URL: http://codereview.chromium.org/4017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2445 0039d316-1c4b-4281-b951-d872f2087c98
* Experimental integration of delta compression content encodingjar@google.com2008-09-228-0/+170
| | | | | | | | | | | | | | | | | | | | | | | The command line option "sdch-enable" enables support of sdch and automtic lazy download of dictionaries. Optionally it can select a singular domain to work from. By default, all domains are enabled when the flag is used. "-sdch-enable=".google.com" Enables it only for Google. When the switch is not set on the command line, all this code is completely disabled. Still TBD: a) Finish implementation of security details (much of it is in place) b) Add tests for security details. r=huanr,ajenjo,kmixter Review URL: http://codereview.chromium.org/461 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2443 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes mnemonic bug in chrome menus. After this change you can indicatesky@google.com2008-09-224-13/+31
| | | | | | | | | | | | | whether menus have mnemonics. Mnemonics are shown if the menus have mnemonics, and the OS says we should show them. BUG=1355952 TEST=add a bookmark and change the title to &foo. Move the bookmark to a folder, click on the folder and make sure the title shows the &. Review URL: http://codereview.chromium.org/4002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2442 0039d316-1c4b-4281-b951-d872f2087c98
* Use the new dll injection blocking api of the sandbox to blockcpu@google.com2008-09-224-32/+35
| | | | | | | | | the loading of dlls that cause renderer crashes. - Remove the old FreeLibrary() method Review URL: http://codereview.chromium.org/2458 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2441 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup EOL and include guards, including fixing one guard that was not the ↵deanm@chromium.org2008-09-2017-38/+27
| | | | | | | | correct path. Lack of EOL on bloom_filter.h had broken the Linux build, this is a fatal warning with GCC. Review URL: http://codereview.chromium.org/4007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2437 0039d316-1c4b-4281-b951-d872f2087c98
* Create a SafeBrowsing database interface to more easilypaulg@google.com2008-09-2011-1713/+1897
| | | | | | | | | | | facilitate alternate implementations. The current SafeBrowsingDatabase code is moved to *_impl files. Adding a new implementation can be done via command line flags in the SafeBrowsingDatabase::Create factory method. Review URL: http://codereview.chromium.org/3162 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2434 0039d316-1c4b-4281-b951-d872f2087c98
* Revert change 2419 because it breaks the buildnsylvain@chromium.org2008-09-206-554/+181
| | | | | | | | | | | | | | | | | | | | | | | | | The stack crashing is this one: chrome_2650000!xmlTextWriterStartElement+0x23 chrome_2650000!MetricsLog::StartElement+0xb5 chrome_2650000!MetricsLog::ScopedElement::ScopedElement+0x67 chrome_2650000!MetricsLog::RecordHistogramDelta+0xd8 chrome_2650000!MetricsService::RecordHistogram+0x122 chrome_2650000!MetricsService::RecordCurrentHistograms+0xc3 chrome_2650000!MetricsService::StopRecording+0x94 chrome_2650000!MetricsService::PushPendingLogsToUnsentLists+0xbf chrome_2650000!MetricsService::SetRecording+0x36f chrome_2650000!MetricsService::Stop+0x11 chrome_2650000!BrowserMain+0xefa chrome_2650000!ChromeMain+0x862 It looks like writer_ is null on invalid. It also look like there is debugging code that was left in. Review URL: http://codereview.chromium.org/4005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2433 0039d316-1c4b-4281-b951-d872f2087c98
* This fixes the following bugs:-iyengar@google.com2008-09-201-0/+10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 1.http://code.google.com/p/chromium/issues/detail?id=292 This was a painting issue in the XStandard plugin. The bug occurs in a windowed instance of the plugin. We handle window repositions in the plugin process until the window becomes visible. We set the SWP_NOREDRAW flag in the SetWindowPos call. This turns off client/non-client paints. After the SetWindowPos call we invalidate the client area. The plugin only receives WM_PAINT as a result. The plugin relies on the WM_NCPAINT message being received as well. In any case the SWP_NOREDRAW flag does not buy us much as we invalidate immediately after. The fix is to take out this flag. 2.http://code.google.com/p/chromium/issues/detail?id=2556 The plugin invoked the NPN_GetValue function to retreive the window script object. This call fails in this case probably because the plugin instance in the renderer process is in the process of shutting down. We return a failure from the call. The plugin fails to check the return code and ends up invoking NPN_GetProperty on a NULL NPObject which causes a crash in chrome when we try to create a proxy for the same. The fix is to add NULL NPObject checks in the NPObjectProxy members and return early. Bug=292,2556 R=jam Review URL: http://codereview.chromium.org/3176 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2429 0039d316-1c4b-4281-b951-d872f2087c98
* Stop exposing manually_selected_match_ outside the AutocompletePopupModel. ↵pkasting@chromium.org2008-09-1911-362/+222
| | | | | | | | | | | | | | | | | | | The main goal of this is to be a first step towards divorcing the popup and the edit from each other. To do this, I changed the behavior of manual selections. They now do not persist once the user types more characters, hits esc, etc. Our old behavior, which Brett and I designed long ago, turns out to have been a mistake; users who arrowed to an item and then typed more weren't expecting "stickiness" on their previous choice, and it led to user mistakes. This also required changing how we do the "keyword UI" persistence in the case where the user switches into keyword UI, but then deletes all his text. Previously, we used manually_selected_match_ with a provider affinity to the keyword provider in order to accomplish this. Now we stick another flag on the AutocompleteInput, which, when set, biases the keyword provider to return the best results. The user-visible effect of this is that when in keyword UI mode with no query string, the selected entry in the popup will be the first, rather than third, entry. This is a small win. While here I fixed the bug where editing a string and transforming it into a keyword search would avoid switching into keyword UI (as expected), but also delete the keyword off the visible string (oops). I also made us lock the popup once the user changes the manually_selected_match_, in order to give a little more stability to it. I'm sorry this makes so many behavioral changes at once. All this code is tangled together and untangling it is hard :( The keyword-related variables in the AutocompleteEditModel seem a mess. They are probably worse now than before this change; I think I need a followup change at some point to make them all more sane. It seems like we have three variables and complex conditionals where two, and simpler ones, would do. BUG=997976,1201974,1204173 Review URL: http://codereview.chromium.org/3172 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2426 0039d316-1c4b-4281-b951-d872f2087c98
* This is the same change as issue 1633 ( http://codereview.chromium.org/1633 ↵petersont@google.com2008-09-196-181/+554
| | | | | | | | ) together with the disabling of a test called MetricsServiceTest.CloseRenderersNormally which the change makes obsolete (see bug 2522.) Review URL: http://codereview.chromium.org/2995 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2419 0039d316-1c4b-4281-b951-d872f2087c98
* Landing a patch for Adam. See http://codereview.chromium.org/3136 for details.finnur@google.com2008-09-194-18/+7
| | | | | | | | TBR=abarth Review URL: http://codereview.chromium.org/2996 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2417 0039d316-1c4b-4281-b951-d872f2087c98
* Adding a CPAPI function to make a function call asynchonously on the plugin ↵zork@google.com2008-09-194-1/+47
| | | | | | | | thread. Review URL: http://codereview.chromium.org/2969 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2414 0039d316-1c4b-4281-b951-d872f2087c98
* Changes the bookmark model to allow more than one bookmark tosky@google.com2008-09-1922-316/+510
| | | | | | | | | | | | | | | | reference the same url. Clicking the star button edits the most recently added bookmark for the URL. Dragging a button/star always does a move, otherwise drops on the bookmark bar create a new bookmark. Also changed the add page context menu for the bookmark bar to remember where you invoked it from. BUG=1173228 1678 Review URL: http://codereview.chromium.org/3203 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2413 0039d316-1c4b-4281-b951-d872f2087c98
* Attempt at fixing flaky Find test.finnur@google.com2008-09-191-1/+6
| | | | | | | | The waterfall (build.chromium.org) has been complaining about this test for a while now. Nicolas and I looked at this, but we don't see anything wrong. We theorized this is because we issue Find right after the navigation and maybe the tab isn't ready. We'll see what happens with this change. Review URL: http://codereview.chromium.org/2978 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2411 0039d316-1c4b-4281-b951-d872f2087c98
* Make sure webkit/port and webkit/glue are in lower case because libGlue.a ↵tc@google.com2008-09-192-7/+5
| | | | | | looks funny. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2410 0039d316-1c4b-4281-b951-d872f2087c98
* Build a bunch more of chrome/ on Linux.deanm@google.com2008-09-1921-74/+83
| | | | | | Patch from Pawel Hajdan Jr. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2408 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes bug in tooltip manager. Mouse coordinates for NC events are insky@google.com2008-09-192-4/+12
| | | | | | | | | | | screen coordinates and need to be converted. BUG=2523 TEST=see bug Review URL: http://codereview.chromium.org/3160 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2406 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting the fixes for the UI test single-process mode in the NPAPIiyengar@google.com2008-09-191-6/+8
| | | | | | | | | | tests. The offending Stream test has been disabled in single-process mode TBR=jam Review URL: http://codereview.chromium.org/3166 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2404 0039d316-1c4b-4281-b951-d872f2087c98
* roll backbeng@google.com2008-09-191-3/+0
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2402 0039d316-1c4b-4281-b951-d872f2087c98
* This CB fixes the following issue1. ↵iyengar@google.com2008-09-198-14/+74
| | | | | | | | http://code.google.com/p/chromium/issues/detail?id=206This is a performance issue while loading PDF documents. The fix is to support PDF fast webview, which is basically support for the NPN_RequestRead API, which allows a plugin to request specific byte ranges in HTTP GET requests. This also needs support for seekable streams. Our support for seekable streams is limited to HTTP servers which allow byte range requests. Firefox also supports a mode in which the the browser caches the file on disk for servers which don't support byte range requests. The plugin_data_stream.cc/.h files are being removed as there is not much value in their existence. The needed functionality is available in the PluginStreamUrl class, which now services manual data streams as well. Testing this is a touch tricky as we need a HTTP server which serves byte range requests. Will add those in a subsequent CB.Also fixed a bug in the multipart parser where we need to ignore leading newline characters while parsing the header.Bug=206 Review URL: http://codereview.chromium.org/2896 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2400 0039d316-1c4b-4281-b951-d872f2087c98
* Make sure the frame is set to the foreground when:ben@chromium.org2008-09-191-0/+3
| | | | | | | | | | | - opening from a shortcut when an existing frame is already open - pressing Ctrl+T from an app window http://crbug.com/2477 Review URL: http://codereview.chromium.org/3134 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2399 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a memory leak in Add to dictionary code.sidchat@google.com2008-09-182-0/+6
| | | | | | Review URL: http://codereview.chromium.org/3148 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2379 0039d316-1c4b-4281-b951-d872f2087c98
* Fix an old leak in tab_strip_model_unittest which had recently contributed ↵erikkay@google.com2008-09-182-59/+7
| | | | | | | | to a new leak showing up. The leak was caused by not cleaning up after ReplaceTabContents. Review URL: http://codereview.chromium.org/2954 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2374 0039d316-1c4b-4281-b951-d872f2087c98
* Use libevent, second try. Changes this time:dkegel@google.com2008-09-181-0/+1
| | | | | | | | | - remove bogus include of base/completion_callback.h - add DEPS rules to allow including third_party/libevent Review URL: http://codereview.chromium.org/2964 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2371 0039d316-1c4b-4281-b951-d872f2087c98
* Make uninstall slightly less prone to chrome.exe crashes by changing default ↵kuchhal@chromium.org2008-09-183-45/+26
| | | | | | | | | | to uninstall confirmation. BUG=1215 Review URL: http://codereview.chromium.org/3128 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2370 0039d316-1c4b-4281-b951-d872f2087c98
* NULL check the return value during navigation to prevent a crash.brettw@google.com2008-09-181-0/+2
| | | | | | | BUG=1384003 Review URL: http://codereview.chromium.org/2966 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2366 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-01 12:13:22 +0000