summaryrefslogtreecommitdiffstats
path: root/chrome
Commit message (Collapse)AuthorAgeFilesLines
* Had the logic for detecting ifdef DEBUG wrong.mbelshe@google.com2008-08-211-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1188 0039d316-1c4b-4281-b951-d872f2087c98
* Fix ChromeClientImpl::windowRect() to return the currenterg@google.com2008-08-213-7/+6
| | | | | | | | | | window's rect. Previously, it was combining the window origin with the size of the renderer; not the size of the window. BUG=1186573 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1184 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes up the autocomplete providers to correctly update starredsky@google.com2008-08-217-85/+41
| | | | | | | | | | | state. I broke this in order to land my last mongo patch. HistoryContentsProvider is still lacking in one area. BUG=1256202 TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1181 0039d316-1c4b-4281-b951-d872f2087c98
* Add missing file to fix the buildjoshia@google.com2008-08-211-2/+2
| | | | | | | TBR=nsylvain git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1179 0039d316-1c4b-4281-b951-d872f2087c98
* Code review changes. Incorporated all the suggestions from previous review. joshia@google.com2008-08-2115-111/+110
| | | | | | | | | | | | | One item not changed yet is to rename 'receiver' in ForwardMessageToExternalHost. The idea is to invoke receiver("message") at the other end. So for example if the args to ForwardMessageToExternalHost("hello", "world") then we will invoke a script hello("world") on the other side. 'receiver' doesn't really describe the first argument here so if there is a better suggestion, I would be happy to change it :) git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1176 0039d316-1c4b-4281-b951-d872f2087c98
* Fix leak on shutdown in the navigation controller. The pending entry was notbrettw@google.com2008-08-211-0/+2
| | | | | | getting deleted. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1173 0039d316-1c4b-4281-b951-d872f2087c98
* Unrollback r1158.rahulk@google.com2008-08-218-55/+92
| | | | | | | BUG=1296800 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1170 0039d316-1c4b-4281-b951-d872f2087c98
* Add the ability to disable breakpad while running the ui tests.maruel@google.com2008-08-213-0/+12
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1169 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 1158 as it is breaking ui_testsrahulk@google.com2008-08-219-93/+56
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1165 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes bug in BookmarkBarNode. I wasn't resetting a load handlesky@google.com2008-08-211-5/+5
| | | | | | | | | | | | | | resulting in the possibility of trying to cancel a bogus load handle. I'm TBRing this one as I just introduced this and its easy to hit a DCHECK now. BUG=1256202 TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1163 0039d316-1c4b-4281-b951-d872f2087c98
* Update chrome strings.tc@google.com2008-08-212-517/+517
| | | | | | TBR=mal git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1161 0039d316-1c4b-4281-b951-d872f2087c98
* disable test to make build greenrahulk@google.com2008-08-211-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1160 0039d316-1c4b-4281-b951-d872f2087c98
* Do not display "Google" in titlebar of Chromium builds. rahulk@google.com2008-08-218-55/+92
| | | | | | | | - Create a new resource file that will contain Google Chrome specific resources. Ideally this new resource file should not be in the Chromium project at all but there doesnt seem to be any way to do conditional includes in vcproj files. So we ifdef its contents. - Make distributor logo optional. If we do not find it, we do not try to paint/layout logo. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1158 0039d316-1c4b-4281-b951-d872f2087c98
* Makes resize of custom frame window a bit smoother. I tried a wholesky@google.com2008-08-211-1/+14
| | | | | | | | | | | | | | | | | slew of variations, and this is the best I could get. From nc calc size we now return WVR_REDRAW, which indicates we need to redraw the frame. Without this I believe windows was copying some bits around for us resulting in the jitter. Additionally in OnNCPaint we do nothing if the root view's size isn't the same as the window's size. This is done as during resizes we get a WM_NCPAINT *before* a WM_SIZE. We also get a WM_NCPAINT after the WM_SIZE, so that it's ok to ignore the first one. BUG=1293978 TEST=make sure sizing of task manager/keyword editor doesn't break. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1157 0039d316-1c4b-4281-b951-d872f2087c98
* Moves bookmarks out of history into its own file (JSON).sky@google.com2008-08-2157-2414/+1216
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Interesting points: . Migration was a bit atypical. Here is the approach I took: . If the URL db contains bookmarks it writes the bookmarks to a temporary file. . When the bookmark bar model is loaded it assumes bookmarks are stored in a file. If the bookmarks file doesn't exist it then attempts to load from history, after waiting for history to finish processing tasks. . I've broken having the omnibox query for starred only. This patch was already too ginormous for me to contemplate this too. I'll return to it after I land this. . Similarly the history page isn't searching for starred titles now. As we discussed with Glen, that is probably fine for now. . I've converted NOTIFY_STARRED_FAVICON_CHANGED to NOTIFY_FAVICON_CHANGED and it is notified ANY time a favicon changes. I'm mildly concerned about the extra notifications, but without having history know about starred it's the best I can do for now. . Autocomplete (specifically URLDatabase::AutocompleteForPrefix) previously sorted by starred. It can no longer do this. I don't think I can get this functionality back:( Luckily it only mattered if you had a starred and non-starred URL with the same type count that matched a query. Probably pretty rare. What's left: . Fix up HistoryContentsProvider to query for starred entries titles. . Clean up the delete all case. I basically just made it compile; it can be greatly simplified. . Rename BookmarkBarModel to BookmarksModel. BUG=1256202 TEST=this is a huge change to bookmarks. Thanfully it's pretty well covered by tests, none-the-less make sure you exercise bookmarks pretty heavily to make sure nothing is busted. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1153 0039d316-1c4b-4281-b951-d872f2087c98
* fix build bustagedarin@google.com2008-08-211-1/+2
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1148 0039d316-1c4b-4281-b951-d872f2087c98
* Fix release build bustage.darin@google.com2008-08-211-0/+3
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1147 0039d316-1c4b-4281-b951-d872f2087c98
* Port the Thread class properly to Mac and Linux. This involved portingdarin@google.com2008-08-214-4/+5
| | | | | | | | | | | | PlatformThread and creating an API on PlatformThread to create a native thread and later join with it. I also made a few other tweaks to PlatformThread, such as eliminating the Current() method which appears to be unused. The operator==() is also unused, so I killed it as well. I made a few other miscellaneous cleanups and adjustments. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1146 0039d316-1c4b-4281-b951-d872f2087c98
* As Brett pointed it out, We normally use 8-bit for encoding names since ↵jnd@google.com2008-08-2132-118/+123
| | | | | | they're always ASCII. Plus, wstrings will also be 32-bit characters on Linux and Mac, which is expensive. So I make this CL by using std::string instead of std::wstring every time you have an encoding name. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1144 0039d316-1c4b-4281-b951-d872f2087c98
* Track removal of browser\navigation_controller_base.cc.sgk@google.com2008-08-211-1/+0
| | | | | | TBR: brettw git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1142 0039d316-1c4b-4281-b951-d872f2087c98
* Fix one bug in the URL list.mbelshe@google.com2008-08-211-2/+7
| | | | | | | Add timeout to NavigateToURL in case there are timeouts. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1140 0039d316-1c4b-4281-b951-d872f2087c98
* Kill NavigationControllerBase. I merged the two into NavigationController.brettw@google.com2008-08-215-710/+536
| | | | | | | | | This fixes a leak of NavigationEntry's by using the spiffy linked ptr. I had to add a const to linked_ptr for the comparisons to work. BUG=1319484 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1137 0039d316-1c4b-4281-b951-d872f2087c98
* Don't compile installer_util_strings.rc as a separate .res,sgk@google.com2008-08-201-10/+5
| | | | | | | it's getting #included by the other .rc files that need it. (While here, refactor the way the libs are configured for consistency.) git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1128 0039d316-1c4b-4281-b951-d872f2087c98
* TrackedObjects assumes you can use a "TLS slot" of -1 to indicate ↵evanm@google.com2008-08-206-23/+25
| | | | | | uninitialized. This isn't true for the pthread_key_t type, which is unsigned on Linux and reportedly a struct on Macs. This change modifies the Slot type to be a struct containing an "initialized" flag. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1122 0039d316-1c4b-4281-b951-d872f2087c98
* Revert a fix where I mistakenly assumed that numbers coming into erg@google.com2008-08-203-10/+8
| | | | | | | | | | | | Browser::MoveContents() were content sizes instead of window sizes; this broke a unit test and is incorrect. Reopening the other bug; it seems like webkit is getting totally wrong numbers when asking for a window's size. BUG=1334628, git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1121 0039d316-1c4b-4281-b951-d872f2087c98
* Revert. Failing unit tests.evanm@google.com2008-08-206-25/+23
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1118 0039d316-1c4b-4281-b951-d872f2087c98
* Allow popups using the new frames to be sized correctly. This involved a ↵beng@google.com2008-08-205-51/+131
| | | | | | | | | slight tweak to how RestoreWindowPosition on Window works - if the window is opened with specified bounds, we still ask the delegate to try and restore the position. The delegate can use the provided bounds as a hint (in the popup case the bounds aren't the true layout bounds of the window, rather the rect contains the window position and content area size) to return the actual bounds of the window. B=1031854 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1117 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes leak in BookmarkBarContextMenu test.sky@google.com2008-08-201-8/+7
| | | | | | | | BUG=1335232 TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1116 0039d316-1c4b-4281-b951-d872f2087c98
* TrackedObjects assumes you can use a "TLS slot" of -1 to indicate ↵evanm@google.com2008-08-206-23/+25
| | | | | | uninitialized. This isn't true for the pthread_key_t type, which is unsigned on Linux and reportedly a struct on Macs. This change modifies the Slot type to be a struct containing an "initialized" flag. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1113 0039d316-1c4b-4281-b951-d872f2087c98
* Do not leave temp files in %TEMP% folder. The log file initialization ↵rahulk@google.com2008-08-205-55/+0
| | | | | | | | | creates these temporary files and these log files are of no use. BUG=1330260 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1111 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a leak in newly added sync channel unit tests.jabdelmalek@google.com2008-08-201-0/+1
| | | | | | BUG=1334220 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1103 0039d316-1c4b-4281-b951-d872f2087c98
* Chrome changes to allow non-ASCII characters in shortcut filenames.mpcomplete@google.com2008-08-204-9/+35
| | | | | | BUG=1331408 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1098 0039d316-1c4b-4281-b951-d872f2087c98
* Workaround for truncation of "Search from right here" text when using Hebrew ↵glen@google.com2008-08-201-2/+8
| | | | | | | | | Chrome on Vista. Will file separate bug so the root cause is fixed. BUG=1325257 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1097 0039d316-1c4b-4281-b951-d872f2087c98
* Update chrome strings.tc@google.com2008-08-202-5/+5
| | | | | | TBR=mal git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1094 0039d316-1c4b-4281-b951-d872f2087c98
* Disable this interactive ui tests because it fails on the bot.nsylvain@google.com2008-08-201-1/+3
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1082 0039d316-1c4b-4281-b951-d872f2087c98
* Add wow_helper.exe to chrome-win32.ziprvargas@google.com2008-08-191-0/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1072 0039d316-1c4b-4281-b951-d872f2087c98
* Update archive script to not include rlz.dll unless we are building Google ↵rahulk@google.com2008-08-193-11/+33
| | | | | | | | | Chrome. BUG=1296800 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1065 0039d316-1c4b-4281-b951-d872f2087c98
* Move time formatters that only use ICU into base/time.*tc@google.com2008-08-198-130/+27
| | | | | | | | | | | | | This allows us to use the time formatters in, e.g., net or webkit. Remove CookieExpires since it's not used. BUG=1164516 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1063 0039d316-1c4b-4281-b951-d872f2087c98
* Add installer/util/browser_distribution.cc to SCons build.sgk@google.com2008-08-192-0/+3
| | | | | | | | Add $CHROME_DIR/installer/util to CPPPATH when compiling the .res files so chrome_dll.res can #include installer_util_strings.rc. TBR: rahulk git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1061 0039d316-1c4b-4281-b951-d872f2087c98
* SCons build accommodation of change from generated setup_string.{rc,h}sgk@google.com2008-08-192-3/+3
| | | | | | | to generated installer_util_strings.{rc,h}. TBR: rahulk git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1056 0039d316-1c4b-4281-b951-d872f2087c98
* Add test_notification_tracker.cc to SCons build unit tests.sgk@google.com2008-08-191-0/+1
| | | | | | TBR: brettw git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1055 0039d316-1c4b-4281-b951-d872f2087c98
* Add a new PrintResult() method that outputs perf-test results in a particularpamg@google.com2008-08-194-35/+81
| | | | | | | | | | | arcane format expected by the Python post-processing script. Switch memory_test to use that method. Fix a small typo in the vcproj group name. BUG=1326725,1221588 TEST=none yet; will be covered by buildbot git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1051 0039d316-1c4b-4281-b951-d872f2087c98
* Drag tab 2 out of the tab strip.sidchat@google.com2008-08-191-0/+148
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1049 0039d316-1c4b-4281-b951-d872f2087c98
* The truncation on the match count label (bug 1110432) has been bugging me a ↵finnur@google.com2008-08-191-2/+0
| | | | | | | | | | bit. This problem has actually improved a bit over time (we used to truncate from the left, but now we are cutting off a small 1 px strip from the bottom). I noticed that we are extending the label one pixel too far down anyway, so by removing that the problem goes away. BUG=1110432 TEST=Open Find, paste some random text into the Find box (something that will result in 0 matched) and notice that the red background on the match-count label is rectangular, not 6-sided. :) git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1047 0039d316-1c4b-4281-b951-d872f2087c98
* The automation system can be torn down before all of the notification observersdarin@google.com2008-08-191-0/+5
| | | | | | | that the automation system created. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1046 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor localized strings used in installer for Chromium/Google Chrome ↵rahulk@google.com2008-08-1919-148/+90
| | | | | | | | | | | | | | | separation (see other change out for review - chromium_1). - Rename resources files as util_strings.* as they will be used by classes in util project. - Instead of directly accessing resource, chrome.dll and setup.exe will get the resource from helper class in util project. Remove references to header file from projects. - The resources still need be bundled in the binary so directly include util_strings.rc in resource file. - Add another string "Google Inc" in resource file to use as Publisher name. - Remove uninstall URL from resource file. This URL is not going to be localized, we are manually appending language parameter to it. BUG=1296800 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1044 0039d316-1c4b-4281-b951-d872f2087c98
* Add renderer\external_host_bindings.cc to the SCons build.sgk@google.com2008-08-193-1/+3
| | | | | | TBR: joshia git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1043 0039d316-1c4b-4281-b951-d872f2087c98
* Cleans up notifications for the NavigationController. There were severalbrettw@google.com2008-08-1917-86/+418
| | | | | | | | | | | | notifications before and some of them were very unclear and misused (STATE_CHANGED). This one, and PRUNED were called unnecessarily in some cases as well. I replaced STATE_CHANGED and INDEX_CHANGED with ENTRY_COMMITTED which is more clear and covers (I think!) all the cases that the callers care about. I added a simple notification testing helper class, and used in the navigation controller unit tests to make sure we get the proper notifications. I had to change NotificationSource/Details to have a = and copy constructor so I can track them easily in my helper. I don't see why this would be bad. BUG=1325636,1321376,1325779 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1039 0039d316-1c4b-4281-b951-d872f2087c98
* Make the otr avatar icon not show in detached OTR popup windows.beng@google.com2008-08-195-28/+29
| | | | | | B=1031854 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1038 0039d316-1c4b-4281-b951-d872f2087c98
* Update chrome strings.tc@google.com2008-08-198-15/+15
| | | | | | TBR=mal git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1034 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-02 03:44:05 +0000