| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
| |
Provide a method that allows the gears plugin to ask the browser
process to verify that its renderer has permission to access the
drop files. Update the copyright notices.
BUG=7995
Review URL: http://codereview.chromium.org/159074
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21437 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Will talk to Scott when he comes back from vacation to get this re-enabled.
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/159225
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21435 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
as more tabs are added. Don't resize on selection when tabs are very small, except just enough to show a close box. Clip closebox and favicon as tab gets very small. Fix z-order to be consistent among all unselected tabs. Fix incognito man disappearing when dragging window via the tab. Tabs can now get about as small as they do on windows allowing many more to fit.
BUG=14911, 14913, 17372
TEST=adding and removing lots of tabs and making sure nothing goes wrong.
Review URL: http://codereview.chromium.org/159206
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21432 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=13516
TEST=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21431 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change will allow two Windows users to install thier own copy of Chrome
and set it as default browser. There is a bunch of refactoring in this change.
- Divided the registry entries into three categories:
* Entries that are only read from HKLM
* Entries that actually tie file/protocol associations to Chrome. This will
almost always be in HKCU (except when it is a OEM install).
* Entries that we can create in HKCU if we fail to create them in HKLM.
- For single user machine nothing should change.
- For two users on the same machine (each with a different user level Chrome
installed), the second user's default browser will get renamed to
Chromium.<user> and the required registry entries will also be renamed so that
they do not overwrite first users's registry entries.
BUG=3641
TEST=Install and set Chromium as default browser from two different logins on the same machine for various combinations of XP/Vista, admin users/non admin user, user-level install/system-level install.
Review URL: http://codereview.chromium.org/159172
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21428 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
data files, and I want a clean try of the actual code changes before I submit :)
BUG=NONE
TEST=NONE
Review URL: http://codereview.chromium.org/159281
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21427 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/159278
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21425 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=17401
TEST=none
Review URL: http://codereview.chromium.org/159244
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21424 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Put recent skia failures into known_crashes.txt.
BUG=http://crbug.com/17569
TEST=Check that the reliability bot goes green.
Review URL: http://codereview.chromium.org/160030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21422 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
there were no other windows as drag targets, but only the first time.
BUG=11125
TEST=dragging tabs in and out of windows should show consistent feedback.
Review URL: http://codereview.chromium.org/160018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21421 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(Hook up WebKit's Frame::eventHandler()->capsLockStateMayHaveChanged() in
WebViewImpl::KeyEvent() and -flagsChanged: to -keyEvent: in BaseView.)
Patch from viettrungluu@gmail.com.
BUG=http://crbug.com/15795
TEST=go to some password field (e.g., in gmail login), cycle capslock
Review URL: http://codereview.chromium.org/159215
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21420 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I chose to add an out parameter to OnReceivedRedirect because it allows for the
default behavior to remain the same.
I considered adding a ContinueAfterRedirect method that all OnReceivedRedirect
implementations would need to call, but this caused one annoying problem: In
the case of a ChromePlugin, it is possible for the URLRequest to get deleted
inside the handler for the redirect. This would make it hard to subsequently
call a method on the URLRequest since I would need to have a way to determine
if the URLRequest had been deleted.
TEST=covered by unit tests
BUG=16413,6442
R=eroman,wtc
Review URL: http://codereview.chromium.org/155897
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21417 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=17572
TEST=none
TBR=levin
Review URL: http://codereview.chromium.org/160029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21414 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
worker tests failures.
Review URL: http://codereview.chromium.org/159276
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21412 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We also don't select all of the text if the user dragged to
highlight some text before releasing the button.
Tested by repeating the scenarios from:
http://codereview.chromium.org/151006
http://codereview.chromium.org/159185
plus checking that the following cases behave as expected:
1. Type some text into the omnibox. Click in Webkit to give
it the focus. Click once in the omnibox. All of its
text should be highlighted, and middle-clicking in
another window should show that the primary selection was
updated.
2. Click in the omnibox to clear its highlighted text and
click in Webkit again. Click in the omnibox again, but
this time drag to highlight some text before letting go
of the button. The highlighted text should be preserved
on button release, and the primary selection should be
updated.
3. Repeat step 2. Click a few times in the omnibox and
confirm that we don't select all of its text (that should
only happen at the end of the initial click that focuses
the omnibox).
(Patch from Dan Erat)
http://codereview.chromium.org/155971
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21410 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
finishing. This is an attempt to fix a memory leak.
BUG=17387
TEST=no
Review URL: http://codereview.chromium.org/155895
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21409 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
menu reload - the dialog is modal, but there may not be anything for it to be modal to.
This is a shorter term fix - a longer term fix will be to change the way the dialog is displayed and allow it to be routed through automation.
Review URL: http://codereview.chromium.org/160010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21400 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Adds ipc/ipc.gyp:* to the windows-only 'pull_in_all' target in chrome.gyp so
that it's built on the windows builders and removes the dependency from
unit_tests onto ipc/ipc.gyp:ipc_tests.
Renames file_descriptor_set_unittest.cc to file_descriptor_set_posix_unittest.cc
to match the .h/.cc files and so that it gets picked up by the exclusion filter
properly.
(Patch from James Robinson)
http://codereview.chromium.org/159272
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21399 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
crashes on reliability. It also seems to be causing
valgrind error.
Original change:
Switch the first thread in a child process to be the main thread, and make theIO thread be the second thread. The change is needed for plugins on mac.
Review URL: http://codereview.chromium.org/159274
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21398 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fix an off-by-one in the zip filename reading code. It's pretty harmless, and
caused by a fairly lousy minizip API. It could lead to an out-of-bounds read
due to lack of null termination.
No way to reliably test.
BUG=NONE
TEST=NONE
Review URL: http://codereview.chromium.org/155984
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21397 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When we drag over a thumbnail we move the drop target 15px towards the
location it would be if we dropped the source.
BUG=14961
TEST=Drag a thumbnail. When dragging over an item the item should move
towards the location of where the source came from.
Review URL: http://codereview.chromium.org/155978
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21396 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
notification.
Review URL: http://codereview.chromium.org/155939
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21394 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=http://crbug.com/17519
TEST=change themes; tabs should theme too
Review URL: http://codereview.chromium.org/159271
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21393 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
error from the notification service. This error seems to be fixed.
BUG=15265
Test=This is a test
Review URL: http://codereview.chromium.org/155858
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21392 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TEST=none
Review URL: http://codereview.chromium.org/160016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21391 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
were moved to IPC, but the source ones in chrome/common were kept.
Review URL: http://codereview.chromium.org/160014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21389 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/159249
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21388 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
together during a drag.
BUG=16386
TEST=dragging together windows of different sizes.
Review URL: http://codereview.chromium.org/159270
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21386 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This allows to redefine flags (e.g. 'logfile') for debugging purposes.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/160003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21385 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=13300
TEST=see bug.
Review URL: http://codereview.chromium.org/159269
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21381 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
SysNativeMBToWide and WideToSysNativeMB (that use mbstowcs and wcstombs) to
work correctly.
This is a clone of http://codereview.chromium.org/155913
BUG=16860 (http://crbug.com/16860 )
TEST=Run Chrome with LC_ALL=en_US.UTF-8 and try to upload a file whose name
contains non-ASCII characters in UTF-8 (e.g. "café.txt" or "一二.txt" ) . The filename field in a form should be populated with the name (rather than empty).
Review URL: http://codereview.chromium.org/159221
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21380 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
window.
BUG=17531
TEST=incognito man doesn't show up in popups, but does in main windows.
Review URL: http://codereview.chromium.org/159267
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21379 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
boolean logic. Difficult to test because this is way up close
to the UI.
Review URL: http://codereview.chromium.org/160002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21376 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/155983
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21371 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(Broke in r21342)
<jamesr> agl: chromium XP release builder builds chrome.sln and then tries to
run ipc_tests.exe. nothing in chrome.gyp depends on ipc_tests now so the
executable doesn't exist on that builder
<jamesr> agl/jrg: adding a dependency on ../ipc/ipc.gyp:ipc_tests to the
'coverage' target would solve both issues
<jrg> jamesr: agl's change will only impact the coverage bots. Sounds like
that't not what you want, right?
<jamesr> jrg: i think it's correct but won't resolve the chromium XP issue.
coverage should run for those tests either way
<agl> jamesr: how about I tie it to unit_tests?
<agl> jamesr: there's a long term solution and then there's getting the builder
green.
<jamesr> agl: yeah. trying to check super fast if getting that builder to not
run ipc_tests.exe is easy
http://codereview.chromium.org/155977
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21369 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
CL 21252 seems to have had some svn brokenness (not sure why). I've recreated
it and resubmitted it. The changes are to move image_diff from
chrome/tools/test to tools/, and to make test_shell depend on image_diff
and npapi_layout_test_plugin (and test_worker, where applicable)
R=nsylvain@chromium.org
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/155959
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21366 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
a 1920x1200 screen.
Also, tweak the default size of new windows slightly. In case we decide
to use side by side windows size the window in such a way that 2
windows fit on the screen and have the kWindowTilePixels spacing
between each other and the screen edges.
BUG=None
TEST=Show two windows side. On a 1920x1200 screen they should both be
showing the thumbnails in normal size.
Review URL: http://codereview.chromium.org/155930
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21364 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/159231
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21362 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
theIO thread be the second thread. The change is needed for plugins on mac.
Review URL: http://codereview.chromium.org/155944
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21355 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=17392
TEST=Less console spew on test bots.
Review URL: http://codereview.chromium.org/155881
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21351 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
extension's name.
TEST=none
http://crbug.com/16759
Review URL: http://codereview.chromium.org/155957
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21350 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
out of the browser. We must wrap the tab renderer widget in a GtkFixed in order to maintain the size we request for the widget; otherwise, the widget will fill the entire window.
BUG=none
TEST=Drag a tab out of the window. This should not crash.
Review URL: http://codereview.chromium.org/155965
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21348 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=Running with --enable-plugins on, go to a page with a plugin and kill the plugin process. The info bar should list the name of the plugin rather than its path.
Review URL: http://codereview.chromium.org/155952
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21347 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add browser-process IPC code + tweak the WebKit Thread. Note that this code can't possibly be called/run yet.
WebKitThread now has a PostIOThreadTask methods that can safely post back to the IO thread. This should be used for all WebKit thread -> the rest of the world communication.
There are many TODOs in this code that should be resolved before this is shipped without a --enable-local-storage flag.
BUG=4360
TEST=none
Review URL: http://codereview.chromium.org/155845
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21346 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
If the mouse down occurs over an unselected row, let the default handler run before we show the context menu (so that row will be selected when we show the menu). If the mouse down occurs over a selected row, don't let the default handler run (because if multiple rows are selected the rest of the selection would get clobbered).
BUG=http://crbug.com/17388
TEST=see bug
Review URL: http://codereview.chromium.org/159179
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21344 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This splits the ipc code from the common project. The 'common' project pulls in
all of webkit, the v8 bindings, skia, googleurl, and a number of other projects
which makes it very difficult to deal with especially for external projects
wanting just to use some of Chromium's infrastructure. This puts the ipc code
into its top-level ipc/ directory with a dependency only on base. The common
project depends on the new ipc/ipc.gyp:ipc target so that all projects currently
pulling common in to get the IPC code still have it available. This mostly
follows agl's pre-gyp attempt to do this which was r13062.
Known issues:
- Currently a number of projects depend on chrome/chrome.gyp:common in order to
use the IPC infrastructure. Rather than fixing all of these dependencies I have
made common depend on ipc/ipc.gyp:ipc and added "ipc" to the include_rules
section of DEPS so that checkdeps.py doesn't complain. Over time projects that
need IPC should depend on the IPC project themselves and dependencies on common
removed, although I don't think many projects that need IPC will be able to get
away without common currently.
- ipc/ipc_message_macros.h still has #include "chrome/common/..." inside of a
ipc/ should not refer to files in chrome/... now. I'm not sure how to resolve
this since it's really an IDE bug
- the named pipe name (windows+linux) and the logging event name (all) + env
variable (posix) refer explicitly to 'Chrome' which somewhat hurts the illusion
of ipc/ being an independent library. I think this should be examined in a
subsequent, much smaller patch.
- I've eliminated the IPC.SendMsgCount counter since it was implemented in a way
to create a dependency from ipc/ to chrome/common/chrome_counters. This is the
same approach that r13062 took.
http://codereview.chromium.org/155905
(Patch from James Robinson)
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21342 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
TBR: aa
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21341 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
browser_tests are not happy.
TBR=aa
BUG=no
TEST=no
Review URL: http://codereview.chromium.org/159243
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21340 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=estade
Review URL: http://codereview.chromium.org/159240
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21338 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
failing on the buildbot.
TBR=aa
BUG=no
TEST=no
Review URL: http://codereview.chromium.org/159235
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21336 0039d316-1c4b-4281-b951-d872f2087c98
|