summaryrefslogtreecommitdiffstats
path: root/chrome
Commit message (Collapse)AuthorAgeFilesLines
* Change the signature of JSONReader::Read() and relatedaa@chromium.org2008-12-2917-149/+121
| | | | | | | | | methods to be more friendly to use with scoped_ptr. Change all the callsites. Review URL: http://codereview.chromium.org/16270 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7486 0039d316-1c4b-4281-b951-d872f2087c98
* * Bring up render_mesages.cc on POSIX.jeremy@chromium.org2008-12-293-2/+24
| | | | | | | | | * Add Pickle::Read/WriteUint32 & ParamTraits<uint32>. * Removed NSEvent from WebInputEvent since it appears not to be needed anymore. Review URL: http://codereview.chromium.org/16479 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7484 0039d316-1c4b-4281-b951-d872f2087c98
* * Update xcode project to add files compiled on Linux but not on OS X in ↵jeremy@chromium.org2008-12-293-30/+44
| | | | | | | | | chrome/common. * Update chrome/common/common.scons for OS X. * bring up property_bag_unittest.cc on Linux & OS X. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7482 0039d316-1c4b-4281-b951-d872f2087c98
* Blind attempt at a fix for the Windows SCons build.evanm@google.com2008-12-261-1/+0
| | | | | | | | I didn't break it, but it'd be useful for verifying my other changes didn't break things if the Windows SCons build were green. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7480 0039d316-1c4b-4281-b951-d872f2087c98
* Mass convert ChromeStaticLibrary -> ChromeLibrary, including pulling the ↵evanm@google.com2008-12-2610-10/+10
| | | | | | | | | | | updated ICU dep that uses it as well. Add a SHARED scons command-line flag to build shared libraries. Review URL: http://codereview.chromium.org/16477 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7479 0039d316-1c4b-4281-b951-d872f2087c98
* Initial subset of .vcproj file generation, covering generation of:sgk@google.com2008-12-241-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | base\build\base.vcproj base\build\base_gfx.vcproj base\build\base_unittests.vcproj base\build\debug_message.vcproj skia\skia.vcproj testing\gtest.vcproj third_party\icu38\icu.vcproj third_party\icu38\icudt.vcproj third_party\libpng\libpng.vcproj third_party\zlib\zlib.vcproj Supporting work in *.scons files: * Adds .h files to the input_files lists in the various *.scons files. * Add arguments to ChromeMSVSProject() to actually generate the .vcproj files. * Add MSVS.AddConfig() calls to the *.scons files to preserve the .vsprops inclusion in the generated .vcproj files. (These will go away eventually as we migrate away from .vsprops in favor of using the settings from the SCons configuration.) * Add MSVS.AddConfig() calls to preserve the .vsprops inclusion. * Move the special generation of dmg_fp/*.cc files ahead of the input file list so we can list the generated object files. * Change the 'solutions' Alias to 'msvs' so we don't mislead about what will actually be generated. Updates to the new _Node_MSVS.py module with latest from upstream prototype development: * Support configurability of: * buildtarget (used to generat project name) * RootNamespace * relative_path_prefix (to prepend './') * tools (to avoid repetition in the project configs) * Track the Visual Studio hierarchy in SCons Nodes, not DOM, so we can delay evaluation until after the complete configuration has been specified. * Add a FileList base class for the things that need, with a subclass hierarchy for the different concrete things in our tree, and a FileListWalk() function for traversing hierarchies. * Centralize turning strings into Nodes in the args2nodes() method and have AddFiles() just use it. Updates to chromium_builders.py to support all this * Add knowledge about stripping out noncompilable files (.h files) from input_files lists. * Return a Null() class if we're not generating MSVS files so we don't have to hide the other calls in if:-blocks. * Add custom ChromeFileList subclass of MSVS.FileList as a container for the file list manipulation we need to do. * Move the Chrome*() function definitions out to global space, and just use the generate() function for adding them to the passed-in environment as class methods. * Make a change to SCons (in Node/FS.py) to handle polymorphism in the new MSVS Node hierarchy. Review URL: http://codereview.chromium.org/16447 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7467 0039d316-1c4b-4281-b951-d872f2087c98
* Implement extension:// protocol.aa@chromium.org2008-12-2419-44/+265
| | | | | | Review URL: http://codereview.chromium.org/15010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7462 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes NPAPITester ui tests. I was trying to diagnose failing ui testssky@google.com2008-12-231-3/+29
| | | | | | | | | | | | | | and with page heap enabled these tests consistenly crashed on me. I've no idea about this code, but this change fixed it. As far as I can tell in some cases Send deletes the NPObjectProxy, so that any code that attempts to access the proxy after the Send may crash. BUG=none TEST=none Review URL: http://codereview.chromium.org/16418 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7452 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor the two URLRequestContext subclasses in profile.cc into a new sharedaa@chromium.org2008-12-235-279/+267
| | | | | | | | | | | | | | | | | ChromeRequestContext class. This will allow us to put browser-specific request context here rather than in URLRequestContext and eliminates a lot of duplicate code. I looked at having two different classes using either inheritance (as proposed by the existing TODO) or composition, but it seems like there isn't enough difference between these two classes to justify it. Removed is_off_the_record() because it wasn't being used anywhere and did a few other minor code cleanup things. Review URL: http://codereview.chromium.org/16408 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7448 0039d316-1c4b-4281-b951-d872f2087c98
* Add a dummy PostThreadMessage and PeekMessage call to help inform Windows ↵darin@chromium.org2008-12-231-9/+19
| | | | | | | | | | | that our subprocesses have started up. This causes Windows to promptly stop showing the IDC_APPSTARTING cursor when opening a new tab or navigating to a new domain via the location bar. BUG=4805 R=ananta Review URL: http://codereview.chromium.org/16464 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7447 0039d316-1c4b-4281-b951-d872f2087c98
* Add some ui_tests to the Purify skip filter until we can fix them.paulg@google.com2008-12-231-0/+5
| | | | | | | | TBR=erikkay Review URL: http://codereview.chromium.org/16245 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7435 0039d316-1c4b-4281-b951-d872f2087c98
* * Bring up GreaseMonkeySlave unittest on OS X.jeremy@chromium.org2008-12-233-4/+29
| | | | | | | | * Fix missing Autoreleasepool warning in SafeBrowsing Unittest. Review URL: http://codereview.chromium.org/16243 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7432 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting my landing (of a patch by external contributer).finnur@google.com2008-12-231-4/+1
| | | | | | | | | | I jumped the gun, Peter raised additional issues after we both LGTM'ed (and I didn't notice those emails). TBR=pkasting Review URL: http://codereview.chromium.org/16234 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7412 0039d316-1c4b-4281-b951-d872f2087c98
* Landing a patch for m0interactive (already in the AUTHORS list):finnur@google.com2008-12-231-1/+4
| | | | | | | | | | | | | | | | Ctrl+U should show up view-source on Application shortcuts. According to pkasting in dev mailing list: "Ctrl-U for an application should do what the context menu option does: open a source tab in some normal window." Hence, made it a NEW_FOREGROUND_TAB for disposition TBR=pkasting BUG=http://crbug.com/5115 Review URL: http://codereview.chromium.org/16233 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7408 0039d316-1c4b-4281-b951-d872f2087c98
* Fix 4830: We navigate back after closing the Save As dialog.finnur@google.com2008-12-231-2/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | If you use Alt-Shift-T and the arrow keys to go to the Page menu and then launch the Save Page As dialog, we would navigate back after saving the page. This is because once we close the Save As dialog with Enter, focus goes to the Back button (which arguable is also wrong, see issue 5750) and it receives a KeyRelease(Enter), which causes us to navigate back right after saving the page. In Windows, pressing Enter while a button has focus clicks the button on KeyPressed, whereas we currently click the button on KeyRelease. This patch makes Chrome mimic native Windows behavior. We retain the current behavior for Space, however, which clicks on KeyReleased in both Chrome and Windows. BUG=4830 TEST=Native Chrome buttons should click buttons on KeyPress when using Enter and on KeyRelease when using Space. Review URL: http://codereview.chromium.org/16202 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7406 0039d316-1c4b-4281-b951-d872f2087c98
* New attempt at landing the resource_dispatcher_host.cc splitting (broke the ↵jcampan@chromium.org2008-12-2341-2635/+3137
| | | | | | | | | build on Friday). TBR=darin Review URL: http://codereview.chromium.org/15801 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7400 0039d316-1c4b-4281-b951-d872f2087c98
* Fix Win/Release build bustage.jeremy@chromium.org2008-12-221-0/+2
| | | | | | Review URL: http://codereview.chromium.org/16435 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7393 0039d316-1c4b-4281-b951-d872f2087c98
* Make Maximized Mode Not Suck, part 1 (checkpoint).pkasting@chromium.org2008-12-221-170/+182
| | | | | | | | | | | | | | | | Pixel perfection (I think) on Normal and App windows, maximized and restored, on Windows XP Luna with default fonts and border widths. Among other things, fixes window control placement, tabstrip height, window icon/title placement, and client edge drawing (especially at the tops/bottoms of windows). Known to still be broken: Popup windows Untested: Vista non-Aero, Classic, non-default fonts/borders, non-main windows (Options, Task Manager, etc.) This change is pretty hacky in some places; once I get the behavior nailed perfectly I'll need to go back and try and cut down on the number of constants and use better logic instead. I do at least try to remove some of the current hacks or else document them. Eventually I'll need Ben's and Glen's eyeballs for things, as I've had to make judgment calls about the correct behaviors; some of these I copied our 1.0 behavior, and some I've tried to ape a native app more closely. Especially tricky are the positioning of window icons/titles, since our titlebar isn't quite like a native one. BUG=5054 Review URL: http://codereview.chromium.org/16219 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7391 0039d316-1c4b-4281-b951-d872f2087c98
* Bring up chrome/common/ipc_sync_message.cc on POSIX.jeremy@chromium.org2008-12-224-7/+24
| | | | | | Review URL: http://codereview.chromium.org/16428 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7390 0039d316-1c4b-4281-b951-d872f2087c98
* Bump build to 156: I branched 155 for a release build ChromeBot run.mal@chromium.org2008-12-221-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7386 0039d316-1c4b-4281-b951-d872f2087c98
* Bring up IPC::ChannelProxy on POSIX.jeremy@chromium.org2008-12-225-4/+68
| | | | | | Review URL: http://codereview.chromium.org/16426 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7385 0039d316-1c4b-4281-b951-d872f2087c98
* My Friday fix for some stack trashing introduced some heap trashing!jcampan@chromium.org2008-12-221-20/+37
| | | | | | | | | | | | | | | | | | The tests create PageInterstitial objects which are self-owned (they delete themselves when hidden). The tests test whether the PageInterstitial instance has been deleted by passing a local variable boolean to its constructor that the InterstitialPage sets to true when deleted. In the stack trashing case, in one of the test the interstitial was deleted from the TearDown() method, so outside of the scope of the test. The interstitial was still accessing the local variable from the test scope, trashing the stack. My previous fix introduced a state guard class allocated on the stack that would notify the InterstitialPage when deleted so it would clear any reference to the local vars, which fixed the stack trashing. But this created a new problem: when the interstitial is deleted in the scope of the unit tests, the state guard object still holds a reference to the now deleted interstitial and calls a method on it when itself deleted. This CL ensures the state guard class does not access any deleted interstitial. BUG=5789 Review URL: http://codereview.chromium.org/16423 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7384 0039d316-1c4b-4281-b951-d872f2087c98
* Review URL: http://codereview.chromium.org/16209jcampan@chromium.org2008-12-221-12/+19
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7355 0039d316-1c4b-4281-b951-d872f2087c98
* Attempt to fix Windows build.phajdan.jr@chromium.org2008-12-201-1/+1
| | | | | | Review URL: http://codereview.chromium.org/14920 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7345 0039d316-1c4b-4281-b951-d872f2087c98
* Platform cleanup in chrome/browser/net.phajdan.jr@chromium.org2008-12-205-29/+23
| | | | | | | | Preparing for more complex changes. Review URL: http://codereview.chromium.org/14919 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7344 0039d316-1c4b-4281-b951-d872f2087c98
* Changed DomAutomationController to use UTF-8 strings.scherkus@chromium.org2008-12-201-1/+1
| | | | | | Review URL: http://codereview.chromium.org/15071 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7340 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting my CL to fix build bustage.jcampan@chromium.org2008-12-2040-3135/+2633
| | | | | | | TBR=maruel Review URL: http://codereview.chromium.org/15099 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7338 0039d316-1c4b-4281-b951-d872f2087c98
* This CL moves the different resource handlers from ↵jcampan@chromium.org2008-12-2040-2633/+3135
| | | | | | | | | | | | | | | | resource_dispatcher_host.cc into their own files, into a new renderer_host directory. Their is no functionality change in this CL. The motivation for doing that was: - resource_dispatcher_host.cc has become very long and more than 1/3 of the code is for the resource handler. - having the resource handler in their own file allows having unit tests for them. BUG=none TEST=run all unit tests and UI tests. Review URL: http://codereview.chromium.org/14487 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7336 0039d316-1c4b-4281-b951-d872f2087c98
* The unit test WebContentsTest.ShowInterstitialProceedMultipleCommands was ↵jcampan@chromium.org2008-12-191-5/+49
| | | | | | | | | | | | crashing. This was caused by a class dereferencing a pointer to a local variable out of the scope of the local var, trashing the stack. BUG=5700 TEST=Run the unit tests. Review URL: http://codereview.chromium.org/14909 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7330 0039d316-1c4b-4281-b951-d872f2087c98
* After staring at this line of code I realized it was saying something much ↵pkasting@chromium.org2008-12-191-3/+1
| | | | | | | | simpler. Review URL: http://codereview.chromium.org/14904 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7322 0039d316-1c4b-4281-b951-d872f2087c98
* Implement command line switch to allow using a FIFO or a socketpair() for ↵jeremy@chromium.org2008-12-196-33/+169
| | | | | | | | IPC on POSIX. Review URL: http://codereview.chromium.org/14863 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7319 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 7304 to reapply 7296. It wasn't its fault.maruel@chromium.org2008-12-191-4/+4
| | | | | | Review URL: http://codereview.chromium.org/15083 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7308 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 7306 to reapply 7296. It wasn't its fault.maruel@chromium.org2008-12-191-0/+1
| | | | | | Review URL: http://codereview.chromium.org/15603 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7307 0039d316-1c4b-4281-b951-d872f2087c98
* Dummy checkin to force a build. NO CODE CHANGE.maruel@chromium.org2008-12-191-1/+0
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7306 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 7296.maruel@chromium.org2008-12-191-4/+4
| | | | | | | | From http://build.chromium.org/buildbot/waterfall/waterfall?builder=Chromium%20Reliability There is a clear increase of crashes after this change. It really seems like a heap overflow but it's hard to tell. Reverting to see if it helps the reliability tests. If not, we can reapply this change and find another culprit. Review URL: http://codereview.chromium.org/15081 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7304 0039d316-1c4b-4281-b951-d872f2087c98
* Changes docking behavior to not offer a maximize drop target if theresky@google.com2008-12-192-8/+35
| | | | | | | | | | | | | | | | | is a maxmized tabbed browser on the monitor already. I don't feel this is the right long term behavior, but until we figure that out I'm going with this. BUG=4878 TEST=maximize a tabbed browser, drag a tab out of the tabbed browser toward the top of the screen and make sure you aren't offered a dock target. Now restore the tabbed browser, drag a tab toward the top of the screen and make sure you are offered a maximized drop target. Review URL: http://codereview.chromium.org/14858 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7301 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes bug where we wouldn't necessarily start throbber timer on dropsky@google.com2008-12-191-0/+7
| | | | | | | | | | | | | | | | of a tab if the page was loading. The fix is to call LoadingStateChanged, which makes sure everything is in sync and the timer is running (if necessary). BUG=2524 TEST=Create two windows. In one of the windows load a page that takes a long time to load. Drag the tab into the first window and make sure when the tab snaps to the final position the throbber starts appropriately. Review URL: http://codereview.chromium.org/15056 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7300 0039d316-1c4b-4281-b951-d872f2087c98
* Initial generation of native Visual Studio solution filessgk@google.com2008-12-1939-81/+1390
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | (project files still to come). To wit: * Solution file configuration is in *_sln.scons files (base\base_sln.scons, chrome\chrome_sln.scons). * Individual Project file configuration is in the the .scons file for the relevant target (base\base_unittests.scons, third_party\libxml\libxml.scons, etc.)--that is, where their file lists will live. * MSVSProject() calls are currently placeholders that establish the existence of Project Nodes (and Project dependencies) but don't yet have actual Project configuration information (file lists, .vsprops, etc.). * Configuraiton is very manual. In particular, the entries in the .sln file will be written out in exactly the order specified in the configuration(s). The current ordering is taken from our existing .sln files, so we can generate virtually the same configurations on output. * Generated solution files are nearly byte-for-byte identical with our existing .sln files, modulo: * net\dump_cache has a WebsiteProperties sections (making that configurable per project isn't important right now); * sandbox\sandbox.sln was missing a dependency of base.vcproj on on debug_message.vcproj (present in other .sln files) * webkit\webkit.sln was missing dependencies of WebCore.vcproj on libxml_config.vcproj and libxslt_config.vcproj (present in chrome.sln); * add a handful of other miscellaneous missing dependencies on various .vcproj definitions in chrome.sln (present in other .sln files). * remove stats_viewer.csproj from chrome.sln (sorry, mbelshe), which was complicating the solution configuration with unnecessary (for us) "Mixed Platform" types; * All MSVSFolder(), MSVSProject() and MSVSSolution() calls have hard-wired guid= values taken from our existing configuration, so we can: 1) verify generation of working configs; 2) minimize diffs when checking in generated .sln files. We can remove these in the future in favor of extracting them from existing .sln files if we wish. * Add ChromeMSVSFolder(), ChromeMSVSProject() and ChromeMSVSSolution() wrappers to chromium_builders.py, that gate the underlying call to the env.MSVS*() builders based on whether env.Bit('msvs') is set (i.e., we're in --mode=msvs). * Remove platform-specific gating of to-be-ported .scons files that we now need to load on any platform to generate coheren MSVS files. Move the env.Bit('windows') tests for actually building their executables into the individual .scons files. Review URL: http://codereview.chromium.org/14472 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7297 0039d316-1c4b-4281-b951-d872f2087c98
* Switched dns_global.cc over to UTF-8 strings.scherkus@chromium.org2008-12-191-4/+4
| | | | | | Review URL: http://codereview.chromium.org/15065 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7296 0039d316-1c4b-4281-b951-d872f2087c98
* Select the Languages tab of the fonts and languages dialog when using ↵pkasting@chromium.org2008-12-195-12/+37
| | | | | | | | spellcheck context menu commands to change spellchecking options. Patch by Mohamed Mansour, r=me,sky; see http://codereview.chromium.org/15031. Tweaked by me. BUG=5639 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7289 0039d316-1c4b-4281-b951-d872f2087c98
* We need to add UI test for "Encoding" menu to avoid regression.jnd@google.com2008-12-199-27/+312
| | | | | | | | | | | | | | | | | | | For this purpose, I have created several methods in automation API. They can be used for the above UI tests. 1 get the current used encoding name of the page in the specified tab. 2 get value of the encoding auto detection option. 3 enables and disable the encoding auto detection. 4 use the specified encoding to override the encoding of the page in the specified tab. BUG=5515 The corresponding UI test is coming soon Review URL: http://codereview.chromium.org/14162 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7286 0039d316-1c4b-4281-b951-d872f2087c98
* Add a filter for ui_tests that don't (yet) work under Purify.paulg@google.com2008-12-191-0/+9
| | | | | | Review URL: http://codereview.chromium.org/14879 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7285 0039d316-1c4b-4281-b951-d872f2087c98
* The WebContentsTest.ShowInterstitialProceedMultipleCommands unit test seem ↵jcampan@chromium.org2008-12-191-1/+2
| | | | | | | | | | | | | | | to crash on the "XP Test" build bot and has been temporarily disabled. Not sure yet why it crashes, I cannot repro locally and Purify is not reporting any memory errors. Disabling it temporarily. BUG=5700 Review URL: http://codereview.chromium.org/14876 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7284 0039d316-1c4b-4281-b951-d872f2087c98
* Changed SessionStartupPref to use UTF-8 strings.scherkus@chromium.org2008-12-191-2/+2
| | | | | | Review URL: http://codereview.chromium.org/14875 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7283 0039d316-1c4b-4281-b951-d872f2087c98
* Updated HtmlDialogContents to use UTF-8 strings.scherkus@chromium.org2008-12-191-2/+2
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7282 0039d316-1c4b-4281-b951-d872f2087c98
* Review URL: http://codereview.chromium.org/14809jcampan@chromium.org2008-12-1938-1601/+1099
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7281 0039d316-1c4b-4281-b951-d872f2087c98
* Fixing 4222: Clear data dialog has new fields, butfinnur@google.com2008-12-1849-52/+52
| | | | | | | | | | | | | size has not increased in non-US locales. While verifying on all locales, I noticed three locales that had this dialog wider than others and I shrunk those too. Those were locales: el, fil and sv. Review URL: http://codereview.chromium.org/15066 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7273 0039d316-1c4b-4281-b951-d872f2087c98
* Make the global render thread object a regular global object rather than abrettw@google.com2008-12-188-61/+51
| | | | | | | | | | | special TLS value. This is slightly faster for this commonly-used function, and we don't ever have more than one (it's like this because we were originally planning on having more than one RenderThread). BUG=5635 Review URL: http://codereview.chromium.org/15052 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7272 0039d316-1c4b-4281-b951-d872f2087c98
* Convert from using env['PLATFORM'] directly to using the more flexiblesgk@google.com2008-12-1834-77/+100
| | | | | | | | | | | | | | | | | | and better-thought-out Hammer env.Bits() idioms: * env['PLATFORM'] == 'win32' => env.Bit('windows') * env['PLATFORM'] == 'posix' => env.Bit('linux') * env['PLATFORM'] == 'darwin' => env.Bit('mac') New idioms: * env.Bit('posix') => really does mean "any POSIX platform" * env.AnyBits('mac', 'linux') => specifically mac or linux, excluding other POSIX platforms Where we were using compound conditionals (e.g., "env['PLATFORM'] in ('posix', 'darwin')") I tried to take my best shot at translating the intent (i.e., "env.Bits('posix')" for something POSIX, "not env.Bits('mac')" for something not yet ported to Mac, etc.) Review URL: http://codereview.chromium.org/15051 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7270 0039d316-1c4b-4281-b951-d872f2087c98
* Increase timeout for ui_test.paulg@google.com2008-12-181-1/+1
| | | | | | Review URL: http://codereview.chromium.org/15061 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7266 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-01-20 07:01:33 +0000