summaryrefslogtreecommitdiffstats
path: root/chrome
Commit message (Collapse)AuthorAgeFilesLines
* Reupload of 12418glen@chromium.org2008-12-0733-229/+1850
| | | | | | Review URL: http://codereview.chromium.org/13183 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6497 0039d316-1c4b-4281-b951-d872f2087c98
* Capitalize the 'Extensions' folder in the visual studio project for consistency.aa@chromium.org2008-12-071-1/+1
| | | | | | Review URL: http://codereview.chromium.org/13613 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6496 0039d316-1c4b-4281-b951-d872f2087c98
* Third time's a charm?dkegel@google.com2008-12-076-293/+89
| | | | | | | | | | | | | | | | | | | | | | | | | | | Fix part of http://code.google.com/p/chromium/issues/detail?id=4510 and improve https support in test shell on linux. This is the same as the earlier ssl cert cl (see http://codereview.chromium.org/11249), but with the certs moved so net can use them without reaching over into chrome's pants and causing test failure on the 'modules' Windows build server, which is set up to test net and base but not chrome. For this to pass, we will need to install the certs on the windows module and try servers. (And make sure tlslite is present.) (A later CL will finish implementing SSLInfo for Linux, and probably reference net/base/ssl_test_util.cc from all three vcproj files that need it, even though that's ugly, because that's less ugly that referencing it from net.lib's vcproj.) Review URL: http://codereview.chromium.org/12930 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6495 0039d316-1c4b-4281-b951-d872f2087c98
* Makes the tab restore service persist closed tabs/windows to disk andsky@google.com2008-12-0642-1213/+2192
| | | | | | | | | | | | | | | | | reload them when asked. Sorry for largish looking change. It's made big by refactoring common code between TabRestoreService and SessionService into a common superclass. At the same time I removed some dead code and shuffled the session related classes into a single directory for easier perusal. BUG=384 TEST=close the browser, start the browser and make sure the new tab page shows closed windows/tabs from the previous session. Review URL: http://codereview.chromium.org/13152 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6490 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes possible flicker when tab finishes animating back to draggedsky@google.com2008-12-061-1/+5
| | | | | | | | | | | position. BUG=NONE TEST=none Review URL: http://codereview.chromium.org/13221 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6489 0039d316-1c4b-4281-b951-d872f2087c98
* Remove an unused string (IDS_PAGE_MENU_REPORT_PHISHING_WEBSITE_URL)jungshik@google.com2008-12-0551-52/+1
| | | | | | | bug=4457 Review URL: http://codereview.chromium.org/13207 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6462 0039d316-1c4b-4281-b951-d872f2087c98
* * Prevent early exit due to && operator.kuchhal@chromium.org2008-12-051-12/+14
| | | | | | | | BUG=5104 Review URL: http://codereview.chromium.org/13179 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6461 0039d316-1c4b-4281-b951-d872f2087c98
* Fixing build bustage. Adding files which were part of the original changeananta@chromium.org2008-12-055-0/+14
| | | | | | | | | | branch r6396, which was reverted partially. TBR=jam Review URL: http://codereview.chromium.org/13215 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6460 0039d316-1c4b-4281-b951-d872f2087c98
* Add error messages to JSONReader and friends. This required a bit of ↵aa@chromium.org2008-12-0514-32/+42
| | | | | | | | refactoring to do cleanly. This CL doesn't actually use this capability anywhere except for unit tests. I will add that in a future CL. Review URL: http://codereview.chromium.org/13169 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6459 0039d316-1c4b-4281-b951-d872f2087c98
* Add a CHECK to assert that each invocation ofwtc@google.com2008-12-051-0/+5
| | | | | | | | | | | ResourceDispatcherHost::RemovePendingRequest removes exactly one URLRequest from pending_requests_. R=eroman BUG=4749 Review URL: http://codereview.chromium.org/12977 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6458 0039d316-1c4b-4281-b951-d872f2087c98
* Add using_wtl.scons to the chrome\test\automation SCons configuration,sgk@google.com2008-12-051-0/+1
| | | | | | | paralleling addition of using_wtl.vsprops to the VS configuration. Review URL: http://codereview.chromium.org/13401 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6456 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a race condition in the SyncChannel code.jam@chromium.org2008-12-052-61/+37
| | | | | | | | | | | The problem is that QueueMessage would be called with listener() on the IPC thread, and then the function would wait on message_lock_ before adding the message and its associated listener. However, in between the time that listener() was called and the lock was taken control of, the listener thread may be calling RemoveListener. The fix is to not send the listener, but instead just send a pointer to the context. It'll be used on the listener thread, at which point listener() can be called to check if the listener is available. BUG=1305036 Review URL: http://codereview.chromium.org/12952 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6448 0039d316-1c4b-4281-b951-d872f2087c98
* fix chrome_paths to make some test dirs relative to base::DIR_SOURCE_ROOTerikkay@google.com2008-12-054-21/+30
| | | | | | | | | | | | | | rather than chrome::DIR_APP. DIR_APP is in different relative locations on different platforms while DIR_SOURCE_ROOT is the same, so this allows us to share code and be correct on all platforms. Also, enable extensions_service_unittest for Mac and Linux and add an NSAutoreleasePool to ChromeTestSuite (which is now being used by run_all_unittests on Mac and Linux per my earlier checkin). Review URL: http://codereview.chromium.org/13177 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6445 0039d316-1c4b-4281-b951-d872f2087c98
* UserData Options tabmunjal@chromium.org2008-12-053-3/+44
| | | | | | | | | Plumbing for User Data tab in Options dialog. Review URL: http://codereview.chromium.org/13150 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6442 0039d316-1c4b-4281-b951-d872f2087c98
* Change "client" parameter in RLZ ping to "referral" gwilson@google.com2008-12-055-11/+11
| | | | | | | | | | to match Omaha's changes. BUG=1520348 Review URL: http://codereview.chromium.org/12975 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6440 0039d316-1c4b-4281-b951-d872f2087c98
* Change the accelerator key for Javascript debug to Ctrl-Shift-D from 'Alt-`'jungshik@google.com2008-12-051-1/+2
| | | | | | | | | BUG=3696,5087 TEST=Install non-en-US keyboard and switch keyboards to one of them (e.g. German, French, Russian) and make sure that shortcut keys for Javascript debug remains 'Ctrl-Shift-L'. Review URL: http://codereview.chromium.org/10652 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6438 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the layout of the Spell Check Options part, in the languages tab, in the ↵sidchat@google.com2008-12-051-18/+20
| | | | | | | | | Fonts and Languages Options Menu, to match with the Mock. Issue=4401 Review URL: http://codereview.chromium.org/12957 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6437 0039d316-1c4b-4281-b951-d872f2087c98
* Fixed a bogus initialization of string constants. The stack allocated ↵erikkay@google.com2008-12-051-12/+6
| | | | | | | | | | | string from StringPrintf gets destroyed right away, and c_str is just a pointer to its internal buffer, so the error constant was bogus memory. This showed up in the purify tests. Sorry I missed this in the initial code review. Review URL: http://codereview.chromium.org/13204 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6436 0039d316-1c4b-4281-b951-d872f2087c98
* move a few #ifdefs around so that unit_tests does proper path initialization ↵erikkay@google.com2008-12-052-9/+8
| | | | | | | | | | for Mac and Linux. This allows use of things like DIR_TEST_DATA. StatsTable also comes along for the ride. Review URL: http://codereview.chromium.org/13153 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6432 0039d316-1c4b-4281-b951-d872f2087c98
* bootstrap app target for browser/renderer.pinkerton@google.com2008-12-055-0/+2736
| | | | | | Review URL: http://codereview.chromium.org/13202 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6430 0039d316-1c4b-4281-b951-d872f2087c98
* We should let binary/octet-stream have an EXE extension to fix compat with ↵abarth@chromium.org2008-12-052-0/+9
| | | | | | | | | | | digsby.com and ohloh.net BUG=1573 R=darin Review URL: http://codereview.chromium.org/13165 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6424 0039d316-1c4b-4281-b951-d872f2087c98
* Clean up junk in content sniffing mock-http-headers.abarth@chromium.org2008-12-056-12/+1
| | | | | | | | R=deanm Review URL: http://codereview.chromium.org/13166 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6423 0039d316-1c4b-4281-b951-d872f2087c98
* Disable the content sniffing algorithm if the server instructs us to do so ↵abarth@chromium.org2008-12-054-1/+18
| | | | | | | | | | | | with the nosniff directive. For context, see http://blogs.msdn.com/ie/archive/2008/09/02/ie8-security-part-vi-beta-2-update.aspx R=deanm,darin Review URL: http://codereview.chromium.org/12982 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6422 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a crash on 64-bit systems when an external message hook is installed. Thebrettw@google.com2008-12-051-1/+3
| | | | | | | | | | proxying for CB_GETCOMBOXINFO is wrong and will crash. Instead, call GetComboBoxInfo. BUG=49 Review URL: http://codereview.chromium.org/13156 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6420 0039d316-1c4b-4281-b951-d872f2087c98
* update chrome stringstc@google.com2008-12-0583-737/+2425
| | | | | | | | | | | This fixes a the Hebrew translation missing a bunch of strings. TBR=mal Review URL: http://codereview.chromium.org/12976 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6417 0039d316-1c4b-4281-b951-d872f2087c98
* Add new multiprofile files to the SCons build:sgk@google.com2008-12-052-0/+3
| | | | | | | | | chrome\browser\user_data_manager.cc chrome\browser\view\new_profile_dialog.cc chrome\browser\view\select_profile_dialog.cc Review URL: http://codereview.chromium.org/12948 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6410 0039d316-1c4b-4281-b951-d872f2087c98
* Add new debugger_host_impl.cpp to the SCons build.sgk@google.com2008-12-051-0/+1
| | | | | | Review URL: http://codereview.chromium.org/12947 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6408 0039d316-1c4b-4281-b951-d872f2087c98
* Introduce ExtensionsService. Load extensions on startup from a directory inaa@chromium.org2008-12-0517-32/+435
| | | | | | | | | | the profile if a command-line flag is present. Please carefully scrutinize the threading/ref-counting schenanigans. Review URL: http://codereview.chromium.org/12876 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6403 0039d316-1c4b-4281-b951-d872f2087c98
* Adding the capacity to interact with modal dialogs to the automation framework.jcampan@chromium.org2008-12-0510-53/+203
| | | | | | | | | This change will be used by Ojan to implement some unload handler tests. TEST=Run the ui tests. Review URL: http://codereview.chromium.org/13113 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6402 0039d316-1c4b-4281-b951-d872f2087c98
* * Do not try to update distribution other than Google Chrome.kuchhal@chromium.org2008-12-051-4/+7
| | | | | | | | BUG=5109 Review URL: http://codereview.chromium.org/13140 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6400 0039d316-1c4b-4281-b951-d872f2087c98
* Don't cancel the original manual data stream request when the plugin invokesananta@chromium.org2008-12-045-14/+0
| | | | | | | | | | | | | | | | | | | | NPN_RequestRead to initiate seekable byte range requests on the stream. While the contract on the plugins part is not fully clear from the mozilla docs, this is what Firefox does. This also improves performance greatly as the manual data stream already has most of the data which the plugin requests anyway. I verified this with large PDF files around 14-15MB. We are twice as faster with this fix. This fixes http://code.google.com/p/chromium/issues/detail?id=5009, which is an issue with the PDF file not loading at times. The problem also occurs at times in Firefox when we set breakpoints and thus slow down the operation. The Reader plugin displays its UI in child windows on a separate thread in the plugin process. These are parented to the plugin window which lives on the plugin thread. The plugin thread unfortunately is treated as an IO thread by the plugin and it uses the SendMessage API to send messages to the plugin thread and back. If the plugin fails to receive data for the PDF file in a reasonable time, it just destroys the PDF window hierarchy causing this issue. Handing the data off the manual data stream along with the byte range data speeds up the whole operation and thus avoids this issue to a great extent. Bug=5009 R=jam Review URL: http://codereview.chromium.org/12960 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6396 0039d316-1c4b-4281-b951-d872f2087c98
* Do not add the Content-Length header in the URLFetcher,paulg@google.com2008-12-041-2/+1
| | | | | | | | | | | since that header will be added later in HttpNetworkTransaction::BuildRequestHeaders. This change prevents POST requests from having a duplicate Content-Length header. Review URL: http://codereview.chromium.org/12965 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6394 0039d316-1c4b-4281-b951-d872f2087c98
* Get rid of kPathSeparator on windows. Port some wstring function to take ↵estade@chromium.org2008-12-0416-45/+47
| | | | | | | | FilePaths. Re-enable relevant posix unit tests. Review URL: http://codereview.chromium.org/12893 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6387 0039d316-1c4b-4281-b951-d872f2087c98
* * Add the checks that Chrome criteria checker will need to do. It mostly ↵kuchhal@chromium.org2008-12-045-16/+467
| | | | | | | | | | | | | | checks for existing installation, appropriate rights and for past offers for Google Chrome. The code borrows heavily from similar code written for Toolbar and Desktop (linked to from the bug). The test executable when run on a machine only makes sure that DLL and lib can be used to invoke the compatibility check function. BUG=1380504 Review URL: http://codereview.chromium.org/12922 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6380 0039d316-1c4b-4281-b951-d872f2087c98
* * Fix Chrome browser not launching when set as default browser.kuchhal@chromium.org2008-12-042-11/+14
| | | | | | | | | | Looks like Desktop (and probably new Talk as well) verify for the existence of "URL Protocol" value before using Chrome command to launch browser (see b/1326171). BUG=1386406 Review URL: http://codereview.chromium.org/13117 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6376 0039d316-1c4b-4281-b951-d872f2087c98
* Changed svn:eol-style of all .sln and .vcproj files to CRLFscherkus@chromium.org2008-12-0491-20341/+20341
| | | | | | Review URL: http://codereview.chromium.org/13133 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6372 0039d316-1c4b-4281-b951-d872f2087c98
* Fix issue 5079: Incorrect "Active match ordinal" count during Find-in-pagefinnur@google.com2008-12-045-62/+144
| | | | | | | | | | | | | | | I introduced a regression in my reimplemenation of Find-in-page. The active match ordinal in Find-in-page (also known as "the 7" in "7 of 9") would be just a little off on pages with frames. Problem A: When you search for something in gmail, for example, the ordinal could start off slightly negative or be 0. I wasn't checking the last_match_count_ of a frame for negative numbers before adding it to the total (it starts off as -1 and remains that way if the frame is not deemed to be worthy of being scoped, i.e. if it is hidden). Problem B: On pages with multiple matches spread across multiple frames the ordinal would not be subtracted correctly after pressing F3 and Shift-F3 to go back to the frame you were on. We shouldn't be increasing/decreasing the active_match_index for a given frame when FindNext/FindPrevious causes us to jump between frames. We should instead reset it. I added two tests to catch this in the future. They test ordinal values as you use Find in page (including combinations of frames/no-frames & FindNext/FindPrevious). Oh, and I also removed some traces that were supposed to expose why a test was flaky, but it turns out to have been something unrelated to the test. Review URL: http://codereview.chromium.org/13130 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6369 0039d316-1c4b-4281-b951-d872f2087c98
* really fix the ifdefpinkerton@google.com2008-12-041-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6367 0039d316-1c4b-4281-b951-d872f2087c98
* wrap logging with correct ifdefpinkerton@google.com2008-12-041-0/+2
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6366 0039d316-1c4b-4281-b951-d872f2087c98
* Add support in spell check options sub-context menu to pop up fonts and ↵sidchat@google.com2008-12-042-3/+18
| | | | | | | | languages options menu. Review URL: http://codereview.chromium.org/12908 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6364 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the issue in Spell Checker when certain words (such as especelly) did ↵sidchat@google.com2008-12-043-1674/+1732
| | | | | | | | | not give any suggestions. Issue=1677 Review URL: http://codereview.chromium.org/11285 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6363 0039d316-1c4b-4281-b951-d872f2087c98
* add a target to run the ipc tests if and when they all pass. Fix up a ↵pinkerton@google.com2008-12-042-7/+79
| | | | | | | | signed/unsigned error in the ipc_message unit test. Review URL: http://codereview.chromium.org/12946 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6358 0039d316-1c4b-4281-b951-d872f2087c98
* adding chrome_paths.ccpinkerton@google.com2008-12-041-0/+2
| | | | | | Review URL: http://codereview.chromium.org/13128 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6355 0039d316-1c4b-4281-b951-d872f2087c98
* Make sure we end the update process if we get an errorfrom the servers. ↵paulg@google.com2008-12-043-8/+18
| | | | | | | | Previously, if we got a 400 (or other)error response, we'd leave the database and transactionopen.BUG=5060 (http://crbug.com/5060) Review URL: http://codereview.chromium.org/12918 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6337 0039d316-1c4b-4281-b951-d872f2087c98
* fix buildtc@google.com2008-12-041-1/+1
| | | | | | | | | TBR=munjal Review URL: http://codereview.chromium.org/13110 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6336 0039d316-1c4b-4281-b951-d872f2087c98
* Chromium-MultiProfile-Prototypemunjal@chromium.org2008-12-0377-19/+1376
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Summary ======= Implement a prototype of multiple profiles in Chrome by utilizing the functionality of user-data-dir command line flag that already exists. A profile in this case is an umbrella for all user data including cookies, history, bookmarks, settings, etc. Each profile gives the user a separation of all these data elements. User Interface ============== - Wrench > "New window in profile" menu item, with sub-menu items. This new menu item has sub menu items for each existing profile, for up to 9 profiles, and one more sub menu item to launch a window in a new profile. The 9 sub-menu items also have the accelerators like CTRL + SHIFT + 1, CTRL + SHIFT + 2, etc. If there are more than 9 profiles, we will also show an extra sub-menu item, "Other...". - New Profile dialog box This dialog box is shown to the use when (s)he clicks Wrench > New window in profile > <New Profile>. It lets the user specify a profile name, and also shows a checkbox to create a desktop shortcut to launch Chrome in that profile. - Choose profile dialog box This dialog box lets the user select a profile from a drop down to open a new window in. It also has an item <New Profile> in the drop down, selecting which will show the new profile dialog box mentioned above. CTRL + M shortcut also launches this dialog box. Code Organization ================= chrome\browser\user_data_dir_profile_manager.h/.cc: This class provides an abstraction of profiles on top of the user data dir command line flag. chrome\browser\views\user_data_dir_new_profile_dialog.h/.cc New profile dialog box code. chrome\browser\views\user_data_dir_profiles_dialog.h/.cc Choose profile dialog box code. Review URL: http://codereview.chromium.org/12895 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6333 0039d316-1c4b-4281-b951-d872f2087c98
* Removing the IsHungAppWindow DCHECK as it does not seem to be indicatingananta@chromium.org2008-12-031-1/+0
| | | | | | | | | | | | | | | | anything useful about the window at this point. It seems to fire at times even when SendMessageTimeout succeeds on the plugin window, which indicates some race condition between Windows updating its state about whether the window is hung. Fixes http://code.google.com/p/chromium/issues/detail?id=5066 Bug=5066 R=nsylvain Review URL: http://codereview.chromium.org/12920 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6318 0039d316-1c4b-4281-b951-d872f2087c98
* Split the cross-platform part of skia_utils_win into skia_utils. Use this newbrettw@google.com2008-12-033-14/+6
| | | | | | | | | function when possible. Add a little documentation. This does not change the Mac build, I'll do that in a separate pass, and the function moved is never used on the mac). Review URL: http://codereview.chromium.org/12917 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6312 0039d316-1c4b-4281-b951-d872f2087c98
* Move base/gfx/skia_util to skia/ext/skia_util_win.brettw@google.com2008-12-0313-13/+13
| | | | | | | In a later pass, I will separate off the cross-platform part of this file into skia/ext/skia_util (only one function). Review URL: http://codereview.chromium.org/13101 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6306 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes bug in window positioning that resulted in positioningsky@google.com2008-12-031-4/+8
| | | | | | | | | | | incorrectly for monitors with an origin < 0 along either axis. BUG=5059 TEST=see bug Review URL: http://codereview.chromium.org/13100 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6300 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-13 03:41:46 +0000