| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13257 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/63029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13256 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
a factory pointer around all the time. Removing TestTabContents will require
making the Browser object keep track of the Factory pointer as well, so I think
the global is the best approach and cleans some things up.
Review URL: http://codereview.chromium.org/62044
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13255 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
It seems there used to be an old bug in Skia, and we explicitly set a stroke
width of 1 instead of 0 to work around it. Internally in Skia this goes down
a more complex path, creating a path from the rect, and then filling the path.
This was causing problems at the edges of the canvas, for example if you were
to DrawRectInt(0, 0, width - 1, height - 1).
Switch some SkRects to SkIRects. Internally Skia will still convert them to scalars, but it makes our code a bit cleaner.
Review URL: http://codereview.chromium.org/62099
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13254 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
a window.
Bug=1751431
Review URL: http://codereview.chromium.org/62042
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13253 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=9806
Review URL: http://codereview.chromium.org/62105
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13250 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
tab model observer API so we once again get update messages.
Review URL: http://codereview.chromium.org/63022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13249 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=9802
Review URL: http://codereview.chromium.org/62104
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13248 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This reverts commit 61ab30f52667e739602ab2af4fd8f2d8a0a2a2f0.
Still seeing memory errors.
Review URL: http://codereview.chromium.org/63056
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13243 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Remove following deprecated wstring-using functions:
net/net_util: FilePathToFileURL
net/net_util: FileURLToFilePath
Switch net/base/upload_data to FilePath.
Switch upload-related parts of net/url_request/url_request to FilePath.
Made necessary adjustments in rest of code (a lot).
Review URL: http://codereview.chromium.org/63011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13242 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This issue is caused by my bonehead mistake in r4300: I misunderstand the behavior of Vista when we call the SetWindowsText() function. It actually cancels an ongoing composition. So, changing this behavior caused this regression.
To fix this issue, this change cancels an ongoing composition instead of completing it. As far as I tested on my XP PC, this fix works also on XP.
BUG=9596
Review URL: http://codereview.chromium.org/60084
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13241 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
- allow resolving local hostname
- simulate a failing lookup of "wpad" in in_process_browser_test
Review URL: http://codereview.chromium.org/63019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13239 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
have to know and copy/paste their extension ID.
This required moving the code that defaults the extension ID earlier
in the load process.
Also fixed some bugs:
* fixed a bug that was causing all user scripts to get executed in
the same context.
* made the greasemonkey api only available in 'standalone' user
scripts.
* re-added the anonymous function wrapper that is supposed to wrap
content scripts.
Also added unit tests for the fixed bugs.
Review URL: http://codereview.chromium.org/60112
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13238 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/60115
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13237 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=9637
Review URL: http://codereview.chromium.org/60086
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13228 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Reverts:
http://codereview.chromium.org/50074
http://src.chromium.org/viewvc/chrome?view=rev&revision=13201
Review URL: http://codereview.chromium.org/63047
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13227 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/62088
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13224 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/62076
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13223 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
in known list.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13222 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/63031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13221 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=9503
Review URL: http://codereview.chromium.org/62087
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13219 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
If system has various fonts, fontconfig will find several font family for
default font, but it might not be the best match in SkFontHost_fontconfig.cpp,
so SkTypeface::Create returns NULL.
Find font family in the same way as FontMatch in SkFontHost_fontconfig.cpp, so
that make sure the font available.
BUG=9654
patch by ukai@google.com: <http://codereview.chromium.org/56147>
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13217 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
The asserts is too aggressive which are causing problems
when closing the tab or reload.
Review URL: http://codereview.chromium.org/62033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13216 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/62084
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13215 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
All infobars consist of nothing but a non-functioning close button.
Review URL: http://codereview.chromium.org/62070
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13206 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
During stopping of the media pipeline in chrome, we
need to detach the filters from WebMediaPlayerDelegateImpl
so it doesn't hold renferences to the filters and filters
can be destructed by the pipeline.
Review URL: http://codereview.chromium.org/60113
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13204 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
right as it's about to display a JS modal dialog.
I don't know how these would be triggered in the field. I ran into them through misuse of the current API (trying to pass in a NULL WebContents).
Review URL: http://codereview.chromium.org/62079
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13203 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
AutocompletePopupViewMac implements AutocompletePopupView in terms of a bare NSWindow containing an NSTableView. AutocompleteTableTarget implements an Obj-C class to bridge from appkit callbacks back to the popup view (and from there to the model which contains the data it needs).
AutocompleteEditViewMac implements AutocompleteEditView in terms of an NSTextField, which is passed down from a nib owner. It works with the popup view to make sure the popup is positioned correctly. AutocompleteFieldDelegate is an internal Obj-C class to bridge from appkit callbacks back to the edit view (and then the edit model).
LocationBarViewMac implements LocationBar for interacting with the rest of the browser, and AutocompleteEditController for managing the edit and popup views. It is mostly placeholder code stolen from the gtk implementation.
---
I've tried to implement an amount of code which worked and was useful, but which didn't drag on and on into the future. So no tab to search or hints or anything, sometimes ugly, selection may be funky, etc.
Review URL: http://codereview.chromium.org/50074
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13201 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
since I don't think the Linux port supports those modes yet. I also ignored RTL. I've made some minor lint/style cleanups along the way.
BUG=9380
Review URL: http://codereview.chromium.org/60104
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13195 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Currently, the bookmark bar only reads state on startup so to see this
work, you have to go to a page, click the star button (that isn't hooked up
yet either), and then restart chromium.
Review URL: http://codereview.chromium.org/60071
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13193 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
keeping it in sync with the member var.
Review URL: http://codereview.chromium.org/62074
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13192 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/62075
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13189 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
OnContentsChanged on the controller.
BUG=None
TEST=
1) Navigate to google.com, copy the contents of the OmniBox (the URL) and paste it back into the OmniBox. The dropdown should appear.
2) Navigate to google.com, copy the word Privacy into the clipboard. Open the Find box, Paste into the Find bar. It should search. Close the Find bar. Reopen the Find bar. Paste again. It should search.
Review URL: http://codereview.chromium.org/63014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13187 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/62072
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13185 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
(Clicking it a second time won't remove the bookmark; need to write the
infobubble next...)
Review URL: http://codereview.chromium.org/63020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13182 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
data) types from WebKit API are allowed to be used in the browser process.
I added a big note about this to webkit_param_traits.h to explain the details
of this decision.
R=dglazkov
Review URL: http://codereview.chromium.org/62032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13181 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
version in tab_strip_model.h. This fixes a bug where we didn't receive tab change messages from the model.
Review URL: http://codereview.chromium.org/63021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13178 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
from m0.
BUG-9393
TEST=see bug
Review URL: http://codereview.chromium.org/62067
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13177 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
text rendering is fixed.
TBR=deanm
Review URL: http://codereview.chromium.org/62066
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13175 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13174 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/60110
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13168 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
check is disabled from the options menu.
Issue=8589
Review URL: http://codereview.chromium.org/60097
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13162 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Skia doesn't current support any form of text layout (ellipsizing, etc). We
use Pango / Cairo to draw our text on the surface. Also moved the non-flags
version of DrawStringInt into the share chrome_canvas.cc. Stubbed out the
SizeStringInt(), I haven't seen it used on Linux, and it would be wrong.
Review URL: http://codereview.chromium.org/62053
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13159 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
handling classes (currently mixed).
All the messages except for the DebuggerCommand should go be dispatched on the Renderer thread by the DevToolsAgent.
DebuggerCommand should be handled by the DevToolsAgentFilter separately (for v8 suspend support).
Review URL: http://codereview.chromium.org/62037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13153 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
The include guards should now match the file paths.
Review URL: http://codereview.chromium.org/62051
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13152 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/62049
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13151 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
(Shouldn't muck with where other platforms put their output.
Review URL: http://codereview.chromium.org/63008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13149 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This crash occurs under the following conditions:
1. Launch Chrome and navigate to any web page
2. Save that page (via ctrl+s or menu option)
3. Click cancel in the Save As dialog box that appears
4. Save the page again
This fix checks to see if the SavePackage was initialized when
handling a stop operation, and skips it if nothing has started.
BUG=9738 (http://crbug.com/9738)
Review URL: http://codereview.chromium.org/62048
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13148 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/63006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13146 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/63004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13145 0039d316-1c4b-4281-b951-d872f2087c98
|