summaryrefslogtreecommitdiffstats
path: root/chrome
Commit message (Collapse)AuthorAgeFilesLines
* Moves some utility functions out of bookmark model intosky@google.com2008-12-0910-175/+185
| | | | | | | | | | | | bookmark_utils. In addition I've converted to using TreeNodeIterator. This doesn't contain any functionality changes. BUG=4065 TEST=none Review URL: http://codereview.chromium.org/13642 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6589 0039d316-1c4b-4281-b951-d872f2087c98
* Attempt 2 at landing tree node iterator. I needed an includesky@google.com2008-12-096-1/+130
| | | | | | | | in tree_node_model. Review URL: http://codereview.chromium.org/13274 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6588 0039d316-1c4b-4281-b951-d872f2087c98
* I tried running the browser in Purify and the browser crashed on me. finnur@google.com2008-12-091-8/+11
| | | | | | | | | | | | | | | | | | | | Basically, the animations were really slow and at one point I got a NULL pointer read because TabContents was NULL while updating the animations. Call stack: TabContents::is_loading(void)const [browser\tab_contents.h:214] Browser::IsCurrentPageLoading(void)const [browser\browser.cc:400] BrowserView::LoadingAnimationCallback(void) [browser\views\frame\browser_view.cc:1325] ... removed Timer calls for clarity... We already check the return value of GetSelectedTabContents in many places. It makes sense to do it here also, I think. Review URL: http://codereview.chromium.org/13647 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6587 0039d316-1c4b-4281-b951-d872f2087c98
* Make the spellcheck-context-menu generation code more robust/future-proof ↵jungshik@google.com2008-12-091-10/+17
| | | | | | | | | | | | | | | | | | (fil and fil-PH will match each other). Currently, en-AU, de-CH, fr-CA do not match any spellcheck language. With this change, they will match en-US, de-DE, fr-FR, respectively unless there's an exact (more specific) match. Matching en-{AU,NZ,ZA} with en-US is not ideal. BUG=5251 TEST=Add 'fr-CA' (but NOT fr or fr-FR) to the accept-language list and see if 'fr-FR' comes up in the list of spell-check languages in the context menu of a textarea. Add 'de' (but not de-DE) to a-l list and see if 'de-DE' comes up in the list of spell-check languages in the context menu. Review URL: http://codereview.chromium.org/13262 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6562 0039d316-1c4b-4281-b951-d872f2087c98
* Specify the dependency on using_wtl.vsprops using a path relative to chrome ↵ananta@chromium.org2008-12-091-1/+1
| | | | | | | | to ensure that the automation vcproj loads correctly in other solutions like chrome tab. Review URL: http://codereview.chromium.org/13643 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6558 0039d316-1c4b-4281-b951-d872f2087c98
* Backs out tree node iterator until I figure out why release build doesn'tsky@google.com2008-12-085-128/+0
| | | | | | | | | | like me. BUG=none TEST=none Review URL: http://codereview.chromium.org/13267 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6554 0039d316-1c4b-4281-b951-d872f2087c98
* Adds an iterator over tree nodes.sky@google.com2008-12-085-0/+128
| | | | | | | | | BUG=4065 TEST=none Review URL: http://codereview.chromium.org/13264 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6552 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup part 3.pkasting@chromium.org2008-12-082-161/+160
| | | | | | | | | | | This changes only whitespace, no code change at all. Attempt to make a couple of long multi-column chunks of text more readable by putting everything within the block at the same offsets. In the case of the .rc file, the entire file is now consistently indented. No lines I'm touching go over 80 columns. What I'm doing to browser.cc here we already do in a few (shorter) cases elsewhere, I think to good effect. Review URL: http://codereview.chromium.org/13641 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6551 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup part 2.pkasting@chromium.org2008-12-081-30/+20
| | | | | | | | | Add appcommands that we have browser commands for. BUG=1113069 Review URL: http://codereview.chromium.org/13639 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6549 0039d316-1c4b-4281-b951-d872f2087c98
* The CHECK I added in r6458 fails. So I'm refining thatwtc@google.com2008-12-081-2/+4
| | | | | | | | | | CHECK to narrow down where it starts to fail. R=eroman BUG=4749 Review URL: http://codereview.chromium.org/13634 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6545 0039d316-1c4b-4281-b951-d872f2087c98
* Fix 1955: Show Chromium build number after version (Chromium only)finnur@google.com2008-12-081-0/+5
| | | | | | | | | | | | People download random builds of Chromium off our server. This makes it easier for them to figure out what build number they are using by showing it in the About box (in parenthesis right after the version number). This change does not change the way we display versions in Google Chrome. Review URL: http://codereview.chromium.org/13194 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6536 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup, part 1.pkasting@chromium.org2008-12-0825-307/+305
| | | | | | | | | | | | | | * Consistently use underscores between words in identifiers (IDC_NEWTAB -> IDC_NEW_TAB) * Make some identifiers clearer or more up-to-date (IDC_DUPLICATE -> IDC_DUPLICATE_TAB, IDC_GOOFFTHERECORD -> IDC_NEW_INCOGNITO_WINDOW, IDC_NEWPROFILEWINDOW -> IDC_PROFILE_MENU) * Try and make string identifiers (IDS_xxx) match their corresponding IDC_xxx commands. Tony tells me this will not cause any need for retranslation. * As much as possible (without modifying automated UI test XML files), use "Bookmark Bar", not "Bookmarks Bar" (this seemed to be prevailing usage in the code) * Fix 80-column issues This patch touches move files than any subsequent patches, but should be the most rubber-stampable. Review URL: http://codereview.chromium.org/13633 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6535 0039d316-1c4b-4281-b951-d872f2087c98
* More addions to the installer html dialog classcpu@google.com2008-12-083-11/+106
| | | | | | | | | | | | - EulaDialog subclass - Wired the output parameter BUG=1468838 Review URL: http://codereview.chromium.org/13601 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6533 0039d316-1c4b-4281-b951-d872f2087c98
* Fixing 5132: Find-in-page reports wrong ordinal when restarting search in ↵finnur@google.com2008-12-081-0/+30
| | | | | | | | | | | | sub-frame ReportFindInPageSelection calls OrdinalOfFirstMatchForFrame internally, so we don't need to do it again at the call site. Added a test to catch this in the future. Review URL: http://codereview.chromium.org/13190 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6532 0039d316-1c4b-4281-b951-d872f2087c98
* bad merge, no need to delete a scoped_ptrtc@google.com2008-12-081-1/+0
| | | | | | | | | TBR=aa Review URL: http://codereview.chromium.org/13252 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6528 0039d316-1c4b-4281-b951-d872f2087c98
* make icon 512x512 resolution. gosh it's pretty.pinkerton@google.com2008-12-081-0/+0
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6527 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes bug during tab close that results in all tabs after closed tabsky@google.com2008-12-081-1/+4
| | | | | | | | | | | | | | | | | | | | | | | | | getting shifted to the left by one pixel. Forcing another layout (by resizing window or such) results in everything fixing itself. When closing a tab we resize the closed tabs width to Tab::GetMinimumUnselectedSize().width(). Subsequent tabs are positioned at width + kTabHOffset. Tab::GetMinimumUnselectedSize().width() is 15, where as kTabHOffset is -16, resulting in all subsequent tabs shifting to the left by 1. You'll have to tell me if this is the right fix. I suspect this could also be fixed by changing Tab::GetMinimumUnselectedSize().width() to be kTabHOffset, but I'm not sure what the effects of that are. We could also enforce next x not shifting back in AnimationLayout BUG=none TEST=create two tabs, select the first and close it. Resize the window a bit and make sure the tab doesn't shift to the right. Review URL: http://codereview.chromium.org/13625 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6525 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a leak in ExtensionsService and another in ExtensionsServiceTest.aa@chromium.org2008-12-082-6/+9
| | | | | | Review URL: http://codereview.chromium.org/13610 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6524 0039d316-1c4b-4281-b951-d872f2087c98
* Fix two minor issues with ExtensionsService test data:aa@chromium.org2008-12-082-0/+2
| | | | | | | | | | | | | * I forgot to add the invalid manifest file in the original checkin. * Git cannot track empty directories, so the no_manifest directory was not showing up in git checkouts. So I added an empty file there. The tests were passing because the error message for invalid and missing manifests are the same. Review URL: http://codereview.chromium.org/11015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6523 0039d316-1c4b-4281-b951-d872f2087c98
* Report errors during extension load. Change all the error strings to utf-8.aa@chromium.org2008-12-086-52/+60
| | | | | | Review URL: http://codereview.chromium.org/13229 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6522 0039d316-1c4b-4281-b951-d872f2087c98
* First cut at POSIX Implementation of IPC Channel using FIFOs.jeremy@chromium.org2008-12-082-18/+518
| | | | | | | | | | The following work still remains: * Provide better encapsulation of libevent. * Use socketpair and use named FIFO code only when debugging. Review URL: http://codereview.chromium.org/12927 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6520 0039d316-1c4b-4281-b951-d872f2087c98
* * Return error in case non admin user tries system level install.kuchhal@chromium.org2008-12-086-8/+33
| | | | | | | | | BUG=5117,4973 TBR=huanr Review URL: http://codereview.chromium.org/13200 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6514 0039d316-1c4b-4281-b951-d872f2087c98
* Platform cleanup in common/deanm@chromium.org2008-12-085-20/+29
| | | | | | | Review URL: http://codereview.chromium.org/10988 Patch from Pawel Hajdan Jr. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6506 0039d316-1c4b-4281-b951-d872f2087c98
* Reupload of 12418glen@chromium.org2008-12-0733-229/+1850
| | | | | | Review URL: http://codereview.chromium.org/13183 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6497 0039d316-1c4b-4281-b951-d872f2087c98
* Capitalize the 'Extensions' folder in the visual studio project for consistency.aa@chromium.org2008-12-071-1/+1
| | | | | | Review URL: http://codereview.chromium.org/13613 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6496 0039d316-1c4b-4281-b951-d872f2087c98
* Third time's a charm?dkegel@google.com2008-12-076-293/+89
| | | | | | | | | | | | | | | | | | | | | | | | | | | Fix part of http://code.google.com/p/chromium/issues/detail?id=4510 and improve https support in test shell on linux. This is the same as the earlier ssl cert cl (see http://codereview.chromium.org/11249), but with the certs moved so net can use them without reaching over into chrome's pants and causing test failure on the 'modules' Windows build server, which is set up to test net and base but not chrome. For this to pass, we will need to install the certs on the windows module and try servers. (And make sure tlslite is present.) (A later CL will finish implementing SSLInfo for Linux, and probably reference net/base/ssl_test_util.cc from all three vcproj files that need it, even though that's ugly, because that's less ugly that referencing it from net.lib's vcproj.) Review URL: http://codereview.chromium.org/12930 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6495 0039d316-1c4b-4281-b951-d872f2087c98
* Makes the tab restore service persist closed tabs/windows to disk andsky@google.com2008-12-0642-1213/+2192
| | | | | | | | | | | | | | | | | reload them when asked. Sorry for largish looking change. It's made big by refactoring common code between TabRestoreService and SessionService into a common superclass. At the same time I removed some dead code and shuffled the session related classes into a single directory for easier perusal. BUG=384 TEST=close the browser, start the browser and make sure the new tab page shows closed windows/tabs from the previous session. Review URL: http://codereview.chromium.org/13152 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6490 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes possible flicker when tab finishes animating back to draggedsky@google.com2008-12-061-1/+5
| | | | | | | | | | | position. BUG=NONE TEST=none Review URL: http://codereview.chromium.org/13221 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6489 0039d316-1c4b-4281-b951-d872f2087c98
* Remove an unused string (IDS_PAGE_MENU_REPORT_PHISHING_WEBSITE_URL)jungshik@google.com2008-12-0551-52/+1
| | | | | | | bug=4457 Review URL: http://codereview.chromium.org/13207 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6462 0039d316-1c4b-4281-b951-d872f2087c98
* * Prevent early exit due to && operator.kuchhal@chromium.org2008-12-051-12/+14
| | | | | | | | BUG=5104 Review URL: http://codereview.chromium.org/13179 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6461 0039d316-1c4b-4281-b951-d872f2087c98
* Fixing build bustage. Adding files which were part of the original changeananta@chromium.org2008-12-055-0/+14
| | | | | | | | | | branch r6396, which was reverted partially. TBR=jam Review URL: http://codereview.chromium.org/13215 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6460 0039d316-1c4b-4281-b951-d872f2087c98
* Add error messages to JSONReader and friends. This required a bit of ↵aa@chromium.org2008-12-0514-32/+42
| | | | | | | | refactoring to do cleanly. This CL doesn't actually use this capability anywhere except for unit tests. I will add that in a future CL. Review URL: http://codereview.chromium.org/13169 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6459 0039d316-1c4b-4281-b951-d872f2087c98
* Add a CHECK to assert that each invocation ofwtc@google.com2008-12-051-0/+5
| | | | | | | | | | | ResourceDispatcherHost::RemovePendingRequest removes exactly one URLRequest from pending_requests_. R=eroman BUG=4749 Review URL: http://codereview.chromium.org/12977 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6458 0039d316-1c4b-4281-b951-d872f2087c98
* Add using_wtl.scons to the chrome\test\automation SCons configuration,sgk@google.com2008-12-051-0/+1
| | | | | | | paralleling addition of using_wtl.vsprops to the VS configuration. Review URL: http://codereview.chromium.org/13401 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6456 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a race condition in the SyncChannel code.jam@chromium.org2008-12-052-61/+37
| | | | | | | | | | | The problem is that QueueMessage would be called with listener() on the IPC thread, and then the function would wait on message_lock_ before adding the message and its associated listener. However, in between the time that listener() was called and the lock was taken control of, the listener thread may be calling RemoveListener. The fix is to not send the listener, but instead just send a pointer to the context. It'll be used on the listener thread, at which point listener() can be called to check if the listener is available. BUG=1305036 Review URL: http://codereview.chromium.org/12952 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6448 0039d316-1c4b-4281-b951-d872f2087c98
* fix chrome_paths to make some test dirs relative to base::DIR_SOURCE_ROOTerikkay@google.com2008-12-054-21/+30
| | | | | | | | | | | | | | rather than chrome::DIR_APP. DIR_APP is in different relative locations on different platforms while DIR_SOURCE_ROOT is the same, so this allows us to share code and be correct on all platforms. Also, enable extensions_service_unittest for Mac and Linux and add an NSAutoreleasePool to ChromeTestSuite (which is now being used by run_all_unittests on Mac and Linux per my earlier checkin). Review URL: http://codereview.chromium.org/13177 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6445 0039d316-1c4b-4281-b951-d872f2087c98
* UserData Options tabmunjal@chromium.org2008-12-053-3/+44
| | | | | | | | | Plumbing for User Data tab in Options dialog. Review URL: http://codereview.chromium.org/13150 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6442 0039d316-1c4b-4281-b951-d872f2087c98
* Change "client" parameter in RLZ ping to "referral" gwilson@google.com2008-12-055-11/+11
| | | | | | | | | | to match Omaha's changes. BUG=1520348 Review URL: http://codereview.chromium.org/12975 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6440 0039d316-1c4b-4281-b951-d872f2087c98
* Change the accelerator key for Javascript debug to Ctrl-Shift-D from 'Alt-`'jungshik@google.com2008-12-051-1/+2
| | | | | | | | | BUG=3696,5087 TEST=Install non-en-US keyboard and switch keyboards to one of them (e.g. German, French, Russian) and make sure that shortcut keys for Javascript debug remains 'Ctrl-Shift-L'. Review URL: http://codereview.chromium.org/10652 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6438 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the layout of the Spell Check Options part, in the languages tab, in the ↵sidchat@google.com2008-12-051-18/+20
| | | | | | | | | Fonts and Languages Options Menu, to match with the Mock. Issue=4401 Review URL: http://codereview.chromium.org/12957 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6437 0039d316-1c4b-4281-b951-d872f2087c98
* Fixed a bogus initialization of string constants. The stack allocated ↵erikkay@google.com2008-12-051-12/+6
| | | | | | | | | | | string from StringPrintf gets destroyed right away, and c_str is just a pointer to its internal buffer, so the error constant was bogus memory. This showed up in the purify tests. Sorry I missed this in the initial code review. Review URL: http://codereview.chromium.org/13204 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6436 0039d316-1c4b-4281-b951-d872f2087c98
* move a few #ifdefs around so that unit_tests does proper path initialization ↵erikkay@google.com2008-12-052-9/+8
| | | | | | | | | | for Mac and Linux. This allows use of things like DIR_TEST_DATA. StatsTable also comes along for the ride. Review URL: http://codereview.chromium.org/13153 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6432 0039d316-1c4b-4281-b951-d872f2087c98
* bootstrap app target for browser/renderer.pinkerton@google.com2008-12-055-0/+2736
| | | | | | Review URL: http://codereview.chromium.org/13202 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6430 0039d316-1c4b-4281-b951-d872f2087c98
* We should let binary/octet-stream have an EXE extension to fix compat with ↵abarth@chromium.org2008-12-052-0/+9
| | | | | | | | | | | digsby.com and ohloh.net BUG=1573 R=darin Review URL: http://codereview.chromium.org/13165 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6424 0039d316-1c4b-4281-b951-d872f2087c98
* Clean up junk in content sniffing mock-http-headers.abarth@chromium.org2008-12-056-12/+1
| | | | | | | | R=deanm Review URL: http://codereview.chromium.org/13166 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6423 0039d316-1c4b-4281-b951-d872f2087c98
* Disable the content sniffing algorithm if the server instructs us to do so ↵abarth@chromium.org2008-12-054-1/+18
| | | | | | | | | | | | with the nosniff directive. For context, see http://blogs.msdn.com/ie/archive/2008/09/02/ie8-security-part-vi-beta-2-update.aspx R=deanm,darin Review URL: http://codereview.chromium.org/12982 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6422 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a crash on 64-bit systems when an external message hook is installed. Thebrettw@google.com2008-12-051-1/+3
| | | | | | | | | | proxying for CB_GETCOMBOXINFO is wrong and will crash. Instead, call GetComboBoxInfo. BUG=49 Review URL: http://codereview.chromium.org/13156 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6420 0039d316-1c4b-4281-b951-d872f2087c98
* update chrome stringstc@google.com2008-12-0583-737/+2425
| | | | | | | | | | | This fixes a the Hebrew translation missing a bunch of strings. TBR=mal Review URL: http://codereview.chromium.org/12976 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6417 0039d316-1c4b-4281-b951-d872f2087c98
* Add new multiprofile files to the SCons build:sgk@google.com2008-12-052-0/+3
| | | | | | | | | chrome\browser\user_data_manager.cc chrome\browser\view\new_profile_dialog.cc chrome\browser\view\select_profile_dialog.cc Review URL: http://codereview.chromium.org/12948 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6410 0039d316-1c4b-4281-b951-d872f2087c98
* Add new debugger_host_impl.cpp to the SCons build.sgk@google.com2008-12-051-0/+1
| | | | | | Review URL: http://codereview.chromium.org/12947 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6408 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-08 01:34:52 +0000