summaryrefslogtreecommitdiffstats
path: root/chrome
Commit message (Collapse)AuthorAgeFilesLines
* Omnibox metrics logging patch splitout, part 5: Add additional ↵pkasting@chromium.org2008-11-1310-47/+58
| | | | | | | | | AutocompleteMatch types, and pass a type to the AutocompleteMatch constructor. The added detail in the new types is not used for anything functional; its sole purpose is for metric logging. Someday we could probably update other bits of the code to make use of this, though (e.g. the paste-and-search vs. paste-and-go determinant code). These are separable changes, but doing either one without the other would have required an annoying number of fragile temporary changes. Review URL: http://codereview.chromium.org/10855 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5329 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the 0x0 canvas used for computing text sizes. Creating this is not ↵brettw@google.com2008-11-133-92/+90
| | | | | | | | | necessary since the text can be sized using the desktop DC, which should be faster. I made this function static, and moved the functions it used into file-local functions since they didn't depend on the class either. This is trying to fix bug 49. This code is very close to the crash, and a 0x0 canvas seems like it might cause problems. However, it is unclear whether this will have any effect (other than performance). Review URL: http://codereview.chromium.org/10409 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5328 0039d316-1c4b-4281-b951-d872f2087c98
* Allow chromium to be built with some system libs by introducingevanm@google.com2008-11-122-3/+6
| | | | | | | | | | | | | | a variable called SYSTEM_LIBS, consisting of a comma-separated list of system libraries. So far, bzip2, libpng, libjpeg, libxml, libxslt, lzma_sdk, zlib, hunspell, sqlite, libevent are recognized. BUG=4321 Review URL: http://codereview.chromium.org/10626 Patch from Fabien Tassin <fta@sofaraway.org>. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5320 0039d316-1c4b-4281-b951-d872f2087c98
* Make unit_tests pass with pt_BR.UTF-8 locale.tc@google.com2008-11-125-0/+663
| | | | | | | | | | | BUG=3675 Patch from Paweł Hajdan jr <phajdan.jr@gmail.com> original issue: http://codereview.chromium.org/9509 Review URL: http://codereview.chromium.org/11002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5319 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes text field background when disabled/read-only to better matchsky@google.com2008-11-122-23/+44
| | | | | | | | | | | | | | | how Windows looks. This also changes SetEnabled not to adjust read_only_ state. That SetEnabled invoked SetReadOnly is just wrong, the two don't have to be the same. BUG=1218491 TEST=bring up the keyword editor and double click on one of the default search engines, make sure the background of the text field looks disabled. Review URL: http://codereview.chromium.org/10662 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5317 0039d316-1c4b-4281-b951-d872f2087c98
* * Try to rename chrome exes in shutdown path as well.kuchhal@chromium.org2008-11-124-21/+37
| | | | | | | | BUG=1463346 Review URL: http://codereview.chromium.org/10805 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5313 0039d316-1c4b-4281-b951-d872f2087c98
* New functions in WebDatabase and WebDataService for the removal of form ↵petersont@google.com2008-11-125-8/+172
| | | | | | | | | | entries made between two given times. BrowserDataRemover::Remove now clears autofill data. BUG=3870 Review URL: http://codereview.chromium.org/9775 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5312 0039d316-1c4b-4281-b951-d872f2087c98
* Fix http://code.google.com/p/chromium/issues/detail?id=4270. Test case added.mpcomplete@google.com2008-11-123-1/+63
| | | | | | | | BUG=4270 Review URL: http://codereview.chromium.org/10620 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5310 0039d316-1c4b-4281-b951-d872f2087c98
* Omnibox metrics logging patch splitout, part 5: Add TypeToString() helpers. ↵pkasting@chromium.org2008-11-123-16/+37
| | | | | | | | One of these is unused for the moment. Review URL: http://codereview.chromium.org/10657 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5307 0039d316-1c4b-4281-b951-d872f2087c98
* Adds the ability for save dialogs to take a default extension.sky@google.com2008-11-1210-36/+56
| | | | | | | | | BUG=4287 TEST=see bug Review URL: http://codereview.chromium.org/10621 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5304 0039d316-1c4b-4281-b951-d872f2087c98
* Fix infobubble crash due to first run bubble having slightly different ↵ben@chromium.org2008-11-122-9/+4
| | | | | | | | | initialization path than the bookmarks bubble. http://crbug.com/4344 Review URL: http://codereview.chromium.org/10849 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5301 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes bug in showing context menu for buttons. In particular becausesky@google.com2008-11-124-15/+25
| | | | | | | | | | | | we weren't resetting state before showing the context menu it was possible for the button to stay in a HOT state even though it isn't. BUG=2620 TEST=see bug Review URL: http://codereview.chromium.org/10835 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5300 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes two menu bugs:sky@google.com2008-11-121-1/+20
| | | | | | | | | | | | | | | | | | | . Pressing shift-F10 would make context menu appear then immediately disappear. This is because MenuController was hiding on a WM_SYSKEYUP. I've changed MenuController to do nothing on WM_SYSKEYUP. If a sys key is pressed again, we'll get a WM_SYSKEYDOWN and hide there. . MenuController needed to handle WM_CONTEXTMENU and not dispatch it, otheriwse we could end up with stacked menus. BUG=3685 TEST=bring up bookmark manager, select a row in the table on the right. Press shift-F10 and make sure the context menu appears and stays up. Review URL: http://codereview.chromium.org/10635 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5299 0039d316-1c4b-4281-b951-d872f2087c98
* Uncomment out these two lines I commented out a few weeks ago so that the ↵ben@chromium.org2008-11-121-4/+0
| | | | | | | | | trunk is usable again. TBR=sky Review URL: http://codereview.chromium.org/10655 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5294 0039d316-1c4b-4281-b951-d872f2087c98
* Break out command execution from ExecuteCommand implementation into separate ↵ben@chromium.org2008-11-122-514/+519
| | | | | | | | functions. Review URL: http://codereview.chromium.org/10823 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5289 0039d316-1c4b-4281-b951-d872f2087c98
* * fix linux buildtc@google.com2008-11-122-2/+2
| | | | | | | | | renamed libv8.a to libv8_g.a Review URL: http://codereview.chromium.org/10845 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5287 0039d316-1c4b-4281-b951-d872f2087c98
* If setProcessBackgrounded fails, don't continue throughmbelshe@google.com2008-11-121-1/+4
| | | | | | | | | | this function. This is defensive coding being added in part to see if it doesn't reveal anything interesting for bug 1231568 Review URL: http://codereview.chromium.org/11003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5286 0039d316-1c4b-4281-b951-d872f2087c98
* Omnibox metrics logging patch splitout, part 4: Reorder fields of ↵pkasting@chromium.org2008-11-121-39/+39
| | | | | | | | | AutocompleteMatchData to correspond to the order in AutocompleteMatch. I am unconvinced this struct is useful or necessary. It seems like we should simply serialize AutocompleteMatch if that's what we want; this is already doing most of that. But whatever. Review URL: http://codereview.chromium.org/10841 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5282 0039d316-1c4b-4281-b951-d872f2087c98
* * Need to read version from registry if relaunching browser.kuchhal@chromium.org2008-11-124-4/+8
| | | | | | | | BUG=4316 Review URL: http://codereview.chromium.org/10820 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5281 0039d316-1c4b-4281-b951-d872f2087c98
* Omnibox metrics logging patch splitout, part 3: Pass match.type to the edit ↵pkasting@chromium.org2008-11-123-17/+13
| | | | | | | | | and let it make the determination about showing the search hint, instead of making the determination in the popup. In the ultimate patch, the types on which we'll show the hint will expand, so this saved duplicating some logic at points in the popup; in retrospect it makes more sense anyway, since there's no reason for the popup to know anything about the search hint. That's more the edit's job anyway. Review URL: http://codereview.chromium.org/10839 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5276 0039d316-1c4b-4281-b951-d872f2087c98
* Omnibox metrics logging patch splitout, part 2: Remove the AutocompleteMatch ↵pkasting@chromium.org2008-11-124-44/+23
| | | | | | | | | NULL constructor. It's too easy to forget to set various members with this. The changes from .resize() to .erase() are necessary because the compiler doesn't know resize() won't be enlarging the vector and thus needing to access the NULL constructor. The changes to the HistoryContents shortcut code were similarly necessary to avoid a NULL construction, but in the end I think made the resulting code a bit clearer. Review URL: http://codereview.chromium.org/10837 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5271 0039d316-1c4b-4281-b951-d872f2087c98
* Use the systemwide google_update pipe when registering for crash servicescpu@google.com2008-11-121-4/+15
| | | | | | | | | | | if chrome is a systemwide install. BUG = 1479718 Review URL: http://codereview.chromium.org/10629 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5268 0039d316-1c4b-4281-b951-d872f2087c98
* Omnibox metrics logging patch splitout, part 1: Random miscellaneous small ↵pkasting@chromium.org2008-11-125-86/+70
| | | | | | | | style and similar changes. In one or two cases the motivation is not obvious without looking at the original patch. Review URL: http://codereview.chromium.org/10822 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5261 0039d316-1c4b-4281-b951-d872f2087c98
* Makes sure ResourceDispatcherHost properly cleans up a cancelledsky@google.com2008-11-121-1/+10
| | | | | | | | | | | | | | | | | | | request that is not in a pending state. When we cancel a URLRequest with no pending IO, nothing happens. This means ResourceDispatcherHost doesn't clean up its maps and delete the URLRequest. Another possibility for fixing this is to invoke OnResponseCompleted, but as the request isn't really completed that may cause other bad things. Let me know if you think this should be fixed in another way. BUG=4302 TEST=see bug Review URL: http://codereview.chromium.org/10814 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5252 0039d316-1c4b-4281-b951-d872f2087c98
* Reorder browser.cc to match style guide, and remove browser_commands.ccben@chromium.org2008-11-124-1705/+1700
| | | | | | Review URL: http://codereview.chromium.org/10623 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5246 0039d316-1c4b-4281-b951-d872f2087c98
* Prevent crash due to DIB allocation failure joshia@google.com2008-11-123-11/+23
| | | | | | | | | | | | | Change the way we capture tab thumbnail images so that the capturing code can deal with failure. BUG=3795 Review URL: http://codereview.chromium.org/9717 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5244 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a race condition in SyncChannel that would happen if a nested Send ↵jam@chromium.org2008-11-122-97/+101
| | | | | | | | | occurred in between the time that SetEvent was called on the current Send's done_event and when OnObjectSignalled was called. The pending signal would be cancelled and since the event was already reset, when we watched it again later OnObjectSignalled would never be called. The fix is to make it a manual reset event. BUG=1474092 Review URL: http://codereview.chromium.org/10817 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5238 0039d316-1c4b-4281-b951-d872f2087c98
* Reorder functions in browser.hben@chromium.org2008-11-127-295/+236
| | | | | | | | | | | | | Also remove unnecessary functions: - Browser::MoveToFront - Browser::WindowActivationChanged - Browser::ExecuteWindowsAppCommand Also rename function: - Browser::ShowNativeUI -> Browser::ShowNativeUITab Review URL: http://codereview.chromium.org/10617 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5236 0039d316-1c4b-4281-b951-d872f2087c98
* Fix history_indexer.idl to stop from rebuilding it every time.maruel@chromium.org2008-11-121-0/+12
| | | | | | Review URL: http://codereview.chromium.org/10816 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5235 0039d316-1c4b-4281-b951-d872f2087c98
* Force the line endings on .sln files to be CRLF.tc@google.com2008-11-122-5678/+5678
| | | | | | | TBR=pamg Review URL: http://codereview.chromium.org/10619 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5234 0039d316-1c4b-4281-b951-d872f2087c98
* Changes TableView to have its own mouse handling code so that we cansky@google.com2008-11-125-8/+158
| | | | | | | | | | | start a drag when user clicks anywhere on a row. BUG=4306 TEST=thoroughly test drag and drop of bookmark manager table. Review URL: http://codereview.chromium.org/9776 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5233 0039d316-1c4b-4281-b951-d872f2087c98
* oopsben@chromium.org2008-11-111-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5222 0039d316-1c4b-4281-b951-d872f2087c98
* oopsben@chromium.org2008-11-111-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5221 0039d316-1c4b-4281-b951-d872f2087c98
* Remove some Windows-specific stuff from RenderProcessHost by having callers ↵brettw@google.com2008-11-1112-28/+21
| | | | | | | | get the process handle and PID directly from the corresponding Process object. Review URL: http://codereview.chromium.org/10608 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5219 0039d316-1c4b-4281-b951-d872f2087c98
* Remove ShowAndFit variation of Browser::Show, since the "varation" doesn't ↵ben@chromium.org2008-11-113-7/+5
| | | | | | | | seem to actually work. Review URL: http://codereview.chromium.org/10807 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5214 0039d316-1c4b-4281-b951-d872f2087c98
* Style fixes to BlockedPopupContainer before I submiterg@google.com2008-11-112-20/+26
| | | | | | | | it for my readability review. Review URL: http://codereview.chromium.org/10606 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5212 0039d316-1c4b-4281-b951-d872f2087c98
* Move the hang monitor to the BrowserView, since it's highly Windows/HWND ↵ben@chromium.org2008-11-115-60/+66
| | | | | | | | | | specific. http://crbug.com/4310 Review URL: http://codereview.chromium.org/10601 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5211 0039d316-1c4b-4281-b951-d872f2087c98
* Accept the changes in the UI Language in Options ... -> Language Menu only ↵sidchat@google.com2008-11-112-4/+18
| | | | | | | | | if "OK" button is clicked - otherwise, discard the changes. Issue=2835 Review URL: http://codereview.chromium.org/9777 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5210 0039d316-1c4b-4281-b951-d872f2087c98
* More cleanup in Browser:ben@chromium.org2008-11-1111-121/+36
| | | | | | | | | | - remove "RunSimpleFrameMenu" method that isn't used anymore. - rename Browser::GetType() to Browser::type() Review URL: http://codereview.chromium.org/10605 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5209 0039d316-1c4b-4281-b951-d872f2087c98
* Handle the possibility of failure when starting apaulg@google.com2008-11-116-26/+10
| | | | | | | | | | SafeBrowsing update transaction. If we fail to start the transaction, we report the error to the protocol manager which aborts the update process. Review URL: http://codereview.chromium.org/9778 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5207 0039d316-1c4b-4281-b951-d872f2087c98
* Only block alert() requests from blocked popups; not all popups.erg@google.com2008-11-1110-89/+198
| | | | | | | | | Add two unit tests to make sure we do the right thing; required adding a bunch of stuff to the automation layer. Review URL: http://codereview.chromium.org/10282 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5198 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a crash when dismissing an infobubble... could not locate Window*ben@chromium.org2008-11-112-6/+9
| | | | | | Review URL: http://codereview.chromium.org/10405 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5196 0039d316-1c4b-4281-b951-d872f2087c98
* * Revert "Por rt flush_cache tool."agl@chromium.org2008-11-115-29/+55
| | | | | | | | | This reverts commit 3bd600b37c5ee613c004c84736ee3cb69434562a. Review URL: http://codereview.chromium.org/9774 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5184 0039d316-1c4b-4281-b951-d872f2087c98
* Port flush_cache tool.agl@chromium.org2008-11-115-55/+29
| | | | | | | | | | BUG=4160 Review URL: http://codereview.chromium.org/9639 Patch from Paweł Hajdan jr. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5182 0039d316-1c4b-4281-b951-d872f2087c98
* These files were missed from my last cleanup CL.beng@google.com2008-11-112-63/+4
| | | | | | | Fix bustage. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5181 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup and rearrange methods on BrowserWindow interface.beng@google.com2008-11-1111-165/+50
| | | | | | Review URL: http://codereview.chromium.org/10291 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5180 0039d316-1c4b-4281-b951-d872f2087c98
* Ensure that windowed plugins get focus during WM_MOUSEACTIVATE. This fixesananta@chromium.org2008-11-111-18/+20
| | | | | | | | | | | | | | | | | | bug http://code.google.com/p/chromium/issues/detail?id=4273, which shows up when windowed plugins enter modal loops like context menu and keyboard navigation does not work in the menu. We were not converting the coordinates returned by GetCursorPos to client coordinates correctly, which caused us to miss the child window (Plugin) at times. This also fixes bug http://code.google.com/p/chromium/issues/detail?id=937, which was an issue with menu selections in Java menus. This occured because we would force the child window to have focus in every WM_MOUSEACTIVATE message. In this case the Java plugin window, which is a child of the plugin window already has focus. It receives a WM_KILLFOCUS message due to the forced SetFocus in our handler and takes out the menu, thus ignoring the menu selection. Fix for this issue is to handle WM_MOUSEACTIVATE only if a child window of RenderWidgetHostHWND does not have focus. R=amit Bug=4273 Review URL: http://codereview.chromium.org/10004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5178 0039d316-1c4b-4281-b951-d872f2087c98
* make sure we match all the tests and files that linux has running. We were ↵pinkerton@google.com2008-11-112-6/+72
| | | | | | | | never building process_posix, but now the newly added unit tests use it. Review URL: http://codereview.chromium.org/10221 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5175 0039d316-1c4b-4281-b951-d872f2087c98
* NO CODE CHANGE. Just force a build.maruel@chromium.org2008-11-111-4/+3
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5171 0039d316-1c4b-4281-b951-d872f2087c98
* Add support for 256 bit full hashes to the new implementation.paulg@google.com2008-11-1115-615/+1045
| | | | | | | | | This CL replaces the following, which seems to have become inaccessible: http://codereview.chromium.org/9202/ Review URL: http://codereview.chromium.org/10402 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5159 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-01-18 23:49:51 +0000