summaryrefslogtreecommitdiffstats
path: root/chrome
Commit message (Collapse)AuthorAgeFilesLines
* Revert 60368 - Client-side phishing detection: grab snapshot of custom sized ↵noelutz@google.com2010-09-249-231/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | view. Client-side phishing detection needs to be able to take a snapshot of a particular page that has a constant size and aspect ratio (e.g., 1024x768). This CL adds a helper function (safe_browsing::GrabPhishingThumbnail) which re-sizes the view a given size, grabs the snapshot, and then re-sizes the view back to its previous size. Note: this function can be slow since it might re-layout the page twice. This function will only be called if we are very confident that the current page is a phishing site in which case we are OK with taking a slow snapshot. Also, this CL adds a test for the OnMsgPaintAtSize method in the RenderWidget since it does something very similar than the new Thumbnailer. BUG=None TEST=GrabPhishingThumbnail Review URL: http://codereview.chromium.org/3380001 TBR=noelutz@google.com Review URL: http://codereview.chromium.org/3439026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60536 0039d316-1c4b-4281-b951-d872f2087c98
* Added code to launch the browser to show token expired notifications.sanjeevr@chromium.org2010-09-241-0/+32
| | | | | | | | | BUG=None TEST=None Review URL: http://codereview.chromium.org/3435028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60532 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: Ignore omnibox selection changes that come from programmatic eventsisherman@chromium.org2010-09-242-21/+27
| | | | | | | | | BUG=56149,56720 TEST=start typing a url, arrow around in the autocomplete popup menu -- the results should not change. Review URL: http://codereview.chromium.org/3397019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60530 0039d316-1c4b-4281-b951-d872f2087c98
* Change the menu item 'Options' to 'Settings' on the wrench menu.tfarina@chromium.org2010-09-242-7/+18
| | | | | | | | | | | BUG=56152 TEST=out/Debug/chrome --enable-tabbed-options, go to wrench menu, you should see a 'Settings' menu item. Also without the switch you should still see the 'Options' menu item. Review URL: http://codereview.chromium.org/3398026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60529 0039d316-1c4b-4281-b951-d872f2087c98
* Adding ability to log into networks, and view network configs, all from the ↵dhg@chromium.org2010-09-248-32/+658
| | | | | | | | | | | DOM_UI BUG=chromium-os:6241 TEST=connect to networks Review URL: http://codereview.chromium.org/3388006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60528 0039d316-1c4b-4281-b951-d872f2087c98
* Fix flickering when calling push/replaceState (or changing the location hash)mihaip@chromium.org2010-09-243-18/+38
| | | | | | | | | | | in a tight loop by delaying the UI updates when beginning a load by 50 milliseconds (and cancelling altogether if the load finishes before then). BUG=50298 TEST=Links on http://bodytag.org/rollstate/ Review URL: http://codereview.chromium.org/3300013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60527 0039d316-1c4b-4281-b951-d872f2087c98
* Updating trunk VERSION from 534.0 to 535.0chrome-release@google.com2010-09-241-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60521 0039d316-1c4b-4281-b951-d872f2087c98
* Small cleanup - remove 2 unnecessary includes.asargent@chromium.org2010-09-241-2/+0
| | | | | | | | | | | | BUG=None TEST=It compiles TBR=mpcomplete@chromium.org Review URL: http://codereview.chromium.org/3473018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60518 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the problem that BlobDispatcherHost is not hooked up in WorkerProcessHost.jianli@chromium.org2010-09-243-2/+11
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/3472010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60513 0039d316-1c4b-4281-b951-d872f2087c98
* Fixed bug where the "Keep everything synced" preference wasn't being honored.akalin@chromium.org2010-09-241-9/+13
| | | | | | | | | BUG=55026 TEST=Manual Review URL: http://codereview.chromium.org/3433017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60511 0039d316-1c4b-4281-b951-d872f2087c98
* Comment typo fix.avi@chromium.org2010-09-241-1/+1
| | | | | | | | | BUG=none TEST=look at file and not get annoyed Review URL: http://codereview.chromium.org/3391025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60510 0039d316-1c4b-4281-b951-d872f2087c98
* ui_tests: check the return value of WaitForAppLaunch.evan@chromium.org2010-09-241-1/+2
| | | | | | | | | | | | | This function has a return value. We should abort the test if it fails. BUG=45115 TEST=EarlyReturnTest.ToastCrasher, which times out, should go red (I preemptively disabled it) Review URL: http://codereview.chromium.org/3470014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60506 0039d316-1c4b-4281-b951-d872f2087c98
* ui_tests: disable EarlyReturnTest.evan@chromium.org2010-09-241-5/+11
| | | | | | | | | | | | It always times out. It is only passing on the bots because of a bug in the UI test framework that doesn't detect the timeout. BUG=45115 TEST=ui_tests are 30 seconds faster Review URL: http://codereview.chromium.org/3433022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60504 0039d316-1c4b-4281-b951-d872f2087c98
* added /webstore to app.urlserikkay@chromium.org2010-09-241-0/+1
| | | | | | | | | BUG=56795 TEST=verify that /webstore URLs can install apps Review URL: http://codereview.chromium.org/3503004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60498 0039d316-1c4b-4281-b951-d872f2087c98
* linux: zygote should suicide when the browser channel closes.evan@chromium.org2010-09-241-5/+6
| | | | | | | | | | | | | We attempt to do this when recvmsg() returns 0, indicating EOF. But man 7 unix also says we can get ECONNRESET, so accept that too. TEST=run Chrome such that it exits quickly, e.g. ./out/Debug/chrome --try-chrome-again=10001 it should not print any zygote error messages. Review URL: http://codereview.chromium.org/3387017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60486 0039d316-1c4b-4281-b951-d872f2087c98
* Remove use of Skia's safeUnref() in favor of SkSafeUnref(...)vandebo@chromium.org2010-09-242-11/+9
| | | | | | | | | | | safeUnref() technically has undefined behavior on a null pointer. TEST=green bots BUG=none Review URL: http://codereview.chromium.org/3475007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60483 0039d316-1c4b-4281-b951-d872f2087c98
* New instant page tear image from Nicholas.sky@chromium.org2010-09-241-0/+0
| | | | | | | | | | BUG=54833 TEST=none TBR=jcivelli@chromium.org Review URL: http://codereview.chromium.org/3475016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60482 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes bug where showing an auth dialog during instant would triggersky@chromium.org2010-09-249-20/+69
| | | | | | | | | | | the page to be prematurely committed. BUG=56462 TEST=see bug Review URL: http://codereview.chromium.org/3461020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60481 0039d316-1c4b-4281-b951-d872f2087c98
* Change NOTREACHED() to LOG(ERROR) when we cannot initializewtc@chromium.org2010-09-241-2/+2
| | | | | | | | | | | | | the web database. This is not a programming error. This can happen if we run an old version of Chrome with a new version of user data directory. R=sky BUG=none TEST=N/A Review URL: http://codereview.chromium.org/3418028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60480 0039d316-1c4b-4281-b951-d872f2087c98
* Adds support for sending script when the user accepts instantsky@chromium.org2010-09-246-41/+98
| | | | | | | | | | | results. Also tweaks the delegate interface to be a bit more sensical. BUG=54833 TEST=see bug Review URL: http://codereview.chromium.org/3440025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60479 0039d316-1c4b-4281-b951-d872f2087c98
* Visually polish language selector for new user pod.dilmah@chromium.org2010-09-242-31/+60
| | | | | | | | BUG=http://crosbug.com/5749, http://crosbug.com/6568 TEST=Manual Review URL: http://codereview.chromium.org/3473014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60478 0039d316-1c4b-4281-b951-d872f2087c98
* Mark TestDigestAuth FLAKY on all platforms.lzheng@chromium.org2010-09-241-8/+1
| | | | | | | | TEST=none BUG=56670 Review URL: http://codereview.chromium.org/3381023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60477 0039d316-1c4b-4281-b951-d872f2087c98
* Make app panels use popup type. Nuke refocus code and tests.skerner@chromium.org2010-09-243-237/+15
| | | | | | | | | BUG=55943 TEST=Manual. Review URL: http://codereview.chromium.org/3418027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60476 0039d316-1c4b-4281-b951-d872f2087c98
* Adding copy to the filebrowser. Also fixes a crash bug when the user tries ↵dhg@chromium.org2010-09-245-27/+239
| | | | | | | | to access a download that no longer exists. Review URL: http://codereview.chromium.org/2844040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60475 0039d316-1c4b-4281-b951-d872f2087c98
* Reland r60342.dtseng@chromium.org2010-09-242-1/+6
| | | | | | | TBR=dmazzoni. Review URL: http://codereview.chromium.org/3444021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60474 0039d316-1c4b-4281-b951-d872f2087c98
* Remove logging for issue 35198.skerner@chromium.org2010-09-244-35/+7
| | | | | | | | | | | Remove switch --issue35198-logging . BUG=56664 TEST=Install an extension on all platforms. Review URL: http://codereview.chromium.org/3427019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60471 0039d316-1c4b-4281-b951-d872f2087c98
* Add IndexedDB to cookie tree.bauerb@chromium.org2010-09-2426-454/+2502
| | | | | | | | | | | XIB changes: Add another view with IndexedDB details to CookieDetailsView.xib. BUG=56248 TEST=CookiesTreeModelTest.*:CookiesDetailsTest.*:CookiesViewTest.*: Review URL: http://codereview.chromium.org/3429020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60470 0039d316-1c4b-4281-b951-d872f2087c98
* Unify experimental location features under one flag.allanwoj@chromium.org2010-09-244-10/+6
| | | | | | | | | | | Changed the CoreLocation and Win7 Location Api enable flags to the same one as gateway data provider so that all experimental geolocation features can be enabled/disabled at once. BUG=None TEST=Experimental location features work under run time flag --experimental-location-features Review URL: http://codereview.chromium.org/3419021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60468 0039d316-1c4b-4281-b951-d872f2087c98
* Hide "Change proxy settings link" during connection in progress.dilmah@chromium.org2010-09-242-2/+3
| | | | | | | | | | | Replace chrome://options with chrome://settings because it was changed recently. BUG=None TEST=Manual Review URL: http://codereview.chromium.org/3397028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60466 0039d316-1c4b-4281-b951-d872f2087c98
* Update the spinner and mic button images to the latest from UX team.satish@chromium.org2010-09-241-0/+0
| | | | | | | | | BUG=53598 TEST=none Review URL: http://codereview.chromium.org/3444019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60464 0039d316-1c4b-4281-b951-d872f2087c98
* Windows Gateway Data Provider.allanwoj@chromium.org2010-09-247-2/+150
| | | | | | | | | | | Provides the MAC address of any routers connected via Ethernet. Also added in a command line flag to enable it. BUG=None TEST=None Review URL: http://codereview.chromium.org/3368014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60463 0039d316-1c4b-4281-b951-d872f2087c98
* Finally flip safe-browsing to SafeBrowsingStoreFile.shess@chromium.org2010-09-241-6/+0
| | | | | | | | | | | | | With this, everyone will use SafeBrowsingDatabaseNew with SafeBrowsingStoreFile backing. The database file should be smaller and faster. BUG=28647 TEST=Monitor crash server and histograms. Review URL: http://codereview.chromium.org/3473016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60461 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Revert 60457 - Adds IDBFactory::didCompleteEventsForTransaction ↵andreip@chromium.org2010-09-2412-28/+135
| | | | | | | | | | | | | | | plumbing" This reverts commit b1e231ca824b2fb9a96bffc04f26eae336ff6ed5. Also disable the transaction_get.html test, added in this CL. BUG= TEST= Review URL: http://codereview.chromium.org/3466018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60460 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 60457 - Adds IDBFactory::didCompleteEventsForTransaction plumbingphajdan.jr@chromium.org2010-09-2412-135/+28
| | | | | | | | | | | | | | | (depends on https://bugs.webkit.org/show_bug.cgi?id=44700) TEST=IndexedDBBrowserTest.TransactionGetTest This takes over http://codereview.chromium.org/3310022/show Review URL: http://codereview.chromium.org/3394007 TBR=andreip@chromium.org Review URL: http://codereview.chromium.org/3405031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60459 0039d316-1c4b-4281-b951-d872f2087c98
* Clean up the policy and message model of the template generatorgfeher@chromium.org2010-09-242-259/+247
| | | | | | | | | | | | | In the old model each policy had to be in a group, and messages could be inherited from groups to policies. In the new model single policies does not have to be in groups and there is no inheritance of messages across policies/groups. Instead of that, policies have now two captions for different purposes. (Documented in policy_templates.json.) This is a more simple concept. BUG=55722,56512 TEST=covered by policy template generator unit tests Review URL: http://codereview.chromium.org/3454017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60458 0039d316-1c4b-4281-b951-d872f2087c98
* Adds IDBFactory::didCompleteEventsForTransaction plumbingandreip@chromium.org2010-09-2412-28/+135
| | | | | | | | | | | | (depends on https://bugs.webkit.org/show_bug.cgi?id=44700) TEST=IndexedDBBrowserTest.TransactionGetTest This takes over http://codereview.chromium.org/3310022/show Review URL: http://codereview.chromium.org/3394007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60457 0039d316-1c4b-4281-b951-d872f2087c98
* Updating trunk VERSION from 533.0 to 534.0chrome-release@google.com2010-09-241-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60454 0039d316-1c4b-4281-b951-d872f2087c98
* Disable crashy MacDirAccessSandboxTest.SandboxAccessphajdan.jr@chromium.org2010-09-241-1/+2
| | | | | | | | | | | TBR=jeremy BUG=56765 TEST=none Review URL: http://codereview.chromium.org/3396023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60450 0039d316-1c4b-4281-b951-d872f2087c98
* Revert incognito option for external_extensions.json filedpolukhin@chromium.org2010-09-246-43/+16
| | | | | | | | | | | | Original codereviw: http://codereview.chromium.org/3360020 BUG=http://code.google.com/p/chromium-os/issues/detail?id=6516 TEST=n/a TBR=skerner@chromium.org Review URL: http://codereview.chromium.org/3415022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60449 0039d316-1c4b-4281-b951-d872f2087c98
* Fix test failures in LanguageMenuButtonTest.GetTextForIndicatorTest.satorux@chromium.org2010-09-241-2/+3
| | | | | | | | | | | Update test expectations broken by r60432. BUG=chromium-os:6561 TEST=out/Release/unit_tests --gtest_filter='*GetTextForIndicatorTest' Review URL: http://codereview.chromium.org/3390025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60448 0039d316-1c4b-4281-b951-d872f2087c98
* Improve flaky ui_test AutomationProxyVisibleTest.AutocompleteMatchesTestjknotten@chromium.org2010-09-2410-23/+107
| | | | | | | | | | | | | | | The omnibox requires that it is focused before text input to it will kick off the autocompletion providers. We add code (edit->WaitForFocus()) to the test to wait for the focus to be obtained before setting the omnibox’s text input and proceeding with the rest of the test. BUG=19876 TEST=Existing Review URL: http://codereview.chromium.org/3348021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60443 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 60035 - Make sure the application icon is up to datephajdan.jr@chromium.org2010-09-241-4/+0
| | | | | | | | | | | | | | | | when destroying DownloadManager. This causes a crash on Windows. BUG=54823, 56722 TEST=see bug Review URL: http://codereview.chromium.org/3397017 TBR=phajdan.jr@chromium.org Review URL: http://codereview.chromium.org/3416024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60442 0039d316-1c4b-4281-b951-d872f2087c98
* Adds accelerators for BWSI(guest) mode.altimofeev@chromium.org2010-09-244-14/+38
| | | | | | | | | BUG=chromium-os:6028 TEST=In login screen press ALT+B, - BWSI session starts. Review URL: http://codereview.chromium.org/3443015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60440 0039d316-1c4b-4281-b951-d872f2087c98
* Fix leak of a DownloadItem in SavePackage::Init.phajdan.jr@chromium.org2010-09-242-3/+12
| | | | | | | | | BUG=56495, 54149 TEST=valgrind, see bugs Review URL: http://codereview.chromium.org/3498002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60439 0039d316-1c4b-4281-b951-d872f2087c98
* Experimental change to try to reduce the flakiness of ↵isherman@chromium.org2010-09-241-0/+5
| | | | | | | | | | | | | | | BrowserKeyEventsTest.AccessKeys The theory is that the QuitTask might be nestling into the message loop before the task for the result of the key press. For example, in bug 55713, the theory is that we quit out of the message loop after the key press is sent, but before the location bar is focused. If so, this patch should serve as a band-aid to (nearly) eliminate the test flakiness. At that point we can try to figure out a more bulletproof fix; for now, I'd like to make sure we're right about the underlying cause of the flakiness. BUG=55713 TEST=interactive_ui_tests --gtest_filter=BrowserKeyEventsTest.AccessKeys should not flakily fail Review URL: http://codereview.chromium.org/3454025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60437 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a crash at browser shutdown time.satorux@chromium.org2010-09-241-3/+27
| | | | | | | | | | | | | | | | | | | Instead of stopping input processes from the destructor of InputMehotdLibrary, we'll observe NotificationType::APP_EXITING to do it. Here's the crash senario: When the browser shuts down, 1. AtExitManager deletes CrosLibrary, a singleton object. 2. CrosLibrary deletes InputMethodLibrary 3. InputMethodLibrary calls StopInputMethodProcesses(). 4. StopInputMethodProcesses() relies on the CrosLibrary instance to alive. 5. Which is not the case here, so it crashes. BUG=chromium-os:6995 TEST=confirmed that StopInputMethodProcesses() is called on APP_EXITINIG. Review URL: http://codereview.chromium.org/3497006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60436 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 60362 - Downloads: Don't create the default download directory on ↵phajdan.jr@chromium.org2010-09-241-5/+0
| | | | | | | | | | | | | | | startup. The change has been committed without "LGTM" from all reviewers. BUG=56021 TEST=see bug. Review URL: http://codereview.chromium.org/3386024 TBR=thestig@chromium.org Review URL: http://codereview.chromium.org/3462010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60434 0039d316-1c4b-4281-b951-d872f2087c98
* A quick fix for Issue 45091.hbono@chromium.org2010-09-241-5/+20
| | | | | | | | | | This change checks the states of ctrl and shift keys when proceesing acclerators to prevent FocusManager from consuming ctrl+alt keys and shift+alt keys. Windows sends SC_KEYMENU commands not only when we type only an alt key but also when we type ctrl+alt keys and shift+alt keys, both are used for changing input languages and keyboard layouts. To prevent these keys from being accidentally consumed by FocusManager, we check the states of these keys and send them to FocusManager. BUG=45091 TEST=interactive_ui_tests.exe --gtest_filter=KeyboardAccessTest.TestShiftAltMenuKeyboardAccess. Review URL: http://codereview.chromium.org/3318022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60433 0039d316-1c4b-4281-b951-d872f2087c98
* Add indicators for Hangul and Quick input methods.satorux@chromium.org2010-09-241-1/+3
| | | | | | | | | TEST=manually on the netbook BUG=chromium-os:6561 Review URL: http://codereview.chromium.org/3395012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60432 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 60421 - Revert 60373, trying to track down a perf regression (see bug ↵thakis@chromium.org2010-09-248-2/+28
| | | | | | | | | | | | | | | | | 56752)- Add about:gpuhang BUG=None TEST=None Review URL: http://codereview.chromium.org/3447023 TBR=thakis@chromium.org Review URL: http://codereview.chromium.org/3398027 TBR=thakis@chromium.org Review URL: http://codereview.chromium.org/3398028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60430 0039d316-1c4b-4281-b951-d872f2087c98