summaryrefslogtreecommitdiffstats
path: root/chrome
Commit message (Collapse)AuthorAgeFilesLines
* Fixing bug 1951: Browser crash on View-Source of an https page.finnur@google.com2008-09-111-4/+5
| | | | | | | | | | | | | | | | http://code.google.com/p/chromium/issues/detail?id=1951 We load the page in view-source mode, then request the favicon to show in the tab. The SSLManager gets notified about OnRequestStarted for both the page and the favicon, but the favicon request gets redirected from: https://www.solomobile.ca/favicon.ico ... to ... http://www.solomobile.ca/Error.aspx?aspxerrorpath=/Page-Not-Found.aspx The SSLManager sees this as mixed content and while handling that it writes a debug message to the console, but in the process of writing the debug message we crash when GetTabContents(TAB_CONTENTS_WEB) returns NULL (since the current tab is TAB_CONTENTS_VIEW_SOURCE). Given that this is a debug message we are trying to write with a function that is only implemented on WebContents we should just NULL check the GetTabContents(TAB_CONTENTS_WEB) return value (and not log the debug message). Review URL: http://codereview.chromium.org/2445 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2090 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting constrained window change. Seems to break tests on TOT.erg@google.com2008-09-112-13/+1
| | | | | | Review URL: http://codereview.chromium.org/2447 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2088 0039d316-1c4b-4281-b951-d872f2087c98
* As described in bug 2136, this test is flaky.jcampan@chromium.org2008-09-111-1/+2
| | | | | | | Temporarily disabling it. Review URL: http://codereview.chromium.org/1955 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2087 0039d316-1c4b-4281-b951-d872f2087c98
* Two minor fixes. Fix the hard coded desired dpi and remove an unneeded include.maruel@google.com2008-09-112-2/+3
| | | | | | Review URL: http://codereview.chromium.org/1954 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2084 0039d316-1c4b-4281-b951-d872f2087c98
* Avoid starting the pause timer if it is already started.darin@chromium.org2008-09-111-2/+3
| | | | | | | | R=sky Review URL: http://codereview.chromium.org/2443 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2083 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes bug in IconManager where it was possible for callback to besky@google.com2008-09-111-3/+4
| | | | | | | | | | | | | invoked with a deleted pointer. We never hit this as none of the callers use the SkBitmap supplied to the callback. I was tempted to nuke the SkBitmap from the callback, but seems useful. BUG=1372146 TEST=none Review URL: http://codereview.chromium.org/2438 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2081 0039d316-1c4b-4281-b951-d872f2087c98
* Fix crasher and possible security vulnerability in popuperg@google.com2008-09-112-1/+13
| | | | | | | | | handling. B=1368898 Review URL: http://codereview.chromium.org/2437 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2079 0039d316-1c4b-4281-b951-d872f2087c98
* Update URL for dictionary download.sidchat@google.com2008-09-111-1/+1
| | | | | | Review URL: http://codereview.chromium.org/1401 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2071 0039d316-1c4b-4281-b951-d872f2087c98
* Changes session service to not persist NavigationEntries that havesky@google.com2008-09-116-40/+93
| | | | | | | | | | | POST data. This is a security problem as POST data can contain passwords in plain text. BUG=1361980 TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2063 0039d316-1c4b-4281-b951-d872f2087c98
* Return the exit code from setup.exe instead of returning a generic return code.kuchhal@chromium.org2008-09-111-2/+2
| | | | | | Review URL: http://codereview.chromium.org/1918 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2059 0039d316-1c4b-4281-b951-d872f2087c98
* Closing a tab with a constrained pop-up showing an SSL interstitial would ↵jcampan@chromium.org2008-09-113-3/+40
| | | | | | | | | | crash the browser. BUG=1966 TEST=Open a page that opens a popup which is served over bad SSL. Close the tab. Review URL: http://codereview.chromium.org/1898 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2058 0039d316-1c4b-4281-b951-d872f2087c98
* Renames BoomarkBarModel to BookmarkModel.sky@google.com2008-09-1150-837/+790
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/1912 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2057 0039d316-1c4b-4281-b951-d872f2087c98
* Tuck the ram/num_processes map into a function, and remove a static initializer.deanm@chromium.org2008-09-111-12/+11
| | | | | | Review URL: http://codereview.chromium.org/1936 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2053 0039d316-1c4b-4281-b951-d872f2087c98
* Make sure the tabstrip doesn't have the chin above it in maximized view in aero.beng@google.com2008-09-111-1/+2
| | | | | | | B=1031854 Review URL: http://codereview.chromium.org/2414 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2051 0039d316-1c4b-4281-b951-d872f2087c98
* Set an upper limit to the number of characters that can appear in a tooltip ↵beng@google.com2008-09-112-0/+19
| | | | | | | | | | string. B=1368905 Review URL: http://codereview.chromium.org/2409 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2042 0039d316-1c4b-4281-b951-d872f2087c98
* Double clicking on an item in the task manager should bring the relevant tab ↵petersont@google.com2008-09-107-10/+101
| | | | | | | | forward. Review URL: http://codereview.chromium.org/1822 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2026 0039d316-1c4b-4281-b951-d872f2087c98
* Google Update gave us a new IDL and asked us to change the CLSID const we ↵finnur@google.com2008-09-101-1/+1
| | | | | | | | use. Effectively there should be no change here. This is not required for the beta branch. Review URL: http://codereview.chromium.org/1901 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2008 0039d316-1c4b-4281-b951-d872f2087c98
* First pass at splitting the AutocompleteEdit into Model and View. This was ↵pkasting@chromium.org2008-09-1014-1302/+1571
| | | | | | | | | noticeably harder than with the Popup and I'm not at all sure I've made the right decisions :(. The View code is about 3x larger than the model. BUG=1343512 Review URL: http://codereview.chromium.org/1872 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2004 0039d316-1c4b-4281-b951-d872f2087c98
* The About box was needlessly blocking Chrome on Vista SP1 (with UAC ↵finnur@google.com2008-09-101-3/+8
| | | | | | | | disabled) from performing an On-demand update. Google Update has worked around the issue - for SP1 and up that is - so we can relax the restriction a bit. Review URL: http://codereview.chromium.org/1708 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2003 0039d316-1c4b-4281-b951-d872f2087c98
* Bump for 153 dev cyclemal@chromium.org2008-09-101-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1999 0039d316-1c4b-4281-b951-d872f2087c98
* If you click a link to a malware page or if a page redirects to malware, the ↵jcampan@chromium.org2008-09-101-3/+2
| | | | | | | | | | | | malware blocking page is shown but it says that the malware page is a resource of the originating page. This is because the blocking page was using the page URL to determine if we are dealing with the main frame, and in these cases the URL was not set yet. BUG=1335251 TEST=Navigate to a page that has a link to malware. Click on the link. The malware blocking page should be displayed and should indicate that the page is malware (and not that the originating page contains malware). Review URL: http://codereview.chromium.org/1881 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1998 0039d316-1c4b-4281-b951-d872f2087c98
* Fix grab bag of AeroGlassFrame issues:beng@google.com2008-09-105-21/+22
| | | | | | | | | | | | - better names and documentation for varions kOnstants in the AeroGlassNonClientView - AeroGlassFrame now uses the actual bounds of the tabstrip to adjust the DWM frame, rather than hard-coding constants. - fix bug in hit testing that meant that tabs weren't selectable... wrong coordinate system used for one function call... not sure how this didn't affect XP?!! B=1031854 Review URL: http://codereview.chromium.org/1882 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1996 0039d316-1c4b-4281-b951-d872f2087c98
* Move a bunch of code from the old to new TLS interface.deanm@chromium.org2008-09-105-30/+36
| | | | | | Review URL: http://codereview.chromium.org/1660 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1982 0039d316-1c4b-4281-b951-d872f2087c98
* Don't send queries when URL is like:darin@chromium.org2008-09-104-16/+52
| | | | | | | | | | | | | | | - starts with http:// or https:// and includes username (e.g. http://me@test.com/) - starts with http:// or https:// and includes query (e.g. http://test.com/?q=x) - starts with https:// and includes path component (e.g. https://test.com/path) so as not to leak user data to the suggest server. Patch by takayoshi.kochi@gmail.com BUG=1647 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1978 0039d316-1c4b-4281-b951-d872f2087c98
* Update the reference build to 1912.maruel@google.com2008-09-1048-0/+0
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1954 0039d316-1c4b-4281-b951-d872f2087c98
* Bounds check the tab index before attempting to index into the TabStripModel ↵beng@google.com2008-09-091-6/+6
| | | | | | | | | using it. Under some circumstances, it seems like it's possible for the user to close or otherwise manipulate a Tab whose corresponding entry has already been removed from the model. This might be related to animations and performance constraints. B=1366019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1949 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a bug with positioning windows from a secondary monitor.mpcomplete@google.com2008-09-091-2/+4
| | | | | | | BUG=1327320 Review URL: http://codereview.chromium.org/1864 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1946 0039d316-1c4b-4281-b951-d872f2087c98
* Fix bug with resizeBy in Gears dialogs.mpcomplete@google.com2008-09-091-11/+1
| | | | | | | BUG=1340253 Review URL: http://codereview.chromium.org/1867 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1945 0039d316-1c4b-4281-b951-d872f2087c98
* Moves bookmark related classes into bookmarks directory. There are nosky@google.com2008-09-0938-75/+72
| | | | | | | | | | | | code changes here (other than converting to COPY_AND_BLAH_BLAH and updating include guards). BUG=none TEST=none Review URL: http://codereview.chromium.org/1868 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1944 0039d316-1c4b-4281-b951-d872f2087c98
* Create "ap" key to fallback on full installer even if the key didnt exist ↵kuchhal@chromium.org2008-09-092-10/+132
| | | | | | (for Google Chrome only). git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1943 0039d316-1c4b-4281-b951-d872f2087c98
* backing out checkin to closed treebeng@google.com2008-09-091-6/+6
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1938 0039d316-1c4b-4281-b951-d872f2087c98
* Bounds check the tab index before attempting to index into the TabStripModel ↵beng@google.com2008-09-091-6/+6
| | | | | | | | | using it. Under some circumstances, it seems like it's possible for the user to close or otherwise manipulate a Tab whose corresponding entry has already been removed from the model. This might be related to animations and performance constraints. B=1366019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1936 0039d316-1c4b-4281-b951-d872f2087c98
* Don't index https content. This uses the toplevel brettw@google.com2008-09-091-0/+9
| | | | | | Review URL: http://codereview.chromium.org/1646 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1927 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes bug in TableView where by we return nothing as selected whensky@google.com2008-09-092-36/+22
| | | | | | | | | | | there was a selection. This appears to be a bug in Vista. I've worked around it by iterating over the elements. BUG=1499 TEST=See my steps in bug. Test on both XP and Vista. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1915 0039d316-1c4b-4281-b951-d872f2087c98
* Patch from Szymon Piechowicz <szymonpiechowicz@o2.pl>beng@google.com2008-09-091-6/+6
| | | | | | | | | Moves the New Tab, Window, Incognito Window menu items from the Page menu to the Wrench menu. Code review: http://codereview.chromium.org/1826 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1903 0039d316-1c4b-4281-b951-d872f2087c98
* Update stringstc@google.com2008-09-097-10/+10
| | | | | | | TBR=mal Review URL: http://codereview.chromium.org/1663 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1901 0039d316-1c4b-4281-b951-d872f2087c98
* Add an AtExitManager to test_chrome_plugin. It uses Time::Now(), which now ↵deanm@chromium.org2008-09-091-0/+5
| | | | | | | | uses a Singleton. Review URL: http://codereview.chromium.org/1843 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1895 0039d316-1c4b-4281-b951-d872f2087c98
* Adding a CHECK in a memcpy that it is not trivial to understand.cpu@google.com2008-09-091-3/+3
| | | | | | Review URL: http://codereview.chromium.org/1630 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1883 0039d316-1c4b-4281-b951-d872f2087c98
* Fix chrome.7z archive on buildbots. The earlier change didn't work 100%.rahulk@google.com2008-09-082-8/+4
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1880 0039d316-1c4b-4281-b951-d872f2087c98
* add debug statementrahulk@google.com2008-09-081-0/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1876 0039d316-1c4b-4281-b951-d872f2087c98
* add debug statementrahulk@google.com2008-09-081-0/+3
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1875 0039d316-1c4b-4281-b951-d872f2087c98
* Pages with mixed content were shown as secure.jcampan@google.com2008-09-081-0/+4
| | | | | | | | BUG=1347301 TEST=Go to https://www.corp.google.com the page should not be reported as safe (the location bar should not show a lock). Review URL: http://codereview.chromium.org/2201 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1874 0039d316-1c4b-4281-b951-d872f2087c98
* Change the external protocol handler to look at thensylvain@google.com2008-09-084-18/+35
| | | | | | | | | | | command that will be run before warning the user. If the command is empty, there is no reason to warn. I removed a dcheck. This dcheck is good, but unfortunately we can't use g_browser_process in the io_thread. Review URL: http://codereview.chromium.org/1632 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1871 0039d316-1c4b-4281-b951-d872f2087c98
* Replace all instances of <hash_map> with a "base/hash_tabe.h",erg@google.com2008-09-0827-99/+63
| | | | | | | | | | | which does the right thing based on whatever platform we're compiling for, along with changing the hardcoded "stdext::", which is a MSVC++ism to use base::hash_{map,set}. B=1869 Review URL: http://codereview.chromium.org/1629 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1862 0039d316-1c4b-4281-b951-d872f2087c98
* Use FRIEND_TEST() instead of guessing the test class name (!)maruel@google.com2008-09-082-6/+9
| | | | | | Review URL: http://codereview.chromium.org/1626 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1857 0039d316-1c4b-4281-b951-d872f2087c98
* Disable a flakey test.deanm@google.com2008-09-081-2/+2
| | | | | | | BUG=http://code.google.com/p/chromium/issues/detail?id=1880 Review URL: http://codereview.chromium.org/1816 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1852 0039d316-1c4b-4281-b951-d872f2087c98
* A couple of quick TODO and other cleanups.beng@google.com2008-09-084-13/+1
| | | | | | | | B=1031854 Review URL: http://codereview.chromium.org/1624 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1850 0039d316-1c4b-4281-b951-d872f2087c98
* Support WM_APPCOMMAND on Window. Make it just pass through to ↵beng@google.com2008-09-085-0/+67
| | | | | | | | | | | | WindowDelegate::ExecuteWindowsCommand. The delegate needs to pre-translate for it. This allows my mouse's back and forward buttons to work on the new frames. B=1031854 Review URL: http://codereview.chromium.org/1620 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1849 0039d316-1c4b-4281-b951-d872f2087c98
* Fix binary patching for localized OS. Not sure how it was working till now.rahulk@google.com2008-09-081-6/+6
| | | | | | | | BUG=1557 Review URL: http://codereview.chromium.org/268 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1848 0039d316-1c4b-4281-b951-d872f2087c98
* Hopefully remove 102 unneeded static initializers. This should require less ↵deanm@google.com2008-09-081-197/+198
| | | | | | | | memory, since now we will share the PrepopulatedEngines across the language locales. Review URL: http://codereview.chromium.org/1619 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1846 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-08 15:57:57 +0000