summaryrefslogtreecommitdiffstats
path: root/chrome
Commit message (Collapse)AuthorAgeFilesLines
* Linux: Stack autocomplete popup window directly on top of the browser's ↵suzhe@chromium.org2009-10-157-23/+65
| | | | | | | | | | | toplevel window. BUG=19082 "Linux: Omnibox auto-complete popup is on top of IME candidate window when using SCIM" TEST=Please refer to the bug report for how to test. Review URL: http://codereview.chromium.org/274046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29102 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: enable DevToolsSanityTest.TestCompletionOnPause that failed ↵yurys@google.com2009-10-151-1/+1
| | | | | | | | | because WebKit@49557 was not rolled. BUG=24805 Review URL: http://codereview.chromium.org/271100 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29101 0039d316-1c4b-4281-b951-d872f2087c98
* Revert checkin 29096jar@chromium.org2009-10-151-1/+0
| | | | | | | | | Removing a line that I put in just to get perf data from the build bots. TBR=mbelshe Review URL: http://codereview.chromium.org/267114 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29100 0039d316-1c4b-4281-b951-d872f2087c98
* Remove instructions to right-click toolstrips toaa@chromium.org2009-10-152-10/+14
| | | | | | | | | bring up an inspector, as that doesn't work anymore. TBR=kathyw@google.com git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29099 0039d316-1c4b-4281-b951-d872f2087c98
* Reland r29095 (removes wrench integration foraa@chromium.org2009-10-1525-276/+265
| | | | | | | | | | | | browser actions). Test failure was a fluke. I forgot that changing resources always makes the first bot run fail. TBR=mpcomplete@chromium.org BUG=24379,24671 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29098 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting r29095 (removes wrench integration foraa@chromium.org2009-10-1525-265/+276
| | | | | | | | | browser actions). TBR=mpcomplete@chromium.org BUG=24379,24671 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29097 0039d316-1c4b-4281-b951-d872f2087c98
* Temporarilly disable SetURL to evaluate perf impactjar@chromium.org2009-10-151-0/+1
| | | | | | | | | | | | | | | This is a temporary checkin, meant to gather data from the bots that run performance tests. I'll revert it asap. Profiling suggests we call SetURL VERY often, so that we can get crash info. The function turns out to cause a memory allocation, and also a string conversion, and hence *might* have a significant perf impact. TBR=mbelshe Review URL: http://codereview.chromium.org/273051 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29096 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the implicit wrench menu items for browser actions.aa@chromium.org2009-10-1525-276/+265
| | | | | | | | | | | Also, allow browser actions with no initial icons, and add some better tests. BUG=24379,24671 Review URL: http://codereview.chromium.org/276010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29095 0039d316-1c4b-4281-b951-d872f2087c98
* Re-try r29078: Remove some deprecated file_util wstring functions.estade@chromium.org2009-10-1523-131/+140
| | | | | | | | | | | | | With the previous patch, the try bots failed with mysterious messages, so I ignored them, patched it into my windows box and tested it there manually, and found no problems. As it turns out, the try failures were real :(. But nsylvain and I found the problem: the behavior of file_util::GetDirectoryFromPath() differs from DirName() when the path is empty (officially, GetDirectoryFromPath is not supposed to support non-absolute paths, but that is not enforced). Here is a green win try result: http://build.chromium.org/buildbot/try-server/builders/win/builds/3705 mac: http://build.chromium.org/buildbot/try-server/builders/mac/builds/3491 linux: http://build.chromium.org/buildbot/try-server/builders/linux/builds/3466 I also applied this patch locally in Windows to test that it doesn't break the chrome frame compile or tests, since that's not covered by the trybots yet. Review URL: http://codereview.chromium.org/271099 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29094 0039d316-1c4b-4281-b951-d872f2087c98
* Remove file_util::TrimTrailingSeparators(), which is deprecated andtkent@chromium.org2009-10-151-6/+5
| | | | | | | | | | doesn't work well for Windows root drives. BUG=24722 TEST=existing tests are enough. Review URL: http://codereview.chromium.org/271086 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29093 0039d316-1c4b-4281-b951-d872f2087c98
* Mark HistorySearchXSS as flaky.nsylvain@chromium.org2009-10-151-1/+2
| | | | | | | | BUG:22111 Review URL: http://codereview.chromium.org/278016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29089 0039d316-1c4b-4281-b951-d872f2087c98
* Revert wstring patch (r29078 and follow up commits). It is causing failures ↵estade@chromium.org2009-10-1523-132/+127
| | | | | | | | | | on the buildbots. TBR=nsylvain Review URL: http://codereview.chromium.org/280004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29085 0039d316-1c4b-4281-b951-d872f2087c98
* Remove some deprecated file_util wstring functions.estade@chromium.org2009-10-1523-127/+132
| | | | | | | | | | | death to the wstring TEST=trybots BUG=none Review URL: http://codereview.chromium.org/276016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29078 0039d316-1c4b-4281-b951-d872f2087c98
* Don't use NSBundle when unsure of thread safety.mark@chromium.org2009-10-152-19/+14
| | | | | | | | BUG=24842 TEST=unit tests pass, app still works Review URL: http://codereview.chromium.org/271094 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29077 0039d316-1c4b-4281-b951-d872f2087c98
* Fix some warnings on Mac that are treated as errors:munjal@chromium.org2009-10-155-28/+13
| | | | | | | | | | | | | | The warnings indicate that a public/protected method of a class visible outside of a .cc file returns a type that's declared in the anonymous namespace in that file (and hence not visible outside the file). BUG=23073 TEST=none Review URL: http://codereview.chromium.org/273058 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29075 0039d316-1c4b-4281-b951-d872f2087c98
* Move the sqlite error handler to a single locationcpu@chromium.org2009-10-157-44/+95
| | | | | | | | | | | | | | - Eliminate code duplication - Cover other 3 databases - Still doing the same as before, sending UMA histograms BUG=11908 TEST=none Review URL: http://codereview.chromium.org/270101 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29073 0039d316-1c4b-4281-b951-d872f2087c98
* Fixing a bug with interstitial pages triggered with malware.jcampan@chromium.org2009-10-153-5/+64
| | | | | | | | | BUG=http://crbug.com/17627 TEST=See bug. Review URL: http://codereview.chromium.org/273022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29071 0039d316-1c4b-4281-b951-d872f2087c98
* Update browser actions api to be like new design doc.aa@chromium.org2009-10-1519-145/+464
| | | | | | | | | BUG=23879 TEST=Install sample gmail browser action sample. Review URL: http://codereview.chromium.org/264046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29068 0039d316-1c4b-4281-b951-d872f2087c98
* Updating trunk VERSION from 222.11 to 223.0eblake@chromium.org2009-10-151-2/+2
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29067 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor notification provider in renderer process to not use a message filter.johnnyg@chromium.org2009-10-144-68/+31
| | | | | | | | | BUG=24241 TEST=not crashing Review URL: http://codereview.chromium.org/276032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29064 0039d316-1c4b-4281-b951-d872f2087c98
* Add histogram for how tab closing time. Did some cleanup along the way. ↵jam@chromium.org2009-10-1413-60/+66
| | | | | | | | Moved the is_showing_before_unload_dialog_ stuff from RenderViewHost to TabContents since we need that bit there as well. Review URL: http://codereview.chromium.org/274057 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29063 0039d316-1c4b-4281-b951-d872f2087c98
* Hides the control buttons for browser when maximized on chromesky@chromium.org2009-10-142-11/+39
| | | | | | | | | | | | os. maximized is the default state on chrome os, so this effectively gives us no window controls just as we have now. BUG=none TEST=none Review URL: http://codereview.chromium.org/273055 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29061 0039d316-1c4b-4281-b951-d872f2087c98
* Small cleanup to extension function registration to avoid scattered definitions.mpcomplete@chromium.org2009-10-1422-211/+98
| | | | | | | | BUG=no Review URL: http://codereview.chromium.org/274059 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29059 0039d316-1c4b-4281-b951-d872f2087c98
* Don't hide task manager key binding from web pages.mmoss@chromium.org2009-10-141-2/+1
| | | | | | | | | | | | | This allows shift-esc to work again in Gmail chat windows. BUG=none TEST=Open Gmail, start a chat, repeatedly press SHIFT+ESC and watch it switch between the chat "window" and the mail list. The Task Manager should not open. Review URL: http://codereview.chromium.org/274028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29055 0039d316-1c4b-4281-b951-d872f2087c98
* For sync exponential backoff, allow one nudge per exponential backoff ↵tim@chromium.org2009-10-143-151/+347
| | | | | | | | | | | | | | | | | | | interval. If the nudge still leaves the syncer with more work to do, don't accept any further nudges for this interval, and keep the exponent stage for exponential backoff the same. As a result of the patch, the unittest can now explicitly determine if exponential backoff kicked in or not. We really need to wire this up directly to the error codes to be precise, because the current impl (and it's the same with my patch) appears to trigger exponential backoff in other cases (ShouldSyncAgain). TEST=SyncerThreadTest Review URL: http://codereview.chromium.org/275015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29053 0039d316-1c4b-4281-b951-d872f2087c98
* Disable "Reset to Default Theme" button in Google Chrome Options / Personal ↵mirandac@chromium.org2009-10-142-0/+7
| | | | | | | | | | | Stuff when the default theme is already set, Windows side. BUG= http://crbug.com/18585 TEST= Install a default theme, note that button is disabled. Install a non-default theme, note that button is enabled. Review URL: http://codereview.chromium.org/279005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29050 0039d316-1c4b-4281-b951-d872f2087c98
* Updating trunk VERSION from 222.10 to 222.11chrome-bot@google.com2009-10-141-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29048 0039d316-1c4b-4281-b951-d872f2087c98
* Disable "Reset to Default Theme" button in Google Chrome Options / Personal ↵mirandac@chromium.org2009-10-144-6/+55
| | | | | | | | | | | | | Stuff when the default theme is already set. This change is for the Mac OS; Windows change in a separate patch. BUG= http://crbug.com/18585 TEST= Install a default theme, note that button is disabled. Install a non-default theme, note that button is enabled. Rinse, repeat. Review URL: http://codereview.chromium.org/278004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29047 0039d316-1c4b-4281-b951-d872f2087c98
* Fix extension canceling; the CFUserNotification functionality gets a bit weird.avi@chromium.org2009-10-141-2/+3
| | | | | | | | | BUG=http://crbug.com/23405 TEST=try to cancel extension load; it should work. Review URL: http://codereview.chromium.org/279006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29046 0039d316-1c4b-4281-b951-d872f2087c98
* Updating trunk VERSION from 222.9 to 222.10chrome-bot@google.com2009-10-141-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29045 0039d316-1c4b-4281-b951-d872f2087c98
* Removing an unused gyp file that somehow did not get removed when I reverted ↵jcampan@chromium.org2009-10-141-150/+0
| | | | | | | | | | | my CL last week. BUG=None TEST=None Review URL: http://codereview.chromium.org/276020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29042 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the base_gfx project since it no longer has an external dependencies.brettw@chromium.org2009-10-142-1/+10
| | | | | | | | | | Replace it with base_i18n which encapsulates all ICU dependencies. BUG=none TEST=none Review URL: http://codereview.chromium.org/267048 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29036 0039d316-1c4b-4281-b951-d872f2087c98
* Eliminate char/wchar_t conversions, probably-unsafe statics, and disk accessmark@chromium.org2009-10-147-41/+80
| | | | | | | | | | when determining the framework and helper app paths on the Mac. BUG=24833 TEST=app still works, tests still pass Review URL: http://codereview.chromium.org/267102 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29034 0039d316-1c4b-4281-b951-d872f2087c98
* Official builds should be on the com.google.Chrome update product ID, notmark@chromium.org2009-10-142-6/+192
| | | | | | | | | | | | | | | com.google.Chrome.framework BUG=24836 TEST=After running Google Chrome.app, run ~/Library/Google/GoogleSoftwareUpdate/GoogleSoftwareUpdate.bundle/Contents/MacOS/ksadmin -p. You should see, at the very least, tickets for com.google.Keystone and com.google.Chrome, and they should appear to have valid data. You should not see any tickets for com.google.Chrome.framework. If you run ksadmin -l, you should not get any error output. Review URL: http://codereview.chromium.org/273059 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29033 0039d316-1c4b-4281-b951-d872f2087c98
* Moving one test to appear last to see if it makes a difference.finnur@chromium.org2009-10-141-10/+10
| | | | | | | | | | TBR=jcampan BUG=None TEST=None Review URL: http://codereview.chromium.org/276031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29029 0039d316-1c4b-4281-b951-d872f2087c98
* rsync needs -C to avoid copying .svn directories.mark@chromium.org2009-10-141-1/+1
| | | | | | | | | | | | I'm not adding temporary code to remove .svn directories that may have gotten copied in because this only applies to the KeystoneRegistration.framework, not present in ordinary developer builds. BUG=24823 TEST=|find "Google Chrome.app" -name .svn| should not show anything Review URL: http://codereview.chromium.org/273057 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29028 0039d316-1c4b-4281-b951-d872f2087c98
* Gets the full screen bubble to work on views/gtk.sky@chromium.org2009-10-145-32/+69
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/264059 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29027 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: colorize the "bookmarks go here" text to match the theme.avi@chromium.org2009-10-141-0/+35
| | | | | | | | | BUG=http://crbug.com/23536 TEST=as in bug Review URL: http://codereview.chromium.org/278008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29025 0039d316-1c4b-4281-b951-d872f2087c98
* Add ChromeOS controls to BrowserViewoshima@chromium.org2009-10-146-4/+227
| | | | | | | | | | | | * Added BrowserExtender class to isolate ChromeOS specific controls from BrowserView * Extender currently adds main menu and status area view only. * System menu is not enabled because using SetContextMenuController on NonClientFrameView didn't work. I need to investigate how. * PanelController support will be added in next CL. Review URL: http://codereview.chromium.org/269078 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29021 0039d316-1c4b-4281-b951-d872f2087c98
* Use FilePath in URLRequestMocks.evan@chromium.org2009-10-1416-61/+88
| | | | | | | | | BUG=24672 TEST=compiles Review URL: http://codereview.chromium.org/271066 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29013 0039d316-1c4b-4281-b951-d872f2087c98
* Marking DISABLED test as FLAKY so I can investigate on the bots. finnur@chromium.org2009-10-141-1/+21
| | | | | | | | | | | Also adding traces. BUG=None TEST=None Review URL: http://codereview.chromium.org/276030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29011 0039d316-1c4b-4281-b951-d872f2087c98
* linux: tickle the render sandbox early so it forks at the right timeevan@chromium.org2009-10-141-17/+21
| | | | | | | | | | | Otherwise, the first time the singleton is touched we've already started loading a page! We surely have a bunch of threads going at that point. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=27528 Review URL: http://codereview.chromium.org/245039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29010 0039d316-1c4b-4281-b951-d872f2087c98
* Fix views build break.estade@chromium.org2009-10-141-22/+0
| | | | | | | | TBR=Finnur Review URL: http://codereview.chromium.org/267103 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29009 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: Prevent another Chrome instance when First Run UI is active.kuchhal@chromium.org2009-10-144-23/+31
| | | | | | | | | BUG=24485 TEST=On Ubuntu, delete 'First Run' file and launch Chrome to bring up First Run UI and then again launch Chrome which should not crash. Review URL: http://codereview.chromium.org/278006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29007 0039d316-1c4b-4281-b951-d872f2087c98
* Make the multiple download request dialog an infobar.estade@chromium.org2009-10-1416-495/+218
| | | | | | | | | | | | The icon is a placeholder until Glen makes a pretty one. BUG=24047 TEST=go to skypher.com/SkyLined/Repro/Chrome/carpet bombing/repro.html allow, deny, closing infobar, and closing tab all work as expected Review URL: http://codereview.chromium.org/275011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29006 0039d316-1c4b-4281-b951-d872f2087c98
* Enable the RenderViewTest printing tests on the Mac.stuartmorgan@chromium.org2009-10-144-26/+35
| | | | | | | | | | | | | | | Migrates some test APIs from wstring path names to FilePath objects, and fixes some gcc compilation issues, to allow the tests to build on Mac. Moves rendering logic and some other pdf logic into PdfMetafile to avoid duplication with unit test code. Switches rendering from the deprecated CGContextDrawPDFDocument to the newer (but less convenient) CGContextDrawPDFPage. Added debugging helpers to PdfMetafile: SaveTo, matching the other platform metafiles, and context retain count checking to get early warning of issues that will cause printing failure. BUG=24750 TEST=N/A Review URL: http://codereview.chromium.org/274052 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29003 0039d316-1c4b-4281-b951-d872f2087c98
* Unversion frameworksmark@chromium.org2009-10-144-68/+138
| | | | | | | | | | | | | | | BUG=24823 TEST= - GC.app/Contents/Versions/GCF.framework should not contain any symlinks. - GC.app/Contents/Versions/GCF.framework/Frameworks/KSR.framework shouldn't either. - There should only be three remaining symlinks in the entire GC.app package, in each of three different Resources directories. Each of the remaining symlinks should just be en.lproj -> en_US.lproj. - The app should still run. Keystone should still operate. (Make sure that Keystone does its up-to-date check in the About box.) Review URL: http://codereview.chromium.org/278007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28999 0039d316-1c4b-4281-b951-d872f2087c98
* Map ctrl+, to open options settings page for Chrome OS.chocobo@google.com2009-10-141-3/+2
| | | | | | | | TEST=none BUG=none Review URL: http://codereview.chromium.org/267095 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28998 0039d316-1c4b-4281-b951-d872f2087c98
* Originally in http://codereview.chromium.org/270096 but got lost somehow.jrg@chromium.org2009-10-141-1/+1
| | | | | | | | | BUG=http://crbug.com/24758 TBR=mrossetti Review URL: http://codereview.chromium.org/273054 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28997 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity: check return of SafeBrowsingProtocolParser::ParseGetHash.mattm@chromium.org2009-10-141-8/+8
| | | | | | | | | | CID=6428 TEST=none BUG=none Review URL: http://codereview.chromium.org/261034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28996 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-08 08:18:42 +0000