| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Mac uses Launch Services to make sure one Chrome is started from the
GUI, and AppleEvents and Launch Services to pass in URLs. When a
developer or test launches multiple browsers against a profile, it
fails in mysterious ways. This adds a profile lock to flush out any
hidden assumptions.
BUG=22163,58986,59061
TEST=Run Chromium twice with same --user-data-dir. Second instances shouldn't launch.
Review URL: http://codereview.chromium.org/3777003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62659 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=58369
TEST=running unit_tests --gtest_filter=ExtensionFromUserScript.* does not leave extra files in ~/.config/chromium/Temp.
Review URL: http://codereview.chromium.org/3708005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62658 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
(3.5 megs off debug linux .a files)
BUG=none
TEST=compiles
Review URL: http://codereview.chromium.org/3806005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62654 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Also makes Browser support browser::NavigatorDelegate.
BUG=none
TEST=BrowserNavigatorTest.Disposition_SingletonTab*
Review URL: http://codereview.chromium.org/3734003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62653 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3812004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62652 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This successfully solves a problem where extension event listeners
were never getting called on Chrome OS because InitEventRouters
wasn't getting called from browser_main.cc if the profile was in the
temporary OTR state while the login was in progress.
BUG=51724
TEST=Log in, test simple extension that notifies when a tab is created.
Review URL: http://codereview.chromium.org/3765001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62648 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BrowsingInstance::UnregisterSiteInstance() now removes the SiteInstance
from both the local instance SiteInstanceMap and the static per-profile map.
BUG=58342
TEST=none
Review URL: http://codereview.chromium.org/3781007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62646 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Data. Essentially a revert of r52258, though done by hand.
xib: Removed the link from the sync group, removed continuation array, resized everything else to close the gap.
BUG=59095
TEST=go into options, find no "go to Google Dashboard" link
Review URL: http://codereview.chromium.org/3761005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62641 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Cancelling out of the setup dialog needs to re-layout in order to properly go
from the setting up text to the sign in text.
BUG=59037
TEST=On Windows, bring up Options, Under the Hood, disable the proxy if it isn't, hit the setup button, cancel out of the login dialog. Button should resize and not clip.
Review URL: http://codereview.chromium.org/3817002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62640 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Moves GUID generation into chrome/browser/guid*. GUID generation is used only within chrome/browser. So am moving it there.
BUG=58813
TEST=GUIDTest.GUIDGeneratesAllZeroes, GUIDTest.GUIDGeneratesCorrectly, GUIDTest.GUIDCorrectlyFormatted, MetricsServiceTest.ClientIdCorrectlyFormatted
Review URL: http://codereview.chromium.org/3800003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62639 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Time is wasted in a permission dialog timeout.
BUG=http://crbug.com/51861
Review URL: http://codereview.chromium.org/3775008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62638 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This was already removed on non-Windows, so this change modifies
the remaining Windows-specific usage. In a few places I converted
use of wstring paths into FilePath, but in general for Windows-specific
code I don't think it's too important to use FilePath everywhere,
because it is equivalent on Windows and the current code already works.
BUG=23581
Review URL: http://codereview.chromium.org/3817001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62637 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* use minimum width when set the bound of menu. This fixes
problem where menu was shown in incorrect place for short period of time
on OOBE.
* clears the content when menu is hidden. This fixes the problem where bigger menu window is showne when opening a menu.
* Update zoom controls only if the menu is root.
* use plain property for scrollEnabled.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3775003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62636 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=59095
TEST=See ui in options tab and clear other data tab
Review URL: http://codereview.chromium.org/3758004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62635 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
the Options menu ("Under the Hood" tab) on Windows.
R=mattm
BUG=59125
TEST=net_unittests.exe --gtest_filter=SSLConfigServiceWinTest.SetTest.
Manually verify the Options menu has the two new checkboxes.
Review URL: http://codereview.chromium.org/3779003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62634 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
With this change, a user can pass in an individual url or a list of urls to be opened with the new window.
BUG=53517
TEST=ExtensionApiTest
Review URL: http://codereview.chromium.org/3772004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62633 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=self
Review URL: http://codereview.chromium.org/3701007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62632 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=59155,59157
TEST=none
TBR=glen
Review URL: http://codereview.chromium.org/3810005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62630 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=54745
TEST=manual
Review URL: http://codereview.chromium.org/3582007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62627 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
the size actually changes. Layout was the wrong place for the check
before as Layout may be invoked even if the size hasn't changed.
BUG=59164
TEST=make sure tabstrip on windows still has animations.
Review URL: http://codereview.chromium.org/3782006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62625 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This changes the url and the text on about:flags to a bit more scary.
The text is taken from https://docs.google.com/a/google.com/document/d/1VRZjR3GGX2FJFsAe8AKMAYRNPMp-sH2cefU0KvaQo0M/edit?hl=en#
BUG=59139,53399
TEST=about:labs doesn't do anything any more. about:flags does.
Review URL: http://codereview.chromium.org/3817004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62624 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=59139
TEST=None
TBR=trungl
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62622 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
change 62314
Review URL: http://codereview.chromium.org/3793003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62606 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is a continuation of the former codereview (
http://codereview.chromium.org/3579012) witch detached from git because of my mistake.
BUG=chromium-os:7008
TEST=none
Review URL: http://codereview.chromium.org/3793004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62599 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Added NetworkMenu::UpdateMenu()
* Added NetworkMenu::ConnectToNetworkAt()
BUG=http://code.google.com/p/chromium-os/issues/detail?id=7343
TEST=Test the network menu (it still looks ugly). Specifically, selecting a non secure network, or one with a certificate installed should connect to it. Also, temporarily, using 'space' or 'return' to select a network should connect to it without closing the menu.
Review URL: http://codereview.chromium.org/3678006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62598 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
I also changed the test to make the cause of failure clear.
TBR=chocobo@chromium.org
BUG=59195
TEST=TestActivateDeactivate will pass
Review URL: http://codereview.chromium.org/3796005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62592 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
url.
BUG=58756
TEST=none
Review URL: http://codereview.chromium.org/3754004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62591 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
My popup tests are causing more harm than good. They fail. We need a better way to be sure when they're up. Disabling them while I work on them.
BUG=59208
TEST=
Review URL: http://codereview.chromium.org/3746006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62583 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Stop refcounting StreamRequest. Establish a clear ownership of the StreamRequest. Deletion implies cancellation. Use ScopedRunnableMethodFactory::NewRunnableMethod() instead of NewRunnableMethod().
Remove Start() from StreamRequest. This is an implementation detail of HttpStreamRequest, so it only exists there now.
BUG=59103
TEST=existing, this is a pure refactor.
Review URL: http://codereview.chromium.org/3746002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62581 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=59195
TEST=None.
Review URL: http://codereview.chromium.org/3792004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62578 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=59198
TEST=none
Review URL: http://codereview.chromium.org/3815004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62572 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
the feedback.
BUG=chromium-os:7717
TEST=open few tabs, then open feedback page, before you submit feedback close all pther tabs. make sure
there is no crash on feedback submit.
Review URL: http://codereview.chromium.org/3772006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62570 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- fixed Disable/Enable Cellular/WiFi buttons
- clicking the secured network multiple times does not generate multiple inputs anymore
- disabled [Login] button on protected SSD networks when no password is entered
BUG=chromium-os:7684, chromium-os:7563, chromium-os:7651
TEST=make sure chrome:settings/internet is happier place to be again
Review URL: http://codereview.chromium.org/3746003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62569 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
The Flash-specific issues with Core Animation have been resolved, so this flag isn't needed any more.
BUG=NONE
TEST=--disable-flash-core-anmiation shouldn't do anything any more.
Review URL: http://codereview.chromium.org/3750005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62566 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:7488
TEST=Verify selection colors in webkit is the same color as in omnibox selection per chromium-os:7488.
Review URL: http://codereview.chromium.org/3653006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62565 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=58192
TEST=Start chrome with --auth-schemes=NTLM and --proxy-server pointing to a Microsoft Forefront Threat Management Gateway proxy configurated for Integrated Authentication. Assuming the user is part of the same domain as the proxy, authentication should work transparently, and the user should not be presented with auth prompts. Also, net_unittests should pass.
Review URL: http://codereview.chromium.org/3676004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62564 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
The policy is wired with settings.enable_screen_lock.
BUG=chromium-os:6546
TEST=Create a policy json file and verify the screen lock checkbox is managed in "Person stuff" options page.
Review URL: http://codereview.chromium.org/3611012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62562 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:6801
TEST=Manual. Have WiFi network with password that's not set for auto connect. There's no way to see it's existing password on OOBE/login.
Review URL: http://codereview.chromium.org/3750007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62561 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Applications that are configured to be launched in a tab are now opened directly in the NTP, rather than opening a new tab and closing the NTP.
BUG=57476
TEST=Try launching an application from the new tab page. If it's set to open as a tab, a pinned tab, or full-screen, the application should launch directly into the existing new tab page. The new tab page should close when opening an application with panel launch type.
Review URL: http://codereview.chromium.org/3673006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62560 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Another component in Chrome OS (session_manager) will handle this instead.
BUG=chromium-os:7511
TEST=unit tests
Review URL: http://codereview.chromium.org/3645006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62559 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=58756
TEST=none
Review URL: http://codereview.chromium.org/3818001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62558 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
No functional changes, just trying to reduce external dependencies to make these tests less flaky.
BUG=44589,58856
TEST=GeolocationBrowserTest.*
Review URL: http://codereview.chromium.org/3752005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62557 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:6185
TEST=manually
Review URL: http://codereview.chromium.org/3768003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62556 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
changed around BlockedPopupContainer so that it can handle any types
and made TabContents offer a mode to block all child content.
BUG=58927
TEST=enable instant, go to a site that would normally show a popup on
entering (or explicitly enable all popups). While typing in
the omnibox the popup shouldn't appear, but as soon as you
commit the instant result it should appear.
Review URL: http://codereview.chromium.org/3694005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62553 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
A devide data provider for linux that providers a gateway's MAC address.
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/3588006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62551 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
instant results to properly move out of the way of the omnibox.
BUG=56385
TEST=Do a Google search with Instant turned on. The omnibox should not overlap with the results.
Review URL: http://codereview.chromium.org/3735005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62550 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
also fix comment to match implementation
BUG=None
TEST=ExtensionTest.EffectiveHostPermissions
Review URL: http://codereview.chromium.org/3813002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62548 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=47201
TEST=Resize the browser action area and then force a shutdown. Ensure that the change is persisted for the next launch.
Review URL: http://codereview.chromium.org/3791003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62545 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=http://crbug.com/59191
TEST=none
Review URL: http://codereview.chromium.org/3827001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62544 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=26450
TEST=Load webpage with three JS alerts. Check "Prevent this page from creating
additional dialogs" on the second, and Cancel that alert. Ensure that the
third alert is not shown.
Review URL: http://codereview.chromium.org/3792001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62543 0039d316-1c4b-4281-b951-d872f2087c98
|