summaryrefslogtreecommitdiffstats
path: root/chrome
Commit message (Collapse)AuthorAgeFilesLines
* [GTTF] Remove the in-process test launcher, which is no longer used.phajdan.jr@chromium.org2010-03-264-198/+0
| | | | | | | | | | | I plan to further rearrange the files after landing this CL so that the names make sense again. TEST=browser tests and live sync tests BUG=none Review URL: http://codereview.chromium.org/1310003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42737 0039d316-1c4b-4281-b951-d872f2087c98
* Implement new websocket handshake based on draft-hixie-thewebsocketprotocol-76ukai@chromium.org2010-03-261-0/+1
| | | | | | | | | BUG=none TEST=net_unittests passes Review URL: http://codereview.chromium.org/1108002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42736 0039d316-1c4b-4281-b951-d872f2087c98
* 3rd try. *sigh*slightlyoff@chromium.org2010-03-264-3/+23
| | | | | | | | | | | | | See: http://codereview.chromium.org/858003 TBR=tommi BUG=22846 TEST=On IE 8, clear the cache entirely, watch GCF launch (via task manager) Review URL: http://codereview.chromium.org/1343004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42732 0039d316-1c4b-4281-b951-d872f2087c98
* Move a few more things out of BrowserMain into helper functions.brettw@chromium.org2010-03-261-41/+55
| | | | | | | | TEST=none BUG=none Review URL: http://codereview.chromium.org/1368001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42725 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 42719 - Adding the cobwerks plugin piecemealcpu@chromium.org2010-03-261-1/+0
| | | | | | | | | | | | | | | BUG=36229 TEST=none TBR=nsylvain Review URL: http://codereview.chromium.org/1338007 TBR=cpu@chromium.org Review URL: http://codereview.chromium.org/1360003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42721 0039d316-1c4b-4281-b951-d872f2087c98
* Label scraping for AutoFill.dhollowa@chromium.org2010-03-264-44/+277
| | | | | | | | | | | | | | | | | | Adds label scraping to AutoFill. Infers labels from surrounding context of input fields in the WebKit DOM. Specific cases added are: - Text element immediately preceeding INPUT element. Eg. First name:<INPUT type="text" id="firstname" value="John"/> - Paragraph element containing text immediately preceeding INPUT element. Eg. <P>First name:</P><INPUT type="text" id="firstname" value="John"/> BUG=33031 TEST=FormManagerTest.LabelsFromInferredParagraph, FormManagerTest.LabelsFromInferredText, FormStructureTest.HeuristicsLabelsOnly Review URL: http://codereview.chromium.org/1380002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42720 0039d316-1c4b-4281-b951-d872f2087c98
* Adding the cobwerks plugin piecemealcpu@chromium.org2010-03-261-0/+1
| | | | | | | | | | | | BUG=36229 TEST=none TBR=bradnelson Review URL: http://codereview.chromium.org/1338007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42719 0039d316-1c4b-4281-b951-d872f2087c98
* Removing AutoFill Death Tests.dhollowa@chromium.org2010-03-264-19/+0
| | | | | | | | | | | | The gunit ASSERT_DEBUG_DEATH check is causing long timeouts on Mac. Removing. BUG=NONE TEST=AutoFill unit tests. Review URL: http://codereview.chromium.org/1400001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42715 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the known stack crash signature for Bug 39356ananta@chromium.org2010-03-261-1/+1
| | | | | | | | | | Bug=39356 TBR=robertshield Review URL: http://codereview.chromium.org/1336005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42714 0039d316-1c4b-4281-b951-d872f2087c98
* Switch from he.xtb to iw.xtb because the translation console istony@chromium.org2010-03-264-4/+6
| | | | | | | | deprecating 'he' in favor of 'iw'. Review URL: http://codereview.chromium.org/1332001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42713 0039d316-1c4b-4281-b951-d872f2087c98
* Added support for pending extensions to ExtensionsService andakalin@chromium.org2010-03-266-90/+543
| | | | | | | | | | | | | | | ExtensionUpdater. This is needed for theme syncing. Basically a pending extension is an (id, update_url) pair. This change makes it so that one can pass pending extensions to the extension service and they will be installed if necessary on the next auto-update cycle. BUG=32414 TEST=unittests, trybots, in-progress theme syncing change Review URL: http://codereview.chromium.org/1232003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42711 0039d316-1c4b-4281-b951-d872f2087c98
* Scope the WriteTransactions during model association so that we don't lock ↵zork@chromium.org2010-03-263-136/+153
| | | | | | | | | | | the UI thread BUG=34206 TEST=none Review URL: http://codereview.chromium.org/1361002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42708 0039d316-1c4b-4281-b951-d872f2087c98
* Add some more EXPECT_TRUE to track down the valgrind issue.arv@chromium.org2010-03-261-2/+6
| | | | | | | | | | BUG=39401 TEST=ui_test --gtest_filter BookmarksUITest.* TBR=dhollowa Review URL: http://codereview.chromium.org/1365003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42707 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Provide GTK+ themed notifications.erg@chromium.org2010-03-262-19/+62
| | | | | | | | | BUG=34514 TEST=none Review URL: http://codereview.chromium.org/1353003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42705 0039d316-1c4b-4281-b951-d872f2087c98
* Views: fix a crash where in the browser actions container.estade@chromium.org2010-03-262-4/+28
| | | | | | | | | | | This crash didn't actually affect linux/views (for some reason the RunContextMenu() call seems to never return). BUG=38964 TEST=crash an extension while the context menu for it is showing. Review URL: http://codereview.chromium.org/1237004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42703 0039d316-1c4b-4281-b951-d872f2087c98
* Make nacl_ui_tests not flaky on Mac, enable the sandbox on Win64gregoryd@google.com2010-03-262-41/+0
| | | | | | | | | | | | Win64 are not enabled yet, but should run in the sandbox once they are. Mac problem was hopefully fixed with bug 37707 BUG=http://code.google.com/p/nativeclient/issues/detail?id=342 TEST=nacl_ui_tests Review URL: http://codereview.chromium.org/1342002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42702 0039d316-1c4b-4281-b951-d872f2087c98
* Disable test AccountScreenTest.TestBasic .skerner@chromium.org2010-03-261-1/+1
| | | | | | | | | BUG=39404 TEST=none TBR=avayvod git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42701 0039d316-1c4b-4281-b951-d872f2087c98
* linux: turn on -Wextraevan@chromium.org2010-03-261-1/+1
| | | | | | | | | | | | | | This is a followup to an earlier change (r38266) which did most of the warning-related cleanup. This one just flips the flag, and fixes some new warnings that crept in during the window while the flag was off. Second try, now with some libpng fixes. BUG=34160 Review URL: http://codereview.chromium.org/1320011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42700 0039d316-1c4b-4281-b951-d872f2087c98
* BookmarksUITest.BookmarksLoaded fails under valgrind on macdhollowa@chromium.org2010-03-251-0/+4
| | | | | | | | | | | | Adding to valgrind exception list while we determine source of failure. Note, same test does not fail under other platforms, nor does it fail under non-valgrind Mac bots. BUG=39401 TEST=none Review URL: http://codereview.chromium.org/1342003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42698 0039d316-1c4b-4281-b951-d872f2087c98
* Adding new test for mount observer. Also changing the usb mounter to only ↵dhg@chromium.org2010-03-255-7/+174
| | | | | | | | | reload the correct tab, not the full browser. BUG=chromium-os:2057 Review URL: http://codereview.chromium.org/1238006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42696 0039d316-1c4b-4281-b951-d872f2087c98
* Add test for power_menu_button.chocobo@chromium.org2010-03-254-7/+107
| | | | | | | | BUG=none TEST=power_menu_button_browsertest Review URL: http://codereview.chromium.org/1338003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42695 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 42656 - Add a Pepper audio basic functionality unit test.skerner@chromium.org2010-03-256-48/+9
| | | | | | | | | | | Also changed TestSink to be derived from IPC::Channel and made MockRenderThread service AddFilter/RemoveFilter, so that it can be used by MessageFilters. Review URL: http://codereview.chromium.org/1207005 TBR=neb@chromium.org Review URL: http://codereview.chromium.org/1344003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42692 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting this CL to see if this fixes chrome frame unit test failures.ananta@chromium.org2010-03-254-23/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Revert 42684 - Implements IDeleteBrowsing history and moves the GCF profile into the IE TIF directory for nonpriv mode users on IE < 8. Implementation notes: Earlier work enabled InPrivate browsing detection and mapped it to creation of an incognito profile instance.Privacy features and how they operate with this change: "Delete Browsing History": IE 6 & 7: all history (including databases) is deleted if cache is cleared *WITHOUT* an active Chrome process holding references to the profile resources. If GCF is rendering a page when the cache is cleared, history *WILL NOT* be deleted on the GCF side, however GCF will continue to operate and IE will remove all other history artifacts as usual. IE 8: GCF cache is cleared in alignment with the options specified by the user. Clearing Temporary Internet Files may destroy the profile entirely, and so we need to consider not moving the GCF profile on IE 8. "InPrivate Filtering": IE 8 (only): more testing required. "InPrivate Browsing": IE 8 (only): pages rendered in GCF *after* entering InPrivate mode are not persisted to disk (use an incognito wrapper on the specified profile). Currently displayed pages are not effected by the switch, although refreshing them will invoke the new behavior. Generally speaking, BHO's are disabled by IE 8 while in InPrivate mode, so entering this state is wonky to begin with but we handle it as well as can be expected. BUG=22846 TEST=On IE 8, clear the cache entirely, note GCF entries in DbgView (better tests coming) Review URL: http://codereview.chromium.org/858003 TBR=slightlyoff@chromium.org Review URL: http://codereview.chromium.org/1353002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42691 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "linux: turn on -Wextra"evan@chromium.org2010-03-251-1/+1
| | | | | | | | Compiled locally and on trybots but failed on builder?! This reverts commit r42688. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42689 0039d316-1c4b-4281-b951-d872f2087c98
* linux: turn on -Wextraevan@chromium.org2010-03-251-1/+1
| | | | | | | | | | | | This is a followup to an earlier change (r38266) which did most of the warning-related cleanup. This one just flips the flag, and fixes some new warnings that crept in during the window while the flag was off. BUG=34160 Review URL: http://codereview.chromium.org/597023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42688 0039d316-1c4b-4281-b951-d872f2087c98
* Updating Chrome's localized strings from the translation console. These ↵robertshield@chromium.org2010-03-2551-478/+140
| | | | | | | | | | strings are generated from checked in .grds from revision 42543. BUG=24305 Review URL: http://codereview.chromium.org/1361001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42685 0039d316-1c4b-4281-b951-d872f2087c98
* Implements IDeleteBrowsing history and moves the GCF profile into the IE TIF ↵slightlyoff@chromium.org2010-03-254-3/+23
| | | | | | | | | | | | | | | | | | | | | | | | | | | | directory for non-priv mode users on IE < 8. Implementation notes: Earlier work enabled InPrivate browsing detection and mapped it to creation of an incognito profile instance.Privacy features and how they operate with this change: "Delete Browsing History": IE 6 & 7: all history (including databases) is deleted if cache is cleared *WITHOUT* an active Chrome process holding references to the profile resources. If GCF is rendering a page when the cache is cleared, history *WILL NOT* be deleted on the GCF side, however GCF will continue to operate and IE will remove all other history artifacts as usual. IE 8: GCF cache is cleared in alignment with the options specified by the user. Clearing Temporary Internet Files may destroy the profile entirely, and so we need to consider not moving the GCF profile on IE 8. "InPrivate Filtering": IE 8 (only): more testing required. "InPrivate Browsing": IE 8 (only): pages rendered in GCF *after* entering InPrivate mode are not persisted to disk (use an incognito wrapper on the specified profile). Currently displayed pages are not effected by the switch, although refreshing them will invoke the new behavior. Generally speaking, BHO's are disabled by IE 8 while in InPrivate mode, so entering this state is wonky to begin with but we handle it as well as can be expected. BUG=22846 TEST=On IE 8, clear the cache entirely, note GCF entries in DbgView (better tests coming) Review URL: http://codereview.chromium.org/858003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42684 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 42570 - Move the installer result enum to the bottomcpu@chromium.org2010-03-251-4/+2
| | | | | | | | | | | | | | | | | it appears that some rely on these numbers, like the help center, sigh BUG=38927 TEST=none TBR=mal Review URL: http://codereview.chromium.org/1323002 TBR=cpu@chromium.org Review URL: http://codereview.chromium.org/1362002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42680 0039d316-1c4b-4281-b951-d872f2087c98
* Calling OpenGL from the renderer processapatrick@chromium.org2010-03-2529-189/+431
| | | | | | | | | | | | | | - Added ability for renderer processes to render to a real window (Windows only so far). - Added ability to create offscreen frame buffer objects that can be resized later. - OpenGL context can have a "parent" context that can access its last swapped back buffer through a texture ID. - Moved code to establish GPU channel from RenderWidget to RenderThread. - Changed way service size command buffer object lifetimes are managed. TEST=trybot and visual verification that OpenGL can clear the browser window to magenta. BUG=none Review URL: http://codereview.chromium.org/1136006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42679 0039d316-1c4b-4281-b951-d872f2087c98
* Clean up read FDs in async network alive. This prevents chrome from eating ↵zork@chromium.org2010-03-251-1/+17
| | | | | | | | | | | all FDs. BUG=35229 TEST=Let Chrome idle with a flakey net connection, and check that the number of open FDs is not increasing. Review URL: http://codereview.chromium.org/1336004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42678 0039d316-1c4b-4281-b951-d872f2087c98
* Adding a chrome crash which occurs in chrome frame reliability test runs to ↵ananta@chromium.org2010-03-251-0/+4
| | | | | | | | | | the known crashes list. Bug=39356 Review URL: http://codereview.chromium.org/1340002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42676 0039d316-1c4b-4281-b951-d872f2087c98
* Temporary stuff for internal plugins, part 1.viettrungluu@chromium.org2010-03-259-5/+52
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/1320002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42674 0039d316-1c4b-4281-b951-d872f2087c98
* Add a basic FileBrowseUI browser test to verify <input type=file..> would ↵xiyuan@chromium.org2010-03-253-1/+160
| | | | | | | | | | | | bring up FileBrowseUI. <http://crosbugs.com/2056> BUG=none TEST=none Review URL: http://codereview.chromium.org/1315003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42672 0039d316-1c4b-4281-b951-d872f2087c98
* Re-land 42631: The problem was that notifications aren't implemented on ↵aa@chromium.org2010-03-2518-26/+176
| | | | | | | | linux/views yet. TBR=rafaelw@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42671 0039d316-1c4b-4281-b951-d872f2087c98
* Convert tab to app after user clicks "create" button per issue 27905.xiyuan@chromium.org2010-03-253-26/+22
| | | | | | | | | BUG=27905 TEST=Verify fix for 27095. Review URL: http://codereview.chromium.org/1351001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42670 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 42665 - broke build as I missed a unit test when building locally.joth@chromium.org2010-03-254-158/+27
| | | | | | | | | | | | | | | | | | | | Adds geolocaiton support to the location bar content image model and content bubble model. Most of these edits were lifted out of http://codereview.chromium.org/650180 TODO: add geolocation support to the views in the three UI platforms for the bubble model. (NOTE this change results in poorly formed bubble contents for the geolocaiton bubble, this will be fixed up in the following CLs) BUG=11246 TEST=open a site that uses geolocaiton, select allow/deny & click the icon. Review URL: http://codereview.chromium.org/1344002 TBR=joth@chromium.org Review URL: http://codereview.chromium.org/1367002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42668 0039d316-1c4b-4281-b951-d872f2087c98
* Removes exception for reliability crash as it doesn't appear to besky@chromium.org2010-03-251-3/+0
| | | | | | | | | | happnening anymore. BUG=23138 TEST=none Review URL: http://codereview.chromium.org/1338002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42666 0039d316-1c4b-4281-b951-d872f2087c98
* Adds geolocaiton support to the location bar content image model and content ↵joth@chromium.org2010-03-254-27/+158
| | | | | | | | | | | | | | | | | | bubble model. Most of these edits were lifted out of http://codereview.chromium.org/650180 TODO: add geolocation support to the views in the three UI platforms for the bubble model. (NOTE this change results in poorly formed bubble contents for the geolocaiton bubble, this will be fixed up in the following CLs) BUG=11246 TEST=open a site that uses geolocaiton, select allow/deny & click the icon. Review URL: http://codereview.chromium.org/1344002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42665 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Notifications shouldn't crash when gtk notification is destroyed.erg@chromium.org2010-03-252-31/+32
| | | | | | | | | | | (Use callbacks, while I'm at it.) BUG=34515 TEST=none Review URL: http://codereview.chromium.org/1372001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42664 0039d316-1c4b-4281-b951-d872f2087c98
* A pretty lame initial UITest for bookmark manager.arv@chromium.org2010-03-253-1/+104
| | | | | | | | | | BUG=None TEST=ui_test.exe --gtest_filter=BookmarksUITest.* Review URL: http://codereview.chromium.org/1292002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42663 0039d316-1c4b-4281-b951-d872f2087c98
* Register internal plugins and fix internal plugins path for Mac tests.viettrungluu@chromium.org2010-03-252-8/+17
| | | | | | | | | | | Fixed version of r42646 which was reverted at r42653. BUG=none TEST=none (but Gears should continue working on Windows) Review URL: http://codereview.chromium.org/1349004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42661 0039d316-1c4b-4281-b951-d872f2087c98
* Workaround for I915 graphics cards which have horrible GL shader support.scherkus@chromium.org2010-03-252-0/+19
| | | | | | | | | | | | | | Summary: - GLEW doesn't load the GL shader functions, so we have to load them ourselves - Replace our varying vec2 with glTexCoord[0].st - Replace our uniform mat3 with manual matrix multiplication BUG=33329 TEST=try it out on anything with an I915 Review URL: http://codereview.chromium.org/1219006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42659 0039d316-1c4b-4281-b951-d872f2087c98
* Remove languages tab from Mac, because languages are set in the System ↵mirandac@chromium.org2010-03-253-831/+738
| | | | | | | | | | | | Preferences. Nib changes: Change the "fonts and languages" string to refer to "fonts" only. Remove the "languages" tab from the "fonts and languages" xib. BUG= 39008 TEST= open preferences in Mac. see no reference to languages in "Under the Hood". Review URL: http://codereview.chromium.org/1306002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42657 0039d316-1c4b-4281-b951-d872f2087c98
* Add a Pepper audio basic functionality unit test.neb@chromium.org2010-03-256-9/+48
| | | | | | | | Also changed TestSink to be derived from IPC::Channel and made MockRenderThread service AddFilter/RemoveFilter, so that it can be used by MessageFilters. Review URL: http://codereview.chromium.org/1207005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42656 0039d316-1c4b-4281-b951-d872f2087c98
* Remove Oriya from the list of UI languages for now because we're not getting ↵jshin@chromium.org2010-03-2516-1048/+0
| | | | | | | | | | | | Oriya translation updated any more. BUG=37562 TEST=On Windows, 'chrome --lang=or' will bring up English Chrome. Review URL: http://codereview.chromium.org/1144001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42655 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Clean up visual appearance of HTML5 notifications.erg@chromium.org2010-03-252-47/+27
| | | | | | | | | | | All widgets are now displayed and the notification has a curved border. BUG=34514 TEST=none Review URL: http://codereview.chromium.org/1247005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42654 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 42646 - Register internal plugins.viettrungluu@chromium.org2010-03-251-7/+3
| | | | | | | | | | | | BUG=none TEST=none (but Gears should continue working on Windows) Review URL: http://codereview.chromium.org/1336002 TBR=viettrungluu@chromium.org Review URL: http://codereview.chromium.org/1355002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42653 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Allow double clicking on an exception to open the edit dialog.erg@chromium.org2010-03-252-17/+22
| | | | | | | | | BUG=38349 TEST=none Review URL: http://codereview.chromium.org/1320001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42652 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the disable metrics command line flag, which is no longer used forbrettw@chromium.org2010-03-252-5/+0
| | | | | | | | | | | | | | anything. This flag was leftover from initial product development when there was no opt-in preference for enabling the metrics service. The only user was a ChromeFrame unit test which I modified to use a different one that has the same effect. BUG=none TEST=none Review URL: http://codereview.chromium.org/1290004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42651 0039d316-1c4b-4281-b951-d872f2087c98
* Basic change correcting the coordinate space of the reference anchor point ↵twiz@chromium.org2010-03-251-7/+6
| | | | | | | | | | | | | for the extension popup API when using borderStyle=rectangle. I will submit a follow-up CL containing tests that will catch future regressions on the positioning of the pop-up. BUG=39235 TEST=None Review URL: http://codereview.chromium.org/1217009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42650 0039d316-1c4b-4281-b951-d872f2087c98