| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
object goes out of scope.
The control flow was as follows:
1. user initiates a save page command
2. user initiates a second save page command
3. tab contents creates a SavePackage, shows dialog
4. tab contents gets second OnSavePage, deletes old SavePackage, which deletes its SelectFileDialogImpl
5. At this point two dialogs are visible.
6. User dismisses second dialog.
7. User dismisses first dialog, and calls us back with pointer to freed SelectFileDialogImpl.
8. Bad stuff.
BUG=23817
TEST=I put a sleep in Browser::SavePage, then hit ctrl+s twice quickly. Only one dialog appeared.
Review URL: http://codereview.chromium.org/243117
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28213 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=unit_tests compiles with views.
Review URL: http://codereview.chromium.org/255102
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28211 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
which failed on XP Perf (single).
This reverts commit r28199.
TBR=tony
Review URL: http://codereview.chromium.org/265002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28209 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Remove unused kernel scoped unlock.
BUG=19895
TEST=Existing unit tests
Review URL: http://codereview.chromium.org/246097
TBR=chron@chromium.org
Review URL: http://codereview.chromium.org/265001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28208 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=23043
TBR=senorblanco
Review URL: http://codereview.chromium.org/242169
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28204 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=erikkay
Review URL: http://codereview.chromium.org/258040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28202 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
TabContents sends a notification which is picked up by the browser
automation controller which keeps a map of events and times. Add
an automation IPC so that tests can get these values from the
browser automation controller. Finally, add a feature startup test
to collect these values.
This is just to get some consistent timings from the buildbot.
BUG=23120
Review URL: http://codereview.chromium.org/246105
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28199 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Remove unused kernel scoped unlock.
BUG=19895
TEST=Existing unit tests
Review URL: http://codereview.chromium.org/246097
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28198 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG= http://crbug.com/22727
TEST= Set preferred language to a different setting from the locale in the OS X system settings.
Make sure that the language of the tips matches the language setting (which
should be the same as that of the Chrome UI). If tips are not available in
the Chrome UI language, no tips should be shown.
Review URL: http://codereview.chromium.org/258037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28193 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Also fixed min size of the browser to take into account the browser actions.
BUG-23924
TESTS=Open Chrome with --bookmark-menu and make sure browser actions you install appear to the left. Also, resize the browser horizontally and make sure it always shows all the controls in the chrome (from Back to App menu).
Review URL: http://codereview.chromium.org/246102
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28191 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BrowserActionsContainer is the child view of ToolBarView. When BrowserActionsContainer gets notification for LOAD/UNLOAD, it needs to re-layout ToolBarView, its parent.
BUG=23381
TEST=none
Review URL: http://codereview.chromium.org/246107
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28190 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=no
TEST=no
Review URL: http://codereview.chromium.org/242168
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28189 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
popup.
BUG=23833,23835
TEST=none
Review URL: http://codereview.chromium.org/259065
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28187 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Shows a Gmail logo with a strike out diagonal line when not logged in.
- Allows the user to click on the BrowserAction to log in.
- If there are unread emails on login, the GMail logo blinks.
- Shows the number of unread emails as a Badge (red in color!).
- Shows the number of unread emails as a tooltip text if hovered on.
- When a new email comes, the GMail logo blinks and the badge text updates.
BUG=23898
TEST=none
Review URL: http://codereview.chromium.org/246093
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28183 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=23458
TEST=Load an extension with a toolstrip. The toolstrip's background should match the shelf's background for your theme.
Review URL: http://codereview.chromium.org/243114
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28177 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
The new tab times didn't change on linux/mac so that's probably
not the problem. This will speed up the new tab tests.
Review URL: http://codereview.chromium.org/256083
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28175 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
spot fix--a comprehensive fix will require
http://code.google.com/p/chromium/issues/detail?id=23571
BUG=23774
TEST=upload a file via Flash (example: Gmail, YouTube). The browser should not crash
after you click "OK" to dismiss the file picker.
Review URL: http://codereview.chromium.org/242161
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28158 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
TBR=aa
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28151 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=23976
Review URL: http://codereview.chromium.org/257064
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28149 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=ananta
BUG=23713, 23706
Review URL: http://codereview.chromium.org/251105
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28147 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=http://crbug.com/15546
TEST=try to use an external protocol; it should put up a dialog
Review URL: http://codereview.chromium.org/256065
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28145 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
CID=6309
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/243103
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28144 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
CID=6384
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/260010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28143 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
to the renderer so this instance is in the callstack, destruction will have to be asynchronous and so scripting still won't work. This change also fixes use of PluginChannel after it's deleted (if this was the last instance).
BUG=23713, 23706
TEST=added ui test
Review URL: http://codereview.chromium.org/258026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28141 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
To fix it, a change needs to be made in V8.
BUG=23768
TEST=none
Review URL: http://codereview.chromium.org/256082
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28140 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/242157
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28139 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=23269
TEST=load the test_browser_action sample extension, and click the browser action. Watch it dynamically update.
Review URL: http://codereview.chromium.org/242150
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28136 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
More details here: http://code.google.com/p/chromium/issues/detail?id=23385
Review URL: http://codereview.chromium.org/259031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28134 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/243105
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28131 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This allows us to pass binary values through extension requests. I use this in
my next CL to pass SkBitmaps.
BUG=23269
TEST=no
Review URL: http://codereview.chromium.org/251093
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28130 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I'm seeing ~DOMView happen after NativeViewHost::Detach has already been
done as part of WM_DESTROY.
BUG=20339
TEST=cancel the sync login dialog and create app shortcuts dialogs.
Review URL: http://codereview.chromium.org/258028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28129 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=23136
TEST=None
Review URL: http://codereview.chromium.org/255091
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28127 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Nib file changes:
- Changed resize flags to pin the bookmark bar a fixed distance from the top of the window, not the bottom.
BUG=23949
TEST=Resize the window, make sure the bookmark bar resizes correctly.
Review URL: http://codereview.chromium.org/256078
Patch from rohitaro@chromium.org.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28121 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=23834
TEST=none
Review URL: http://codereview.chromium.org/257048
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28119 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=brettw
Review URL: http://codereview.chromium.org/257062
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28118 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Refactor ImporterHost as preparation for OOPprofile import.
ImporterHost currently requires substantial infrastructure in order to run which we don't need or can't have in a utility process.
This change splits ImporterHost into a couple of subclasses so that the profile import process can remain light weight and doesn't need to initialize Profile, etc.
ImporterList: Manages the list of importers, this class will allow the utility process to locate and instantiate an importer without initializing the world.
ImprterBridge/InProcessImporterBridge: Provides an abstract interface for the importers to interact with the rest of the App. The idea is to stick the IPC boundary in using this interface.
There may still be some rough spots in the separation (e.g. Firefox locking and surrounding UI) but I'll sort those out in a followup CL that makes the OOP stuff work. For now I'm trying to keep these CLs as small as I can.
BUG=14458
TEST=Profile import should continue to work on Windows/Linux & Mac.
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=27996
Review URL: http://codereview.chromium.org/242091
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28117 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
in odd text colors in the Omnibox when typing.
BUG=none
TEST=Visit m/, then type a letter into the omnibox and make sure it's black.
Review URL: http://codereview.chromium.org/259054
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28116 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=23832
TBR=mpcomplete
Review URL: http://codereview.chromium.org/257056
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28115 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Update installer files so that they don't reference syncapi.dll. Add a
reference to iphlpapi, and make it and pthreads lazy-loaded.
BUG=23609
TEST=interactive testing of two sync clients with notifications.
Review URL: http://codereview.chromium.org/242118
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28112 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=brettw
Review URL: http://codereview.chromium.org/255088
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28111 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
If the renderer tells the browser to close a window, we no longer
run the unload events, because the renderer already has.
BUG=11647
TEST=BrowserTest.SingleBeforeUnloadAfterWindowClose
Review URL: http://codereview.chromium.org/246080
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28110 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28107 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Update the code to pull the omnibox images from the pak files instead.
TEST=Omnibox still has all the right images next to the things it lists
BUG=20230
Review URL: http://codereview.chromium.org/246101
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28104 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28100 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/243107
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28099 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28098 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Next step: enable ones that should work, but (for some reason) don't.
TEST=It runs.
BUG=none
Review URL: http://codereview.chromium.org/256070
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28097 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
of incrementing a static counter.
BUG=21281
TEST=Load an unpacked extension from chrome://extensions/ that
does not have an ID in its manifest. The resulting ID should
be random-looking, not something like "aaaaaa".
Review URL: http://codereview.chromium.org/256049
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28095 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=12497
TEST=none
Review URL: http://codereview.chromium.org/255075
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28093 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
in app_controller_mac.mm, under the assumption we're either already
the foreground app or should become the foreground mac
(when created from the dock menu).
BUG=22595
TEST="New Window" or "New Incognito Window" from dock menu with other app in foreground
Review URL: http://codereview.chromium.org/256054
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28091 0039d316-1c4b-4281-b951-d872f2087c98
|