| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL requires a patch to webkit to compile. That patch is tracked here:
https://bugs.webkit.org/show_bug.cgi?id=35257
This CL makes a change on Mac and Linux. Windows will follow in a sepperate change.
BUG=30247
TEST=Manual testing using the test case attached to the bug and the sample extensions.
Review URL: http://codereview.chromium.org/657012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40036 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=36630
TEST=many worker ui_tests
Review URL: http://codereview.chromium.org/660094
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40035 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Infobars.xib changes - Connect and fix class for close button since the translate infobar needs to know where it is to position the "Options" menu to it's left.
BUG=34466
TEST=Translate infobars should continue to workon Windows.
Review URL: http://codereview.chromium.org/594056
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40034 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
correctly:-
it was waiting for the initial polling policy interval before making the initial scan, on windows this means a 10s latency in getting first fix, but on mac this was creating a 2min latency.
Adds detailed logging for the mac wifi data provider as this is the easiest way to debug on Mac it seems.
BUG=none
TEST=run browser with --enable-geolocation. open maps.google.com & click my location dot.
Review URL: http://codereview.chromium.org/661084
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40032 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/660083
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40027 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
be fixed.
BUG=http://crbug.com/36485
TEST=none; marking things to be fixed
Review URL: http://codereview.chromium.org/661047
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40026 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=36800
TEST=XP and Vista UI Tests
Review URL: http://codereview.chromium.org/661082
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40025 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Moves the implementation of cookie methods in RendererWebKitClientImpl
into RendererWebCookieJarImpl.
Moves the implementation of cookie methods in TestShellWebKitInit into
SimpleWebCookieJarImpl.
This leaves us with no longer implementing the cookie methods on
WebKitClient. That'll allow us to delete those.
WebPluginImpl needs to access the WebCookieJar used by either the
renderer or test_shell. To enable that, I added a GetCookieJar method
on WebPluginPageDelegate. This interface is used whenever the
WebPluginImpl needs to talk to the RenderView or TestWebViewDelegate.
R=jorlow
BUG=35589
Review URL: http://codereview.chromium.org/661070
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40023 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40020 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
The previous code forced a dialog size, but what we really
want is to just set the minimum size.
BUG=36723
TEST=pt_BR dialogs look ok, de_DE dialogs are still wide
Review URL: http://codereview.chromium.org/660079
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40015 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
'experimental' in the permissions section of its manifest file, if
--enable-experimental-extension-apis was provided to Chrome on the
command line.
BUG=36702
TEST=as per repro in bug 36702
Review URL: http://codereview.chromium.org/661013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40014 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Patch from Daniel Clifford <danno@google.com>.
Review URL: http://codereview.chromium.org/661077
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40013 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40008 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=36770
TEST=Memory Waterfall should become greener
Review URL: http://codereview.chromium.org/660075
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40005 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Pulls in the custom header file uesd to access these functions in gears
BUG=11246
TEST=unit_tests.exe --gtest_filer=Geoloc*
Review URL: http://codereview.chromium.org/600146
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40004 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Move the buttons to the right to improve the balance of the window.
Review URL: http://codereview.chromium.org/652230
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40001 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When merging in GTMTheme/ThemeProvider changes I missed one. Adding
in a patch to make correct since the "half converted" state makes the
code unhappy.
Error was seen as bookmark bar folder windows with themed text but NOT
with a themed background.
Review URL: http://codereview.chromium.org/660071
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40000 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
to terminate their thread when the IPC channel fails.
Usually, the ChildThread::OnChannelError() simply kills the message loop. we want to give workers
an opportunity to get out of their threads to avoid crashes when main thread destroys globals.
BUG=35963
TEST=WorkerTest.StressJSExecution
Review URL: http://codereview.chromium.org/647064"
Revert r39997 - Attempted Fix - "Fix a conditional jump depending on an uninitialized value by setting it to false in the ctor."
TBR=dimich
BUG=none
TEST=Valgrind
Review URL: http://codereview.chromium.org/661068
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39999 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
address on an interface
This currently only works on Posix, not windows.
Network changes are monitored, and the test is repeated each time interfaces
change (which is a subset of any IP addresses changing).
The test performed is still relatively low latency, and we *may* need
to eventually move to an high latency test, such as a DNS resolution,
or an actual test connection. If we move in that direction, then we'll
need to post a task to perform the work, rather than immediately returning.
BUG=25680
BUG=12754
r=wtc,eroman
Review URL: http://codereview.chromium.org/652072
TBR=jar@chromium.org
Review URL: http://codereview.chromium.org/660073
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39998 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
setting it to false in the ctor.
TBR=dimich
BUG=none
TEST=Linux, Mac, and ChromiumOS valgrind UI tests
Review URL: http://codereview.chromium.org/661065
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39997 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This currently only works on Posix, not windows.
Network changes are monitored, and the test is repeated each time interfaces
change (which is a subset of any IP addresses changing).
The test performed is still relatively low latency, and we *may* need
to eventually move to an high latency test, such as a DNS resolution,
or an actual test connection. If we move in that direction, then we'll
need to post a task to perform the work, rather than immediately returning.
BUG=25680
BUG=12754
r=wtc,eroman
Review URL: http://codereview.chromium.org/652072
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39996 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Fix valgrind by changing destructor order.
2nd item, parentBarController, references objects in 1st item, helper_.
Review URL: http://codereview.chromium.org/660070
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39992 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=33196
TEST=Go to http://webkit.org/misc/DatabaseExample.html. Open cookie manager and find entry for webkit.org. See database icon.
TEST=Go to http://demos.hacks.mozilla.org/openweb/todo/ and repeat above steps. Same icon.
Review URL: http://codereview.chromium.org/661064
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39990 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=33221 Keyboard shortcuts doesn't work on extension bubble popups
TEST=Open an extension popup with a text box in it, then try to copy/paste text in the text box with cmd-c/v.
Review URL: http://codereview.chromium.org/654005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39989 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
constrained window.
Since this pushes the SetVisuallyDeemphasized call into TabContents, it should also cover linux/views.
BUG=32399
TEST=see bug (http auth)
Review URL: http://codereview.chromium.org/650184
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39987 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
to autofill username/password forms.
BUG=none
TEST=FormStructureTest
TEST=log in to gmail. AutoFill infobar should not show up.
Review URL: http://codereview.chromium.org/661026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39985 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Fixed build problem with database_tracker.(cc|h).
BUG=36590
Review URL: http://codereview.chromium.org/660039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39983 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Has been flaky on windows
TBR=markus
Review URL: http://codereview.chromium.org/660064
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39982 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change introduces a new interface/class called DataTypeManager whose job is to choreograph the start up and shut down of all registered data types. It starts each data type serially, waiting for each data type to finish starting before starting the next one. If anything goes wrong on startup, all data types are stopped.
Note that this change also simplifies the ProfileSyncServiceStartupTest as many of the cases it tested for are now the responsibility of the DataTypeManagerImpl (and these are thoroughly tested in its unit test).
I also killed off the TestProfileSyncFactory in the ProfileSyncServiceTest since it was lame and could be done with the mock.
BUG=36506
Review URL: http://codereview.chromium.org/650175
TBR=skrul@chromium.org
Review URL: http://codereview.chromium.org/661053
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39977 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/660049
TBR=skrul@chromium.org
Review URL: http://codereview.chromium.org/661052
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39976 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=markus
BUG=36630
TEST=none
Review URL: http://codereview.chromium.org/661049
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39974 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/660049
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39966 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=36334
TEST=none
Review URL: http://codereview.chromium.org/661030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39965 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change introduces a new interface/class called DataTypeManager whose job is to choreograph the start up and shut down of all registered data types. It starts each data type serially, waiting for each data type to finish starting before starting the next one. If anything goes wrong on startup, all data types are stopped.
Note that this change also simplifies the ProfileSyncServiceStartupTest as many of the cases it tested for are now the responsibility of the DataTypeManagerImpl (and these are thoroughly tested in its unit test).
I also killed off the TestProfileSyncFactory in the ProfileSyncServiceTest since it was lame and could be done with the mock.
BUG=36506
Review URL: http://codereview.chromium.org/650175
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39964 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Issue 32106 happens when user creates a browser window without creating
desktop shortcut. In this case, Windows does not have sufficient
relaunching info to support pinning the browser window. The fix is to
create a shortcut in "User Pinned" folder which Win7 watches and would
get relaunch info from it.
Also fix a minor bug in win_util::SetAppIdForWindow that would make the
function only work for Win7 but not above.
BUG=32106
TEST=Verify fix for 32106. See comemnts #1 and #5 for repro steps.
Review URL: http://codereview.chromium.org/660038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39963 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
process if we actually fail to execute JavaScript. Previously, we were sending the notification whenever WebKit queried us about whether JavaScript was enabled (which happens for every frame, regardless of whether that frame actually tries to execute JavaScript).
BUG=36094
TEST=Disable JavaScript in the UI and then load about:blank
Review URL: http://codereview.chromium.org/660033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39962 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This adds a simple browsertest that sanity checks that WebSockets can be opened and used from extension processes.
BUG=NONE
TEST=NONE
Review URL: http://codereview.chromium.org/660011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39961 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This new method will replace existing autofill entries with the list provided as the argument. Provided entries that don't exist are added.
BUG=36713
Review URL: http://codereview.chromium.org/660023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39959 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=36736
TEST=None
Review URL: http://codereview.chromium.org/660045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39958 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=31911
Review URL: http://codereview.chromium.org/638001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39957 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=34811
TEST=none
Review URL: http://codereview.chromium.org/661034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39955 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=36107
TEST=see bug.
Review URL: http://codereview.chromium.org/661025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39953 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
IPC channel fails.
Usually, the ChildThread::OnChannelError() simply kills the message loop. we want to give workers
an opportunity to get out of their threads to avoid crashes when main thread destroys globals.
BUG=35963
TEST=WorkerTest.StressJSExecution
Review URL: http://codereview.chromium.org/647064
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39951 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=Open Activity Monitor, and visit a page with a plugin. The plugin process should show the name of the plugin.
Review URL: http://codereview.chromium.org/659007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39950 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
- Rename nss_decryptor_linux to nss_decryptor_posix as it's more appropriate
Review URL: http://codereview.chromium.org/656012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39949 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=36091
TEST=Start Chrome in Hebrew, click upper left corner, no sysmenu should appear.
Review URL: http://codereview.chromium.org/661033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39948 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Full behavior: http://JRG_WRITE_FULL_DOC_AND_TEST_PLAN_TOMORROW
BUG=17608 (and a slew of others)
Brief details on how to test:
- add some bookmarks and bookmark folders.
- at a basic level, make sure bookmark folders feel like menus e.g.
-- click to open
-- can open "submenus" and sub-sub-menus
-- can open (click on) bookmarks in any of these submenus
- click-drag does NOT open a menu (different than Mac menus); it initiates a Drag
- click on folder in bookmark bar initiates "hover open"; moving mouse
over other folders will pop them open immediately (much like Mac menus)
- Bookmark bar non-drag hover-open is immediate, but bookmark folder
hover-open has a brief delay so quick "move down" a folder does not
trigger them all to open while you travel (much like Mac menus).
- DnD of bookmarks and folders on bookmark bar.
- While doing DnD of bookmark, "hover" over a folder and see it open.
- Bookmark folder menus have normal DnD "drop indicators" like the bookmark bar.
- Can "hover open" a nested subfolder.
- Can drag a bookmark from one deep sub-sub-folder to a different deep one.
- Confirm buttons and folders in submenus are themed, both with the
theme set at launch time and the theme we change to after launch.
- Empty folders have an "(empty)" item which is not selectable.
- Intentional delay in closing a sub-sub-folder when hovering over
another one. E.g. When moving to a sub-sub-menu, 'brief' travel
over a different submenu does not close the destination sub-menu.
- can use bookmark context menus in folder "menus".
- confirm DnD from "Other bookmarks" to any other random folder and
vice versa.
- While non-drag hover open is active, clicking anywhere other than
the bookmark bar or folder (e.g. the main web view) turns it off.
TODO:
- random bugs (e.g. "add folder" over a folder doesn't put it in there)
- (empty) needs to be revisited, both visually and for a drop indication
- core animations instead of drop indicators
- ...
Review URL: http://codereview.chromium.org/551226
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39947 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Started failing after WebKit update picked up
http://trac.webkit.org/changeset/55180/
BUG=36630
TBR=dimich@chromium.org
Review URL: http://codereview.chromium.org/660037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39946 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fix up observer list so we can use FOR_EACH_OBSERVER when check_empty is set.
Clean up the ObserverList API a bit, replacing GetElementAt() with HasObserver() and Clear().
BUG=36590
Review URL: http://codereview.chromium.org/652205
TBR=willchan@chromium.org
Review URL: http://codereview.chromium.org/661029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39945 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=36691
Review URL: http://codereview.chromium.org/660007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39943 0039d316-1c4b-4281-b951-d872f2087c98
|