summaryrefslogtreecommitdiffstats
path: root/chrome
Commit message (Collapse)AuthorAgeFilesLines
* Mark a layout tests as crash/pass; disable two crashing UI tests.senorblanco@chromium.org2009-08-071-2/+4
| | | | | | | | | BUG=http://crbug.com/18784,http://crbug.com/18786 TEST=less redness == more goodness TBR=tim git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22768 0039d316-1c4b-4281-b951-d872f2087c98
* Move some Mac l10n helpers out into app/l10n so they are closer to the ↵thomasvl@chromium.org2009-08-075-83/+6
| | | | | | | | | | | | | generic ones. Complete the apis points so the ones folks might need are all there already. Switch the code using the old calls over to the new helpers. TEST=no l10n stuff broke BUG=none Review URL: http://codereview.chromium.org/165132 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22753 0039d316-1c4b-4281-b951-d872f2087c98
* In app windows, fallback to the product icon if there's no site favicon.tc@google.com2009-08-071-2/+6
| | | | | | | | | | TEST=Open the web inspector. When it finishes loading, it should show the chromium icon instead of the last frame of the throbber. Review URL: http://codereview.chromium.org/164159 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22747 0039d316-1c4b-4281-b951-d872f2087c98
* Add a new net::Error value: ERR_CONNECTION_TIMED_OUT.willchan@chromium.org2009-08-072-3/+9
| | | | | | | | | TEST=net_unittests BUG=none Review URL: http://codereview.chromium.org/159904 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22746 0039d316-1c4b-4281-b951-d872f2087c98
* Add module-level permissions to extensions.mpcomplete@chromium.org2009-08-0721-53/+246
| | | | | | | | | | | | | | This first pass is fairly simple. If a permission is not specified in the manifest, the corresponding module will not be exposed to script. For example, without specifying the "tabs" permission, chrome.tabs and chrome.windows will not be available. BUG=12140 TEST=no Review URL: http://codereview.chromium.org/164039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22745 0039d316-1c4b-4281-b951-d872f2087c98
* Fix some issues with bookmark bar folder menu.estade@chromium.org2009-08-071-11/+32
| | | | | | | | | | | | Without this patch, you have to click repeatedly on a folder to get the context menu to pop up, because the first few clicks dismiss whatever submenus you may have open. This patch fixes that. There is another problem present with and without this patch where a bookmark bar folder menu that has shown a context menu will not regain the application/X grabs. This makes it possible to use the rest of the browser while the menu is showing, and clicking away from the menu won't dismiss the menu. In the interests of keeping this patch easy to review I will look into that issue separately. BUG=18275 Review URL: http://codereview.chromium.org/165138 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22743 0039d316-1c4b-4281-b951-d872f2087c98
* Move the sync options group from "user Data" tab to "Personal Stuff" tab and ↵munjal@chromium.org2009-08-078-293/+191
| | | | | | | | | | | remove the "User Data" tab. BUG=none TEST=none Review URL: http://codereview.chromium.org/165105 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22742 0039d316-1c4b-4281-b951-d872f2087c98
* Finish adding l10n constants for the menu items i didn't do before.thomasvl@chromium.org2009-08-072-80/+152
| | | | | | | | TEST=Nothing really until the new constants are translated BUG=none Review URL: http://codereview.chromium.org/165137 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22741 0039d316-1c4b-4281-b951-d872f2087c98
* Implement back/forward toolbar menus on Mac (bug 13203).avi@chromium.org2009-08-0713-48/+547
| | | | | | | | | | | | | | | | | | | | Note: The drop-down menu is actually a drag-down (activating on click-hold or on drag), working much like Safari's (and other Apple apps, such as Dictionary). This can be changed to a pop-down if that's what's desired. TODO: Show keyboard shortcut for "Show Full History". Patch by viettrungluu. BUG=http://crbug.com/13203 TEST=Navigate around, check out and use the menus; do so in multiple tabs and windows. Review URL: http://codereview.chromium.org/160496 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22740 0039d316-1c4b-4281-b951-d872f2087c98
* Add CSS Keyword values and conversion routines to webkit glue.jeremy@chromium.org2009-08-077-0/+96
| | | | | | Review URL: http://codereview.chromium.org/149044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22737 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a bug where we don't maximize on titlebar double click in KWin.tc@google.com2009-08-072-4/+39
| | | | | | | | | | | | | | | | | | | GTK+ sends the following events on double click: GDK_BUTTON_PRESS GDK_BUTTON_RELEASE GDK_BUTTON_PRESS GDK_2BUTTON_PRESS GDK_BUTTON_RELEASE If we start a gtk_window_begin_move_drag on the second GDK_BUTTON_PRESS, the call to gtk_window_maximize fails. To work around this, we keep track of the last click and if it's going to be a double click, we don't call gtk_window_begin_move_drag. BUG=18401 Review URL: http://codereview.chromium.org/165102 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22736 0039d316-1c4b-4281-b951-d872f2087c98
* Removing unused #include from url_constants.cc.phajdan.jr@chromium.org2009-08-071-3/+0
| | | | | | | | | | | Patch by Thiago Farina, original review: http://codereview.chromium.org/165113 BUG=None TEST=None Review URL: http://codereview.chromium.org/165135 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22733 0039d316-1c4b-4281-b951-d872f2087c98
* Support cntrl-tab to switch tabs on OS X.jeremy@chromium.org2009-08-071-0/+2
| | | | | | | | | BUG=13299 TEST=Cntrl-Tab should switch to the next tab, cntrl-shift-tab should switch to the previous tab. Review URL: http://codereview.chromium.org/164133 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22731 0039d316-1c4b-4281-b951-d872f2087c98
* Deps roll to pull in new GTM.thomasvl@chromium.org2009-08-076-235/+786
| | | | | | | | | | | | | | | | | Bookmark localization (BookmarkBar, BookmarkEditor, and BookmarkNameFolder). Toolbar localization. TabView localization (the tab itself). Bookmark Editor window fixup: Align the labels to the front of the edit fields (ui guidelines). Make the labels auto size to their text and resize the window as needed. Make the buttons auto size to their strings and adjust to stay right pinned. Make the window resize in general correctly. BUG=16764 TEST=Try the Danish local, a bunch of this UI should localized, and the bookmark editor shouldn't truncate the labels or buttons. Review URL: http://codereview.chromium.org/160328 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22730 0039d316-1c4b-4281-b951-d872f2087c98
* Reverts the revert of 22517.rohitrao@chromium.org2009-08-0724-441/+512
| | | | | | | | | | | | | | | | | | | | Rewrites the Mac view resizing logic to have the BrowserWindowController directly resize and relayout its children views. Now when a view needs to be resized, it asks its resize delegate (typically its controller's parent) to perform the resize. BUG=http://crbug.com/17619 TEST=Make sure that views are laid out correctly, even when they change size. Open and close the bookmark bar. Trigger an infobar and then close it. Trigger the download shelf and then close it. Trigger a download shelf with the infobar open, or with the bookmark bar open. Switch to and from fullscreen with various bars open. Resize the browser window with various bars open. Start the browser with and without the bookmark bar open. Try all of the above in a popup window. Review URL: http://codereview.chromium.org/165014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22721 0039d316-1c4b-4281-b951-d872f2087c98
* Add recent crash found by reliability bot to known_crashes.txt.tim@chromium.org2009-08-071-0/+4
| | | | | | | | | | TBR=pkasting BUG=18743 TEST=none Review URL: http://codereview.chromium.org/165116 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22719 0039d316-1c4b-4281-b951-d872f2087c98
* Try to add filters again, this time with proper normalized purify output.tim@chromium.org2009-08-071-113/+113
| | | | | | | | | | | | | | | | | | | | | | Original attempt: http://codereview.chromium.org/165088 RevocableStore- issue 17385 CreateChannel - issue 17979 IPC::Channel::Channel() - issue 17888 SyncChannel::SyncChannel - issue 16128 CreatePipe - issue 18696 ReceivedSyncMsgQueue - issue 8469 OnAddFilter - 18698 IPC::Channel::ChannelImpl::Connect - issue 18699 TBR=pkasting BUG=17385, 17979, 17888, 16128, 18696, 8469, 18698, 18699 TEST=none Review URL: http://codereview.chromium.org/164127 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22715 0039d316-1c4b-4281-b951-d872f2087c98
* Gtk Cookie Manager polish.mattm@chromium.org2009-08-071-1/+7
| | | | | | | | | | Make dialog wider, set first column width to fixed (but resizable), set initial sort order. BUG=17919 Review URL: http://codereview.chromium.org/164125 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22713 0039d316-1c4b-4281-b951-d872f2087c98
* Fix crash on fullscreening of popup.jrg@chromium.org2009-08-073-0/+22
| | | | | | | | | | | | | BUG=http://crbug.com/18551 TEST=Create a pop-up window. Fullscreen it (Cmd-Shift-F). Go back (Cmd-Shift-F again). Repeat a few times across different launches of Chromium. Review URL: http://codereview.chromium.org/164024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22712 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a few bugs with the theme infobar:aa@chromium.org2009-08-076-16/+84
| | | | | | | | | | | | | | * Don't animate the infobar closing and opening when switching between themes. * Don't show multiple infobars when intalling themes in rapid succession. BUG=18213 Review URL: http://codereview.chromium.org/165029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22711 0039d316-1c4b-4281-b951-d872f2087c98
* Porting POINT to gfx::Point.thestig@chromium.org2009-08-072-8/+12
| | | | | | | | | | | Patch from thiago.farnia at gmail.com. Original review url: http://codereview.chromium.org/155888 BUG=none TEST=none Review URL: http://codereview.chromium.org/164121 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22710 0039d316-1c4b-4281-b951-d872f2087c98
* Restore right click on bookmark bar.estade@chromium.org2009-08-071-1/+1
| | | | | | | | it stopped working after r22660 Review URL: http://codereview.chromium.org/165108 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22708 0039d316-1c4b-4281-b951-d872f2087c98
* Buff out Windows & Tabs API, fix a few doc bugs.rafaelw@chromium.org2009-08-079-35/+146
| | | | | | | | | | | | | | This adds callback types, event types, and descriptions for the tabs & windows api. All defined types are loaded first in preparing the template data, so that types can cross reference across apis. Also, additional commentary is added to content_scripts.html doc about communication with the embedding page of a content_script. A check is now made in build.py for the case of the doc page rendering timing out (which is typically a clue that page rendering went wrong and should be inspected with chrome). Review URL: http://codereview.chromium.org/165063 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22706 0039d316-1c4b-4281-b951-d872f2087c98
* Make user data dir deletion optional for InProcessBrowserTests.tim@chromium.org2009-08-072-1/+12
| | | | | | | | | | | | | | Original patch by tejasshah@google.com Original review: http://codereview.chromium.org/159896 TEST=any browser test or live sync test TBR=nick Review URL: http://codereview.chromium.org/164118 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22705 0039d316-1c4b-4281-b951-d872f2087c98
* NNTP: Add a menu item that allows the user to restore all blacklistedarv@google.com2009-08-073-22/+51
| | | | | | | | | | | | | | thumbnails BUG=15247 TEST=Blacklist (remove) a few thumbnails (hit the x on the thumbnail toolbar). Then go to the options menu and "Restore all removed thumbnails". The removed thumbnails should be back. Review URL: http://codereview.chromium.org/165107 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22704 0039d316-1c4b-4281-b951-d872f2087c98
* Set the dangerous download text to the bookmark bar texttc@google.com2009-08-071-0/+3
| | | | | | | | | | color since we already set the shelf to the toolbar background color. Review URL: http://codereview.chromium.org/164116 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22703 0039d316-1c4b-4281-b951-d872f2087c98
* linux: fix windowless Flash when scrollingpiman@chromium.org2009-08-071-0/+6
| | | | | | | | | | | | | Apparently on linux windowless Flash needs a paint after a NPP_SetWindow, otherwise it cancels its timer to do InvalidateRect. Also in this change: WebKit calls WebPluginImpl::setFrameRect at each paint, even if the rects haven't changed. That used to always send a message to the plugin process, which is unnecessary (that case is always a no-op in the WebPluginDelegateImpl), so I fixed that too. BUG=18423 Review URL: http://codereview.chromium.org/159907 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22702 0039d316-1c4b-4281-b951-d872f2087c98
* Changelist for mattm readability review.mattm@chromium.org2009-08-073-157/+187
| | | | | | Review URL: http://codereview.chromium.org/160037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22697 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Change the way to calculate the position of the tab title text.estade@chromium.org2009-08-061-4/+8
| | | | | | | | | | On my machine this doesn't actually change the position, but at least it gets rid of the magic -1. BUG=18555 Review URL: http://codereview.chromium.org/165024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22696 0039d316-1c4b-4281-b951-d872f2087c98
* Add a temporary extension error message box on linux.tc@google.com2009-08-061-2/+4
| | | | | | | | | The NOTREACHED() crashed my debug build. Review URL: http://codereview.chromium.org/164088 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22695 0039d316-1c4b-4281-b951-d872f2087c98
* Relanding r22644, "GTK: Rounded corner on status bubble."erg@google.com2009-08-062-28/+128
| | | | | | | | | | | | | | The previous patch made ui_tests red because we don't always have a GdkWindow when a widget's size-allocate signal is called. Move all responsibility into the expose-event handler. http://crbug.com/18309 Original Review URL: http://codereview.chromium.org/164010 Review URL: http://codereview.chromium.org/164104 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22692 0039d316-1c4b-4281-b951-d872f2087c98
* NNTP: Remove tips and downloads and introduce a recently closed bar instead.arv@google.com2009-08-066-330/+168
| | | | | | | | | | | | | | Make the list mode only show one column and make the items look like links. BUG=None TEST= On the new tab page try opening and closing tabs and windows. The closed tabs and windows should appear in the recently closed bar at the bottom. Review URL: http://codereview.chromium.org/165095 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22691 0039d316-1c4b-4281-b951-d872f2087c98
* Move ClosePage method to WebView.darin@chromium.org2009-08-061-1/+1
| | | | | | | | | | | | Since it is about closing a page, WebView is a better home for it. R=dglazkov BUG=10034 TEST=none Review URL: http://codereview.chromium.org/164105 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22689 0039d316-1c4b-4281-b951-d872f2087c98
* When the plugin crashes, cleanup references to its window in the renderer.piman@chromium.org2009-08-066-2/+31
| | | | | | | | | This avoids spurious messages when the plugin crashes, and potential issues (plugin crashes, the HWND/XID gets destroyed, a new one gets created by a new instance and gets the same HWND/XID, the browser operates on the new one instead of the old one). Review URL: http://codereview.chromium.org/160614 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22688 0039d316-1c4b-4281-b951-d872f2087c98
* Hook up copy pasta hotkeys in gtk bookmark manager.estade@chromium.org2009-08-062-4/+32
| | | | | | | | | | | Also change the display hotkey for tab reload from f5 (windowsy) to ctrl+r (linuxy). BUG=none TEST=use the new hotkeys Review URL: http://codereview.chromium.org/164097 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22685 0039d316-1c4b-4281-b951-d872f2087c98
* Don't pack an empty label into bookmarks with empty titles.estade@chromium.org2009-08-061-9/+16
| | | | | | | | BUG=18348 Review URL: http://codereview.chromium.org/164101 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22684 0039d316-1c4b-4281-b951-d872f2087c98
* Relanding Coverity fixes from http://codereview.chromium.org/159862 ↵phajdan.jr@chromium.org2009-08-063-3/+3
| | | | | | | | | | | | | excluding the broken ones. The change of GURL -> const GURL& caused some nasty crash and the change got reverted. TEST=none BUG=none Review URL: http://codereview.chromium.org/164095 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22682 0039d316-1c4b-4281-b951-d872f2087c98
* CL 22502 dropped the app_strings as part of the switch, so we don't have ↵thomasvl@chromium.org2009-08-061-0/+3
| | | | | | | | | | some of the strings we actually need to run. BUG=none TEST=none (no really good way to confirm that app_strings are in there now, pending cl uses them). Review URL: http://codereview.chromium.org/164098 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22681 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: Pass font settings through to interstitial renderers.derat@chromium.org2009-08-065-46/+77
| | | | | | | | | BUG=18483 TESTED=restarted and visited a page with a broken SSL cert a few times while changing font settings via gnome-appearance-properties Review URL: http://codereview.chromium.org/164094 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22679 0039d316-1c4b-4281-b951-d872f2087c98
* Add recent crash found by reliability bot to known_crashes.txt. Bug for ↵senorblanco@chromium.org2009-08-061-0/+2
| | | | | | | | | | | crash logged as 18700. BUG=http://crbug.com/18700 TEST=less redness == more goodness Review URL: http://codereview.chromium.org/165092 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22678 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Don't choke when there's no selection in the bookmark editor tree view.estade@chromium.org2009-08-062-7/+24
| | | | | | | | | 1) disable "new folder" when no folder is selected 2) if a user clicks apply when no folder is selected, apply the title/url edits but leave it in its original location Review URL: http://codereview.chromium.org/164016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22676 0039d316-1c4b-4281-b951-d872f2087c98
* Properly size accepted dangerous downloads.estade@chromium.org2009-08-061-4/+6
| | | | | | | | BUG=18448 Review URL: http://codereview.chromium.org/165086 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22675 0039d316-1c4b-4281-b951-d872f2087c98
* Add filters for IPC::SyncChannel leaks on purify.tim@chromium.org2009-08-061-0/+135
| | | | | | | | | | | | | | | | | | | | Most already are suppressed and have bugs for valgrind. RevocableStore- issue 17385 CreateChannel - issue 17979 IPC::Channel::Channel() - issue 17888 SyncChannel::SyncChannel - issue 16128 CreatePipe - issue 18696 ReceivedSyncMsgQueue - issue 8469 OnAddFilter - 18698 IPC::Channel::ChannelImpl::Connect - issue 18699 BUG=17385, 17979, 17888, 16128, 18696, 8469, 18698, 18699 Review URL: http://codereview.chromium.org/165088 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22674 0039d316-1c4b-4281-b951-d872f2087c98
* Correctly handle extensions width in the GTK extension shelf.phajdan.jr@chromium.org2009-08-066-6/+14
| | | | | | | | | | | Also make the method name used on Windows shorter and more obvious. TEST=none http://crbug.com/16759 Review URL: http://codereview.chromium.org/164092 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22672 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the size of a cancelled download in the download shelf.paul@chromium.org2009-08-062-5/+3
| | | | | | | | | | | | | Patch created by Thiago Farina, original CL: http://codereview.chromium.org/160465 BUG=17180 (http://crbug.com/17180) TEST=Download some file, then cancel it and notice the shelf UI does not any longer display the size of download. Review URL: http://codereview.chromium.org/165073 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22666 0039d316-1c4b-4281-b951-d872f2087c98
* Switch extension update manifest parse errors to LOG(WARN).asargent@chromium.org2009-08-061-1/+1
| | | | | | | | | | | | | | | | Before this patch they are using ExtensionErrorReporter, but I don't think it's actually useful for users to see them on the chrome://extensions page. BUG=http://crbug.com/18565 TEST=You should no longer see messages like "Extension update manifest parse error: Invalid codebase url"on the chrome://extensions page. Review URL: http://codereview.chromium.org/164008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22662 0039d316-1c4b-4281-b951-d872f2087c98
* Another day, another round of suppressions from my local continous mac ui ↵dank@chromium.org2009-08-061-0/+2
| | | | | | | | | | | | | | | valgrind run. Move one suppression from 6547 to new bug 18664 as we widen it, 'cause 6547 was marked closed, and the history was messy. Also disable ErrorPageTest.DNSError_GoBack2Forward2 -- it hangs often on mac under valgrind, possibly a bug in valgrind. BUG=6547,16628,18661,18664 TEST=swing mac around your head on its power cord, see if any memory leaks out Review URL: http://codereview.chromium.org/165076 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22661 0039d316-1c4b-4281-b951-d872f2087c98
* More theme fixes.tc@google.com2009-08-065-30/+38
| | | | | | | | | | | | | | 1) Fix the bookmark bar to draw the same as the toolbar (tile the background image and have a transparent background). 2) Fix the tab backgrounds to be offset correctly rather than always drawing as if we're the first tab. Some small code cleanup in views/tabs/tab_renderer.h. Review URL: http://codereview.chromium.org/165078 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22660 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: handle Escape in omnibox when numlock/scrolllock/caps lock is on.estade@chromium.org2009-08-061-1/+2
| | | | | | | | | BUG=18643 TEST=turn on num lock. Escape in omnibox resets the address. Review URL: http://codereview.chromium.org/165079 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22659 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "GTK: Rounded corner on status bubble."erg@google.com2009-08-062-124/+28
| | | | | | | | | | This reverts commit d98d01314c8b0905ac236d98dc39508ad8acfd05 (r22644). This should make the linux ui tests green. Review URL: http://codereview.chromium.org/164086 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22656 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-01-31 19:17:50 +0000