summaryrefslogtreecommitdiffstats
path: root/chrome
Commit message (Collapse)AuthorAgeFilesLines
* Add checks to track down crashes in URLRequestChromeJob.willchan@chromium.org2009-07-062-0/+18
| | | | | | | | | BUG=http://crbug.com/13924 TEST=none Review URL: http://codereview.chromium.org/155011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19950 0039d316-1c4b-4281-b951-d872f2087c98
* Re-enable BlockedPopupContainerView tests (Disabled earlier in r19942)nirnimesh@chromium.org2009-07-061-4/+0
| | | | | | | | BUG=15818 TEST=Valgrind-Mac green Review URL: http://codereview.chromium.org/149201 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19948 0039d316-1c4b-4281-b951-d872f2087c98
* Makes unit tests compilable for linux2.sky@chromium.org2009-07-061-1/+1
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/155002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19947 0039d316-1c4b-4281-b951-d872f2087c98
* Make two IPC messages async.stoyan@chromium.org2009-07-061-4/+4
| | | | | | Review URL: http://codereview.chromium.org/155009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19946 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes two documentation bugs in property_bag.sky@chromium.org2009-07-061-4/+2
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/155012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19945 0039d316-1c4b-4281-b951-d872f2087c98
* Add remaining functionality for popup blocker: popup menu to unblock ↵pinkerton@chromium.org2009-07-065-20/+181
| | | | | | | | | | individual popups and whitelist sites. Also fixes intermittant leak on valgrind bots from poorly constructed unit test. BUG=13160, 15818 TEST=unblocking popups, whitelisting sites, and unwhitelisting them. Green valgrind bot. Review URL: http://codereview.chromium.org/149145 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19944 0039d316-1c4b-4281-b951-d872f2087c98
* Move Emf class to the printing library. Also creates a platform agnostic ↵sverrir@google.com2009-07-0618-701/+77
| | | | | | | | | | | NativeMetafile definition to ease platform porting. BUG=none TEST=none (No functional change) Review URL: http://codereview.chromium.org/149181 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19943 0039d316-1c4b-4281-b951-d872f2087c98
* Disable BlockedPopupContainerView tests on Mac Valgrindnirnimesh@chromium.org2009-07-061-0/+4
| | | | | | | | | | BUG=15818 TEST=None TBR=pinkerton Review URL: http://codereview.chromium.org/149196 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19942 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: preserve focus on activating dev tools window.pfeldman@chromium.org2009-07-068-1/+32
| | | | | | | | BUG=15912 Review URL: http://codereview.chromium.org/155068 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19938 0039d316-1c4b-4281-b951-d872f2087c98
* Redraw the location bar on reload. This change is Mac port of ↵yusukes@google.com2009-07-061-1/+1
| | | | | | | | | | | http://codereview.chromium.org/100198. BUG=none TEST=open http://dev.chromium.org/, double click the location bar, press delete (delete URL string), press reload button, verify the URL is redrawn. Review URL: http://codereview.chromium.org/155070 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19936 0039d316-1c4b-4281-b951-d872f2087c98
* Fix problems with render_widget_host_ being deleted out-of-sync with ↵shess@chromium.org2009-07-062-12/+32
| | | | | | | | | | | | | | | cocoa_view_. Right after Destroy() is called, render_widget_host_ is deleted. So clear render_widget_host_ and guard calls to render_widget_host_. http://crbug.com/14613 http://crbug.com/13514 http://crbug.com/12725 Review URL: http://codereview.chromium.org/155021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19933 0039d316-1c4b-4281-b951-d872f2087c98
* Ensure that VisitedLink listener Add event only fires when new fingerprint ↵dglazkov@chromium.org2009-07-043-17/+20
| | | | | | | | | | | | is added, and not during resizing/rebuilding or deleting fingerprints. R=brettw TEST=VisitedLinkTest.Listener BUG=15926 Review URL: http://codereview.chromium.org/149185 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19931 0039d316-1c4b-4281-b951-d872f2087c98
* Add an ExtensionBrowserTest base class that allows in-process browser tests ↵aa@chromium.org2009-07-0427-440/+364
| | | | | | | | of extensions using ExtensionsService directly, rather than TestExtensionLoaded. Use it to re-enable some old browser tests that had been disabled. Review URL: http://codereview.chromium.org/150213 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19930 0039d316-1c4b-4281-b951-d872f2087c98
* Initial html page views for print preview and setupmhm@chromium.org2009-07-034-0/+26
| | | | | | | | | | | This is still the foundation, has no implementation, just plain old html and its structure. BUG=173, 947 TEST=none Review URL: http://codereview.chromium.org/155051 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19918 0039d316-1c4b-4281-b951-d872f2087c98
* Modifying mini_installer to have different additional options.bradnelson@chromium.org2009-07-031-0/+1
| | | | | | | | | | | | This should not affect other targets. BUG=None TEST=None TBR=sgk Review URL: http://codereview.chromium.org/149152 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19916 0039d316-1c4b-4281-b951-d872f2087c98
* Fix EOL style on this file.maruel@chromium.org2009-07-031-293/+293
| | | | | | | | BUG=none TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19913 0039d316-1c4b-4281-b951-d872f2087c98
* Fix Acid3 Test 48: LINKTEST, Chromium side....dglazkov@chromium.org2009-07-0329-117/+968
| | | | | | | | | | | | | | | | | R=brettw BUG=http://crbug.com/231 BUG=http://crubg.com/5160 TEST=ExpireHistoryTest.ArchiveSomeOldHistory TEST=ExpireHistoryTest.ExpiringVisitsReader TEST=VisitedLinkTest.Listener TEST=VisitedLinkTest.Resizing TEST=VisitedLinkRelayTest.* TEST=VisitedLinkEventsTest.* Review URL: http://codereview.chromium.org/113591 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19910 0039d316-1c4b-4281-b951-d872f2087c98
* Move RenderViewHostManager back to tab_contents. Moving it to renderer_hostbrettw@chromium.org2009-07-039-69/+98
| | | | | | | | | | | | | | | was a bad idea because of its significant dependencies on NavigationController and NavigationEntry. I'm trying to make renderer_host not depend on tab_contents at all. Remove the dependency on TabContents pointers for notifications from the ResourceDispatcherHost. Instead of having the broadcast code in the ResourceDispatcherHost, I made it call a RenderViewHostDelegate callback. Then TabContents implements the notification, so that it's really from the TabContents. Review URL: http://codereview.chromium.org/150069 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19909 0039d316-1c4b-4281-b951-d872f2087c98
* Remove unused notification in print code to simplify before refactoring.sverrir@google.com2009-07-038-118/+72
| | | | | | | | | | | | Removed the PRINTED_DOCUMENT_UPDATED notification and move the debug output from PrintJobManager to PrintedDocument. Also made the --debug-print startup parameter only active in non-official builds. BUG=none TEST=Should have no functional affect. Review URL: http://codereview.chromium.org/149148 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19907 0039d316-1c4b-4281-b951-d872f2087c98
* Foundations for Print Preview and Setupmhm@chromium.org2009-07-0310-14/+65
| | | | | | | | | | | | | Create the foundations of implementing a tab for printing should be in the form of: print:http://www.google.com I have followed similar approach as what has been done with view-source: and chrome-extension: BUG=173, 947 TEST=none Review URL: http://codereview.chromium.org/150207 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19906 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: Console tests.pfeldman@chromium.org2009-07-032-0/+50
| | | | | | Review URL: http://codereview.chromium.org/149178 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19904 0039d316-1c4b-4281-b951-d872f2087c98
* Handle partial sends over the ChromeDevToolsProtocol.apavlov@chromium.org2009-07-031-9/+22
| | | | | | | send() can send parts of the buffer fed in. We should send parts of the buffer until the entire buffer has been transferred. Review URL: http://codereview.chromium.org/150229 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19902 0039d316-1c4b-4281-b951-d872f2087c98
* We used to store/restore the frame and node that were focused last when a ↵jcampan@chromium.org2009-07-031-12/+0
| | | | | | | | | | | | | | age would lose/gain focus. This patches lets WebKit takes care of it by using the new FocusController::setFocused method. BUG=http://crbug.com/15777 TEST=Open www.google.com, the focus should be on the text-field (focus ring + blinking caret). Activate another window. The page should not show the text-field with the focus. Switch tabs, make sure the focus is remembered correctly. Do the same tests in a page with frames. Run the layout tests. Review URL: http://codereview.chromium.org/151195 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19899 0039d316-1c4b-4281-b951-d872f2087c98
* Create a project for maintaining default extensions.finnur@chromium.org2009-07-034-8/+18
| | | | | | | | | | | | | | | | | | | | | This project is responsible for listing and copying the extensions we want to ship with Chrome by default. It copies the .crx files listed in the project plus a .json file from: src\chrome\browser\extensions\default_extensions to debug\extensions ... where the mini_installer will pick them up. At the moment only the json file is getting copied, but we can add .crx files when they are ready. BUG=None TEST=I will give a build to QA for testing this. Review URL: http://codereview.chromium.org/155016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19889 0039d316-1c4b-4281-b951-d872f2087c98
* Fixing unitialized variable (Coverity nit).finnur@chromium.org2009-07-031-2/+3
| | | | | | | | | BUG=None TEST=None Review URL: http://codereview.chromium.org/155025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19888 0039d316-1c4b-4281-b951-d872f2087c98
* Initializing the struct before using it, as mandated byfinnur@chromium.org2009-07-031-9/+9
| | | | | | | | | | | our Coverity overlord. BUG=None TEST=None Review URL: http://codereview.chromium.org/149155 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19887 0039d316-1c4b-4281-b951-d872f2087c98
* Make action buttons listen to the enter key.arv@google.com2009-07-033-67/+119
| | | | | | | | | | | | | | | | | | | | | | Hide menus when the window is blurred or the user presses Alt or Meta. Only show tootlip for the title of the thumbnail. Allow mouse over on the window menu. Made the windows opaque but with a hsla background color to make it more readable. Quote all background image URLs so that we can display icons for URLs with spaces in them. Call preventDefault when using the keyboard to navigate the options menu so that the page does not scroll. BUG=15268, 15503, 15715, 15769, 15411, 15458 TEST=See bug descriptions Review URL: http://codereview.chromium.org/149163 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19884 0039d316-1c4b-4281-b951-d872f2087c98
* Modify ThumbnailStore to make one call to the HistoryBackend using ↵meelapshah@chromium.org2009-07-035-400/+217
| | | | | | | | | | | QueryTopURLsAndRedirects instead of a seperate call for each URL. Also clean up some of the code and fix bug 14644. BUG=14644 TEST=none Review URL: http://codereview.chromium.org/149126 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19879 0039d316-1c4b-4281-b951-d872f2087c98
* Another batch of performance improvements for NNTP.arv@google.com2009-07-033-167/+307
| | | | | | | | | | | | | | | | | | Hard code the DOM and the layout for the default case so that we do not need to do any js layout at startup. Be more careful when calling layout. I added a dirty bit so that we don't layout too often. CSS cleanup/optimization to make selectors faster. TEST=Run the perf test BUG=13362 Review URL: http://codereview.chromium.org/149127 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19877 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Preview images in file chooser.estade@chromium.org2009-07-031-0/+36
| | | | | | | | | BUG=http://crbug.com/15500 TEST=select an image in a file chooser Review URL: http://codereview.chromium.org/151100 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19874 0039d316-1c4b-4281-b951-d872f2087c98
* Fix showModalDialog regression.jam@chromium.org2009-07-035-1/+42
| | | | | | | | BUG=4202 TEST=added regression test. Review URL: http://codereview.chromium.org/149143 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19872 0039d316-1c4b-4281-b951-d872f2087c98
* Change some numbers on the gtk bookmark bar.estade@chromium.org2009-07-032-2/+2
| | | | | | | | | | | | height = 29 matches windows constant padding between bookmark name and favico: I couldn't find a relevant constant in the windows code, so I experimentally matched the spacing between the two, for the same bookmark on linux and windows. BUG=http://crbug.com/15882 TEST=look at bookmark bar Review URL: http://codereview.chromium.org/155019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19871 0039d316-1c4b-4281-b951-d872f2087c98
* Knock out a couple more TODOs from the bookmark manager.estade@chromium.org2009-07-031-3/+34
| | | | | | | | | TEST=edit the name of a folder; it should update in the left pane. Add a new bookmark URL; it should show up selected in the right pane. Also, see bug BUG=http://crbug.com/15844 Review URL: http://codereview.chromium.org/149151 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19870 0039d316-1c4b-4281-b951-d872f2087c98
* Re-show bookmark bar buttons whenever they're configured.estade@chromium.org2009-07-031-0/+2
| | | | | | | | | BUG=http://crbug.com/15859 TEST=see bug Review URL: http://codereview.chromium.org/155008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19869 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Initial implementation of using GTK themes, partially based on evan's ↵erg@google.com2009-07-0329-143/+665
| | | | | | | | | | | | | | | | | | | | | | | CL 118358. A lot of stuff works: - Colors are picked out of the GTK theme. - Buttons use the current GTK button theme. - We use the user's icon theme. A lot of stuff doesn't: - We could do a better job of picking colors for the skylines. - The omnibox hasn't been touched. - UI that's not part of the toolbar hasn't been touched. - We currently fail on themes like HighContrastInverse. TEST=Under Options>Personal Stuff, click GTK Theme. Colors and widgets should be rendered with the current GTK theme stuff. TEST=With chrome open and in GTK Theme mode, change your GTK theme or icon theme. chrome should pick up on the change immediately and reimport the colors and images. http://crbug.com/13967 Review URL: http://codereview.chromium.org/150176 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19868 0039d316-1c4b-4281-b951-d872f2087c98
* Add getFileSize support to chromiumvictorw@chromium.org2009-07-0314-0/+309
| | | | | | | | | | | | | | | | | The current implementation only allows getting file size if the child process has been granted permission to upload file. May need to update the policy checking code if getFileSize is needed in other cases. Here is the webkit implementation to support this: https://bugs.webkit.org/show_bug.cgi?id=26521 TEST=none BUG=9102 Review URL: http://codereview.chromium.org/131082 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19866 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 19829.mirandac@chromium.org2009-07-026-223/+9
| | | | | | | | BUG= http://crbug.com/1455 Review URL: http://codereview.chromium.org/149156 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19861 0039d316-1c4b-4281-b951-d872f2087c98
* Disable IPCSyncChannelTest.* under Valgrindnirnimesh@chromium.org2009-07-023-3/+6
| | | | | | | | | Times out too often under Valgrind on Mac Tracking bug: crbug.com/15817 Review URL: http://codereview.chromium.org/150218 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19846 0039d316-1c4b-4281-b951-d872f2087c98
* Fix some issues with extension messaging:mpcomplete@chromium.org2009-07-029-32/+64
| | | | | | | | | | | | | | - Disconnect ports properly (javascript mistake). - Use the right port ID when dispatching the disconnect event. - Fix a bug with 2 extensions loaded in the same process. BUG=12686 BUG=15798 TEST=Load an extension that uses messaging, and make sure it disconnects when you navigate or close the connecting. Review URL: http://codereview.chromium.org/152003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19844 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the Linux2 build.brettw@chromium.org2009-07-023-3/+3
| | | | | | | | I removed the extra argument from WidgetGTK::Init but didn't update these sites. Review URL: http://codereview.chromium.org/155006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19843 0039d316-1c4b-4281-b951-d872f2087c98
* Add a couple of more extension unit tests for pagefinnur@chromium.org2009-07-023-2/+100
| | | | | | | | | | | | | actions. One for the helper function that parses a page action from the manifest and another that tests the page action api. BUG=None TEST=None Review URL: http://codereview.chromium.org/151181 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19840 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: when doing a drag from a web page, pass a recent mouse down to ↵estade@chromium.org2009-07-022-6/+12
| | | | | | | | | | | | | | | | | | | gtk_drag_begin() so it has a better idea what time to pass to gdk_grab_pointer(). I believe the following was happening: - render view gets mouse down, forwards to webkit - render view gets motion, forwards to webkit - user releases mouse button, that event is added to the queue - browser gets message from webkit that a drag has begun, calls gtk_drag_begin() with no event - gtk_drag_begin initiates a cursor grab, but it only applies to events that have not yet been added to the queue - mouse release comes up in queue; passed to render view rather than the drag widget TEST=You can't get stuck in really short render view drags. Whereas it was really easy to repro before (especially in Xephyr), I can repro no longer. BUG=http://crbug.com/15768 Review URL: http://codereview.chromium.org/150204 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19839 0039d316-1c4b-4281-b951-d872f2087c98
* Fix bookmark util crashestade@chromium.org2009-07-021-0/+4
| | | | | | | | | BUG=http://crbug.com/15853 TEST=none Review URL: http://codereview.chromium.org/155004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19838 0039d316-1c4b-4281-b951-d872f2087c98
* Pop-up chrome.jrg@chromium.org2009-07-024-6/+54
| | | | | | | | | | | | | | | | | | | | | | | BUG=http://crbug.com/15727 TEST=Load a web page that has a popup. Example: <!DOCTYPE html> Click button to open a new window. <br> <button onclick="w = window.open('http://www.google.com', 'New Window', 'width=512,height=512'); w.moveTo(300,300);">Open with w,h</button> Now click on the button to get a pop-up. In the new window, make sure there is no "tab" area above the URL bar, and no "new tab" button. Hit Cmd-T to create a new tab, and make sure it gets created in the OTHER window. More work is needed to minimize pop-up chrome more, but this'll prevent the most brutal failures (e.g. team meeting "demo" today). Review URL: http://codereview.chromium.org/151135 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19837 0039d316-1c4b-4281-b951-d872f2087c98
* Add morejs to page cycler tests.cmp@google.com2009-07-021-0/+8
| | | | | | | | | BUG=12357 TEST=page cycler runs to completion Review URL: http://codereview.chromium.org/155003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19833 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a typo I came across while debugging.eroman@chromium.org2009-07-022-3/+3
| | | | | | | | | | BUG=None TEST=None TBR=brettw Review URL: http://codereview.chromium.org/149128 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19832 0039d316-1c4b-4281-b951-d872f2087c98
* Add more functionality to the gtk task manager:jhawkins@chromium.org2009-07-023-14/+64
| | | | | | | | | | * Columns are resizable. * Resource icon displayed by resource name. BUG=11392 TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19830 0039d316-1c4b-4281-b951-d872f2087c98
* Change status bubble so that it expands to accommodate URL's that are ↵mirandac@chromium.org2009-07-026-9/+223
| | | | | | | | | | | abridged in the standard width. BUG= http://crbug.com/1455 TEST= Mouse over a link which is abridged in the status bubble. Hover for 2 seconds. Link should expand to show as much as possible without extending out of the view in which it is contained. Review URL: http://codereview.chromium.org/146043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19829 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Clean up some bookmark related UI hacks.estade@chromium.org2009-07-023-57/+34
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/150203 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19827 0039d316-1c4b-4281-b951-d872f2087c98
* Implement Add and Update for PasswordStoreMac.stuartmorgan@chromium.org2009-07-0210-49/+154
| | | | | | | | | | | Modify LoginDatabase slightly to give PasswordStoreMac enough information to do the right thing. Add creator code for keychain items we create, and unit tests to make sure. BUG=11745 TEST=Visit a site for which you have a password in the Keychain. Type your username, unfocus the field, and then log in with the filled password. Log out, return to the login page, and the username and password should now autofill without user interaction. Review URL: http://codereview.chromium.org/151176 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19822 0039d316-1c4b-4281-b951-d872f2087c98