summaryrefslogtreecommitdiffstats
path: root/chrome
Commit message (Collapse)AuthorAgeFilesLines
* Create a bookmark editor dialog interface and implement a GTK version.erg@google.com2009-04-289-73/+516
| | | | | | | | | | The GTK version is currently limited to only editing the name/url of the bookmark; I'm submitting this since it's getting big and I want a design review. Review URL: http://codereview.chromium.org/99131 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14763 0039d316-1c4b-4281-b951-d872f2087c98
* Make Chrome default after importing from current default browser.kuchhal@chromium.org2009-04-281-2/+2
| | | | | | | | | BUG=11094 Review URL: http://codereview.chromium.org/99136 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14762 0039d316-1c4b-4281-b951-d872f2087c98
* One more try to make these tests pass. Added a while loop to wait until the ↵anantha@chromium.org2009-04-283-3/+19
| | | | | | | | | key is open. Sorry for enabling and disabling the tests for few times. I really want these tests to run asap, so that I can add new tests. Review URL: http://codereview.chromium.org/99142 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14761 0039d316-1c4b-4281-b951-d872f2087c98
* Support for tabs reaching a threshold before tearing off (magnetism), ↵pinkerton@chromium.org2009-04-2810-111/+294
| | | | | | showing position of where the tab will go in the destination tab strip. Use new close box icon. Don't draw the tab title over the close box. Patch from alcor@google.com git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14758 0039d316-1c4b-4281-b951-d872f2087c98
* Disable Tab1Tab2, as it's flaky.evan@chromium.org2009-04-281-1/+2
| | | | | | | | BUG=10941 Review URL: http://codereview.chromium.org/99138 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14751 0039d316-1c4b-4281-b951-d872f2087c98
* Disabling the tests again. Looking into them.anantha@chromium.org2009-04-281-1/+1
| | | | | | Review URL: http://codereview.chromium.org/101010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14749 0039d316-1c4b-4281-b951-d872f2087c98
* Added a check to look for setup.exe before looking at registry. This test is ↵anantha@chromium.org2009-04-282-8/+13
| | | | | | | | failing becase of race conditon. This fix should resolve the problem. Review URL: http://codereview.chromium.org/99134 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14747 0039d316-1c4b-4281-b951-d872f2087c98
* Always simulate a mouse movement after animations in the Linux tabstrip to ↵jhawkins@chromium.org2009-04-281-23/+19
| | | | | | | | make sure we never have a stale hover index. Review URL: http://codereview.chromium.org/101009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14743 0039d316-1c4b-4281-b951-d872f2087c98
* Remove platform defines now that things work on Mac.pinkerton@chromium.org2009-04-281-10/+0
| | | | | | Review URL: http://codereview.chromium.org/99129 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14741 0039d316-1c4b-4281-b951-d872f2087c98
* For system level install read setup.exe path from HKLM instead of HKCU.kuchhal@chromium.org2009-04-281-15/+20
| | | | | | | | | | | Also register extensions separately for Chrome and Chromium (only one can be made default at one time). BUG=9697 Review URL: http://codereview.chromium.org/101001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14739 0039d316-1c4b-4281-b951-d872f2087c98
* Relanding this: jcampan@chromium.org2009-04-2810-19/+793
| | | | | | | | | | | | | | | | | | | | | | | | | This patch adds a new kind of tests: browser tests. They are intended to provide an alternative to the UI tests, hopefully helping with flackiness. These tests are in-process browser test. There are 2 projects to build the tests: - the browser_test.dll that contains the tests, the gtest framework and the browser classes. - the browser_test_launcher.exe. The launcher loads the browser_test.dll for each test, run the test and then unloads the DLL. This insures the static initializers are run before each test and that any atexit handler is invoked properly. This is Windows only for now. BUG=9764 TEST=Run browser_test.exe TBR=maruel Review URL: http://codereview.chromium.org/99097 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14738 0039d316-1c4b-4281-b951-d872f2087c98
* Allow File>Open File with no window open.avi@google.com2009-04-281-0/+6
| | | | | | Review URL: http://codereview.chromium.org/99128 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14737 0039d316-1c4b-4281-b951-d872f2087c98
* Make the font scale and the font family to use for UI 'OS-dependent' (Win XP ↵jungshik@google.com2009-04-2851-71/+187
| | | | | | | | | | | | | | | | | | | | vs Win Vista/ Win 7). In r13773, the localizable font size/family override was added to work around the tiny font issue for some Indian languages. Initially, I thought the 'tiny UI font' issue was completely taken care of on Vista/Win 7 (it's resolved for Malayalam) and added a check for that. It turned out that Indian fonts on Vista and Windows 7 were updated, but the issue has not been resolved. As a result, he scale and the fonts for Windows XP do not work on Vista/Win 7 and we need to use different values for Vista/Win 7. Note that what this CL does (having separate resource entries in a single reosource bundle for Win XP and Vista/Win 7 and picking one at run-time) is a temporary work-around for the branch and for the trunk, we need to have a better way of handling platform-dependent resources. It's not just for different flavors of Windows but also for taking care of differences between Win, Mac and Linux. BUG=7319 TEST=On Vista/Win7/Win XP, run Chrome with '--lang=XX' where XX is hi, mr, kn, gu, te, ta, bn, ml (and or on Vista/Win 7) and make sure that UI font size looks ok and there's no truncated strings/dialog box. Review URL: http://codereview.chromium.org/92135 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14736 0039d316-1c4b-4281-b951-d872f2087c98
* New close box images.pinkerton@chromium.org2009-04-284-0/+5149
| | | | | | Review URL: http://codereview.chromium.org/100109 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14735 0039d316-1c4b-4281-b951-d872f2087c98
* Should handle the events when no printer is detected on localmaruel@chromium.org2009-04-283-1/+19
| | | | | | | | | | | | | | | | | machineGetDefaultPrintSettings was returning an empty struct because no printer is installed. Checking when its empty will allow us to know that a printer is missing on that system. There is clearly no other way to do this, unless we do not do all those dchecks on dpi and other struct members.BUG=6835TEST=Tested only on windows, since linux/mac printing not even implemented. Removed all printer drivers, opened chromium, and ran a print job, popup dialog appeared stating no printer installed. Installed my printer drivers again, print dialog appeared. Patch contributed by Mohamed Mansour <m0.interactive@gmail.com> Review: http://codereview.chromium.org/100023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14731 0039d316-1c4b-4281-b951-d872f2087c98
* Unittest for FindBarBridge.rohitrao@chromium.org2009-04-282-0/+34
| | | | | | | TEST=The new unittest passes. BUG=10802 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14729 0039d316-1c4b-4281-b951-d872f2087c98
* Remove a NOTIMPLEMENTED for Macpinkerton@chromium.org2009-04-281-5/+0
| | | | | | Review URL: http://codereview.chromium.org/99086 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14727 0039d316-1c4b-4281-b951-d872f2087c98
* Swap NOTIMPLEMENTED with a bug comment.pinkerton@chromium.org2009-04-281-1/+1
| | | | | | Review URL: http://codereview.chromium.org/99085 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14726 0039d316-1c4b-4281-b951-d872f2087c98
* Fix PageLoadTest.Reliability which I broke in my previous checkin to make thebrettw@chromium.org2009-04-281-5/+1
| | | | | | | | | | | | | throbber more responsive. The issue is that I changed the meaning of LOAD_START from indicating that the renderer started loading to indicating when the browser told the renderer to start loading. This means it now looks like we started loading "about:crash" whereas before it didn't. I think this change is reasonable and how we could about:crash in this respect isn't important, so I just removed the failing checks. Review URL: http://codereview.chromium.org/99118 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14720 0039d316-1c4b-4281-b951-d872f2087c98
* Synchronously update the loading state when a load starts so that the UI willbrettw@chromium.org2009-04-2811-38/+51
| | | | | | | | | | | | | be more responsive and the loading state won't be out-of-sync with anything else. This also removes the synchronous update to the throbber when we load a URL because this happens before the loda actually starts, giving a flash of the default favicon. The load start call made by RenderViewHost will cover this case after the load actually starts. BUG=11051 Review URL: http://codereview.chromium.org/100033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14718 0039d316-1c4b-4281-b951-d872f2087c98
* ImportantFileWriterphajdan.jr@chromium.org2009-04-2822-176/+424
| | | | | | | | | | | | | | Introducing a class for writing important files, preventing their corruption during writing. Switched PrefService to use it. Other classes will be switched in future changesets. TEST=This may affect things using preferences. Make sure that changes in preferences don't get lost, and that you don't get excessive disk activity when changing preferences. http://crbug.com/10618 Review URL: http://codereview.chromium.org/83001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14717 0039d316-1c4b-4281-b951-d872f2087c98
* Implement tabs.createWindow extension api call. Required: (a) new ↵rafaelw@chromium.org2009-04-2828-22/+266
| | | | | | | | | | | RVHDelegate & TabContentsDelegate method(s) CreateExtensionFunctionDispatcher() so that the dispatcher could be created with (an optional) browser attached to it, while avoiding having render_host depend on browser.h BUG=11092: R=aa,mpComplete,darin,pkasting Review URL: http://codereview.chromium.org/79070 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14710 0039d316-1c4b-4281-b951-d872f2087c98
* POSIX: = {0} syntax causes a warning.agl@chromium.org2009-04-281-1/+2
| | | | | | | (Replace with memset) git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14708 0039d316-1c4b-4281-b951-d872f2087c98
* Updating trunk VERSION build from 177.0 to 178.0laforge@chromium.org2009-04-281-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14707 0039d316-1c4b-4281-b951-d872f2087c98
* POSIX: don't spawn zombies.agl@chromium.org2009-04-289-12/+123
| | | | | | | | | http://codereview.chromium.org/93147 BUG=9401 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14705 0039d316-1c4b-4281-b951-d872f2087c98
* Disabling the test again. This time the test doesn't fail at mulitple ↵anantha@chromium.org2009-04-281-1/+1
| | | | | | | | places. It fails at only one place. investigating... Review URL: http://codereview.chromium.org/102003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14696 0039d316-1c4b-4281-b951-d872f2087c98
* Enabling the user install tests to see if they pass. They were failing ↵anantha@chromium.org2009-04-283-4/+3
| | | | | | | | | | | | | | | because of two reasons: 1. the new profile dialog closes the setup.exe process as soon as the dialog is closed. The testcase used to wait for setup.exe to start/end, which would never happen. heence the test failed. 2. Closing of new profile dialog also deletes the reg keys right away. looks like there were some timing issues.Added a sleep of 400 to see if the test passes now. if it passes, then I will look into other options and remove the sleep. ----- The standalone installer path got changed recently. modified that path also. Review URL: http://codereview.chromium.org/100086 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14693 0039d316-1c4b-4281-b951-d872f2087c98
* Filter modifier to only include accelerator modifiers.willchan@chromium.org2009-04-281-0/+3
| | | | | | Review URL: http://codereview.chromium.org/99103 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14690 0039d316-1c4b-4281-b951-d872f2087c98
* Removes the use of Windows-specific types for accessibility roles and states ↵klink@chromium.org2009-04-2829-157/+194
| | | | | | | | in Views and Browser\Views. Helps with the porting effort, and makes for a cleaner implementation. Review URL: http://codereview.chromium.org/93085 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14689 0039d316-1c4b-4281-b951-d872f2087c98
* Convert Windows Sleep to PlatformThread::Sleepevan@chromium.org2009-04-2810-32/+30
| | | | | | | | | | | | First stage to make tests/others cross-platform. BUG=None TEST=Ran tests successfully (windows) Review URL: http://codereview.chromium.org/63113 Patch from Mohamed Mansour <m0.interactive@gmail.com>. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14688 0039d316-1c4b-4281-b951-d872f2087c98
* When navigating from an interstitial to another page with an interstitial, ↵jcampan@chromium.org2009-04-272-3/+19
| | | | | | | | | | we should not discard the non committed entries, as this would cause the new navigation pending entry to go away. BUG=9791 TEST=Visit a page with an SSL error (ex: https://ebay.com). Focus the location bar and press enter (to navigate again to that page). The interstitial should be shown again and the location bar should show the URL. Also ensure that interstitial pages (SSL and safe browsing) still work as expected. Review URL: http://codereview.chromium.org/100002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14687 0039d316-1c4b-4281-b951-d872f2087c98
* Disable a test that fails on mac. I enabled this in r14684, buttc@google.com2009-04-271-2/+2
| | | | | | | | | | | it's not ready yet for mac. TBR=evan Review URL: http://codereview.chromium.org/100083 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14686 0039d316-1c4b-4281-b951-d872f2087c98
* Port another UI test file. Disable tests that still need to be ported.tc@google.com2009-04-272-12/+38
| | | | | | | Review URL: http://codereview.chromium.org/92106 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14684 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the unwanted code snippet that was removed by Tim, butmunjal@chromium.org2009-04-271-12/+0
| | | | | | | | | | reintroduced in a later CL (probably due to SVN merge). This will fix p13n build. Review URL: http://codereview.chromium.org/99078 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14683 0039d316-1c4b-4281-b951-d872f2087c98
* Fix several painting glitches for toolstrips.aa@chromium.org2009-04-279-58/+143
| | | | | | | | | | | | | | * Reset HWND size when HWNDHtmlView changes size. The two should always be in sync. * Race: We might already have frames when RenderWidget receives a new background, need to set these to transparent too. * Race: Toolstrip background not always available by the time ExtensionToolstrip is constucted * Make images line up correctly for toolstrip buttons. Review URL: http://codereview.chromium.org/99042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14682 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r14620 which was a rollback of r14549 and r14508. Thistc@google.com2009-04-273-12/+39
| | | | | | | | | | | | change re-enables the ui tests. Since jam re-enabled some tests, I had to #ifdef around 4 tests that are not shutting down cleanly on linux. It looks like we have renderers that aren't shutting down properly (pegged at 100% cpu). Review URL: http://codereview.chromium.org/100061 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14680 0039d316-1c4b-4281-b951-d872f2087c98
* POSIX: Make --user-data-dir work when it doesn't exist.agl@chromium.org2009-04-271-1/+1
| | | | | | | | | | | | | | | | | Previously, --user-data-dir called PathService::Override which called AbsolutePath. On POSIX, this calls realpath and fails if the given path doesn't actually exist. We need to do this on Windows because we change the current directory in order to load plugins (at least). However, on POSIX we shouldn't ever change cwd. So, on POSIX, don't try to make the user-data-dir absolute. TEST=On POSIX, start chrome with --user-data-dir=/tmp/xyz (where xyz is a directory which doesn't exist). Once running, check that /tmp/xyz exists and contains the expected files. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14679 0039d316-1c4b-4281-b951-d872f2087c98
* Landing Hamaji's patch.jcampan@chromium.org2009-04-271-0/+8
| | | | | | | See http://codereview.chromium.org/93135 Review URL: http://codereview.chromium.org/99079 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14678 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a popup menu offset bug.paul@chromium.org2009-04-271-1/+3
| | | | | | | | BUG=8389 Review URL: http://codereview.chromium.org/99075 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14673 0039d316-1c4b-4281-b951-d872f2087c98
* Add menu tag to View + Encoding menus.jeremy@chromium.org2009-04-272-1/+4
| | | | | | Review URL: http://codereview.chromium.org/99083 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14672 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting my change it breaks release compilation on Windows.jcampan@chromium.org2009-04-2710-785/+19
| | | | | | | TBR=maruel Review URL: http://codereview.chromium.org/103001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14669 0039d316-1c4b-4281-b951-d872f2087c98
* Unfork some code who's dependency has landed on Mac.shess@chromium.org2009-04-271-6/+0
| | | | | | | | | I believe that this was originally commented out due to fonts not being quite wired in. Review URL: http://codereview.chromium.org/92142 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14667 0039d316-1c4b-4281-b951-d872f2087c98
* Do not send stats from Chromium builds.kuchhal@chromium.org2009-04-278-28/+67
| | | | | | | | | BUG=1435533 Review URL: http://codereview.chromium.org/93109 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14665 0039d316-1c4b-4281-b951-d872f2087c98
* This patch adds a new kind of tests: browser tests.jcampan@chromium.org2009-04-2710-19/+785
| | | | | | | | | | | | | | | | | | They are intended to provide an alternative to the UI tests, hopefully helping with flackiness. These tests are in-process browser test. There are 2 projects to build the tests: - the browser_test.dll that contains the tests, the gtest framework and the browser classes. - the browser_test_launcher.exe. The launcher loads the browser_test.dll for each test, run the test and then unloads the DLL. This insures the static initializers are run before each test and that any atexit handler is invoked properly. This is Windows only for now. BUG=9764 TEST=Run browser_test.exe Review URL: http://codereview.chromium.org/88066 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14664 0039d316-1c4b-4281-b951-d872f2087c98
* Fail the plugin initialization if we are unable to duplicate the event ↵ananta@chromium.org2009-04-273-4/+10
| | | | | | | | | | | | | | handle which is used for deciding whether we need to pump window messages in outgoing sync calls from the plugin. The theory is that the DuplicateHandle call could fail if the renderer process exited. It is unclear as to what a reliable test for this would be. Will think over and possibly add in a future CB. Fixes http://code.google.com/p/chromium/issues/detail?id=10972 Bug=10972 Review URL: http://codereview.chromium.org/99018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14662 0039d316-1c4b-4281-b951-d872f2087c98
* Disabling user install testcase to investigate why it fails on the bot and ↵anantha@chromium.org2009-04-271-1/+1
| | | | | | | | not locally. Review URL: http://codereview.chromium.org/99080 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14660 0039d316-1c4b-4281-b951-d872f2087c98
* Update selected line in model before accepting input when the user clicks in ↵shess@chromium.org2009-04-272-5/+6
| | | | | | | | | | the popup. BUG=10932 Review URL: http://codereview.chromium.org/93130 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14659 0039d316-1c4b-4281-b951-d872f2087c98
* Add quarantine metadata to downloads on the Mac. Patch by Stuart Morganmark@chromium.org2009-04-277-1/+128
| | | | | | | | | | | <stuart.morgan@gmail.com>. BUG=10853 Code review URL: http://codereview.chromium.org/99005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14657 0039d316-1c4b-4281-b951-d872f2087c98
* Changes to get multi-process plug-in scaffolding building on Mac.pinkerton@chromium.org2009-04-273-97/+57
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14656 0039d316-1c4b-4281-b951-d872f2087c98
* Its strange that these tests are failing only on bots, but not on local ↵anantha@chromium.org2009-04-272-4/+16
| | | | | | | | machines. I added few checks to get rid of cascading errors. Enabled only one test to see if it passses this time. Review URL: http://codereview.chromium.org/100003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14654 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-12 23:16:52 +0000