| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
| |
While I'm at it, remove references to .dll in comments in the file.
Review URL: http://codereview.chromium.org/27223
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10524 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
VNC servers don't support Xrender. For this use case, we implement a
slow fallback which byte-fiddles the Skia bitmaps as needed to support
32 and 24 bit visuals.
Review URL: http://codereview.chromium.org/27227
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10523 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/28224
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10517 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10508 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
mode. The problem was that RenderProcess was being destructed on both threads at the same time because of the scoped_ptr.
Review URL: http://codereview.chromium.org/27228
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10507 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/28209
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10506 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
ResourceDispatcherTest.CrossSiteAfterCrash
PageLoadTest.Reliability
CrashRecoveryUITest.Reload
CrashRecoveryUITest.LoadInNewTab
Review URL: http://codereview.chromium.org/28208
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10505 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- when started, the focus was not on the page (it was on the location bar, which is not shown)
- ALT-F4 would not work at that point since the location bar was focused but not showing
- since the location bar was focusable, tabbing through would focus it (causing the focus to go to the top window).
BUG=8124,6046,8126
TEST=See bugs.
R=sky
Review URL: http://codereview.chromium.org/28202
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10504 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
window to appear instead of being invisible.
The discovery is that Windows enforces that you call ShowWindow with the value of STARTUPINFO's wShowWindow field first before calling it with any other value, otherwise all subsequent calls are ignored. I used to have code that flattened the return value of a function into something that would ensure the window is visible, but what I actually needed to do was show the window twice in this case. Ick.
http://crbug.com/3126
TEST=Have someone send you a link in a Windows Live Messenger window, click it without Chrome running (Chrome must be default browser), and a Chrome window should appear, visible, loading the link.
Also try running chrome.exe from bash to make sure that still works.
Review URL: http://codereview.chromium.org/27190
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10502 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
It was mistakenly resting the wrong iterator, so I also renamed the outer one to avoid confusion.
BUG=2569
Review URL: http://codereview.chromium.org/28200
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10500 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10498 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10495 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Re-enable the scons code that walks a grd file and adds its dependencies as
build dependencies. This requires that all our dependencies are files in our
source tree (which is what motivated getting rid of the tld data as a
generated resource). I had to fix up the terms of service for this.
Also remove some code that disabled .pak file generation on windows which was
broken because it couldn't find the tld data.
Review URL: http://codereview.chromium.org/28194
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10494 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
TBR=brettw
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10492 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Added a UI test to catch this in the future. Also, in some of the UI tests I added a generic URL for pages that don't care about the content of the page and are just testing visibility of the Find box, etc.
TEST=Covered by tests already.
BUG=8063
Review URL: http://codereview.chromium.org/28162
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10490 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The first attempt to fix this was unsuccessful and crashes showed
up again during the automated ui testing. I still can't reproduce
locally, but when I look again at the crash dump I think that the
fact that it looked like the FindBarView was destroyed is misleading
and the real issue is the same as with the crash in StopFinding
(that web_contents has been destroyed moments before we receive the
request).
I am therefore removing the code I added earlier and replacing it
with a null check for web_contents.
TEST=Covered by automated ui tests.
BUG=8048
Review URL: http://codereview.chromium.org/27219
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10489 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When restoring a session, the browser is shown after a tab is selected causing
the focus to be on the location bar (not tab contents for web pages).
This CL ensures the tab decides where the focus should be after the browser is
shown.
BUG=6000
TEST=See bug
R=sky
Review URL: http://codereview.chromium.org/28156
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10488 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/28170
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10487 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
removed in r10346.
TBR=brettw
Review URL: http://codereview.chromium.org/28195
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10486 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
when the browser window is maximized.
BUG=8025
Review URL: http://codereview.chromium.org/28168
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10485 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The NX X server doesn't support xRGB32 XRENDER picture formats. So, if
we don't find one of those formats, fall back on ARGB32, which is
fine, except that the X server will spend time dealing with an alpha
channel which is all 254 or 255. ARGB32 support is required by the
XRENDER spec.
(This doesn't fix VNC, a patch for that is forthcoming.)
Review URL: http://codereview.chromium.org/28192
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10484 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10483 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/27215
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10482 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/28169
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10481 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/28127
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10480 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/28185
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10479 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/27216
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10478 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
this when sorting the contents of a bookmark folder.
BUG=1750
TEST=none
Review URL: http://codereview.chromium.org/28175
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10477 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
the UI.
If we do that, the result is the layout-dependent. For instance, in fr-FR layout, we get 'a with grave' in place of '0' for Ctrl+0 (normal in Zoom menu). Besides, in Slovak lazout, we get 'e with accent'
This CL does not affect the actual behavior of accelerators (see issue 8043 for that), but only change the way they're displayed in the menu (even without this CL, ctrl-0 works fine in fr-FR AZERY layout and Slovak layout).
BUG=7444
TEST=Change your kbd layout to French Azery and see what key is shown next to 'Normal' in Page-Zoom menu. It should be 'Ctrl+0'.
Review URL: http://codereview.chromium.org/28121
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10476 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=jam
BUG=8119
Review URL: http://codereview.chromium.org/28190
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10475 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/27193
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10474 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
We previously crashed with a NOTREACHED() when you clicked the go button.
Review URL: http://codereview.chromium.org/27205
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10473 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
We are hopefully over our zombie problems, and this can cause other troubles. This should also improve startup performance, since we don't need to iterate all processes on the system on startup.
BUG=6468
Review URL: http://codereview.chromium.org/27203
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10471 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/28188
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10470 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
is. Will fix and recommit.
Review URL: http://codereview.chromium.org/28186
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10469 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/27212
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10468 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Have the IAT patcher take some "ownership" of the DLL, by taking a library name and then calling LoadLibrary() / FreeLibrary() to manage the reference count. This means as long is there isn't some other reference count balancing bug happening in the process, the DLL will never be unloaded while we are patched.
This effectively reverts r9929, the VirtualQuery additional checks are removed.
BUG=7701
Review URL: http://codereview.chromium.org/21453
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10467 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
A recommit of http://codereview.chromium.org/27056 .
Review URL: http://codereview.chromium.org/28136
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10464 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=mark@chromium.org
Review URL: http://codereview.chromium.org/27209
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10462 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- compile resource_bundle
- add resource_bundle_mac by cloning the linux and using some NSBundle to find
the files.
- enable resource bundles on the mac in the calling code.
- added script to app target to repack .pak files into larger chunks (chrome,
theme, and localized bits).
- added script to copy repacked files into the app bundle.
Review URL: http://codereview.chromium.org/28171
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10460 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
RenderView running developer tools front-end instantiates DevToolsClient that handles IPC communication with DevToolsAgent.
All messages are wrapped and routed through browser process.
darin: please look at changes related to messages handling in RenderView
jam: please review handling of forwarded messages in DevToolsClient and DevToolsAgent.
Review URL: http://codereview.chromium.org/21543
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10459 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/28180
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10458 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/28120
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10457 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
To fix this issue, this change adds a new function TrimWhitespaceUTF8(), which trims space characters (including non-printable characters and broken UTF-8 characters) from either end of a UTF-8 string.
Please feel free to give me your comments since I'm not sure this implimentation is correct. (Maybe this implementation trims too aggressively.)
BUG=7377
Review URL: http://codereview.chromium.org/20219
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10456 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
they were represented as int type+string body).
I stole IPC::Message serialization code from jam's CL(http://codereview.chromium.org/20413).
jam: please look at message forwarding code. When tools messages are send from browser to renderer they are also wrapped(unlike worker messages which are unwrapped and sent as is). It allows to describe developer tools messages in its own file instead of putting all of them into render_messages_internal.h
brettw: please check if it's OK to have ForwardMessageToToolsClient in WebContentsView
Review URL: http://codereview.chromium.org/21540
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10455 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/28177
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10454 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
build following r10436.
Review URL: http://codereview.chromium.org/28176
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10453 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/27196
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10451 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
true for all the versions we support (or test on)
bug: 7735
Review URL: http://codereview.chromium.org/27171
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10444 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/27192
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10443 0039d316-1c4b-4281-b951-d872f2087c98
|