summaryrefslogtreecommitdiffstats
path: root/chrome
Commit message (Collapse)AuthorAgeFilesLines
* Hook up browser cursors on linux.estade@chromium.org2009-02-133-2/+26
| | | | | | Review URL: http://codereview.chromium.org/21358 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9785 0039d316-1c4b-4281-b951-d872f2087c98
* Port remaining .rc data resource files to grd. This includestc@google.com2009-02-1326-138/+157
| | | | | | | | debugger_resources.rc, common_resources.rc, and renderer_resources.rc. Review URL: http://codereview.chromium.org/21307 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9784 0039d316-1c4b-4281-b951-d872f2087c98
* Originally this change was intended as the solution to accidentally ↵idanan@google.com2009-02-131-3/+2
| | | | | | | | | | | maximizing Chrome by double-clicking on the new tab button. This solution does work but another one is being coded for a more general problem. This change solves also the accidental maximizing of Chrome when double-clicking the close tab button except on the last tab (rightmost in LTR systems). See issue 2827 for further details.This change removes a band-aid which did not perform a hit-test on the tab-strip while it is animating in order to avoid unknown chromebot crashes as reported by Ben. The removal of the fix makes the hit-test perform as expected.Trying this now, at Peter's suggestion, so that we can measure and diagnose potential problems hidden by the said band-aid. [NOTE] Revied and approved as http://codereview.chromium.org/20329 by Peter kasting. Had to copy changes to repo where I have commit rights. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9777 0039d316-1c4b-4281-b951-d872f2087c98
* Add debugger_shell to the POSIX build.thestig@chromium.org2009-02-132-6/+8
| | | | | | | Reviewed in issue 20321. Got reverted, but was not the cause of the debugger test failure. Review URL: http://codereview.chromium.org/21355 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9776 0039d316-1c4b-4281-b951-d872f2087c98
* add infobar_delegate.cc to the buildtc@google.com2009-02-136-26/+25
| | | | | | | Review URL: http://codereview.chromium.org/20341 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9774 0039d316-1c4b-4281-b951-d872f2087c98
* Fix an off-by-one error in posix backing store scrolling.estade@chromium.org2009-02-131-1/+1
| | | | | | | | This error (sometimes) caused a crash when scrolling all the way to the bottom of a page and then attempting to scroll back up. Review URL: http://codereview.chromium.org/20361 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9768 0039d316-1c4b-4281-b951-d872f2087c98
* Make system menus show up at the right place for all frames, whether they're ↵pkasting@chromium.org2009-02-1312-155/+141
| | | | | | | | | | | | | | | | triggered by clicking the window icon or hitting alt-space. Make clicking the icon for windows without a non-client view (e.g. the Bookmark Manager on Aero Glass) bring up the system menu. Clean up more dead code, verbose code, or unnecessary statics/members. TEST=Right-click titlebars, hit alt-space, and left-click window icons (where present), for: * Main window * Dialogs, e.g. the bookmark manager * Popups * App windows When right-clicking, a system menu should appear at the cursor. For the other cases, a system menu should appear at the system native location (roughly just below the titlebar). Review URL: http://codereview.chromium.org/20225 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9766 0039d316-1c4b-4281-b951-d872f2087c98
* Don't focus unfocusable things.pkasting@chromium.org2009-02-135-12/+11
| | | | | | Review URL: http://codereview.chromium.org/20348 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9765 0039d316-1c4b-4281-b951-d872f2087c98
* Make some functions const. This will help with my fullscreen mode changes.pkasting@chromium.org2009-02-138-13/+23
| | | | | | | The only tricky bit here is how GetBookmarkBarView() is no longer guaranteed to return non-NULL. The only caller of this is the automation framework, in one place, which explicitly NULL-checks the result and does the right thing, so there should not be any problems. Review URL: http://codereview.chromium.org/23026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9764 0039d316-1c4b-4281-b951-d872f2087c98
* Register Metrics prefs for Mac and Linux.avi@chromium.org2009-02-131-3/+3
| | | | | | | http://codereview.chromium.org/20350 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9763 0039d316-1c4b-4281-b951-d872f2087c98
* A patch from external contributor Yong Shin (already in AUTHORS list). I ↵finnur@google.com2009-02-131-18/+18
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | also removed some lint errors. This was reviewed by me and Scott TBR=sky Original changelist description (http://codereview.chromium.org/17608): Context menu for title bar doesn't appear when a tab's context menu was open. --------------------------------------------------------------------------- * About the Bug --------------------------------------------------------------------------- - What steps will reproduce the problem? 1. Open the context menu for a tab of your choice. 2. Right-click on the title bar. - What is the expected result? The application context menu should show up. - What happens instead? Nothing (The tab's context menu is correctly closed, of course). - What is the reason? The context menu for an App is displayed when WM_NCRBUTTONDOWN event is processed on the Window::OnNCRButtonDown() handler. In normal case, when the right mouse button is clicked on the NC area, this event is generated. But in the case that the context menu for a tab is being displayed, WM_NCRBUTTONDOWN is not received. Instead, WM_NCLBUTTONDOWN is generated. (This is wrong because left mouse button is never pressed.) So the right handler (Window::OnNCRButtonDown()) cannot be called. --------------------------------------------------------------------------- * About the Fix --------------------------------------------------------------------------- What is modified? Modified MenuController::RepostEvent() method. This function is called when the mouse button is pressed while the context menu for a tab is being displayed. In this function, following two steps occur in order. 1st. Determine the event type. 2nd. Post this event using PostMessage(). On the 2nd step, In the case that the determined event on the 1st step is for the client area, there's no problem. But in the case of the non-client area, it doesn't use the right event type but use the fixed event type (WM_NCLBUTTONDOWN). This is the wrong implementation. So, I modified this part so that it use the right event type. Bug=5695 http://crbug.com/5695 Review URL: http://codereview.chromium.org/21354 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9761 0039d316-1c4b-4281-b951-d872f2087c98
* Fix an issue with HWNDView visibility where invisible (i.e. ↵pkasting@chromium.org2009-02-132-5/+3
| | | | | | | | SetVisible(false)) views would have ShowWindow() called on them, which was bogus. Review URL: http://codereview.chromium.org/21333 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9760 0039d316-1c4b-4281-b951-d872f2087c98
* Fix some focus traversal issues:pkasting@chromium.org2009-02-131-11/+9
| | | | | | | | * When we're on the only focusable view, AdvanceFocus() should just focus us again. * When only one focusable view exists, FindLastFocusableView() should return it, not NULL. Also the code here was longer than it needed to be. Review URL: http://codereview.chromium.org/20347 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9759 0039d316-1c4b-4281-b951-d872f2087c98
* Hack to get CG functions working in the OS X sandbox.jeremy@chromium.org2009-02-131-0/+15
| | | | | | Review URL: http://codereview.chromium.org/21324 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9758 0039d316-1c4b-4281-b951-d872f2087c98
* Disable Native Crash reporting on OS X, till we enable Breakpad integration.jeremy@chromium.org2009-02-131-0/+5
| | | | | | See http://crbug.com/7652 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9757 0039d316-1c4b-4281-b951-d872f2087c98
* Check for hung plugin windows before detaching themjoshia@google.com2009-02-131-1/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | The process of detaching plugin windows from tab window involves windows messages across browser and plugin process. If the pungin process is hung this hangs the browser shutdown sequence. This workaround first checks if the plugin is responsive before detaching its window from the tab. If a plugin is hung, it's window would not be detached (and would be destroyed with the tab window). The side effect of not detaching is that some plugins expect their window to be valid until they get NPAPI shut down notifications and may crash if those notifications were sent after the window was destroyed. But since the plugin is hung anyway, we can go ahead not detaching the window. Plugin process will be cleaned up later. BUG=3613 Review URL: http://codereview.chromium.org/20301 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9756 0039d316-1c4b-4281-b951-d872f2087c98
* Platform cleanup in chrome/browser/history/history_unittest.cc.phajdan.jr@chromium.org2009-02-131-41/+38
| | | | | | Review URL: http://codereview.chromium.org/21314 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9751 0039d316-1c4b-4281-b951-d872f2087c98
* Remember that we've white listed a certificate when we switch to a new tab.abarth@chromium.org2009-02-1310-53/+204
| | | | | | | | R=wtc BUG=6456 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9749 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 9747abarth@chromium.org2009-02-139-201/+53
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9748 0039d316-1c4b-4281-b951-d872f2087c98
* Remember that we've white listed a certificate when we switch to a new tab.abarth@chromium.org2009-02-139-53/+201
| | | | | | | | | R=wtc BUG=6456 Review URL: http://codereview.chromium.org/20296 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9747 0039d316-1c4b-4281-b951-d872f2087c98
* The WebFrame interface currently supports reference counting, but no one uses.darin@chromium.org2009-02-133-7/+6
| | | | | | | | | | | | | | | | Internally, WebFrameImpl needs reference counting, so we still define it there. Same goes for WebView and WebWidget. While making this change, I noticed that WebInspectorClient was casting WebView pointers to WebViewImpl pointers too much. By just starting with WebViewImpl pointers, things could be cleaned up considerably. R=brettw Review URL: http://codereview.chromium.org/21342 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9745 0039d316-1c4b-4281-b951-d872f2087c98
* Fixing reverse tabbing.tommi@chromium.org2009-02-131-2/+2
| | | | | | Review URL: http://codereview.chromium.org/21341 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9744 0039d316-1c4b-4281-b951-d872f2087c98
* Stop crash in renderer at the end of displayingjrg@chromium.org2009-02-131-4/+0
| | | | | | | | | | | | | | | http://dev.chromium.org. Now that webkit merge has landed, actually create a RenderView in RenderThread. With these changes, there is only manual tweak needed (locally called "disable-button.diff") to get bits on the screen for OSX without crashing. Review URL: http://codereview.chromium.org/20349 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9743 0039d316-1c4b-4281-b951-d872f2087c98
* Fixing the buildhclam@chromium.org2009-02-131-1/+1
| | | | | | | | I commited a patch with typo, this patch should fix it. Review URL: http://codereview.chromium.org/21339 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9742 0039d316-1c4b-4281-b951-d872f2087c98
* Some consumers in the renderer process need access to an IO message loop, ↵hclam@chromium.org2009-02-132-0/+14
| | | | | | | | | | RenderThread which holds WebKit runs on a message loop with type TYPE_DEFAULT, so we need to expose the owner loop of RenderThread which has type TYPE_IO. That particular message loop is used for handling all IPC messages, so we need to be cautious about using this message loop and don't block on it. Review URL: http://codereview.chromium.org/21318 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9741 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: build fixagl@chromium.org2009-02-131-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9738 0039d316-1c4b-4281-b951-d872f2087c98
* POSIX: fix Mac buildagl@chromium.org2009-02-131-0/+3
| | | | | | | (It worked on the try bot, what's different with the builders?) git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9737 0039d316-1c4b-4281-b951-d872f2087c98
* POSIX: Add FileDescriptorSet unittestagl@chromium.org2009-02-133-0/+164
| | | | | | | Review URL: http://codereview.chromium.org/21296 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9736 0039d316-1c4b-4281-b951-d872f2087c98
* Missing file, broken buildcpu@google.com2009-02-131-0/+24
| | | | | | | | | TBR=huanr Review URL: http://codereview.chromium.org/21335 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9735 0039d316-1c4b-4281-b951-d872f2087c98
* Test for Symantec SEPcpu@google.com2009-02-135-2/+108
| | | | | | | | | | | | - Versions before 11MR3 crash chrome - Still need to wire the code. BUG=38 Review URL: http://codereview.chromium.org/24015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9733 0039d316-1c4b-4281-b951-d872f2087c98
* Add TableModel to the scaffold, so we don't depend on views.thestig@chromium.org2009-02-133-0/+25
| | | | | | Review URL: http://codereview.chromium.org/21315 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9730 0039d316-1c4b-4281-b951-d872f2087c98
* Add installer error strings for localizationcpu@google.com2009-02-132-0/+6
| | | | | | | | | | - Conflict with another application (such as Kingsoft Powerword) BUG=3868 Review URL: http://codereview.chromium.org/21316 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9727 0039d316-1c4b-4281-b951-d872f2087c98
* Try and make the GetXXXBounds() functions share more code to be shorter, and ↵pkasting@chromium.org2009-02-133-24/+19
| | | | | | | | change a name to make it a bit clearer. No user-visible change. Review URL: http://codereview.chromium.org/21332 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9726 0039d316-1c4b-4281-b951-d872f2087c98
* Add ability to set a flag in the Label view class that tells it tomunjal@chromium.org2009-02-133-0/+22
| | | | | | | | return a preferred size of 0, 0 when the label is not visible. Review URL: http://codereview.chromium.org/21313 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9725 0039d316-1c4b-4281-b951-d872f2087c98
* Fewer NOTIMPLEMENTED()s, more comments.evan@chromium.org2009-02-131-1/+5
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9724 0039d316-1c4b-4281-b951-d872f2087c98
* Remove a NOTIMPLEMENTED(). It's obviously wrong and we will be revisitingevan@chromium.org2009-02-131-1/+0
| | | | | | | it with plugins anyway. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9723 0039d316-1c4b-4281-b951-d872f2087c98
* Relocate a NOTIMPLEMENTED() to its proper place.evan@chromium.org2009-02-132-6/+7
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9722 0039d316-1c4b-4281-b951-d872f2087c98
* Fix build break.paul@chromium.org2009-02-131-1/+1
| | | | | | | TBR=evan git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9721 0039d316-1c4b-4281-b951-d872f2087c98
* Port most of MetricsService to Mac and linux.paul@chromium.org2009-02-139-36/+47
| | | | | | Review URL: http://codereview.chromium.org/20338 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9720 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 9706. Hopefully this will fix the broken debugger_test.thestig@chromium.org2009-02-132-8/+6
| | | | | | Review URL: http://codereview.chromium.org/21329 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9717 0039d316-1c4b-4281-b951-d872f2087c98
* Fix tiny fonts in Mac/Linux. Tony deserves credit for this.evan@chromium.org2009-02-132-0/+10
| | | | | | | Review URL: http://codereview.chromium.org/21323 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9716 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 9698.joshia@google.com2009-02-121-2/+0
| | | | | | | | TBR=nsylvain Review URL: http://codereview.chromium.org/20332 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9711 0039d316-1c4b-4281-b951-d872f2087c98
* Remove firefox[23]_importer.cc from the POSIX build.thestig@chromium.org2009-02-121-0/+4
| | | | | | | Another step in fixing the dynamic run. Review URL: http://codereview.chromium.org/20323 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9707 0039d316-1c4b-4281-b951-d872f2087c98
* Add debugger_shell to the POSIX build.thestig@chromium.org2009-02-122-6/+8
| | | | | | | Fixes static linking for the chrome executable on Linux. Review URL: http://codereview.chromium.org/20321 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9706 0039d316-1c4b-4281-b951-d872f2087c98
* Sort all the files w/in the compile sources step of the targets.thomasvl@chromium.org2009-02-121-4/+4
| | | | | | Review URL: http://codereview.chromium.org/21311 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9705 0039d316-1c4b-4281-b951-d872f2087c98
* Reapply of Tony's r9656 (Add chrome/browser/ssl/ssl_manager.cc to the build.)estade@chromium.org2009-02-129-68/+64
| | | | | | | | | | | Also port 2 more files in browser/ssl to posix * ssl_policy * ssl_blocking_page Review URL: http://codereview.chromium.org/21297 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9703 0039d316-1c4b-4281-b951-d872f2087c98
* Pump events to the renderer. Doesn't work currently due to activation issues.avi@chromium.org2009-02-125-6/+153
| | | | | | Review URL: http://codereview.chromium.org/21306 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9702 0039d316-1c4b-4281-b951-d872f2087c98
* Add a --load-plugin flag to load an NPAPI plugin from an arbitrary location.mpcomplete@google.com2009-02-123-0/+12
| | | | | | | This is to support running Chromebot to exercise a given NPAPI plugin. Review URL: http://codereview.chromium.org/21279 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9701 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup step 2, now all sources are in the right folders and sorted.thomasvl@chromium.org2009-02-121-50/+58
| | | | | | | | Created a missing source group. Still need to deal w/ targets, but checkpointing for conflicts. Review URL: http://codereview.chromium.org/21309 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9699 0039d316-1c4b-4281-b951-d872f2087c98
* Fix output dir for generated resourcesjoshia@google.com2009-02-121-91/+93
| | | | | | | | TBR=tony Review URL: http://codereview.chromium.org/21308 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9698 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-06-15 19:34:37 +0000