summaryrefslogtreecommitdiffstats
path: root/chrome
Commit message (Collapse)AuthorAgeFilesLines
* Fix --kiosk to work regardless of the startup pref setting or supplied URLs. pkasting@chromium.org2010-08-033-15/+23
| | | | | | | | | | This also fixes a bug in Linux Views where calling BrowserWindow::Show() wouldn't synchronously call BrowserList::SetLastActive(). This happens naturally in Windows and was already explicitly done in BrowserWindowGtk and BrowserWindowCocoas, but missing it for Linux Views resulted in crashes when the kiosk code tried to get the last active window before the message loop had pumped the async activation change message. BUG=none TEST=Set Chrome to "open windows and tabs from last time", then run with --kiosk. Should start in kiosk mode (fullscreen, no status bubble). Review URL: http://codereview.chromium.org/2847090 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54643 0039d316-1c4b-4281-b951-d872f2087c98
* Mark PPAPITest.PaintAggregator flakynick@chromium.org2010-08-031-1/+2
| | | | | | | | | BUG=51012 TEST=ui_tests Review URL: http://codereview.chromium.org/3064031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54639 0039d316-1c4b-4281-b951-d872f2087c98
* Use the blue style for the save password info bar.tfarina@chromium.org2010-08-021-11/+13
| | | | | | | | | | BUG=47233 TEST=go to mail.google.com, log in, wait until the info bar appears, see if the info bar has a blue background. Review URL: http://codereview.chromium.org/3080016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54634 0039d316-1c4b-4281-b951-d872f2087c98
* Fix for RenewAuthToken crash. Extend life of AuthWatcher.chron@chromium.org2010-08-021-1/+9
| | | | | | | | | TEST=Open and close browser repeatedly. BUG=50955 Review URL: http://codereview.chromium.org/3034045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54633 0039d316-1c4b-4281-b951-d872f2087c98
* Fix mac build for sync integration tests.rsimha@chromium.org2010-08-021-0/+3
| | | | | | | | | | | | | The sync integration tests are missing some dependencies on mac, as a result of which they crash when they are run. Adding this build flag seems to fix the problem elsewhere in chrome_tests.gypi. BUG=50789 TEST=sync_integration_tests Review URL: http://codereview.chromium.org/3057030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54632 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes a crash seen on chrome frame reliability test runs. We need to ↵ananta@chromium.org2010-08-021-4/+6
| | | | | | | | | | | | | | | validate the iterator from the render view map in the SetCookies IPC as well as the render view could be in the process of being deleted Fixes bug http://code.google.com/p/chromium/issues/detail?id=50966 Bug=50966 TBR=amit Review URL: http://codereview.chromium.org/3050030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54629 0039d316-1c4b-4281-b951-d872f2087c98
* Make sure we fully remove child context menu items when deleting a parent.asargent@chromium.org2010-08-023-20/+91
| | | | | | | | | BUG=49742 TEST=Follow steps in the bug report Review URL: http://codereview.chromium.org/3081009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54628 0039d316-1c4b-4281-b951-d872f2087c98
* Start of a more restricitve sandbox policy for flash on windowscpu@chromium.org2010-08-021-0/+44
| | | | | | | | | | | | | | - This only works with --safe-plugins and the built-in-flash - Removing all file IO BUG=50796 TEST= use --safe-plugins and observe flash still works (for most sites) Review URL: http://codereview.chromium.org/3043039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54626 0039d316-1c4b-4281-b951-d872f2087c98
* Win: Don't give some downloads duplicate extensions like .arj.arjthakis@chromium.org2010-08-022-2/+29
| | | | | | | | | BUG=49621 TEST=See bug. Also unittests. Review URL: http://codereview.chromium.org/3069018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54625 0039d316-1c4b-4281-b951-d872f2087c98
* enable apps by defaulterikkay@chromium.org2010-08-0212-37/+12
| | | | | | | | | BUG=none TEST=run Chrome with no command line flags, apps should be enabled Review URL: http://codereview.chromium.org/3015043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54624 0039d316-1c4b-4281-b951-d872f2087c98
* Return an error code to extensions requesting a resource that requires basicmpcomplete@chromium.org2010-08-021-1/+4
| | | | | | | | | | | HTTP authentication. BUG=31388 TEST=test that basic HTTP authentication still works Review URL: http://codereview.chromium.org/2824063 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54622 0039d316-1c4b-4281-b951-d872f2087c98
* Fix wrong use of substr in autofill fix for bug 49172inferno@chromium.org2010-08-021-1/+1
| | | | | | | | | BUG=49172 TEST=None Review URL: http://codereview.chromium.org/3035046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54619 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 54429 - Suppress a reliability crash.nick@chromium.org2010-08-021-3/+0
| | | | | | | | | | | | BUG=50822 TEST=reliability bot goes green. TBR=vandebo Review URL: http://codereview.chromium.org/2883049 TBR=thestig@chromium.org Review URL: http://codereview.chromium.org/3046040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54618 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 54435 - Suppress a reliability crash (try 2)nick@chromium.org2010-08-021-1/+1
| | | | | | | | | | | | BUG=50822 TEST=reliability bot goes green. TBR=vandebo Review URL: http://codereview.chromium.org/3040029 TBR=thestig@chromium.org Review URL: http://codereview.chromium.org/2819087 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54617 0039d316-1c4b-4281-b951-d872f2087c98
* Enable autofill tests on winnirnimesh@chromium.org2010-08-021-2/+0
| | | | | | | | | | Has been fixed by Alyssa in r54552 BUG=50904 Review URL: http://codereview.chromium.org/2808089 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54615 0039d316-1c4b-4281-b951-d872f2087c98
* Address a TODO: use HostPortPair rather than a naked host string.eroman@chromium.org2010-08-021-8/+4
| | | | | | Review URL: http://codereview.chromium.org/3047033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54613 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor cros_in_process_browser_test to separate the mock initialization.chaitanyag@chromium.org2010-08-0212-387/+551
| | | | | | Review URL: http://codereview.chromium.org/3012017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54612 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes bug where border highlight was drawn wrong forsky@chromium.org2010-08-021-3/+8
| | | | | | | | | | | increment/decrement button in wrench menu. BUG=50959 TEST=see bug Review URL: http://codereview.chromium.org/3056039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54610 0039d316-1c4b-4281-b951-d872f2087c98
* Make life easier for dirkjrg@chromium.org2010-08-021-0/+3
| | | | | | Review URL: http://codereview.chromium.org/3040031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54609 0039d316-1c4b-4281-b951-d872f2087c98
* When dropping a tab torn from a maximized window, inherit the restored size ↵pkasting@chromium.org2010-08-029-30/+17
| | | | | | | | | | and maximized state, instead of creating a restored window at the maximized size. BUG=22154 TEST=Drag a tab from a maximized window and drop it; it should create a maximized window. Review URL: http://codereview.chromium.org/3032039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54607 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the wrong substr use in autofill fix for bug 49332.inferno@chromium.org2010-08-021-1/+1
| | | | | | | | | BUG=49332 TEST=None Review URL: http://codereview.chromium.org/2808091 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54606 0039d316-1c4b-4281-b951-d872f2087c98
* Display an infobar after enrolling a client certificatedavidben@chromium.org2010-08-0210-60/+325
| | | | | | | | | | | | This gives the user some feedback that we added a certificate. R=wtc,brettw TEST=none BUG=50782 Review URL: http://codereview.chromium.org/2815023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54602 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes a crash seen on chrome frame reliability test runs. The crash occurs ↵ananta@chromium.org2010-08-022-9/+31
| | | | | | | | | | | | | | | while servicing the GetCookies IPC from the renderer and routing it over the automation channel to the host. It looks like the render view is in the process of being deleted and thus it does not exist in the render view map. Fixes bug http://code.google.com/p/chromium/issues/detail?id=50966 Bug=50966 Review URL: http://codereview.chromium.org/2878067 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54593 0039d316-1c4b-4281-b951-d872f2087c98
* DOMUI prefs: Remove use of tables for layout in Personal panestuartmorgan@chromium.org2010-08-024-156/+104
| | | | | | | | | | | | | In addition clean up the JS for showing/hiding sections of controls so that it's class-based rather than manipulating raw styles. Also fixes registration order of the top-level prefs (where order matter). BUG=None TEST=DOMUI Personal prefs still display and work correctly. Review URL: http://codereview.chromium.org/3037030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54590 0039d316-1c4b-4281-b951-d872f2087c98
* Don't leak memory when displaying a SFChooseIdentityPaneldavidben@chromium.org2010-08-021-26/+32
| | | | | | | | | | | | | | | | | | | | SFChooseIdentityPanel has rather non-standard (buggy) referencing semantics as compared to other sheets. In particular, it fails to take a reference to itself while open. It also takes a reference to its delegate, introducing a reference cycle in our implementation. This removes the panel reference in the delegate, in light of the second behavior, and works around problems caused by the first with an autorelease. Also avoids an indexing error in release mode should a DCHECK fail. R=wtc,mark BUG=none TEST=displaying certificate selections still work in OS X Review URL: http://codereview.chromium.org/3044036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54588 0039d316-1c4b-4281-b951-d872f2087c98
* Remove some code that seems unnecessary now that the distributor logo is dead.pkasting@chromium.org2010-08-021-18/+1
| | | | | | | | BUG=none TEST=Window frame still looks OK after switching themes or resizing Review URL: http://codereview.chromium.org/3053025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54587 0039d316-1c4b-4281-b951-d872f2087c98
* AutoFill Credit Card matching for Diners Club incorrectdhollowa@chromium.org2010-08-021-1/+1
| | | | | | | | | | | Changes matching logic for Diner's club card. BUG=50976 TEST=none Review URL: http://codereview.chromium.org/3061043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54582 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes bug where toggling side tabs wouldn't do a Layout. This was asky@chromium.org2010-08-022-1/+9
| | | | | | | | | | | result of recent changes to View::Layout BUG=chromium-os:4637 TEST=see bug Review URL: http://codereview.chromium.org/3056017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54581 0039d316-1c4b-4281-b951-d872f2087c98
* Unlink SingletonLock and SingletonSocket to allow for reusing profile ↵pathorn@chromium.org2010-08-021-27/+41
| | | | | | | | | | | directory between tests. BUG=50454 TEST=Run ui_tests --user-data-dir=/tmp/foo Review URL: http://codereview.chromium.org/3053020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54575 0039d316-1c4b-4281-b951-d872f2087c98
* Fix language detection with short text pages.jcivelli@chromium.org2010-08-021-7/+6
| | | | | | | | | | | | Changed CLD wrapper function to return the number of bytes used for language detection, and using that in the render view to ignore detection for short texts. BUG=45156 TEST=Visit www.voila.fr, an infobar should show reporting the page is in French. Visit http://jdvhotels.com/calendar.html?datetime=1274857200000&id=0, no translate infobar should show. Review URL: http://codereview.chromium.org/3038018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54568 0039d316-1c4b-4281-b951-d872f2087c98
* Modify display of time in net-internals to be more humancbentzel@chromium.org2010-08-022-7/+29
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | readable. The right pane on the Requests tab now displays the local time the selected request was started at the top of each log page. The time, in milliseconds, of each event relative to the source's first event is displayed in a new "[st=#]" column. In the Data tab, after pressing dump to text, request entries also display the information mentioned above. Also, the local time is displayed in human readable format for each "Host resolver cache" entry. Note that just updating the two modified files may not result in the pak file they're merged into being rebuilt. On Linux, touching chrome/browser/resources/net_internals/index.html seems to do the trick. On Windows, just forcing chrome_extra_resources to be rebuilt manually works as well. BUG=41799 TEST=Go to the aforementioned tabs on about:net-internals and confirm the time is displayed. Review URL: http://codereview.chromium.org/2868079 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54567 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Revert 53989 - Implement new mock for user options page per ↵xiyuan@chromium.org2010-08-0210-71/+216
| | | | | | | | | | | | | | chromium-os:5028" This reverts commit r54128. TBR=dhg@chromium.org BUG=chromium-os:5028 TEST=erify the user options page matches mock per chromium-os:5028. Note the underlying libcros is still missing and UI shows up mock data only. Review URL: http://codereview.chromium.org/3071013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54566 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 54560 - nick@chromium.org2010-08-0222-106/+91
| | | | | | | | | | | | | | | | Change removing method, GetBrowser from TabContentsDelegate, as this was breaking an abstraction layer. This routine was originally added in CL 434046, which required the Browser* to construct extension popup views from within Chrome-Frame instances. I changed all accesses to Browser instances from usage of the above method, to either iterating the BrowserList using the situation-specific profile as a search key, or modifying the appropriate delegate interfaces to provide the functionality that was previously used directly via the Browser. BUG=None TEST=None Review URL: http://codereview.chromium.org/2941001 TBR=twiz@google.com Review URL: http://codereview.chromium.org/3012042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54565 0039d316-1c4b-4281-b951-d872f2087c98
* Initial locale is used if current locale is not handled by manifest.glotov@chromium.org2010-08-021-4/+9
| | | | | | | | | BUG=chromium:3178 TEST=none Review URL: http://codereview.chromium.org/3036034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54563 0039d316-1c4b-4281-b951-d872f2087c98
* Add referrer to the NavigationInfo struct.tommi@chromium.org2010-08-022-0/+6
| | | | | | | | | TEST=n/a BUG=none Review URL: http://codereview.chromium.org/3036030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54562 0039d316-1c4b-4281-b951-d872f2087c98
* Change removing method, GetBrowser from TabContentsDelegate, as this was ↵twiz@google.com2010-08-0222-91/+106
| | | | | | | | | | | | | breaking an abstraction layer. This routine was originally added in CL 434046, which required the Browser* to construct extension popup views from within Chrome-Frame instances. I changed all accesses to Browser instances from usage of the above method, to either iterating the BrowserList using the situation-specific profile as a search key, or modifying the appropriate delegate interfaces to provide the functionality that was previously used directly via the Browser. BUG=None TEST=None Review URL: http://codereview.chromium.org/2941001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54560 0039d316-1c4b-4281-b951-d872f2087c98
* Updating trunk VERSION from 483.0 to 484.0chrome-release@google.com2010-08-021-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54556 0039d316-1c4b-4281-b951-d872f2087c98
* Issue 4072: App panels don't look right on Chromium OSstevenjb@chromium.org2010-08-021-1/+1
| | | | | | | | | BUG=chromeos:4072 http://code.google.com/p/chromium-os/issues/detail?id=4072 TEST=See issue. Review URL: http://codereview.chromium.org/2819076 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54554 0039d316-1c4b-4281-b951-d872f2087c98
* Fix pyauto AutoFill hook/test based on new CC functionality.alyssad@chromium.org2010-08-023-5/+3
| | | | | | | | With this CL: http://codereview.chromium.org/3010041 credit cards were changed so that the type is determined based upon the number. Fixing the pyauto test to pass with new functionality. Review URL: http://codereview.chromium.org/3084004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54552 0039d316-1c4b-4281-b951-d872f2087c98
* Fix test for valid UTF-16 input.evan@chromium.org2010-08-021-1/+1
| | | | | | | | | | | I got this wrong initially; Ningxin wrote a patch to fix it, which agl then also got wrong. So I am relanding Ningxin's original patch. Patch by Ningxin Hu <ningxin.hu@intel.com>. Review URL: http://codereview.chromium.org/3029048 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54551 0039d316-1c4b-4281-b951-d872f2087c98
* DISABLE ConnectionTesterTest.RunAllTestscbentzel@chromium.org2010-08-021-1/+3
| | | | | | | | | | | Mac Valgrind bot is consistently complaining a pure virtual method being called. The root cause is not obvious (i.e. calling directly in a constructor/destructor). BUG=50950 TBR=eroman Review URL: http://codereview.chromium.org/3087002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54549 0039d316-1c4b-4281-b951-d872f2087c98
* Remove dead command line flaggavinp@google.com2010-08-021-1/+0
| | | | | | | | | | | | kDisablePrefetch was dead, and declared without defintion. It was missed in an earlier CL, and should be removed now. BUG=none TEST=none Review URL: http://codereview.chromium.org/3043043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54548 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity 12013: Uninitialized member in LocationBarViewfinnur@chromium.org2010-08-021-0/+1
| | | | | | | | | BUG=None TEST=None Review URL: http://codereview.chromium.org/3018028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54545 0039d316-1c4b-4281-b951-d872f2087c98
* Uninitialized member in IndexedDBKey.finnur@chromium.org2010-08-021-1/+2
| | | | | | | | | | BUG=None TEST=None CID=11644 Review URL: http://codereview.chromium.org/3073011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54544 0039d316-1c4b-4281-b951-d872f2087c98
* New pyauto translate hook: wait until translation complete.alyssad@chromium.org2010-08-023-0/+67
| | | | | | | | This hook allows tests to wait until translation has been completed after visiting a page that should be automatically translated. Review URL: http://codereview.chromium.org/3074014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54543 0039d316-1c4b-4281-b951-d872f2087c98
* Pass background to WizardController after new user login. This fixes ↵avayvod@chromium.org2010-08-021-3/+3
| | | | | | | | | | | | SEGFAULT after new user login. BUG=chromium-os:5250 TEST=Login as new user and verify that Chrome doesn't crash and camera screen is shown. TBR=dpolukhin Review URL: http://codereview.chromium.org/3010044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54542 0039d316-1c4b-4281-b951-d872f2087c98
* A/B test for measuring effect of number of proxy connections.ziadh@chromium.org2010-08-023-1/+80
| | | | | | | | | | | | | | | | | Currently, we limit the number of connections per proxy server to 32 (raised from 15). Firefox uses 8. A low value keeps from overloading the proxy servers; at the same time, some users may hit the limit (since we use the same number for both HTTP and SOCKS proxies). This experiment selects a different number at browser launch (from the set [8, 16, 32, 64]), and attempts to look at certain stats to get a clearer picture of how this affects the user. BUG=44501 r=jar Review URL: http://codereview.chromium.org/3033045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54541 0039d316-1c4b-4281-b951-d872f2087c98
* Replace obsolete kProfile switch with kLoginProfilecmasone@google.com2010-08-027-16/+7
| | | | | | | | | BUG=50866 TEST=it compiles Review URL: http://codereview.chromium.org/3013050 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54539 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 54535jorlow@chromium.org2010-08-023-3438/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54537 0039d316-1c4b-4281-b951-d872f2087c98
* Introduce a preliminary version of the sidebar API.akoub@google.com2010-08-023-1/+3438
| | | | | | | | | BUG=2872660 TEST=open the experimental.sidebar.html page. Review URL: http://codereview.chromium.org/3015034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54535 0039d316-1c4b-4281-b951-d872f2087c98