summaryrefslogtreecommitdiffstats
path: root/chrome
Commit message (Collapse)AuthorAgeFilesLines
* Free memory in unit test, so purify doesn't complain.evanm@google.com2008-10-292-5/+6
| | | | | | | Review URL: http://codereview.chromium.org/8405 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4163 0039d316-1c4b-4281-b951-d872f2087c98
* Added strings to support Spellchecker operations in the context menu.sidchat@google.com2008-10-291-0/+12
| | | | | | Review URL: http://codereview.chromium.org/8710 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4160 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a couple of tab related bugs:ben@chromium.org2008-10-293-0/+13
| | | | | | | | | | | | - moving the window while a tab is animating to its final resting position disembodies the tab - it's possible to make a tab disappear while clicking on another tab while a tab is animating to its final resting position http://crbug.com/2388 http://crbug.com/1142 Review URL: http://codereview.chromium.org/8689 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4155 0039d316-1c4b-4281-b951-d872f2087c98
* Add command line option to suppress Chrome launch after successful installkuchhal@chromium.org2008-10-297-1066/+1090
| | | | | | | | BUG=1443250 Review URL: http://codereview.chromium.org/8644 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4154 0039d316-1c4b-4281-b951-d872f2087c98
* Adding in BuildComponents to allow things like Defer and publishing.bradnelson@google.com2008-10-291-1/+1
| | | | | | Review URL: http://codereview.chromium.org/8666 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4153 0039d316-1c4b-4281-b951-d872f2087c98
* remove svn:executablekuchhal@chromium.org2008-10-291-0/+0
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4147 0039d316-1c4b-4281-b951-d872f2087c98
* Trivial patch: add whitespace to some SQL statements to turn "INSERT INTO ↵pkasting@chromium.org2008-10-295-15/+13
| | | | | | | | | foo(bar,baz)VALUES(?,?)" into "INSERT INTO foo (bar, baz) VALUES (?,?)" (which is the way we have it in most of our code). This was annoying me while I tried to track down cases where we omitted the appropriate fieldnames from our SQL statements. Review URL: http://codereview.chromium.org/8855 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4145 0039d316-1c4b-4281-b951-d872f2087c98
* remove svn:executable propertykuchhal@chromium.org2008-10-291-0/+0
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4143 0039d316-1c4b-4281-b951-d872f2087c98
* remove svn:executable propertykuchhal@chromium.org2008-10-293-0/+0
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4142 0039d316-1c4b-4281-b951-d872f2087c98
* Add option to disable/enable Spell Check. In addition, remove additional ↵sidchat@google.com2008-10-2913-151/+132
| | | | | | | | | | code in resource message filter, which was initilaizing spellchecker in the filter if it was NULL. This part of the code is not required since the resource message filter should not initialize spellchecker; it is up to the profile to give the spellchecker to the resource message filter. Issue = 120 Review URL: http://codereview.chromium.org/7935 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4140 0039d316-1c4b-4281-b951-d872f2087c98
* Add fieldnames to SQL statements for better forward-compatibility. Had we ↵pkasting@chromium.org2008-10-291-2/+8
| | | | | | | | | had this code in place already, I wouldn't have needed to rev the compatible version number in my upcoming database change >:( I checked the rest of our sourcebase's INSERT and SELECT statements, but these were the only ones that needed to have fieldnames added (in a few cases SELECT * was appropriate). Review URL: http://codereview.chromium.org/8684 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4130 0039d316-1c4b-4281-b951-d872f2087c98
* Adds a string that we'll need when importing bookmarks.sky@google.com2008-10-292-0/+6
| | | | | | | | | BUG=674 TEST=none Review URL: http://codereview.chromium.org/8862 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4124 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a minor memory leak.paulg@google.com2008-10-294-8/+6
| | | | | | | | | BUG=1340229 Review URL: http://codereview.chromium.org/8690 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4117 0039d316-1c4b-4281-b951-d872f2087c98
* The "extra view" used by the DialogClientView must not be retrieved before ↵ben@chromium.org2008-10-292-8/+17
| | | | | | | | | the contents view has been attached to the view hierarchy. http://crbug.com/2751 Review URL: http://codereview.chromium.org/8681 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4116 0039d316-1c4b-4281-b951-d872f2087c98
* Moved the SelfDeletePluginInvokeInSynchronousMouseMove to interactive ui testsananta@chromium.org2008-10-299-40/+255
| | | | | | | | | | | | | | | | | | | | | | | | | | as we need to simulate mousemoves here. ui tests run on machines which are locked, causing this test to fail. Moved the NPAPITester and NPAPIVisiblePluginTester classes to a common file npapi_test_helper.cc so it can be used from both tests. Relanding the SetCursor patch. It has already been approved by John. Description below:- Proposed fix for http://b/issue?id=1362948, which is a crash in the rendererwhen we invoke the setCursor call on the parent view in WebPluginImpl::handleEvent. This crash occurs because the plugin is deleted in the context of a mouse down event. This could occur by invoking a javascript function via NPN_Evaluate. On return from the HandleEvent sync call we attempt to retreive the parent frame, which returns NULL and hence the crash. The fix is to retreive the parent frameview at the start of the WebPluginImpl::handleMouseEvent function and use it whereever needed. Added a unit test which deletes the plugin instance in a mousemove event. R=jam Bug=1362948 Review URL: http://codereview.chromium.org/8691 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4115 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r4094; ui_tests failures in SelfDeletePluginInvokeInSynchronousMouseMove.sgk@google.com2008-10-282-76/+1
| | | | | | Review URL: http://codereview.chromium.org/8861 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4107 0039d316-1c4b-4281-b951-d872f2087c98
* Change our phishing 'learn more' URL to something that will soon be translated.glen@chromium.org2008-10-2842-42/+42
| | | | | | | | BUG=2804 Review URL: http://codereview.chromium.org/8196 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4104 0039d316-1c4b-4281-b951-d872f2087c98
* Fix crbug.com/3684.tim@chromium.org2008-10-282-21/+25
| | | | | | | | | | | | | | | | Change 6053 involved making the PasswordManagerView's table model contain a vector of stack-allocated PasswordRow that owned a heap allocated PasswordForm, but std::vector creates temp PasswordRow's internally (on the stack) that were deleting the PasswordForm in their dtor. This accidental vector-internal delete caused subsequent operations on saved_signons_ to blow up. My fix is to make PasswordRows a vector of heap allocated PasswordRow instead, and have a STLElementDeleter member handle cleanup. Review URL: http://codereview.chromium.org/8651 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4103 0039d316-1c4b-4281-b951-d872f2087c98
* Don't automatically deny subresource requests that have minorwtc@google.com2008-10-282-26/+43
| | | | | | | | | | | | | | | | certificate errors (ERR_CERT_NO_REVOCATION_MECHANISM and ERR_CERT_UNABLE_TO_CHECK_REVOCATION). This requires moving the code that automatically denies subresource requests into only the SSLPolicy subclasses that need it. To avoid duplicating that code in five classes, I added convenience methods for handling overridable certificate errors and fatal errors. R=jcampan,abarth Review URL: http://codereview.chromium.org/8085 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4098 0039d316-1c4b-4281-b951-d872f2087c98
* Proposed fix for http://b/issue?id=1362948, which is a crash in the ↵ananta@chromium.org2008-10-282-1/+76
| | | | | | | | | | | | | | rendererwhen we invoke the setCursor call on the parent view in WebPluginImpl::handleEvent. This crash occurs because the plugin is deleted in the context of a mouse down event. This could occur by invoking a javascript function via NPN_Evaluate. On return from the HandleEvent sync call we attempt to retreive the parent frame, which returns NULL and hence the crash. The fix is to retreive the parent frameview at the start of the WebPluginImpl::handleMouseEvent function and use it whereever needed. Added a unit test which deletes the plugin instance in a mousemove event.R=jamBug=1362948 Review URL: http://codereview.chromium.org/8178 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4094 0039d316-1c4b-4281-b951-d872f2087c98
* Fix browser crash when closing popups (issue 3631).finnur@google.com2008-10-281-5/+7
| | | | | | | | The Google Bookmarks bookmarklet opens a popup window that allows you to bookmark a page. When the window closes we crash because we dereference a NULL TabContents pointer the we get from GetSelectedTabContents(). This fixes that. Review URL: http://codereview.chromium.org/8185 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4093 0039d316-1c4b-4281-b951-d872f2087c98
* Give the new implementation a unique name for the databasepaulg@google.com2008-10-281-1/+1
| | | | | | | | and filter storage so that it can run side by side with the old implementation without data loss. Review URL: http://codereview.chromium.org/8844 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4087 0039d316-1c4b-4281-b951-d872f2087c98
* Add referrer to session restore.ericroman@google.com2008-10-289-49/+96
| | | | | | | | http://code.google.com/p/chromium/issues/detail?id=3774 Review URL: http://codereview.chromium.org/8649 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4086 0039d316-1c4b-4281-b951-d872f2087c98
* Adds strings needed for the bookmark manager.sky@google.com2008-10-281-0/+18
| | | | | | | | | BUG=3784 TEST=none Review URL: http://codereview.chromium.org/8837 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4083 0039d316-1c4b-4281-b951-d872f2087c98
* No code change. Just to force a build.maruel@chromium.org2008-10-281-4/+3
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4075 0039d316-1c4b-4281-b951-d872f2087c98
* No code change. Just to force a rebuild.maruel@chromium.org2008-10-281-4/+3
| | | | | | Review URL: http://codereview.chromium.org/8667 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4074 0039d316-1c4b-4281-b951-d872f2087c98
* - Make user script loading asynchronous on the file thread.evanm@google.com2008-10-289-44/+385
| | | | | | | | - Automatically reload scripts when the directory changes. - Add a unit test for the GreasemonkeyMaster. Review URL: http://codereview.chromium.org/7472 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4069 0039d316-1c4b-4281-b951-d872f2087c98
* No code change. Just force a build.maruel@google.com2008-10-281-4/+3
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4064 0039d316-1c4b-4281-b951-d872f2087c98
* Makes sure TaskManager doesn't return an empty icon. If we return ansky@google.com2008-10-281-1/+9
| | | | | | | | | | | | empty icon we get an ugly black square in the table. BUG=3784 TEST=Follow steps in bug, also make sure you don't see any problems with icons in task manager. Review URL: http://codereview.chromium.org/8208 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4055 0039d316-1c4b-4281-b951-d872f2087c98
* Makes tree double duffered so that it doesn't flicker during resize.sky@google.com2008-10-281-0/+14
| | | | | | | | | BUG=3784 TEST=none Review URL: http://codereview.chromium.org/8819 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4054 0039d316-1c4b-4281-b951-d872f2087c98
* Make it so the user can't drag javascript: links to thetc@google.com2008-10-282-5/+28
| | | | | | | | | | | | desktop from web content or the bookmarks bar. Maintain the ability to drag javascript: links from web content to the bookmarks bar or to drag the javascript: link as plain text. BUG=3431 Review URL: http://codereview.chromium.org/8638 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4050 0039d316-1c4b-4281-b951-d872f2087c98
* Do not localize the name of 'download' directory. Chrome's UI languages can bejungshik@google.com2008-10-285-12/+20
| | | | | | | | | | | | | | | | | | | changed and a user will be confused as to where her download goes. Add DIR_DEFAULT_DOWNLOADS to chrome_paths (which is set to 'Downloads' under DIR_USER_DOCUMENTS) and use that in both save_package and download_manager. This patch does not offer a migration path. BUG=3097 TEST=Switch Chrome's UI to non-English and download a file. The file should be downloaded to '..\My Documents\Downloads' rather than '..\My Documents\<'Downloads' in that language>. Review URL: http://codereview.chromium.org/7945 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4049 0039d316-1c4b-4281-b951-d872f2087c98
* Add the language to the google help center URL (hl=lang).tc@google.com2008-10-281-2/+8
| | | | | | Review URL: http://codereview.chromium.org/8803 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4048 0039d316-1c4b-4281-b951-d872f2087c98
* Fix new string to the new format.erg@google.com2008-10-281-1/+1
| | | | | | Review URL: http://codereview.chromium.org/8641 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4047 0039d316-1c4b-4281-b951-d872f2087c98
* Plumb the referrer throughout the OpenURL APIs.ericroman@google.com2008-10-2761-177/+258
| | | | | | | | | | | | | http://code.google.com/p/chromium/issues/detail?id=3224 Caveats: * Did not update TabNavigation yet. Hence session restore will continue to load the tabs with empty referrer. * Did not plumb referrer into incognito url open. (Not sure what the right thing to do is here with respect to privacy vs compatibility.) * Did not plumb referrer throughout the automation controller. No functional impact here, but it makes the code inconsistent with the non-automation version. Review URL: http://codereview.chromium.org/8186 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4036 0039d316-1c4b-4281-b951-d872f2087c98
* Clean up the chunk processing pipeline. We are no longerpaulg@google.com2008-10-272-326/+216
| | | | | | | | | asynchronous, so we can greatly simplify the code. Refactor BuildBloomFilter() to smaller worker functions. Review URL: http://codereview.chromium.org/8605 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4032 0039d316-1c4b-4281-b951-d872f2087c98
* Add string for the new popup blockserg@google.com2008-10-271-0/+3
| | | | | | Review URL: http://codereview.chromium.org/8631 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4027 0039d316-1c4b-4281-b951-d872f2087c98
* Add a suggestion to "Learn more about this problem." if there istc@google.com2008-10-274-10/+45
| | | | | | | | | | a redirect loop. We could easily use this for other errors too if there are URLs to the help center. BUG=http://crbug.com/2445 Review URL: http://codereview.chromium.org/8174 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4023 0039d316-1c4b-4281-b951-d872f2087c98
* Move Time, TimeDelta and TimeTicks into namespace base.dsh@google.com2008-10-27185-249/+539
| | | | | | Review URL: http://codereview.chromium.org/7995 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4022 0039d316-1c4b-4281-b951-d872f2087c98
* Update prepopulate data by request for a couple different issues.pkasting@chromium.org2008-10-272-19/+14
| | | | | | | | | Revert keyword dialog to being unsorted by default, which is appropriate for users looking at search engines -- users looking for keywords can always click the column header to sort things. BUG=3219,1358883 Review URL: http://codereview.chromium.org/8802 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4021 0039d316-1c4b-4281-b951-d872f2087c98
* Update RLZ according to the bugs:cpu@google.com2008-10-272-31/+72
| | | | | | | | | BUG = 1447656 BUG = 1391110 Review URL: http://codereview.chromium.org/8171 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4017 0039d316-1c4b-4281-b951-d872f2087c98
* Add '--' to Chrome open command linekuchhal@chromium.org2008-10-272-2/+11
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4016 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup of DNS prefetch related filesjar@google.com2008-10-279-31/+29
| | | | | | | | | | | I have a separate change list coming to support predictive DNS resolutions, so I pulled out a pile of mechanical changes (with no semantic changes intendend). r=mbelshe Review URL: http://codereview.chromium.org/8624 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4015 0039d316-1c4b-4281-b951-d872f2087c98
* * Update comments from code review feedback.kuchhal@chromium.org2008-10-272-2/+2
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4006 0039d316-1c4b-4281-b951-d872f2087c98
* Reshuffling the options in the UnderTheHood section. A summary of my ↵finnur@google.com2008-10-279-275/+266
| | | | | | | | changes:Renamed ContentSection to WebContentSection to reflect changes that have already been made to the UI (prior to this change list).Renamed GeneralSection to PrivacySectionMoved various checkboxes that appear in other categories in the "Under the hood"-tab to appear under the new PrivacySection.Moved the checkbox "Use a suggestion service" from Edit Search Engines to the PrivacySection, since we don't want it in two different places. - If you check the "Use Suggest" but have a provider that doesn't support it, it will just not perform Suggest queries.The mock I was following has the Learn More link right after the text blurb, but this version has the link below the text. We need to figure out what we want to do here. Review URL: http://codereview.chromium.org/7985 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4005 0039d316-1c4b-4281-b951-d872f2087c98
* Update contents_mime_type_ of WebContents only for the main frame. ↵jungshik@google.com2008-10-271-1/+5
| | | | | | | | | | | | | | | | RenderView does not set the value for sub frames. As a result, we ended up resetting to NULL by updating it for any frame. This CL should go in for both trunk and 0.3.154.x branch. BUG=2929 TEST=Open http://fund.eastmoney.com in a tab, switch to another tab and then switch back. Encoding menu should be enabled which tab you're in. Review URL: http://codereview.chromium.org/8206 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4001 0039d316-1c4b-4281-b951-d872f2087c98
* Window controls were aligned to the top of the window, so their rollover ↵glen@chromium.org2008-10-271-1/+1
| | | | | | | | states caused the window border not to be shown. Review URL: http://codereview.chromium.org/4044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3999 0039d316-1c4b-4281-b951-d872f2087c98
* Declare encoding on the New Tab.glen@chromium.org2008-10-271-8/+5
| | | | | | | | BUG=998 Review URL: http://codereview.chromium.org/8080 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3998 0039d316-1c4b-4281-b951-d872f2087c98
* Superficial change to force a build.maruel@chromium.org2008-10-271-4/+3
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3994 0039d316-1c4b-4281-b951-d872f2087c98
* Move the spellcheck unittest into browser next to the filetc@google.com2008-10-262-1/+1
| | | | | | | it tests. Review URL: http://codereview.chromium.org/8176 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3989 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-01-19 17:39:16 +0000