summaryrefslogtreecommitdiffstats
path: root/chrome
Commit message (Collapse)AuthorAgeFilesLines
* When no theme is installed, don't attempt to tint buttons.avi@chromium.org2009-07-241-2/+4
| | | | | | | | | BUG=http://crbug.com/17511 TEST=all toolbar buttons should be black Review URL: http://codereview.chromium.org/160032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21526 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: split console evaluation into two steps: actual evaluation and ↵yurys@google.com2009-07-241-0/+5
| | | | | | | | result wrapping. When second step is executed debugger_agent_manager will autocontinue on break. We assume that second step doesn't call user scripts. Review URL: http://codereview.chromium.org/160012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21525 0039d316-1c4b-4281-b951-d872f2087c98
* NO CODE CHANGEhbono@chromium.org2009-07-241-1689/+1689
| | | | | | | | | | | This change just changes the line-endings of suggestmgr.cxx to LF and set svn:eol-style to LF for supporting <http://codereview.chromium.org/155841>. TBR=sidchat BUG=none TEST=none Review URL: http://codereview.chromium.org/160096 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21524 0039d316-1c4b-4281-b951-d872f2087c98
* Integrates a custom JumpList of Windows 7 into Chromium.hbono@chromium.org2009-07-249-0/+951
| | | | | | | | | | | | This change adds an option "--enable-custom-jumplist" that uses the ICustomDestinationList interface to add "Most Visited" pages, "Recently Closed" pages, and "Tasks" to the JumpList of Chromium. This change registers the CustomJumpList class into an observer of TabRestoreService so it can update the JumpList when a user adds/removes a tab. This change stores icon files used by a custom JumpList under "$(User Data Dir)/JumpListIcons" so Taskbar can show JumpList icons even when Chromium is not running. BUG=8037 TEST=Right-click the taskbar icon of Chromium on Windows 7. Review URL: http://codereview.chromium.org/56175 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21522 0039d316-1c4b-4281-b951-d872f2087c98
* Let theme values that previous had to be real be specified as ints.glen@chromium.org2009-07-242-13/+25
| | | | | | | | | | | Also bonus update to background_tab_text naming. BUG=16892 TEST=Create and install a theme with integer values for ntp_section opacity or tint values. Review URL: http://codereview.chromium.org/160093 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21519 0039d316-1c4b-4281-b951-d872f2087c98
* Make the bookmark buttons follow theme changes correctly.glen@chromium.org2009-07-242-14/+36
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/160092 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21518 0039d316-1c4b-4281-b951-d872f2087c98
* Move parts of npruntime into the WebKit API so it no longer has any ↵jorlow@chromium.org2009-07-241-2/+4
| | | | | | | | | | dependencies on WebCore. TEST=none BUG=none Review URL: http://codereview.chromium.org/160091 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21516 0039d316-1c4b-4281-b951-d872f2087c98
* Disable NPAPIVisiblePluginTester.OpenPopupWindowWithPlugin, which is flaky.yuzo@chromium.org2009-07-241-1/+2
| | | | | | | | | | BUG=17645 TEST=none Review URL: http://codereview.chromium.org/159333 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21514 0039d316-1c4b-4281-b951-d872f2087c98
* I edited the wrong one. DUH.glen@chromium.org2009-07-241-1/+1
| | | | | | | | | | TBR=nsylvain BUG=none TEST=none Review URL: http://codereview.chromium.org/159337 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21512 0039d316-1c4b-4281-b951-d872f2087c98
* Workaround to get Linux/ChromeOS building - it appears to not be picking up ↵glen@chromium.org2009-07-241-1/+1
| | | | | | | | | | | | file adds to app/theme/google_chrome (product_logo_white.png was added, but the ChromeOS builder can't find it). We need to figure this out tomorrow for beta cutoff. TBR=ben,brettw,nsylvain BUG=none TEST=none Review URL: http://codereview.chromium.org/160090 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21511 0039d316-1c4b-4281-b951-d872f2087c98
* Add link to themes gallery.glen@chromium.org2009-07-244-5/+37
| | | | | | | | | BUG=16381 TEST=Go to second page of options, verify that the 'Get themes' button opens a new tab and takes you to the themes gallery. Review URL: http://codereview.chromium.org/160081 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21510 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a bunch of bugs related to NNTP theming.glen@chromium.org2009-07-2433-36/+193
| | | | | | | | | | | | | | | | | | Basically: - Add NNTP Theming BrowserThemeProvider: - Add NNTP logo inversion capability - Only allow a set of images to be themed. - Tint incognito windows correctly. (Sorry for the feature-mush) BUG=17379,14578,17593 TEST=Make sure the NNTP is themed correctly. Review URL: http://codereview.chromium.org/159305 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21509 0039d316-1c4b-4281-b951-d872f2087c98
* Make the NNTP listen for the correct theme changed notification.glen@chromium.org2009-07-241-2/+2
| | | | | | | | | BUG=17565 TEST=Install a theme, reset the theme, verify that the NNTP changes correctly in both cases. Review URL: http://codereview.chromium.org/160027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21507 0039d316-1c4b-4281-b951-d872f2087c98
* When closing the download shelf, hide the buttons of the dangerous downloadthakis@chromium.org2009-07-242-4/+6
| | | | | | | | | | | | | | | warning. Also fix the shelf closing animation. BUG=13632 TEST=Download an exe (e.g. limewire from downloads.com), so that a "dangerous download" message appears on the shelf. Then close the shelf. The "Yes" and "No" buttons should be hidden, and the whole download shelf should slide down with all items on it in place. Original review url: http://codereview.chromium.org/159261 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21506 0039d316-1c4b-4281-b951-d872f2087c98
* Recommit of r21474. Original description:glen@chromium.org2009-07-245-3/+22
| | | | | | | | | | | | | | | | """ Make the tab close button color match the tab text. BUG=17378 TEST=Install themes with different tab text colors and verify that the tab close button changes color appropriately. Review URL: http://codereview.chromium.org/155882 """ Changes since then include removing a NOTREACHED and changing that method so that a caller can detect whether a ThemeProvider is available. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21505 0039d316-1c4b-4281-b951-d872f2087c98
* Remove mention that we don't support different types of font rendering from ↵agl@chromium.org2009-07-242-4/+0
| | | | | | the splash page. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21504 0039d316-1c4b-4281-b951-d872f2087c98
* Push bookmarks.remove/removeAll polymorphism into c++. fix bookmarks id ↵rafaelw@chromium.org2009-07-2410-80/+76
| | | | | | | | | | | schema issues (http://code.google.com/p/chromium/issues/detail?id=17562 failed to update schema types from int to string). R=erikkay BUG=17417 Review URL: http://codereview.chromium.org/160064 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21503 0039d316-1c4b-4281-b951-d872f2087c98
* Fix typos (incorrectly capitalized 'R': Reset => reset).jshin@chromium.org2009-07-242-2/+2
| | | | | | | | | | | | | | BUG=2834 TEST=Click in "Reset to defaults" button on the options dialog and the 2nd setence should read 'Do you want to reset ...?' TBR=mal Patch by tfarina Original Review: http://codereview.chromium.org/155910 Review URL: http://codereview.chromium.org/160080 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21498 0039d316-1c4b-4281-b951-d872f2087c98
* The final CL for plumbing DOM Storage.jorlow@chromium.org2009-07-2412-0/+417
| | | | | | | | | | | | | Add webKitClient plumbing for getting/creating storage namespaces. Add a chromium implementation for WebStorageArea and WebStorageNamespace which communicates via IPC with the dom_storage_dispatcher_host in the browser process. Flesh out the StorageAreaProxy and StorageNamespaceProxy to use the aforementioned implementations. The WebStorageArea implementation includes decently aggressive caching optimizations. There's still a lot of work to do, though. BUG=4360 TEST=none Review URL: http://codereview.chromium.org/147248 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21495 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: splice together RendererPreferences and SkFontHostagl@chromium.org2009-07-244-3/+102
| | | | | | | | | | | | | | | | | | | | | Dan Erat has been working down, plumbing the user's font settings from XSETTINGS in the UI thread of the browser to RendererPreferences in the renderer. At the same time, I've been working upwards: implementing subpixel rendering support in Skia and adding an interface to it in WebCore. This patch joins the two together. It adds an API surface to the WebKit API for configuring the font preferences and adds code to translate from RendererPreferences to that API. It's a little unfortunate that we need four sets of enums around the code base for things like the hinting level, but each is supposed to be self contained and adding a dependancy would much more grevious. BUG=12179 http://codereview.chromium.org/159152 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21493 0039d316-1c4b-4281-b951-d872f2087c98
* Fix newline issues in tab_renderer.hglen@chromium.org2009-07-241-1/+2
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21491 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 21474glen@chromium.org2009-07-245-21/+1
| | | | | | | | | | TBR=joshia BUG=none TEST=none Review URL: http://codereview.chromium.org/160074 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21489 0039d316-1c4b-4281-b951-d872f2087c98
* Fixit: Coverity check return value.kuchhal@chromium.org2009-07-241-3/+6
| | | | | | Review URL: http://codereview.chromium.org/159320 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21488 0039d316-1c4b-4281-b951-d872f2087c98
* Another try at enabling the content script messaging test.mpcomplete@chromium.org2009-07-247-77/+107
| | | | | | | | | | | | | Also fixes some issues that that test exposes. My previous attempt (http://src.chromium.org/viewvc/chrome?view=rev&revision=21324) was reverted. TEST=no BUG=no Review URL: http://codereview.chromium.org/160048 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21483 0039d316-1c4b-4281-b951-d872f2087c98
* Disable the BookmarkEditorGtk.* tests again while I investigate the issue.jhawkins@chromium.org2009-07-241-0/+3
| | | | | | | TBR=dank Review URL: http://codereview.chromium.org/160071 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21482 0039d316-1c4b-4281-b951-d872f2087c98
* Enable SVG icons for linux.estade@chromium.org2009-07-241-2/+1
| | | | | | | | | | | get rid of kEnableSVG BUG=12272 TEST=I made it load an svg for the download shelf and it worked. SVGZ did not work. Review URL: http://codereview.chromium.org/159247 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21481 0039d316-1c4b-4281-b951-d872f2087c98
* Adds the first run banner.arv@google.com2009-07-234-35/+103
| | | | | | | | | | | | | | First run is determined by checking if there are no thumbnails. The check for no thumbnails is done on the backend since I need to add code to add some pre populated thumbnails and therefore the most visited pages will not be empty on the client. There is one edge case where the banner can show up again and that is if the user blacklists all his thumbnails and restarts chrome. Also, updates the look of the fillers to match the latest mocks. BUG=15079 TEST=Start with a new empty profile. You should see the blue first run banner. Then navigate to some link and come back the NTP. The banner should not be shown again. Also, test that this did not break the yellow notification banner shown when a thumbnail is removed. Review URL: http://codereview.chromium.org/159304 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21480 0039d316-1c4b-4281-b951-d872f2087c98
* Added menus for bookmark bar folders. This is NOT based on the Colejrg@chromium.org2009-07-2311-200/+506
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | prototype; it is an attempt to get something functional in the short term, and have a visual baseline before doing something new. Added folder icons for bookmark bar folder buttons. Added an "off the side" button/menu for bookmark buttons which don't fit on the bar. Updated "Add page..." item to allow creating bookmarks in the folders (if selected over a folder button). BUG=http://crbug.com/8381 TEST=Here we go: 1) Make sure bookmark bar folders have the "folder" icon. 2) Right click on a folder --> Add Page, and add a bookmark. Make sure bookmark is now in the folder, not at the top level. 3) (Oh, you just implicitly verified you can open bookmark folders!) 4) Add 5 bookmarks then shrink the window thinner so all bookmark buttons don't fit. Make sure "off the right" button gets enabled (on right side of bar) and shows bookmarks in a pop-up menu (when clicked) that don't completely fit on the bar. 5) Make it super-wide so the all fit and make sure "off the right" button is disabled. 6) Add a bunch of bookmarks to a folder; make sure they all work. 7) Add nested folders (by editing the bookmark pref file and restarting Chrome) and make sure bookmark folder buttons have nested/cascading menus. Review URL: http://codereview.chromium.org/159286 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21479 0039d316-1c4b-4281-b951-d872f2087c98
* linux: obey window positioning information when bounds are overriddenevan@chromium.org2009-07-232-4/+17
| | | | | | | | | | | | | Normally we want to let windows position themselves, but in some cases (like dropping a tab) we really do want to drop the window where we dropped. BUG=15404 TEST=Drag off a tab and drop it. It should drop where you released it. Review URL: http://codereview.chromium.org/159316 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21478 0039d316-1c4b-4281-b951-d872f2087c98
* Fix linux/mac build errors.glen@chromium.org2009-07-231-3/+3
| | | | | | | | | TBR=jrg BUG=none TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21477 0039d316-1c4b-4281-b951-d872f2087c98
* Adds MSAA information to various (previously uncovered) bits of the UI, ↵klink@chromium.org2009-07-2312-20/+171
| | | | | | | | | | | including Bookmark and Extensions infobars. This is to moving towards completing the hierarchy for the benefit of full screen reader support. BUG=None. Test=None. Review URL: http://codereview.chromium.org/155446 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21476 0039d316-1c4b-4281-b951-d872f2087c98
* Make the tab close button color match the tab text.glen@chromium.org2009-07-235-0/+20
| | | | | | | | | BUG=17378 TEST=Install themes with different tab text colors and verify that the tab close button changes color appropriately. Review URL: http://codereview.chromium.org/155882 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21474 0039d316-1c4b-4281-b951-d872f2087c98
* Fix memory leak in VisitSegmentDatabase::QuerySegmentUsage and ↵meelapshah@chromium.org2009-07-232-3/+8
| | | | | | | | | | | HistoryBackend::QueryTopURLsAndRedirects. BUG=16104 TEST=sh tools/valgrind/chrome_test.sh -t ui --gtest_filter=TabRestoreUITest.RestoreIntoSameWindow Review URL: http://codereview.chromium.org/160060 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21472 0039d316-1c4b-4281-b951-d872f2087c98
* Adding a new parsing system to the metadata url request.brettw@chromium.org2009-07-2313-7/+442
| | | | | | | | | | | BUG=none TEST=none Original review: http://codereview.chromium.org/155803 Patch by: dhg@google.com Review URL: http://codereview.chromium.org/160059 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21469 0039d316-1c4b-4281-b951-d872f2087c98
* gtk: Set the treeview column title even for headers we aren't displaying. ↵jhawkins@chromium.org2009-07-232-5/+2
| | | | | | | | | | Older versions of gtk trip up on an empty title string. BUG=15445 TEST=Watch the Linux valgrind bot stay green. Review URL: http://codereview.chromium.org/159312 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21468 0039d316-1c4b-4281-b951-d872f2087c98
* Allow the browser to send actions back to the render for media element ↵ajwong@chromium.org2009-07-2310-47/+202
| | | | | | | | | | | | | context menus. Also renamed ContextNodeType per fishd's suggestion. BUG=15686 TEST=none Review URL: http://codereview.chromium.org/155954 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21466 0039d316-1c4b-4281-b951-d872f2087c98
* Gtk: Add cookie details to cookie manager.mattm@chromium.org2009-07-232-8/+153
| | | | | | | | BUG=11507 Review URL: http://codereview.chromium.org/155974 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21463 0039d316-1c4b-4281-b951-d872f2087c98
* Change the toasting to 60 dayscpu@google.com2009-07-231-2/+2
| | | | | | | | | | | - same deal GB only BUG=1484308 TEST=see the bug Review URL: http://codereview.chromium.org/160044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21461 0039d316-1c4b-4281-b951-d872f2087c98
* Avoid directory traversal attacks when unpacking zips. The sandbox would tendcevans@chromium.org2009-07-232-7/+24
| | | | | | | | | | | | | to catch & deny this, but the Linux and Mac port does not yet do extension packing inside the sandbox. Therefore, reject any filenames in the zip which have .. in them. BUG=NONE TEST=ZipTest.UnzipEvil Review URL: http://codereview.chromium.org/160028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21460 0039d316-1c4b-4281-b951-d872f2087c98
* A small refactor of the toolbar background.tc@google.com2009-07-232-12/+2
| | | | | | | | | | I'm not sure in what cases SetProfile will be called to change the profile, but this seems to handle that possible case. Review URL: http://codereview.chromium.org/159282 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21457 0039d316-1c4b-4281-b951-d872f2087c98
* linux: generalize desktop environment guessing to encompass KDEevan@chromium.org2009-07-231-16/+26
| | | | | | | | BUG=17363 Review URL: http://codereview.chromium.org/159297 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21455 0039d316-1c4b-4281-b951-d872f2087c98
* Pass input string parameters by reference.jhawkins@chromium.org2009-07-231-6/+6
| | | | | | | | | CID=5116 BUG=none TEST=none Review URL: http://codereview.chromium.org/160052 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21454 0039d316-1c4b-4281-b951-d872f2087c98
* linux: show the manpage on -h or --helpevan@chromium.org2009-07-231-0/+10
| | | | | | Review URL: http://codereview.chromium.org/160026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21450 0039d316-1c4b-4281-b951-d872f2087c98
* Bookmark bar: Don't connect to the OnDragDrop signal since we can just use ↵estade@chromium.org2009-07-232-24/+0
| | | | | | | | | | | | | the default. Eventually we may want to allow dropping more different types, and we will need to implement an OnDragDrop handler so we can properly prioritize these types (preferring BOOKMARK_ITEM over TEXT_PLAIN and so forth). But for now we can just use the default handler. BUG=17501 TEST=drag an image onto the bookmark bar, note that there is only one link created Review URL: http://codereview.chromium.org/159256 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21448 0039d316-1c4b-4281-b951-d872f2087c98
* Close pop up notification when navigating to other site.erg@google.com2009-07-231-0/+6
| | | | | | | | | | | | | When BlockedPopupContainer stopped being a ConstrainedWindow, the notification stopped being cleared in TabContents::MaybeCloseChildWindows. http://crbug.com/8622 http://crbug.com/14150 TEST=See 8622 for repro steps. Review URL: http://codereview.chromium.org/159287 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21445 0039d316-1c4b-4281-b951-d872f2087c98
* Headers cleanup:phajdan.jr@chromium.org2009-07-2326-14/+43
| | | | | | | | | - reduce header dependencies by using bookmark_model_observer.h - replace #include <iostream> by #include <iosfwd> in headers Review URL: http://codereview.chromium.org/159280 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21444 0039d316-1c4b-4281-b951-d872f2087c98
* gtk: Fix the case where a user quickly moves the mouse away from a dragged tabjhawkins@chromium.org2009-07-236-3/+33
| | | | | | | | | | | | | causing gtk to stop generating motion-notify-event signals. In this case, a call to gtk_grab_add lets gtk clean up the drag for us. BUG=16509 TEST=Quickly move the mouse away from a dragged tab (up and left works best). The drag will end and a new window will open. The dragged tab window should not still exist. Review URL: http://codereview.chromium.org/159290 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21440 0039d316-1c4b-4281-b951-d872f2087c98
* Fixing the crash signature for masksuperblitter.huanr@chromium.org2009-07-231-1/+1
| | | | | | Review URL: http://codereview.chromium.org/159291 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21439 0039d316-1c4b-4281-b951-d872f2087c98
* This CL adds an infobar instructing users they can do search directly from ↵jcampan@chromium.org2009-07-2314-7/+355
| | | | | | | | the location bar when they navigate to their default search engine.The infobar is dismissed and not shown again if the user does a search from the omnibox or dismiss the infobar.This is part of a UX experiment and is behind a switch.BUG=NoneTEST=Start Chrome with a fresh profile. Navigate to www.google.com. An info bar should be shown. Click the 'show me' button, the location bar should display a message explaining search can be made from it. Review URL: http://codereview.chromium.org/159242 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21438 0039d316-1c4b-4281-b951-d872f2087c98
* CPAPI (0.11) for gears drag drop.mpcomplete@chromium.org2009-07-239-11/+92
| | | | | | | | | | | | Provide a method that allows the gears plugin to ask the browser process to verify that its renderer has permission to access the drop files. Update the copyright notices. BUG=7995 Review URL: http://codereview.chromium.org/159074 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21437 0039d316-1c4b-4281-b951-d872f2087c98