summaryrefslogtreecommitdiffstats
path: root/chrome
Commit message (Collapse)AuthorAgeFilesLines
* This fixes the following bugs:-iyengar@google.com2008-09-201-0/+10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 1.http://code.google.com/p/chromium/issues/detail?id=292 This was a painting issue in the XStandard plugin. The bug occurs in a windowed instance of the plugin. We handle window repositions in the plugin process until the window becomes visible. We set the SWP_NOREDRAW flag in the SetWindowPos call. This turns off client/non-client paints. After the SetWindowPos call we invalidate the client area. The plugin only receives WM_PAINT as a result. The plugin relies on the WM_NCPAINT message being received as well. In any case the SWP_NOREDRAW flag does not buy us much as we invalidate immediately after. The fix is to take out this flag. 2.http://code.google.com/p/chromium/issues/detail?id=2556 The plugin invoked the NPN_GetValue function to retreive the window script object. This call fails in this case probably because the plugin instance in the renderer process is in the process of shutting down. We return a failure from the call. The plugin fails to check the return code and ends up invoking NPN_GetProperty on a NULL NPObject which causes a crash in chrome when we try to create a proxy for the same. The fix is to add NULL NPObject checks in the NPObjectProxy members and return early. Bug=292,2556 R=jam Review URL: http://codereview.chromium.org/3176 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2429 0039d316-1c4b-4281-b951-d872f2087c98
* Stop exposing manually_selected_match_ outside the AutocompletePopupModel. ↵pkasting@chromium.org2008-09-1911-362/+222
| | | | | | | | | | | | | | | | | | | The main goal of this is to be a first step towards divorcing the popup and the edit from each other. To do this, I changed the behavior of manual selections. They now do not persist once the user types more characters, hits esc, etc. Our old behavior, which Brett and I designed long ago, turns out to have been a mistake; users who arrowed to an item and then typed more weren't expecting "stickiness" on their previous choice, and it led to user mistakes. This also required changing how we do the "keyword UI" persistence in the case where the user switches into keyword UI, but then deletes all his text. Previously, we used manually_selected_match_ with a provider affinity to the keyword provider in order to accomplish this. Now we stick another flag on the AutocompleteInput, which, when set, biases the keyword provider to return the best results. The user-visible effect of this is that when in keyword UI mode with no query string, the selected entry in the popup will be the first, rather than third, entry. This is a small win. While here I fixed the bug where editing a string and transforming it into a keyword search would avoid switching into keyword UI (as expected), but also delete the keyword off the visible string (oops). I also made us lock the popup once the user changes the manually_selected_match_, in order to give a little more stability to it. I'm sorry this makes so many behavioral changes at once. All this code is tangled together and untangling it is hard :( The keyword-related variables in the AutocompleteEditModel seem a mess. They are probably worse now than before this change; I think I need a followup change at some point to make them all more sane. It seems like we have three variables and complex conditionals where two, and simpler ones, would do. BUG=997976,1201974,1204173 Review URL: http://codereview.chromium.org/3172 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2426 0039d316-1c4b-4281-b951-d872f2087c98
* This is the same change as issue 1633 ( http://codereview.chromium.org/1633 ↵petersont@google.com2008-09-196-181/+554
| | | | | | | | ) together with the disabling of a test called MetricsServiceTest.CloseRenderersNormally which the change makes obsolete (see bug 2522.) Review URL: http://codereview.chromium.org/2995 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2419 0039d316-1c4b-4281-b951-d872f2087c98
* Landing a patch for Adam. See http://codereview.chromium.org/3136 for details.finnur@google.com2008-09-194-18/+7
| | | | | | | | TBR=abarth Review URL: http://codereview.chromium.org/2996 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2417 0039d316-1c4b-4281-b951-d872f2087c98
* Adding a CPAPI function to make a function call asynchonously on the plugin ↵zork@google.com2008-09-194-1/+47
| | | | | | | | thread. Review URL: http://codereview.chromium.org/2969 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2414 0039d316-1c4b-4281-b951-d872f2087c98
* Changes the bookmark model to allow more than one bookmark tosky@google.com2008-09-1922-316/+510
| | | | | | | | | | | | | | | | reference the same url. Clicking the star button edits the most recently added bookmark for the URL. Dragging a button/star always does a move, otherwise drops on the bookmark bar create a new bookmark. Also changed the add page context menu for the bookmark bar to remember where you invoked it from. BUG=1173228 1678 Review URL: http://codereview.chromium.org/3203 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2413 0039d316-1c4b-4281-b951-d872f2087c98
* Attempt at fixing flaky Find test.finnur@google.com2008-09-191-1/+6
| | | | | | | | The waterfall (build.chromium.org) has been complaining about this test for a while now. Nicolas and I looked at this, but we don't see anything wrong. We theorized this is because we issue Find right after the navigation and maybe the tab isn't ready. We'll see what happens with this change. Review URL: http://codereview.chromium.org/2978 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2411 0039d316-1c4b-4281-b951-d872f2087c98
* Make sure webkit/port and webkit/glue are in lower case because libGlue.a ↵tc@google.com2008-09-192-7/+5
| | | | | | looks funny. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2410 0039d316-1c4b-4281-b951-d872f2087c98
* Build a bunch more of chrome/ on Linux.deanm@google.com2008-09-1921-74/+83
| | | | | | Patch from Pawel Hajdan Jr. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2408 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes bug in tooltip manager. Mouse coordinates for NC events are insky@google.com2008-09-192-4/+12
| | | | | | | | | | | screen coordinates and need to be converted. BUG=2523 TEST=see bug Review URL: http://codereview.chromium.org/3160 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2406 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting the fixes for the UI test single-process mode in the NPAPIiyengar@google.com2008-09-191-6/+8
| | | | | | | | | | tests. The offending Stream test has been disabled in single-process mode TBR=jam Review URL: http://codereview.chromium.org/3166 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2404 0039d316-1c4b-4281-b951-d872f2087c98
* roll backbeng@google.com2008-09-191-3/+0
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2402 0039d316-1c4b-4281-b951-d872f2087c98
* This CB fixes the following issue1. ↵iyengar@google.com2008-09-198-14/+74
| | | | | | | | http://code.google.com/p/chromium/issues/detail?id=206This is a performance issue while loading PDF documents. The fix is to support PDF fast webview, which is basically support for the NPN_RequestRead API, which allows a plugin to request specific byte ranges in HTTP GET requests. This also needs support for seekable streams. Our support for seekable streams is limited to HTTP servers which allow byte range requests. Firefox also supports a mode in which the the browser caches the file on disk for servers which don't support byte range requests. The plugin_data_stream.cc/.h files are being removed as there is not much value in their existence. The needed functionality is available in the PluginStreamUrl class, which now services manual data streams as well. Testing this is a touch tricky as we need a HTTP server which serves byte range requests. Will add those in a subsequent CB.Also fixed a bug in the multipart parser where we need to ignore leading newline characters while parsing the header.Bug=206 Review URL: http://codereview.chromium.org/2896 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2400 0039d316-1c4b-4281-b951-d872f2087c98
* Make sure the frame is set to the foreground when:ben@chromium.org2008-09-191-0/+3
| | | | | | | | | | | - opening from a shortcut when an existing frame is already open - pressing Ctrl+T from an app window http://crbug.com/2477 Review URL: http://codereview.chromium.org/3134 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2399 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a memory leak in Add to dictionary code.sidchat@google.com2008-09-182-0/+6
| | | | | | Review URL: http://codereview.chromium.org/3148 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2379 0039d316-1c4b-4281-b951-d872f2087c98
* Fix an old leak in tab_strip_model_unittest which had recently contributed ↵erikkay@google.com2008-09-182-59/+7
| | | | | | | | to a new leak showing up. The leak was caused by not cleaning up after ReplaceTabContents. Review URL: http://codereview.chromium.org/2954 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2374 0039d316-1c4b-4281-b951-d872f2087c98
* Use libevent, second try. Changes this time:dkegel@google.com2008-09-181-0/+1
| | | | | | | | | - remove bogus include of base/completion_callback.h - add DEPS rules to allow including third_party/libevent Review URL: http://codereview.chromium.org/2964 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2371 0039d316-1c4b-4281-b951-d872f2087c98
* Make uninstall slightly less prone to chrome.exe crashes by changing default ↵kuchhal@chromium.org2008-09-183-45/+26
| | | | | | | | | | to uninstall confirmation. BUG=1215 Review URL: http://codereview.chromium.org/3128 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2370 0039d316-1c4b-4281-b951-d872f2087c98
* NULL check the return value during navigation to prevent a crash.brettw@google.com2008-09-181-0/+2
| | | | | | | BUG=1384003 Review URL: http://codereview.chromium.org/2966 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2366 0039d316-1c4b-4281-b951-d872f2087c98
* Submit Issue 2965 patch by vega.james@gmail.com (jamessan)mmoss@google.com2008-09-181-2/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2362 0039d316-1c4b-4281-b951-d872f2087c98
* Enable safe browsing tests exercising VerifyMAC. Reorder libraries to match ↵deanm@chromium.org2008-09-183-14/+5
| | | | | | | | | the dependency order required on Posix. Patch from Pawel Hajdan Jr. Review URL: http://codereview.chromium.org/3143 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2361 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a typo in r2358.deanm@chromium.org2008-09-181-1/+1
| | | | | | Review URL: http://codereview.chromium.org/3142 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2360 0039d316-1c4b-4281-b951-d872f2087c98
* Add cross platform base::SysInfo::AmountOfPhysicalMemoryMB to replace the ↵deanm@chromium.org2008-09-185-18/+6
| | | | | | | | | Windows only env_util::GetPhysicalMemoryMB. From Seo Sanghyeon. Review URL: http://codereview.chromium.org/2962 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2358 0039d316-1c4b-4281-b951-d872f2087c98
* Add some padding between the right edge of the new tab button and the left ↵ben@chromium.org2008-09-181-2/+7
| | | | | | | | | | edge of the window controls. http://crbug.com/2451 Review URL: http://codereview.chromium.org/3130 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2355 0039d316-1c4b-4281-b951-d872f2087c98
* Make sure window controls in maximized browser windows can be hit-tested as ↵ben@chromium.org2008-09-181-2/+8
| | | | | | | | | | the appropriate HTCLOSE HTMINBUTTON etc types. Buggy code would previously prevent this from happening by detecting the entire area to the right of the tabstrip as being part of the caption. http://crbug.com/2449 Review URL: http://codereview.chromium.org/2955 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2354 0039d316-1c4b-4281-b951-d872f2087c98
* Fix painting of the title bar when the window is maximized and then deactivated.ben@chromium.org2008-09-181-1/+1
| | | | | | | | http://crbug.com/2456 Review URL: http://codereview.chromium.org/2953 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2350 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Make tcp_client_socket_unittest pass on Linux."evanm@google.com2008-09-181-1/+0
| | | | | | | This reverts commit d63170654d935f5a8ff6517bfacb60893f186a6b. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2347 0039d316-1c4b-4281-b951-d872f2087c98
* Make tcp_client_socket_unittest pass on Linux.dkegel@google.com2008-09-181-0/+1
| | | | | | | | | | Requires another changeset that puts libevent in third_party; I'll upload that next. This is not the final word; it makes too many syscalls per read. But it's a start. Review URL: http://codereview.chromium.org/3202 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2346 0039d316-1c4b-4281-b951-d872f2087c98
* Disable part of the Importer unit test because it failsnsylvain@chromium.org2008-09-181-0/+6
| | | | | | | | | | on windows sp3 (clean machine). See bug 2466. Review URL: http://codereview.chromium.org/3127 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2344 0039d316-1c4b-4281-b951-d872f2087c98
* filter out a couple of tests which seem to be causing a lot of purify crasheserikkay@google.com2008-09-181-1/+6
| | | | | | | | | BUG=http://code.google.com/p/chromium/issues/detail?id=2468 TBR=pamg Review URL: http://codereview.chromium.org/2952 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2343 0039d316-1c4b-4281-b951-d872f2087c98
* Fix GDI leak in Window object (leak of HICONs)ben@chromium.org2008-09-171-4/+12
| | | | | | | | http://crbug.com/2322 Review URL: http://codereview.chromium.org/3120 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2341 0039d316-1c4b-4281-b951-d872f2087c98
* =fix stretched logokuchhal@chromium.org2008-09-171-0/+0
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2338 0039d316-1c4b-4281-b951-d872f2087c98
* Rename legacy methods that were in CamelCase to unix_hacker.erg@google.com2008-09-1796-1664/+1631
| | | | | | | | | Required going through and modifying some of the code to solve name clashes. Review URL: http://codereview.chromium.org/2945 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2337 0039d316-1c4b-4281-b951-d872f2087c98
* Fix for issue 2362: On-demand update hang with "Checking for update..."finnur@google.com2008-09-171-1/+3
| | | | | | | | | We have been restructuring the message loop code lately and the MessageLoop on the file thread is not dispatching messages as it was before. I have changed the file thread to start with type MessageLoop::TYPE_IO, which pumps messages in such a way that Google Update can communicate back to us. I'm not sure what the best way to test this is but I ran the UI tests and the unit tests and they all pass. Review URL: http://codereview.chromium.org/2918 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2334 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a leak in the view unit tests.ben@chromium.org2008-09-171-2/+2
| | | | | | Review URL: http://codereview.chromium.org/3115 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2328 0039d316-1c4b-4281-b951-d872f2087c98
* Disable Add to dictionary unit tests temporarily. It is flaky.sidchat@google.com2008-09-171-2/+2
| | | | | | Review URL: http://codereview.chromium.org/3116 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2327 0039d316-1c4b-4281-b951-d872f2087c98
* Don't set any cookies as a result of the Google URL Tracker update check. ↵pkasting@chromium.org2008-09-171-1/+5
| | | | | | | | | This way, if users clear their cookies and restart, they won't have to wonder why a Google cookie has suddenly mysteriously appeared. BUG=1204 Review URL: http://codereview.chromium.org/2937 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2323 0039d316-1c4b-4281-b951-d872f2087c98
* Add support for "Add to dictionary" in the context menu.sidchat@google.com2008-09-1718-925/+1239
| | | | | | Review URL: http://codereview.chromium.org/2446 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2322 0039d316-1c4b-4281-b951-d872f2087c98
* Add gears.dll to Chrome installer. Also uninstall gears.msi if new installer ↵kuchhal@chromium.org2008-09-172-0/+20
| | | | | | | | succeeds. Review URL: http://codereview.chromium.org/2938 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2320 0039d316-1c4b-4281-b951-d872f2087c98
* Include chrome SConscript.unit_tests in Linux build.tc@google.com2008-09-177-223/+262
| | | | | | | | | | | | BUG=2335 Original patch by phajdan.jr@gmail.com in http://codereview.chromium.org/2891 R=mark,sgk Review URL: http://codereview.chromium.org/2939 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2319 0039d316-1c4b-4281-b951-d872f2087c98
* Second try to make the theme dll no-executable.nsylvain@chromium.org2008-09-171-1/+1
| | | | | | | Hopefully this flag wont cause a performance regression. Review URL: http://codereview.chromium.org/3109 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2318 0039d316-1c4b-4281-b951-d872f2087c98
* Include chrome/browser/SConscript in Linux build.tc@google.com2008-09-1711-264/+298
| | | | | | | | | | | | | | | In dns_host_info.cc there was probably a bug (hardcoded 1 instead of length. BUG=2333 R=mark,sgk Original patch by phajdan.jr@gmail.com at: http://codereview.chromium.org/2890 Review URL: http://codereview.chromium.org/3108 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2317 0039d316-1c4b-4281-b951-d872f2087c98
* Delete the provisional load commit notification since it duplicates the nav ↵brettw@google.com2008-09-176-61/+60
| | | | | | | | | | | entry committed notification. I had to add some more stuff to the nav entry committed structure which now looks suspiciously like the provisional load details structure. I'll see how I can improve this in a future pass. I used the new NotificationRegistrar to automatically unregister for notifications in the SSL manager, which reduces some code. Review URL: http://codereview.chromium.org/3095 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2313 0039d316-1c4b-4281-b951-d872f2087c98
* Adds logging to file_util::WriteFile to figure out why writingsky@google.com2008-09-173-115/+1
| | | | | | | | | | | | | bookmarks is failing for some people. As a result of this I moved some code from common/win_util to base/win_util so that file_util_win could call it. The only changes to this code are formatting. BUG=none TEST=none Review URL: http://codereview.chromium.org/2931 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2312 0039d316-1c4b-4281-b951-d872f2087c98
* Some initial work on compiling chrome/common/ on Linux.deanm@chromium.org2008-09-1710-159/+162
| | | | | | | | | Patch from Pawel Hajdan Jr. BUG=2410 Review URL: http://codereview.chromium.org/2929 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2311 0039d316-1c4b-4281-b951-d872f2087c98
* Wires up session restore so that it correctly deals with thesky@google.com2008-09-177-40/+232
| | | | | | | | | | | | navigation controller removing entries from the front of its list. BUG=1324021 TEST=covered by unit tests, but make sure you don't see problems with session restore. Review URL: http://codereview.chromium.org/2906 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2310 0039d316-1c4b-4281-b951-d872f2087c98
* Remove a referenced file that doesn't exist.maruel@google.com2008-09-171-4/+0
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2308 0039d316-1c4b-4281-b951-d872f2087c98
* Add a missing include and match a constant type better. From phajdan.jr.deanm@chromium.org2008-09-171-1/+4
| | | | | | Review URL: http://codereview.chromium.org/2922 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2300 0039d316-1c4b-4281-b951-d872f2087c98
* Don't load the font for the window title if we're not going to be painting a ↵beng@google.com2008-09-178-154/+76
| | | | | | | | | | text title bar... ie. don't load the font for the title bar for the main browser window since we won't use it - it's only used for app windows. http://crbug.com/2369 Review URL: http://codereview.chromium.org/2919 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2299 0039d316-1c4b-4281-b951-d872f2087c98
* Re-land this fix from earlier. Since I was making the tab icon view ↵beng@google.com2008-09-173-21/+29
| | | | | | | | | | | optional, I needed to adjust the accessibility tests so that they use the right index. Don't initialize the TabIconView if we don't need to. It's expensive to create. http://crbug/2369 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2298 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-01 20:29:28 +0000