| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
| |
created after that are queued.
Review URL: http://codereview.chromium.org/125242
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18763 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
turning the window off for the gtk_fixed that represents the
tabstrip. For some reason, this caused the tabs to render relative to
the top of the window, so adjust the tab painting via the event
area offset.
BUG=13789
Review URL: http://codereview.chromium.org/131069
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18762 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/131052
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18761 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
tbr=pinkerton
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18759 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This has lots of missing stuff (e.g. a custom download item view that shows
download progress, the popup is the same for in-progress and completed
downloads, no animation, everything looks ugly, the info bubble overlaps the
shelf when it's visible, no "open download manager page" link, etc), but the
basic functionality is hooked up: The shelf appears when files are downloaded,
and something ugly is added to the shelf for each download. The popup's "Reveral
in Finder" even works. The shelf is per-window as it should be.
BUG=12500
TEST=Download something and check the shelf appears. Click the close button and
make sure it disappears again.
Review URL: http://codereview.chromium.org/93129
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18757 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18756 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18755 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Although it compiles in all builds etc., someone left the enabling code
ifdef'ed in browser main. This should enable SDCH on mac/linux.
To test, visit a site that supports SDCH (twice... the first time
you'll get the dictionary in the background), and then do a
view-cache:
in front of the resulting URL, and check to see that you're getting
Content-Encoding: sdch,gzip
If it is not sdch encoded, then with some tiny (1%) probability,
you're in a control group of a current experiment... and you can
try starting your browser again... and doing another two visits.
To better track the issue if you think you are in the control group,
you can also visit
about:histograms
and you should see that a dictionary was downloaded, and then
either some content was decoded, with timings in Sdch3.Experiment_Decode
or was not run in SDCH and was timed in Sdch3.Experiment_Holdback.
BUG=14516
r=willchan,pinkerton
Review URL: http://codereview.chromium.org/131025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18753 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=9000
Review URL: http://codereview.chromium.org/131004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18751 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=evan
Review URL: http://codereview.chromium.org/131063
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18750 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=Tab dragging on the Mac should still work.
Review URL: http://codereview.chromium.org/131055
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18749 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
We apply the theme background color to the window and use a NineBox
to draw the theme images around the border.
BUG=13430
Review URL: http://codereview.chromium.org/131049
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18748 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
files in webkit/api.
Here's the mapping:
webkit/glue/webdatasource.h -> webkit/api/public/WebDataSource.h
webkit/glue/weberror.h -> webkit/api/public/WebURLError.h
webkit/glue/weburlrequest.h -> webkit/api/public/WebURLRequest.h
webkit/glue/webresponse.h -> webkit/api/public/WebURLResponse.h
I kept the implementation of WebDataSource in webkit/glue for now because it
helps to have it close to WebFrameImpl and WebFrameLoaderClient.
To facilitate this change, I needed to make use of WrappedResourceRequest and
WrappedResourceResponse from webkit/api/src within the implementation files of
webkit/glue. This is only a temporary usage of webkit/api/src from the
outside. It will go away when WebFrame, etc. get moved into webkit/api.
I modified these wrapper classes to expose the 'bind' function so that I can
re-bind a wrapper. This is used in WebDataSourceImpl::request() and related
methods to allow the interface to return a const reference to a WebURLRequest
and WebURLResponse.
The changes here are fairly mechanical. I'm not too happy about the way
WebDataSource::redirectChain now works. I would prefer a solution that didn't
involve so much copying, but I'm not going to worry about optimizing that now.
R=brettw
BUG=10041
TEST=none
Review URL: http://codereview.chromium.org/126286
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18747 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18746 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
runs. Since the reference run always comes second, it seems like it gets the UBC advantage and everything is a little after (when using two of the same builds). So try to load all the needed data into the UBC before we start the tests.
Review URL: http://codereview.chromium.org/131057
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18745 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=14460 (http://crbug.com/14460)
TEST=Cmd+S on Mac should bring up the save page dialog.
Review URL: http://codereview.chromium.org/126299
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18744 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
skia/ext/skia_utils_mac.h and removed chrome/browser/cocoa/cocoa_utils.h.
Patch by rsesek.
BUG=13565
Review URL: http://codereview.chromium.org/131018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18743 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Make l10n_util::ToLower string16 friendly.
BUG=13326
Review URL: http://codereview.chromium.org/126260
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18742 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
to the Extension class.
BUG=http://crbug.com/12117
TEST=none
Review URL: http://codereview.chromium.org/131044
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18736 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
default drag icon.
BUG=none
TEST=Drag a tab out of the tabstrip. The default gtk drag icon should not be visible.
Review URL: http://codereview.chromium.org/131043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18734 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Added const to methods not changing the state, except for the lazy setting of an escaped version of a path which is now mutable.
Also made some lint fixes.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/132024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18733 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
I copied the logic about whether to show the loading status or URL from
the Views code.
Review URL: http://codereview.chromium.org/125267
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18730 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/132028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18728 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=13326
Review URL: http://codereview.chromium.org/126305
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18727 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=http://crbug.com/14211
TEST=See test case in bug.
Review URL: http://codereview.chromium.org/125211
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18720 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Now you can import and export an .html file with your bookmarks in it.
BUG=13110
Review URL: http://codereview.chromium.org/132006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18719 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Relands http://codereview.chromium.org/126281 which had been reverted due to a leak.
The only difference is in extension_prefs.h where extension_data_ is now a scoped_ptr.
Review URL: http://codereview.chromium.org/131040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18717 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
intent is to be able to debug problems with NativeControls under Gtk.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/131027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18715 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
no-op on Chromium builds)
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/131035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18709 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/132016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18703 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
generator uses Cygwin's bash and not cmd to execute commands.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/131028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18695 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18692 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
to 'chrome'.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/131011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18689 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
issue for clobber build :
Configuration: test_support_ui - Debug|Win32
Compiling...
npapi_test_helper.cc
c:\b\slave\win\build\src\chrome/browser/tab_contents/navigation_entry.h(15) : fatal error C1083: Cannot open include file: 'grit/theme_resources.h': No such file or directory
ui_test.cc
Review URL: http://codereview.chromium.org/131019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18686 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Broke purify and mac valgrind. "Pull Extension-related prefs into its own class. Also add a notification for when the extensions service has finished its initial load of extensions, separate from EXTENSIONS_LOADED.TEST=noneBUG=none"
Review URL: http://codereview.chromium.org/132008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18682 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Relands r18641, original code review: http://codereview.chromium.org/125268
Expect a crash on Windows.
The old method of crashing was flawed on posix (KillProcess just does a SIGTERM). On Windows though, it would terminate the process with the desired exit code, in order to make DidProcessCrash() return true. This process termination does not dump crash information though, since it just forcibly terminates the process, like a SIGKILL on posix. When I switched it to navigate to about:crash though, it actually crashes, and dumps crash information, which the UITest in windows (but not linux/mac) detects. Therefore, until those platforms can detect, we just use #if defined(OS_WIN) around the expected_crashes = 1.
Review URL: http://codereview.chromium.org/131007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18680 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=No visible changes yet
Review URL: http://codereview.chromium.org/131010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18677 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
a command-line switch.
BUG=4938
Review URL: http://codereview.chromium.org/131002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18675 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=13326
Review URL: http://codereview.chromium.org/126307
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18671 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
browser/views/tab_contents/tab_contents_view_gtk.cc implements sizing in a similar fashion to windows - i.e. when the GtkWidget is resized, it tells the RenderViewHost that it was sized, which causes the RVH to resize the view. A check for if (parent_) in the Gtk RenderWidgetHostView impl was preventing this sizing from occurring.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/125275
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18670 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
click context menu.
After I spent more time investigating, it seems that when the popup menu closes, it always returns focus to the toplevel that previously had it. Thus we don't have to worry about some other toplevel getting focus without us getting another focus-out.
BUG=13554
TEST=right click spellcheck correction works in gmail
Review URL: http://codereview.chromium.org/126301
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18667 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Use cross-platform method to get the NativeWindow.
BUG=13326
Review URL: http://codereview.chromium.org/126302
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18666 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
for when the extensions service has finished its initial load of extensions, separate from EXTENSIONS_LOADED.TEST=noneBUG=none
Review URL: http://codereview.chromium.org/126281
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18661 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=everything behaves the same, and you don't sad tab when resizing a very large autocomplete popup
BUG=13805
Review URL: http://codereview.chromium.org/125274
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18660 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=no
TEST=no
Review URL: http://codereview.chromium.org/126288
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18658 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/126295
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18657 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
AdditionalManifestFiles of setup.exe and mini_installer.exe.
BUG=14439
TEST=none
Review URL: http://codereview.chromium.org/125273
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18656 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Copy in the "First Run" file.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/126287
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18654 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
wired up yet, but will be shortly.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/126235
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18653 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/125262
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18651 0039d316-1c4b-4281-b951-d872f2087c98
|