summaryrefslogtreecommitdiffstats
path: root/chrome
Commit message (Collapse)AuthorAgeFilesLines
* Handle the possibility of failure when starting apaulg@google.com2008-11-116-26/+10
| | | | | | | | | | SafeBrowsing update transaction. If we fail to start the transaction, we report the error to the protocol manager which aborts the update process. Review URL: http://codereview.chromium.org/9778 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5207 0039d316-1c4b-4281-b951-d872f2087c98
* Only block alert() requests from blocked popups; not all popups.erg@google.com2008-11-1110-89/+198
| | | | | | | | | Add two unit tests to make sure we do the right thing; required adding a bunch of stuff to the automation layer. Review URL: http://codereview.chromium.org/10282 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5198 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a crash when dismissing an infobubble... could not locate Window*ben@chromium.org2008-11-112-6/+9
| | | | | | Review URL: http://codereview.chromium.org/10405 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5196 0039d316-1c4b-4281-b951-d872f2087c98
* * Revert "Por rt flush_cache tool."agl@chromium.org2008-11-115-29/+55
| | | | | | | | | This reverts commit 3bd600b37c5ee613c004c84736ee3cb69434562a. Review URL: http://codereview.chromium.org/9774 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5184 0039d316-1c4b-4281-b951-d872f2087c98
* Port flush_cache tool.agl@chromium.org2008-11-115-55/+29
| | | | | | | | | | BUG=4160 Review URL: http://codereview.chromium.org/9639 Patch from Paweł Hajdan jr. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5182 0039d316-1c4b-4281-b951-d872f2087c98
* These files were missed from my last cleanup CL.beng@google.com2008-11-112-63/+4
| | | | | | | Fix bustage. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5181 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup and rearrange methods on BrowserWindow interface.beng@google.com2008-11-1111-165/+50
| | | | | | Review URL: http://codereview.chromium.org/10291 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5180 0039d316-1c4b-4281-b951-d872f2087c98
* Ensure that windowed plugins get focus during WM_MOUSEACTIVATE. This fixesananta@chromium.org2008-11-111-18/+20
| | | | | | | | | | | | | | | | | | bug http://code.google.com/p/chromium/issues/detail?id=4273, which shows up when windowed plugins enter modal loops like context menu and keyboard navigation does not work in the menu. We were not converting the coordinates returned by GetCursorPos to client coordinates correctly, which caused us to miss the child window (Plugin) at times. This also fixes bug http://code.google.com/p/chromium/issues/detail?id=937, which was an issue with menu selections in Java menus. This occured because we would force the child window to have focus in every WM_MOUSEACTIVATE message. In this case the Java plugin window, which is a child of the plugin window already has focus. It receives a WM_KILLFOCUS message due to the forced SetFocus in our handler and takes out the menu, thus ignoring the menu selection. Fix for this issue is to handle WM_MOUSEACTIVATE only if a child window of RenderWidgetHostHWND does not have focus. R=amit Bug=4273 Review URL: http://codereview.chromium.org/10004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5178 0039d316-1c4b-4281-b951-d872f2087c98
* make sure we match all the tests and files that linux has running. We were ↵pinkerton@google.com2008-11-112-6/+72
| | | | | | | | never building process_posix, but now the newly added unit tests use it. Review URL: http://codereview.chromium.org/10221 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5175 0039d316-1c4b-4281-b951-d872f2087c98
* NO CODE CHANGE. Just force a build.maruel@chromium.org2008-11-111-4/+3
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5171 0039d316-1c4b-4281-b951-d872f2087c98
* Add support for 256 bit full hashes to the new implementation.paulg@google.com2008-11-1115-615/+1045
| | | | | | | | | This CL replaces the following, which seems to have become inaccessible: http://codereview.chromium.org/9202/ Review URL: http://codereview.chromium.org/10402 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5159 0039d316-1c4b-4281-b951-d872f2087c98
* Rename BrowserView2 to BrowserView.ben@chromium.org2008-11-1115-178/+174
| | | | | | | | http://crbug.com/4286 Review URL: http://codereview.chromium.org/9759 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5152 0039d316-1c4b-4281-b951-d872f2087c98
* Review URL: http://codereview.chromium.org/10005petersont@google.com2008-11-119-60/+109
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5151 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes bug where carpet bombing dialog would come in some situations itsky@google.com2008-11-111-10/+20
| | | | | | | | | | | | should not have. BUG=4136 TEST=see bug for details, along with 4220. You should also verify that carpet bombing dialog comes up when it should. Review URL: http://codereview.chromium.org/10270 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5148 0039d316-1c4b-4281-b951-d872f2087c98
* Forgot to remove these files.ben@chromium.org2008-11-102-0/+0
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5139 0039d316-1c4b-4281-b951-d872f2087c98
* * Fix two bugskuchhal@chromium.org2008-11-102-0/+2
| | | | | | | | | | | | - quoted path to chrome exe for Google update to launch - create Chrome guid key if not present. BUG=1443250 TBR=huanr Review URL: http://codereview.chromium.org/10403 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5136 0039d316-1c4b-4281-b951-d872f2087c98
* Removes the old frames.ben@chromium.org2008-11-1026-7035/+23
| | | | | | | http://crbug.com/2324 Review URL: http://codereview.chromium.org/10265 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5130 0039d316-1c4b-4281-b951-d872f2087c98
* Move 'learn more' in the privacy section to its own line.glen@chromium.org2008-11-101-18/+5
| | | | | | | | | BUG=4264 Review URL: http://codereview.chromium.org/9749 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5129 0039d316-1c4b-4281-b951-d872f2087c98
* Changes tree/table to pass in an appropriate location when the contextsky@google.com2008-11-109-55/+95
| | | | | | | | | | | | | menu is invoked from the keyboard. BUG=4029 TEST=In the bookmark manager bring up the context menu of the tree/table via the menu key and make sure the menu appears at a reasonable location. Review URL: http://codereview.chromium.org/10256 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5125 0039d316-1c4b-4281-b951-d872f2087c98
* Re-land this change now that I've made a speculative fix to the ↵ben@chromium.org2008-11-105-65/+151
| | | | | | | | DraggedTabController. Review URL: http://codereview.chromium.org/10263 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5124 0039d316-1c4b-4281-b951-d872f2087c98
* Minor layout changes that make the bookmark manager and popup blocker look ↵glen@chromium.org2008-11-103-5/+4
| | | | | | | | | | better. BUG=4271 Review URL: http://codereview.chromium.org/10262 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5121 0039d316-1c4b-4281-b951-d872f2087c98
* Add helper batch files to make launching JSC projects easier.dglazkov@google.com2008-11-101-0/+3
| | | | | | Review URL: http://codereview.chromium.org/9748 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5118 0039d316-1c4b-4281-b951-d872f2087c98
* Tweak delegate setting in the DraggedTabController to be more robust. ↵ben@chromium.org2008-11-101-10/+2
| | | | | | | | Delegates should be NULLed more aggressively. Review URL: http://codereview.chromium.org/10235 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5117 0039d316-1c4b-4281-b951-d872f2087c98
* Change old code from "unloadListnerChanged" model to new WebKit ↵erikkay@google.com2008-11-102-19/+8
| | | | | | | | | | | EnableSuddenTermination, unforking a bunch of code. BUG=http://crbug.com/4064 Review URL: http://codereview.chromium.org/9746 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5116 0039d316-1c4b-4281-b951-d872f2087c98
* Make sure that we deny javascript window.close() requests when we are showingerg@google.com2008-11-104-0/+85
| | | | | | | a blocked popup notification. Review URL: http://codereview.chromium.org/9709 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5115 0039d316-1c4b-4281-b951-d872f2087c98
* Fix tests ImporterTest.Firefox2Importer and Firefox3Importer.maruel@chromium.org2008-11-101-14/+16
| | | | | | | BUG=4185 Review URL: http://codereview.chromium.org/9484 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5106 0039d316-1c4b-4281-b951-d872f2087c98
* Don't crash on chrome.exe --type=renderer. Don't try to GlobalCleanup() if ↵deanm@chromium.org2008-11-101-1/+2
| | | | | | | | GlobalInit() wasn't successful. Review URL: http://codereview.chromium.org/10247 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5104 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes Issue 3096 in chromium "[Find in page] responds each IME composition, ↵hbono@chromium.org2008-11-101-3/+74
| | | | | | | | | | | | making "not found" noises or jumping within the page." This issue is caued by the TextField::Edit class which start searching a page with a string retrieved with the GetWindowText() function every time when a user presses a key. A string retrived with the GetWindowText() function contains a composition string, a string being composed by an IME. This string changes too often and users do not like to start searching a page with the string. To fix this issue, this change removes a composition string from a search string to emulate Firefox. BUG=3096 "Issue 3096: [Find in page] responds each IME composition, making "not found" noises or jumping within the page." Review URL: http://codereview.chromium.org/9634 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5096 0039d316-1c4b-4281-b951-d872f2087c98
* Implements a WM_MOUSEHWHEEL message handler.hbono@chromium.org2008-11-101-0/+1
| | | | | | | | A change r2266 removed fake scroll bars used to handle WM_MOUSEWHEEL messages. This change prevents Windows from sending WM_HSCROLL messages when tilting a mouse wheel (Windows sends WM_HSCROLL messages only to a window which has scroll bars.) and this causes a regression problem that we cannot use tilt-wheel to scroll horizontally. To solve this problem, this change implements a WM_MOUSEHWHEEL (0x020E) message handler to dispatch tilt-wheel events to the RenderWidgetHostViewWin::OnWheelEvents() function. Also, It changes scroll direction in creating a WebMouseWheelEvent instance. Review URL: http://codereview.chromium.org/9319 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5095 0039d316-1c4b-4281-b951-d872f2087c98
* EXPERIMENT:deanm@chromium.org2008-11-082-3/+7
| | | | | | | | | Push breakpad initialization until chrome.dll has already been loaded. This basically currently happens anyway, since loading chrome.dll in the main thread will beat the threaded breakpad initialization. Retrieving the file version information goes from ~4ms to ~1ms if chrome.dll is already loaded. Also move the file version code to the initialization thread. Review URL: http://codereview.chromium.org/10242 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5069 0039d316-1c4b-4281-b951-d872f2087c98
* Review URL: http://codereview.chromium.org/10237petersont@google.com2008-11-089-109/+60
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5059 0039d316-1c4b-4281-b951-d872f2087c98
* Entries in a form get recorded when the user submits the form. Database and ↵petersont@google.com2008-11-089-60/+109
| | | | | | | | pop-up menu talk to each other. Pop-up menu appears containing suggestions. Review URL: http://codereview.chromium.org/9462 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5058 0039d316-1c4b-4281-b951-d872f2087c98
* * Create unique event in global namespacekuchhal@chromium.org2008-11-081-9/+3
| | | | | | | | so that we can detect Chrome instances across user sessions. Review URL: http://codereview.chromium.org/10234 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5057 0039d316-1c4b-4281-b951-d872f2087c98
* In dialogs, when the focus moves to a button, that button should become the ↵jcampan@chromium.org2008-11-0812-13/+241
| | | | | | | | | | | | | | default button. When the focus is not a button, then the default button should be the one the delegate specifies. BUG=4132 TEST=Open the option dialog. OK should be the default and focused button. Move the focus around by pressing tab. When a button is selected, it should be the default button. Review URL: http://codereview.chromium.org/10230 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5056 0039d316-1c4b-4281-b951-d872f2087c98
* Add history/history_publisher.cc and history/history_indexer.idl.sgk@google.com2008-11-081-0/+6
| | | | | | Review URL: http://codereview.chromium.org/9719 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5052 0039d316-1c4b-4281-b951-d872f2087c98
* Switch to the new crash service URL.mal@chromium.org2008-11-081-1/+1
| | | | | | Review URL: http://codereview.chromium.org/9503 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5050 0039d316-1c4b-4281-b951-d872f2087c98
* Add chrome\browser\autofill_manager.cc andsgk@google.com2008-11-081-0/+2
| | | | | | | chrome\browser\net\referrer.cc to the SCons build (on Windows). Review URL: http://codereview.chromium.org/9710 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5048 0039d316-1c4b-4281-b951-d872f2087c98
* Adding in new solution builder pattern.bradnelson@chromium.org2008-11-081-3/+5
| | | | | | Review URL: http://codereview.chromium.org/10231 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5047 0039d316-1c4b-4281-b951-d872f2087c98
* Roll this change back until I understand the crashes.ben@chromium.org2008-11-085-152/+65
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5046 0039d316-1c4b-4281-b951-d872f2087c98
* Dramatically improve the link time in release mode. Today's MC Hammer Xcodemark@chromium.org2008-11-071-1/+17
| | | | | | | | Voodoo lesson: don't use the slow dsymutil utility; instead, make a "fake" .dSYM that contains the original unstripped Mach-O file. Review URL: http://codereview.chromium.org/9659 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5042 0039d316-1c4b-4281-b951-d872f2087c98
* * fix system level install bugkuchhal@chromium.org2008-11-071-1/+1
| | | | | | Review URL: http://codereview.chromium.org/10224 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5038 0039d316-1c4b-4281-b951-d872f2087c98
* Add installer\util\delete_reg_value_work_item{,_unittest}.ccsgk@google.com2008-11-072-0/+2
| | | | | | | to the SCons build. Review URL: http://codereview.chromium.org/9705 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5037 0039d316-1c4b-4281-b951-d872f2087c98
* * Check the presence of new_chrome.exe before using opv key for version.kuchhal@chromium.org2008-11-073-32/+47
| | | | | | Review URL: http://codereview.chromium.org/10214 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5035 0039d316-1c4b-4281-b951-d872f2087c98
* Removed lint problems. NO funcationality changes.brg@chromium.com2008-11-073-73/+71
| | | | | | Review URL: http://codereview.chromium.org/10219 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5031 0039d316-1c4b-4281-b951-d872f2087c98
* We have a crash caused by view_ being NULL here.nsylvain@chromium.org2008-11-071-1/+1
| | | | | | | | | | | | | | Everywhere else in this class we look to see if view_ is NULL before dereferencing it, except in this case. This would fix a crash found in the distributed tests. BUG: 1074508 Review URL: http://codereview.chromium.org/9674 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5030 0039d316-1c4b-4281-b951-d872f2087c98
* Update the SafeBrowsing protocol version to 2.2, which handlespaulg@google.com2008-11-071-3/+3
| | | | | | | | | | | - Zero sized chunks - Redirect URL format changes http://crbug.com/3418 Review URL: http://codereview.chromium.org/10222 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5028 0039d316-1c4b-4281-b951-d872f2087c98
* Looks like a size method got left behind in the gfx update. Also make sure ↵glen@chromium.org2008-11-072-8/+17
| | | | | | | | | | | | that we only restore the page info window position, but not the size. Plus some dead code removal in options_window_view. BUG=3509 Review URL: http://codereview.chromium.org/10218 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5027 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes bug in building filter string for open dialog that resulted insky@google.com2008-11-071-1/+2
| | | | | | | | | | | | showing garbage in files types combobox. BUG=4211 TEST=bring up bookmark manager, click on import, click on 'files of type' and make sure you only see *.html. Review URL: http://codereview.chromium.org/10225 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5026 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a failure on the ipc_tests due to a race between closing thervargas@google.com2008-11-071-0/+6
| | | | | | | | | ipc channel and sending the last message. Sometimes that last write is cancelled so there will be a channel error at the other end. Review URL: http://codereview.chromium.org/9629 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5022 0039d316-1c4b-4281-b951-d872f2087c98
* Switch MessagePumpForIO to use completion ports on Windows.rvargas@google.com2008-11-073-82/+84
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Cleanup the separation between MessagePumpForUI and MessagePumpForIO, and convert the latter to use Completion Ports instead of MsgWaitForMultipleobjects to sleep when idle. Remove all traces of Windows messages from MessagePumpForIO, remove the transitional API of completion port notifications and remove WatchObject API. Modify all callers of RegisterIOHandler so that they are no longer using RegisterIOContext, and also handle properly the new semantics of completion ports (notifications even when the IO completes immediately). Add a new interface to allow proper cleanup of disk cache (to replace code that was waiting for pending APCs from the destructor). Add a way for the message pump to perform cleanup of abandoned IO. BUG=B/1344358, 3497, 3630 TESt=unit tests R=darin Review URL: http://codereview.chromium.org/8156 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5021 0039d316-1c4b-4281-b951-d872f2087c98