| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
| |
SafeBrowsing update transaction.
If we fail to start the transaction, we report the error
to the protocol manager which aborts the update process.
Review URL: http://codereview.chromium.org/9778
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5207 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Add two unit tests to make sure we do the right thing; required
adding a bunch of stuff to the automation layer.
Review URL: http://codereview.chromium.org/10282
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5198 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/10405
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5196 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
This reverts commit 3bd600b37c5ee613c004c84736ee3cb69434562a.
Review URL: http://codereview.chromium.org/9774
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5184 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=4160
Review URL: http://codereview.chromium.org/9639
Patch from Paweł Hajdan jr.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5182 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Fix bustage.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5181 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/10291
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5180 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
bug http://code.google.com/p/chromium/issues/detail?id=4273, which shows up
when windowed plugins enter modal loops like context menu and keyboard navigation
does not work in the menu.
We were not converting the coordinates returned by GetCursorPos to client coordinates correctly, which caused us to miss the child window (Plugin) at times.
This also fixes bug http://code.google.com/p/chromium/issues/detail?id=937, which was an issue with menu selections in Java menus. This occured because we would force
the child window to have focus in every WM_MOUSEACTIVATE message. In this case the Java plugin window, which is a child of the plugin window already has focus. It receives a WM_KILLFOCUS message due to the forced SetFocus in our handler and takes out the menu, thus ignoring the menu selection. Fix for this issue is to handle WM_MOUSEACTIVATE only if a child window of RenderWidgetHostHWND does not have focus.
R=amit
Bug=4273
Review URL: http://codereview.chromium.org/10004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5178 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
never building process_posix, but now the newly added unit tests use it.
Review URL: http://codereview.chromium.org/10221
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5175 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5171 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
This CL replaces the following, which seems to have become inaccessible:
http://codereview.chromium.org/9202/
Review URL: http://codereview.chromium.org/10402
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5159 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
http://crbug.com/4286
Review URL: http://codereview.chromium.org/9759
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5152 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5151 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
should not have.
BUG=4136
TEST=see bug for details, along with 4220. You should also verify that
carpet bombing dialog comes up when it should.
Review URL: http://codereview.chromium.org/10270
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5148 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5139 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
- quoted path to chrome exe for Google update to launch
- create Chrome guid key if not present.
BUG=1443250
TBR=huanr
Review URL: http://codereview.chromium.org/10403
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5136 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
http://crbug.com/2324
Review URL: http://codereview.chromium.org/10265
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5130 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=4264
Review URL: http://codereview.chromium.org/9749
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5129 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
menu is invoked from the keyboard.
BUG=4029
TEST=In the bookmark manager bring up the context menu of the
tree/table via the menu key and make sure the menu appears at a
reasonable location.
Review URL: http://codereview.chromium.org/10256
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5125 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
DraggedTabController.
Review URL: http://codereview.chromium.org/10263
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5124 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
better.
BUG=4271
Review URL: http://codereview.chromium.org/10262
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5121 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/9748
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5118 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Delegates should be NULLed more aggressively.
Review URL: http://codereview.chromium.org/10235
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5117 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
EnableSuddenTermination, unforking a bunch of code.
BUG=http://crbug.com/4064
Review URL: http://codereview.chromium.org/9746
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5116 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
a blocked popup notification.
Review URL: http://codereview.chromium.org/9709
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5115 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=4185
Review URL: http://codereview.chromium.org/9484
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5106 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
GlobalInit() wasn't successful.
Review URL: http://codereview.chromium.org/10247
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5104 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
making "not found" noises or jumping within the page."
This issue is caued by the TextField::Edit class which start searching a page with a string retrieved with the GetWindowText() function every time when a user presses a key. A string retrived with the GetWindowText() function contains a composition string, a string being composed by an IME. This string changes too often and users do not like to start searching a page with the string.
To fix this issue, this change removes a composition string from a search string to emulate Firefox.
BUG=3096 "Issue 3096: [Find in page] responds each IME composition, making "not found" noises or jumping within the page."
Review URL: http://codereview.chromium.org/9634
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5096 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
A change r2266 removed fake scroll bars used to handle WM_MOUSEWHEEL messages. This change prevents Windows from sending WM_HSCROLL messages when tilting a mouse wheel (Windows sends WM_HSCROLL messages only to a window which has scroll bars.) and this causes a regression problem that we cannot use tilt-wheel to scroll horizontally.
To solve this problem, this change implements a WM_MOUSEHWHEEL (0x020E) message handler to dispatch tilt-wheel events to the RenderWidgetHostViewWin::OnWheelEvents() function. Also, It changes scroll direction in creating a WebMouseWheelEvent instance.
Review URL: http://codereview.chromium.org/9319
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5095 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Push breakpad initialization until chrome.dll has already been loaded. This basically currently happens anyway, since loading chrome.dll in the main thread will beat the threaded breakpad initialization.
Retrieving the file version information goes from ~4ms to ~1ms if chrome.dll is already loaded. Also move the file version code to the initialization thread.
Review URL: http://codereview.chromium.org/10242
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5069 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5059 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
pop-up menu talk to each other. Pop-up menu appears containing suggestions.
Review URL: http://codereview.chromium.org/9462
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5058 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
so that we can detect Chrome instances across user sessions.
Review URL: http://codereview.chromium.org/10234
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5057 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
default button.
When the focus is not a button, then the default button should be the one the delegate specifies.
BUG=4132
TEST=Open the option dialog. OK should be the default and focused button. Move the focus around by pressing tab. When a button is selected, it should be the default button.
Review URL: http://codereview.chromium.org/10230
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5056 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/9719
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5052 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/9503
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5050 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
chrome\browser\net\referrer.cc to the SCons build (on Windows).
Review URL: http://codereview.chromium.org/9710
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5048 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/10231
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5047 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5046 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Voodoo lesson: don't use the slow dsymutil utility; instead, make a "fake"
.dSYM that contains the original unstripped Mach-O file.
Review URL: http://codereview.chromium.org/9659
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5042 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/10224
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5038 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
to the SCons build.
Review URL: http://codereview.chromium.org/9705
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5037 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/10214
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5035 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/10219
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5031 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Everywhere else in this class we look to see
if view_ is NULL before dereferencing it, except
in this case.
This would fix a crash found in the distributed tests.
BUG: 1074508
Review URL: http://codereview.chromium.org/9674
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5030 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
- Zero sized chunks
- Redirect URL format changes
http://crbug.com/3418
Review URL: http://codereview.chromium.org/10222
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5028 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
that we only restore the page info window position, but not the size.
Plus some dead code removal in options_window_view.
BUG=3509
Review URL: http://codereview.chromium.org/10218
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5027 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
showing garbage in files types combobox.
BUG=4211
TEST=bring up bookmark manager, click on import, click on 'files of
type' and make sure you only see *.html.
Review URL: http://codereview.chromium.org/10225
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5026 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
ipc channel and sending the last message. Sometimes that last
write is cancelled so there will be a channel error at the other end.
Review URL: http://codereview.chromium.org/9629
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5022 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Cleanup the separation between MessagePumpForUI and
MessagePumpForIO, and convert the latter to use Completion
Ports instead of MsgWaitForMultipleobjects to sleep
when idle.
Remove all traces of Windows messages from MessagePumpForIO,
remove the transitional API of completion port notifications
and remove WatchObject API.
Modify all callers of RegisterIOHandler so that they are no
longer using RegisterIOContext, and also handle properly
the new semantics of completion ports (notifications even when
the IO completes immediately).
Add a new interface to allow proper cleanup of disk cache (to
replace code that was waiting for pending APCs from the destructor).
Add a way for the message pump to perform cleanup of abandoned IO.
BUG=B/1344358, 3497, 3630
TESt=unit tests
R=darin
Review URL: http://codereview.chromium.org/8156
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5021 0039d316-1c4b-4281-b951-d872f2087c98
|