| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
| |
allow user to choose another browser as default."
reverting r23841
Review URL: http://codereview.chromium.org/173131
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23845 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=19820
Review URL: http://codereview.chromium.org/174153
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23844 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
browser as default.
BUG=14023
TEST=Make sure the option of choosing a different browser shows up during uninstall (and works as intended) iff chrome is set as default browser.
Review URL: http://codereview.chromium.org/172080
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23841 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/173074
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23840 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR: huanr
BUG=19833
BUG=19834
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23838 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Extension signature sizes are always 4 bytes, not variable depending
on platform.
Review URL: http://codereview.chromium.org/173104
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23837 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
command-line switch to select the old WinInet-based FTP
implementation.
R=phajdan.jr
BUG=http://crbug.com/4965
TEST=none
Review URL: http://codereview.chromium.org/173099
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23836 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=19745
Review URL: http://codereview.chromium.org/174084
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23835 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
r23596 was the original attempt; r23714 reverted it. Using
gtk_text_buffer_copy_clipboard() gives the GtkTextBuffer
ownership of the GtkClipboard and appears to prevent it from
unhighlighting its text.
Tested as follows:
1. Select text in webkit and hit Ctrl-C; check that both the
PRIMARY and CLIPBOARD selections contain it.
2. Click in the omnibox. All of the text gets highlighted.
Check that the PRIMARY selection contains the omnibox text and
the CLIPBOARD selection contains the webkit text.
3. Type Ctrl-C and confirm that the CLIPBOARD selection now
contains the omnibox text.
4. Copy webkit text back to both selections.
5. Type Ctrl-L. The omnibox text gets highlighted but both
selections still contain the webkit text.
6. Type Ctrl-C and confirm that both selections now contain the
omnibox text.
7. Try hitting Ctrl-C again while the omnibox text is on the
CLIPBOARD selection to make sure that a bizarre GTK crash
doesn't occur (see comment in code).
BUG=19648
TESTED=see above
Review URL: http://codereview.chromium.org/173098
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23834 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/173085
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23833 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=brg
TEST=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23830 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=tony
Review URL: http://codereview.chromium.org/174146
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23829 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
http://crbug.com/18856
Review URL: http://codereview.chromium.org/174100
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23828 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=none
http://crbug.com/17251
Review URL: http://codereview.chromium.org/171082
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23827 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=18534
TEST=Open a new window. Open several tabs in this window and then close
the window. An item representing this window should be shown on the new
tab page. Hover this item (or tab to it). The tooltip should be
repositioned so that it is not clipped by the window viewport.
Review URL: http://codereview.chromium.org/173100
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23825 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/174099
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23824 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This involves moving the xml parsing code from static functions in
extension_updater.cc to a UpdateManifest class, and switching from
logging any errors directly to collecting them up and passing them
across the IPC channel.
BUG=http://crbug.com/12677
TEST=extensions auto-update should still work correctly
Review URL: http://codereview.chromium.org/164541
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23822 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Truncate match contents to 70% of the available width, reserving 30% for the
description.
* Animate omnibox shrinkage.
BUG=14898
TEST=Omnibox should animate smaller, but not bigger/opened/closed. Match
description should always be partially visible, if present.
Review URL: http://codereview.chromium.org/173002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23821 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/174140
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23820 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This will eliminate the workingsetsize reductions
that we currently do in the browser.
Memory usage will increase by about 25%. But it should
alleviate swapping issues that some users are seeing.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/173057
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23818 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
susceptible to random leaks.
BUG=http://crbug.com/18661
TEST=throbbers should work just fine
Review URL: http://codereview.chromium.org/171110
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23813 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=19813
TBR=jam
TEST=none
Review URL: http://codereview.chromium.org/173120
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23812 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23807 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/174013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23805 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
porting them.
BUG=none
TEST=make sure to thorougly test bookmark menus on windows.
Review URL: http://codereview.chromium.org/173091
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23801 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none, not worth it for this
TEST=unit_tests '--gtest_filter=UtilityProcessHostTest*' runs Chromium Helper,
not Chromium. No application icon should appear in the dock during this
test.
Review URL: http://codereview.chromium.org/174061
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23792 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
TBR: huanr
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23788 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also, do proper cleanup before browser shutdown in MetricsService UI test.
I hope this will reduce the flakiness.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/173023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23780 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
and custom frame + gtk theme.
By default, we try to detect custom frame or not based on the
window manager. On the bots, we run the startup tests in Xvfb
with no window manager running, so they don't get the custom
frame.
Review URL: http://codereview.chromium.org/174032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23778 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also, send more information in AutomationMsg_DidNavigate
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/165333
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23776 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=16361, 15099
TEST=Drag the thumbnails on the new tab page and make sure that the
visual representation is never clipped. Also make sure that no new
scrollbars show up due to dragging.
Review URL: http://codereview.chromium.org/173090
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23775 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Original code review: http://codereview.chromium.org/174038
BUG=19758
TEST=automated_ui_tests works as expected.
Review URL: http://codereview.chromium.org/173086
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23774 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
VisitedLinkMaster::AddFingerprint is reached. This causes an exit on debug builds, for production builds part of the history would silently not get imported. The root cause is that the initial size of the hash table only considers one of the two sources of input.
BUG=none
TEST=VisitedLinkTest::BigImport
Review URL: http://codereview.chromium.org/164419
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23773 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
resubmission.
BUG=19761
TEST=none
Review URL: http://codereview.chromium.org/174092
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23772 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
of time regenerating the images for all the tabs. This speeds
up the time needed to paint a tab by about 30%.
This helps a bit, but we're still slow. We need to calculate
damage rects and only redraw damage rects (most of the remaining
time is spent on painting to the canvas now).
BUG=15872
Review URL: http://codereview.chromium.org/174095
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23771 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
of executing JS in the renderer from a ui test, we'll have to use hacks like this.
Review URL: http://codereview.chromium.org/165090
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23770 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
is to make ResourceDispatcherHost support a handler pausing a request in its OnResponseStarted callback.
Note I didn't find any way of testing the resource handler code, so I didn't know how to add a good test for this.
BUG=19414
Review URL: http://codereview.chromium.org/173037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23769 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
under the drag.
BUG=19552
TEST=Drag a tab up and out of the tab strip. This should not crash.
Review URL: http://codereview.chromium.org/174091
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23768 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
will replace the original script which is used by buildbot to run sync test.
Review URL: http://codereview.chromium.org/172068
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23765 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Original code review: http://codereview.chromium.org/171006
BUG=19085
TEST=reliability_tests runs as expected.
Review URL: http://codereview.chromium.org/174083
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23763 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
previous CL.
BUG=8198
TEST=Building all targets succeed without an error.
TBR=darin
Review URL: http://codereview.chromium.org/173076
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23762 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=19130
TESTED=checked that it compiles :-P
Review URL: http://codereview.chromium.org/173079
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23760 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Makes SSLConfigService into a ref-counted interface, and makes Profile own an SSLConfigServiceFactory which is used to create the SSLConfigService and pass it through the URLRequestContext on down to where it is actually used.
R=eroman,wtc
BUG=11507,19290
Review URL: http://codereview.chromium.org/165003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23757 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
they work. Currently they are broken in buildbot due to this issue.
Review URL: http://codereview.chromium.org/174073
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23751 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
to show.
I also changed to use black text on white for the menu.
BUG=None
TEST=Hide and show the different sections on new tab page and makes
sure that the checkbox is correctly synced with the state.
Review URL: http://codereview.chromium.org/174035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23750 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
It was upset about assigning const char* to char *.
Original patch by dmaclach@gmail.com
Original review http://codereview.chromium.org/173046
R=me
BUG=19679
TEST=none
Review URL: http://codereview.chromium.org/173084
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23749 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
to update them in the future.
Review URL: http://codereview.chromium.org/174070
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23748 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
are too big
Review URL: http://codereview.chromium.org/174019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23747 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Advantages:
* Matches safari
* Does not clash with webapps that use cmd-b for "bold"
Review URL: http://codereview.chromium.org/173089
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23746 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This reverts commit 872a67636100b790dd034fe502e585d6a6abe716
(r23734). Use of notifications is questionable.
TBR=estade
Review URL: http://codereview.chromium.org/174087
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23744 0039d316-1c4b-4281-b951-d872f2087c98
|