| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
| |
Commit: http://codereview.chromium.org/113733
BUG=12170
TEST=Enable user scripts and create one. See that it runs. Now delete it. See
that it does not run!
Review URL: http://codereview.chromium.org/113741
Patch from Ted Crossman <tedoc2000@gmail.com>.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16864 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16861 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/115742
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16857 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16847 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
WebKit name for this piece of data.
R=jackson
BUG=None
TEST=No behavior change
Review URL: http://codereview.chromium.org/115743
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16843 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/115741
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16842 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Remove old, empty suppressions file.
BUG=12539
Review URL: http://codereview.chromium.org/115738
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16841 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
It's getting used by a lot of test executables now.
Review URL: http://codereview.chromium.org/113779
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16840 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
renaming it accordingly).
Review URL: http://codereview.chromium.org/115730
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16839 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
different every time.
Review URL: http://codereview.chromium.org/114049
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16836 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Description:
Make sure extension_uitest.cc is actually built (my bad - got confused
about the whole .gyp vs. .sln thing).
Also, to get things building now that extension_uitest.cc is built,
shuffle the extension automation constants around so they end up in
the browser library (I didn't realize the UI tests are already linking
with that, and the linker was bringing in the
automation_extension_function.obj file ended up causing lots of
unresolved linker problems). Note that this did build the other day
when I submitted the file originally, but it must have been
essentially a fluke that the linker chose the other .obj file to get
the constants.
BUG=none
TEST=none
Original issue: http://codereview.chromium.org/113734
Review URL: http://codereview.chromium.org/113788
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16835 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change adds a new test 'RenderViewTest.PrintLayoutTest', which prints an HTML page and verify its output.
To process a print job and verify its output, this change adds a pseudo-printer device "MockPrinter" into the MockRenderThread object. This MockPrinter object receives print-related IPC messages, process print jobs, and store the MD5 checksum of the output data.
The current RenderViewTest.PrintLayoutTest retrieves the MD5 checksum values and just compare them with expected values. Nevertheless, please feel free to give me your ideas to improve this test.
Finally, this change is inspired by PrintingLayoutTextTests (created by maruel) and a RenderViewTest.OnPrintPages (created by Mohamed Mansour). I would like to express my best gratitude to them.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/100255
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16834 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
make it run faster.
Review URL: http://codereview.chromium.org/115678
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16833 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/113801
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16832 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
FindBarViews, but I'm leaving it as is for now.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/113793
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16830 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
clients maintained by WebPluginProxy.
The PluginStreamUrl object ensures that it notifies the webplugin object that it is being deleted in its destructor.
The other change is to remove the call to CancelRequest in WebPluginDelegateImpl::CreateResourceClient for
seekable streams, as this call does not do anything for manual streams created with a resource id of -1.
In any case for byte range requests, receiving a new response does not mean that earlier requests should
be cancelled.
This fixes bug http://code.google.com/p/chromium/issues/detail?id=12445
BUG=12445
Review URL: http://codereview.chromium.org/113772
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16828 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This one is a strong suspect for several otherwise unexplained crashes
Image path: C:\Program Files\Spyware Doctor\smum32.dll
Image name: smum32.dll
Timestamp: Wed Nov 12 19:33:53 2008 (491BA021)
CheckSum: 0002DA62
ImageSize: 00029000
File version: 6.1.0.2
Product version: 6.1.0.2
TEST = no test required
BUG = 10695
Review URL: http://codereview.chromium.org/114043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16827 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
chrome.dll if present.
Review URL: http://codereview.chromium.org/114048
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16826 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
and end of animation. This allows the system bubble to hide and display
in systems that don't respect opacity, such as the Parallels desktop.
BUG= http://crbug.com/622
TEST=Start Chrome on a system running in a Parallels window. Hover over
a status bubble, and move mouse away. Status bubble should disappear.
(NOTE: This was reviewed at http://codereview.chromium.org/113747. It is in a
different review here because that code was uploaded from another machine,
before I had committer access.)
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=16802
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16824 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
has_focus already.
http://crbug.com/11920
TEST=Browser to www.google.com, focus is in search field, bring up new tab, click back to first tab, focus should be in search field.
TEST=Select messages in gmail, focus should NOT go to autocomplete field (omnibox, url bar).
Review URL: http://codereview.chromium.org/113751
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16823 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/113800
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16822 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
problems during shutdown in atypical cases.We can now be more stringent with the Remove() check that was already in place, since now users _must_ go through NotificationRegistrar to register an observer.
BUG=12560
Review URL: http://codereview.chromium.org/115733
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16821 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=avi
Review URL: http://codereview.chromium.org/113799
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16818 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=2381
TBR=avi
Review URL: http://codereview.chromium.org/113796
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16816 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/112058
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16815 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
and turn off access to AddObserver()/RemoveObserver() entirely.
This eliminates one element of the unittests which tested that removing an observer that doesn't exist is harmless; in NotificationRegistrar-land, doing this will NOTREACHED().
BUG=2381
Review URL: http://codereview.chromium.org/114044
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16814 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
NotificationRegistrar.
BUG=2381
Review URL: http://codereview.chromium.org/113790
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16813 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(1) Use nonblocking sockets. Blocking the IO thread is bad.
(2) Handle multiple SocketReaders.
(3) Stop leaking file descriptors in SocketReader. Old code used to stop watching the fds, but not close them.
(4) Handle partial reads and writes. SocketReader reads until the sender shuts down his side of the socket.
(5) Timeout readers after 5 seconds so they don't hang forever.
BUG=http://www.crbug.com/12343
TEST=Open a chrome instance. Check /proc/<pid>/fd/ to see how many descriptors there are. Run "chrome www.google.com" on the command line a bunch of times, which should create a bunch of tabs. Make sure you close all these new tabs that pop up.a Check /proc/<pid>/fd/ to see how many descriptors there are. There shouldn't be many more (although some of the new renderers that got created take awhile because they get cleaned up). Keep repeating, you should be at a steady state of file descriptors.
Review URL: http://codereview.chromium.org/112054
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16811 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
platform-specific inner classes.
BUG=none
TEST=make sure web page focus cycling in and out of the content area still works.
Review URL: http://codereview.chromium.org/113784
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16810 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/113794
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16809 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
CPAPI (0.10) functions for gears drag drop; one to extract thedrag type/data given an NPObject *event, one to override thedrop effect (drag cursor).
Gears drag drop API receives a browser event as an NPObject* sothe event is untrusted. Provide IPC calls to the renderer sogears can pass the event to renderer/V8 for checking, prior todrag type/data extraction, or the setting of the drop effect.
Original patch by Noel Gordon via:
http://codereview.chromium.org/99240
BUG=7995
TEST=none
Review URL: http://codereview.chromium.org/112056
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16808 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=2381
Review URL: http://codereview.chromium.org/113792
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16806 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=11971
Review URL: http://codereview.chromium.org/115722
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16805 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/115726
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16803 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
and end of animation. This allows the system bubble to hide and display
in systems that don't respect opacity, such as the Parallels desktop.
BUG= http://crbug.com/622
TEST=Start Chrome on a system running in a Parallels window. Hover over
a status bubble, and move mouse away. Status bubble should disappear.
Review URL: http://codereview.chromium.org/114046
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16802 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=mmoss
Review URL: http://codereview.chromium.org/115724
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16801 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/113791
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16800 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16799 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
and make this file easier to port.
Review URL: http://codereview.chromium.org/113778
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16798 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
of WindowWin was unnecessary so I removed it. I created a function in Menu
go get the system menu so that can be ported inside views.
Review URL: http://codereview.chromium.org/113785
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16797 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=10005
Review URL: http://codereview.chromium.org/114041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16796 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
EPERM. We then procede to print out a scary error message to the terminal, even though this is non-fatal.
This CL special cases EPERM on the Mac so we don't print the error message.
I'm leaving in the LOG() since I think we still want to know about any out of bound values coming back.
Review URL: http://codereview.chromium.org/113786
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16795 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The logic in the seek method of BufferedResourceLoader was
that it will wait until the data is downloaded if we know
that the desired seek position is within the bufferable range
of the buffer, which is 10MB for now. This number is found to
be too big and we should have another constant that governs
the threshold of bytes that we should wait for forward
seeking instead of starting a new request, this value is
essentially much smaller than the buffer size, we guess this
number to be 2MB.
Also introduced the timeout logic to BufferedResourceLoader,
so if BufferedResouceLoaderRead() takes more than a certain
amount of time it is declared timeout and a new request
should be started. The current timeout is set to 5s.
Review URL: http://codereview.chromium.org/115627
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16793 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=2381
Review URL: http://codereview.chromium.org/114040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16792 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
renderer.
gtk_grab_add() causes us to receive all events. That means we receive
mouse events for other widgets with the coordinates relative to the other
widget. We actually the coordinates relative to the popup.
This caused jankiness with the popup on news.google.com. Since the popup happened to be on
the left side of the page, we sent event coordinates that happened to land in
the popup, causing us to select stuff.
BUG=12025
Review URL: http://codereview.chromium.org/113750
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16791 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/115718
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16790 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
TBR=eglaysher
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16787 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
prepopulated search (what you have searched for in other tabs).
TEST=Covered by in-process-browser test now. To test manually: open a tab, search for something in FindInPage, Press Ctrl+T and then F3. It should search for the same thing in the newly opened tab.
BUG=12468
Review URL: http://codereview.chromium.org/115714
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16786 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=11971
TEST=fresh install of Chrome should still bring up the first run dialog
Review URL: http://codereview.chromium.org/115689
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16783 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=erg
BUG=12533
Review URL: http://codereview.chromium.org/113781
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16779 0039d316-1c4b-4281-b951-d872f2087c98
|