summaryrefslogtreecommitdiffstats
path: root/chrome
Commit message (Collapse)AuthorAgeFilesLines
* Allow TabContentsDelegates to process unhandled keyboard messages coming ↵ananta@chromium.org2009-07-144-25/+47
| | | | | | | | | | | | | | | | | | | back from the renderer. This is required for ExternalTabContainer to be able to pass unhandled keyboard accelerator messages back to the external host. This worked before as the focus manager would hand off these messages to keystroke listeners like the ExternalTabContainer. However with the ExternalTabContainer no longer using the focus manager this does not work anymore. Removed the keystroke listener code from the focus manager as the ExternalTabContainer was the only consumer and it does not use it anymore. This fixes bug http://b/issue?id=1975749 Bug=1975749 Review URL: http://codereview.chromium.org/149520 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20600 0039d316-1c4b-4281-b951-d872f2087c98
* Copy codec Mac build stage (branded and unbranded)jrg@chromium.org2009-07-141-0/+16
| | | | | | Review URL: http://codereview.chromium.org/149593 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20596 0039d316-1c4b-4281-b951-d872f2087c98
* Hookup Print HTML page to the DOM UI for Print Preview and Settingsmhm@chromium.org2009-07-147-8/+101
| | | | | | | | | | | | | | Depends on initial foundation: http://src.chromium.org/viewvc/chrome?view=rev&revision=19906 And html mockup: http://src.chromium.org/viewvc/chrome?view=rev&revision=19918 BUG=173, 947 TEST=The user will see the print html page as a html test webpage. Review URL: http://codereview.chromium.org/155067 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20595 0039d316-1c4b-4281-b951-d872f2087c98
* Temporarily disable TestConsoleLog in interactive_tests. dimich@google.com2009-07-141-1/+1
| | | | | | | | | BUG=16684 TEST=none TBR=mhm@chromium.org Review URL: http://codereview.chromium.org/155472 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20593 0039d316-1c4b-4281-b951-d872f2087c98
* More bookmark bar changes.jrg@chromium.org2009-07-1421-142/+1285
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Applied memory cleanliness fix in unit test; follow-up from http://codereview.chromium.org/149308. * Move bookmark bar into it's own nib; minor code refactor to accomodate. * The toolbar STAR button somehow lost it's action; added it back in. * Implemented delete bookmark notification callback so we behave (remove button from the screen) when a bookmark is deleted. * Added context menus for the bookmark bar and bookmark buttons. * Hooked up a handful of these menu items. E.g. - open in new tab, window, incog window - delete bookmark (finally) - bookmark manager (which then hits a NOTIMPLEMENTED()) - always show bookmark bar * Truncate bookmark button text on end, not on middle. Experimental to look more like Windows. It looks cleaner but is less Mac-like. * Add "draws border when mouse goes over" for bookmark buttons. Need to do it by hand since we have a custom button drawing method. BUG=crbug.com/8381 TEST=Here's a list: - Make sure the bookmark buttons don't have a border unless the mouse is over them - Toolbar "STAR" should now add bookmarks when clicked - Test context menus on bookmark buttons, and the bar itself - Confirm a few of the behaviors as listed in the 'what I hooked up'; e.g. Right click on bookmark --> delete menu item should delete button Review URL: http://codereview.chromium.org/155358 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20591 0039d316-1c4b-4281-b951-d872f2087c98
* This provides a simpler js template engine than JsTemplate. It has beenarv@google.com2009-07-1430-230/+429
| | | | | | | | | | | | | | | | | | optimized for the way we do internationalization with JST before and is about 4 times faster (average 4.8ms vs 22.8ms) for the history page. The syntax for this is very similar to JsTemplates. It uses the attributes i18n-values and i18n-content which worls like jsvalues and jscontent except that it does not allow arbitrary expressions. BUG=None TEST=All UI pages should work as before Review URL: http://codereview.chromium.org/149420 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20590 0039d316-1c4b-4281-b951-d872f2087c98
* Roll WebKit DEPS from 45738 to 45840.dimich@google.com2009-07-145-2/+67
| | | | | | Review URL: http://codereview.chromium.org/149575 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20589 0039d316-1c4b-4281-b951-d872f2087c98
* Fix unittest; we changed the name of the PDF file that the test was using. ↵avi@chromium.org2009-07-142-5/+6
| | | | | | | | | | | | | (Plus a quick part of the original patch missed on checkin.) BUG=none TEST=none TBR Review URL: http://codereview.chromium.org/149587 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20586 0039d316-1c4b-4281-b951-d872f2087c98
* Add "learn more" link to privacy settings.mattm@chromium.org2009-07-141-1/+23
| | | | | | | | BUG=11507 Review URL: http://codereview.chromium.org/149581 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20584 0039d316-1c4b-4281-b951-d872f2087c98
* Adding Ogg/Theora/Vorbis-only FFmpeg binaries to Chromium nightly builds.scherkus@chromium.org2009-07-143-4/+14
| | | | | | | | | BUG=16657 TEST=nightly builds of Chromium should include avutil-50.dll, avformat-52.dll, avcodec-52.dll and pthreadGC2.dll Review URL: http://codereview.chromium.org/149571 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20583 0039d316-1c4b-4281-b951-d872f2087c98
* Nukes the 3 arg TabMoved variant in favor of the 4 arg variant.sky@chromium.org2009-07-1313-23/+27
| | | | | | | | | BUG=16634 TEST=none Review URL: http://codereview.chromium.org/155441 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20581 0039d316-1c4b-4281-b951-d872f2087c98
* Fix chromium build.estade@chromium.org2009-07-131-2/+2
| | | | | | | | TBR=erg Review URL: http://codereview.chromium.org/155466 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20580 0039d316-1c4b-4281-b951-d872f2087c98
* Make sure the wrapper uses our included ffmpeg libs.mmoss@chromium.org2009-07-131-0/+3
| | | | | | | Review URL: http://codereview.chromium.org/155455 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20579 0039d316-1c4b-4281-b951-d872f2087c98
* Updating trunk VERSION build from 194.0 to 195.0jon@chromium.org2009-07-131-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20578 0039d316-1c4b-4281-b951-d872f2087c98
* Bring RPM packaging scripts into the build.mmoss@chromium.org2009-07-131-0/+7
| | | | | | | Review URL: http://codereview.chromium.org/155460 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20576 0039d316-1c4b-4281-b951-d872f2087c98
* Re-enable previously flaky download ui tests. I can't reproduce the ↵estade@chromium.org2009-07-131-21/+5
| | | | | | | | | | failures. Will watch tree after commit. TBR=evan Review URL: http://codereview.chromium.org/155449 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20575 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: For the render view, count keyboard grab shadows the same as focus events.estade@chromium.org2009-07-131-0/+18
| | | | | | | | | | | | | This fixes an age old bug that dropdown menus still looked depressed after you select something from them and they collapse. It also fixes the more recent bug that you could have focus in the render view without any indication drawn by the renderer. I suspect there was a change to webkit that exacerbated this bug, because it seems like something we would have noticed earlier. Verified in a debugger that showing/hiding a dropdown menu doesn't emit focus signals, but does emit grab notify signals. Also verified that the bug is no longer reproducible in a simple page with <select> and <input> elements. BUG=16313 TEST=see desc. Review URL: http://codereview.chromium.org/149506 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20574 0039d316-1c4b-4281-b951-d872f2087c98
* Support individual Keychain item deletion in PasswordStoreMac.stuartmorgan@google.com2009-07-138-58/+180
| | | | | | | | | | | | Rename AddLogin to AddPassword for consistency with other method names. Remove a confusing out param from the form merge check function. BUG=16486 TEST=Once the UI exists, deleting individual passwords should work on the Mac. Review URL: http://codereview.chromium.org/155451 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20573 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Force a size on download items and elide the dangerous download filename.estade@chromium.org2009-07-131-3/+8
| | | | | | | | | | | | | This is a temporary hack that might not work in all locales and definitely won't work if we ever let users change font sizes. GtkLabels are just plain broken. Pango is also broken because you can get height-for-width for a layout but not width-for-height. Thus we should switch to using skia to draw download items fonts, but this solution will work for now. BUG=16389 TEST=download the Dansk version of open office for windows Review URL: http://codereview.chromium.org/155395 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20572 0039d316-1c4b-4281-b951-d872f2087c98
* Don't clobber the previous session when showing about-linux splash page.estade@chromium.org2009-07-132-13/+21
| | | | | | | | | BUG=16599 TEST=previous session should restore + linux splash page Review URL: http://codereview.chromium.org/149555 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20571 0039d316-1c4b-4281-b951-d872f2087c98
* Make chrome version legible in about:chrome dialog for dark themes.estade@chromium.org2009-07-131-15/+43
| | | | | | | | | | | Add Terms of Service link for google chrome (not chromium). BUG=16544 TEST=use dark theme, look at version in about:chrome Review URL: http://codereview.chromium.org/155454 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20570 0039d316-1c4b-4281-b951-d872f2087c98
* Set infobar height on a different widget.estade@chromium.org2009-07-131-1/+2
| | | | | | | | | | | Honestly I'm not completely sure why this is happening, all I know is the internal widget isn't getting sized as large as we want it, so I changed it to take a more direct action to set the size. BUG=16412 TEST=go to c, see infobar, switch tabs and go back and re-look at infobar. Should look same, with no 4 pixel strip of plainness. Review URL: http://codereview.chromium.org/149579 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20569 0039d316-1c4b-4281-b951-d872f2087c98
* Restore RTL icons to CustomDrawButtonBase.tc@google.com2009-07-133-11/+34
| | | | | | | | | | Since moving from ResourceBundle to ThemeProvider, we needed to plumb through GetRTLEnabledPixbufNamed in ThemeProvider. Review URL: http://codereview.chromium.org/149483 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20568 0039d316-1c4b-4281-b951-d872f2087c98
* posix: show "plugin crashed" info bar when appropriateevan@chromium.org2009-07-132-3/+6
| | | | | | | | Note I fixed a bug in AlertInfoBar while I was at it. Review URL: http://codereview.chromium.org/155462 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20567 0039d316-1c4b-4281-b951-d872f2087c98
* Try the original CL "Always persist bookmark IDs" again with the fix tomunjal@chromium.org2009-07-1320-195/+195
| | | | | | | | | | | | | | Valgrind issue. The fix is in bookmark_storage.h - initialized the newly added member ids_reassigned_ of LoadDetails class. See http://codereview.chromium.org/149310 for the original CL. TEST=NONE BUG=16068 Review URL: http://codereview.chromium.org/155456 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20565 0039d316-1c4b-4281-b951-d872f2087c98
* Add cookie behavior combobox.mattm@chromium.org2009-07-131-2/+50
| | | | | | | | | BUG=11507 TEST=Disable cookie saving and try to login to iGoogle. Reenable and try again. Review URL: http://codereview.chromium.org/149574 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20564 0039d316-1c4b-4281-b951-d872f2087c98
* Re-land the patch to elide the status bubble to 1/3 the width of thetc@google.com2009-07-131-3/+10
| | | | | | | | | window. Review URL: http://codereview.chromium.org/155432 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20563 0039d316-1c4b-4281-b951-d872f2087c98
* GTK Themes: Refactored to use notifications instead of manual plumbing.erg@google.com2009-07-1331-426/+569
| | | | | | | | | | | | - Removes large amounts of plumbing because: - All GtkChromeButtons are constructed from GtkThemeProvider which keeps a reference to all live buttons and sends them theme change notifications. - CustomDrawButtons now subscribe themselves to the BROWSER_THEME_CHANGED notification; this gets rid of a LOT of plubming. - Removes the GtkThemeProperties struct; just pass the theme provider around. - Move all the constants from the themes namespace to class statics, per tony's suggestion Review URL: http://codereview.chromium.org/149547 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20561 0039d316-1c4b-4281-b951-d872f2087c98
* Initial support for theming on Mac OS X.avi@chromium.org2009-07-1341-7906/+9247
| | | | | | | | | | | | | Patch by alcor. Original review: http://codereview.chromium.org/149204 BUG=http://crbug.com/14451 TEST=Open a theme, watch it apply. Review URL: http://codereview.chromium.org/155355 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20560 0039d316-1c4b-4281-b951-d872f2087c98
* Platform cleanup in worker_uitest.cc.phajdan.jr@chromium.org2009-07-131-4/+4
| | | | | | | | It compiles and links on Linux after this change, but doesn't pass, so I don't enable it. Review URL: http://codereview.chromium.org/149561 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20559 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r20553.thestig@chromium.org2009-07-137-48/+10
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20554 0039d316-1c4b-4281-b951-d872f2087c98
* Additional svn ignores for native_client and Makefile.thestig@chromium.org2009-07-137-10/+48
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20553 0039d316-1c4b-4281-b951-d872f2087c98
* Various updates to the buildbot sample.aa@chromium.org2009-07-132-21/+32
| | | | | | | | | BUG=none TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20552 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Always persist bookmark IDs."tc@google.com2009-07-1320-193/+194
| | | | | | | | | | | | | This reverts commit r20532 because valgrind was complaining about uninitialized memory: http://build.chromium.org/buildbot/waterfall/builders/Chromium%20Linux%20(valgrind)/builds/697/steps/valgrind%20test:%20unit/logs/stdio TBR=munjal Review URL: http://codereview.chromium.org/155448 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20550 0039d316-1c4b-4281-b951-d872f2087c98
* Refactoring handle and dragging a bit in preparation for moles. The primary ↵erikkay@chromium.org2009-07-135-305/+430
| | | | | | | | change for this is to get rid of the concept of a "current" toolstrip and the idea that there's only one handle around. Instead, each toolstrip has its own handle and each can be displaying it independently. There's some initial work for moles in there, but it's disabled since this will require some other plumbing to hook up properly. Review URL: http://codereview.chromium.org/155192 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20544 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a memory leak in AudioRendererHost unit testhclam@chromium.org2009-07-133-7/+204
| | | | | | | | | BUG=16554 TEST=AudioRendererHostTest.MockStreamDataConversation Review URL: http://codereview.chromium.org/155412 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20541 0039d316-1c4b-4281-b951-d872f2087c98
* Add a temporary flag to enable plugins on the Mac and Linux whileamanda@chromium.org2009-07-133-0/+11
| | | | | | | | | | | | | | leaving the default to "disabled" until they work better. Temporary, for use by people who like living on the bleeding edge. BUG=none TEST=none jam: review evan,jon: FYI Review URL: http://codereview.chromium.org/149570 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20540 0039d316-1c4b-4281-b951-d872f2087c98
* Lands http://codereview.chromium.org/149404 for cmasone:sky@chromium.org2009-07-138-0/+234
| | | | | | | | | | | | | | | Adding a protobuf-based metrics communication scheme between Chrome OS and Chrome. Essentially, Chrome is used as a metrics upload service, and this hacks in a simple IPC mechanism for Chrome OS to use to communicate metrics info to Chrome for upload. We eventually want to do this using protobuffers over DBus, but this protobuffers-over-X-properties mechanism will work for now. TEST=none BUG=none Review URL: http://codereview.chromium.org/149459 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20539 0039d316-1c4b-4281-b951-d872f2087c98
* Changes Mac behavior to reblit the entire RWHVCocoa when scrolling.rohitrao@chromium.org2009-07-131-17/+8
| | | | | | | | | | | This fixes the trails left behind when scrolling with the findbar open. BUG=16124 TEST=Scroll with the find bar or popup blocker open. Make sure there are no trails left behind or other drawing issues. Review URL: http://codereview.chromium.org/149556 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20538 0039d316-1c4b-4281-b951-d872f2087c98
* Don't store blacklist entries in the keychain.stuartmorgan@google.com2009-07-132-4/+18
| | | | | | | | | BUG=none TEST=none; mac password storage has no UI yet. (Once it does: opting never to remember passwords for a site should not create a Keycahin entry.) Review URL: http://codereview.chromium.org/155389 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20537 0039d316-1c4b-4281-b951-d872f2087c98
* posix: drop Gears NOTIMPLEMENTED()evan@chromium.org2009-07-131-2/+1
| | | | | | Review URL: http://codereview.chromium.org/155429 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20536 0039d316-1c4b-4281-b951-d872f2087c98
* Always persist bookmark IDs.munjal@chromium.org2009-07-1320-194/+193
| | | | | | | | | | | | | | | | Remove the preference to persist IDs. NOTE that we need to save the file the first time with IDs since existing bookmark files won't have IDs and the file won't be saved until something changes in the bookmark model. So we need to explicitly save once when we assign ids for the first time. TEST=NONE BUG=16068 Review URL: http://codereview.chromium.org/149310 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20532 0039d316-1c4b-4281-b951-d872f2087c98
* posix: drop a NOTIMPLEMENTED that is now implementedevan@chromium.org2009-07-131-13/+0
| | | | | | Review URL: http://codereview.chromium.org/149550 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20530 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the carbon event dispatcher from the main thread of the plugin processamanda@chromium.org2009-07-131-48/+0
| | | | | | | | | | | | and replace it with a pump for null events on the plugin thread. This removes a deadlock that the previous code inadvertently created, and is a much more focused solution to the problem. BUG=10809 TEST=none Review URL: http://codereview.chromium.org/155439 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20528 0039d316-1c4b-4281-b951-d872f2087c98
* Adds rendering and dragging of pinned tabs to gtk.sky@chromium.org2009-07-1310-143/+684
| | | | | | | | | BUG=16634 TEST=not yet Review URL: http://codereview.chromium.org/149544 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20523 0039d316-1c4b-4281-b951-d872f2087c98
* Switching an instance of SolutionDir to ProjectDir.gspencer@google.com2009-07-131-1/+1
| | | | | | | | | | | Please try not to use SolutionDir when you mean ProjectDir -- it prevents building the project from any directory other than the solution directory. BUG=none TEST=none Review URL: http://codereview.chromium.org/151165 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20522 0039d316-1c4b-4281-b951-d872f2087c98
* Add an optional channel name to the extension message connect event.mpcomplete@chromium.org2009-07-1312-67/+118
| | | | | | | | | | | Also changed the way port IDs work internally to reduce confusion. Each end of the port has its own ID, not the ID of its opposite end. BUG=13706 TEST=no Review URL: http://codereview.chromium.org/155381 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20519 0039d316-1c4b-4281-b951-d872f2087c98
* Revert previous clipping rect change for Cairo to see if it fixes the build.brettw@chromium.org2009-07-131-3/+10
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20516 0039d316-1c4b-4281-b951-d872f2087c98
* Correct the output-dir parameter passed to scan_server_dlls.py - it is ↵robertshield@google.com2009-07-131-1/+1
| | | | | | | | | | supposed to point at the build output directory, not the intermediate obj directory. TBR=slightlyoff, stoyan Review URL: http://codereview.chromium.org/155436 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20515 0039d316-1c4b-4281-b951-d872f2087c98
* linux: don't destroy the cairo_t* returned by beginPlatformPaint().evan@chromium.org2009-07-131-2/+1
| | | | | | | | (Checking in on a closed tree because Brett thinks it'll fix layout tests.) Review URL: http://codereview.chromium.org/149557 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20513 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-01-22 15:56:32 +0000