summaryrefslogtreecommitdiffstats
path: root/chrome
Commit message (Collapse)AuthorAgeFilesLines
* RSS feed support (part 1)finnur@chromium.org2009-03-1321-80/+392
| | | | | | | | | | | | | | | | Part 1 is RSS feed auto-discovery. This will parse the web page header to find the feeds in the document and notify the browser to display the RSS icon in the toolbar. You can click on the icon, but it will just navigate to the first feed on the page, which (unless it has been designed to be browser friendly) will just dump XML as text on the user. For this reason I have disabled the code that makes the RSS icon appear and intend to enable it when we have a good landing page to display the XML. Review URL: http://codereview.chromium.org/43109 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11640 0039d316-1c4b-4281-b951-d872f2087c98
* This CL fixes issue 8684 -- RTL Regression: Text should be right aligned for ↵xji@chromium.org2009-03-131-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | RTL languages on "Bookmark Manager" (http://crbug.com/8684) The problem is canvas.DrawStringWithHalo() within BookmarkTableView::PaintAltText() always use left alignment. The fix is to pass the correct canvas text alignment when DrawStringWithHalo(). Test: 1. Run Hebrew Chrome 2. Hit Ctrl + Shift + B go to "Bookmark Manager" dialog 3. Select "Search" 4. Observe Without the fix: Text "Enter a query in the text field above to search your bookmarks" is left aligned With the fix: The above text is right aligned Hebrew Review URL: http://codereview.chromium.org/43146 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11639 0039d316-1c4b-4281-b951-d872f2087c98
* Revert a change made to try and make purify errors go away now that Erik Kay ↵pkasting@chromium.org2009-03-131-5/+2
| | | | | | | | has disabled purify runs for the relevant tests. Review URL: http://codereview.chromium.org/42162 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11638 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup AutocompleteEditViewGtk's resources and widgets.deanm@chromium.org2009-03-131-0/+19
| | | | | | | Review URL: http://codereview.chromium.org/46034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11636 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a crash when with chrome-ui://about/" or anything invalidamit@chromium.org2009-03-131-4/+4
| | | | | | | | | | | | If DOMUIContents::InitCurrentUI returns true then current_ui_ should always be valid. Changed logic inside to make sure that this is the case. Review URL: http://codereview.chromium.org/46009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11634 0039d316-1c4b-4281-b951-d872f2087c98
* Stats for the renderers are all broken, because of this change:davemoore@chromium.org2009-03-131-6/+14
| | | | | | | | | | | | | | | | http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/chrome_dll_main.cc?r1=6627&r2=6626&pathrev=6627 line 236 We are appending the pid to the name of the shared memory object, which causes each renderer to get its own uninitialized copy of the stats counters, breaking the sharing. So then the about:stats code can't find the counters created and updated by these processes. This includes all the V8 counters and timers. Original issue: http://codereview.chromium.org/40012/show Review URL: http://codereview.chromium.org/42130 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11632 0039d316-1c4b-4281-b951-d872f2087c98
* Remove unneeded includes.maruel@chromium.org2009-03-132-2/+0
| | | | | | Review URL: http://codereview.chromium.org/43091 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11629 0039d316-1c4b-4281-b951-d872f2087c98
* Fix some browser shutdown issues on Linux.deanm@chromium.org2009-03-132-8/+27
| | | | | | | | | | | | | The previous code ended up destroying the BrowserWindow (removing it from BrowserList) while BrowserList was in the middle of iterating. Push the deletion onto the message loop (using DeleteSoon) to emulate what I'm guessing happens on Windows (the message is queue instead of processed right away). This fixes a second bug involving re-entrancy issues with Close() and window_, we now make sure to set window_ to NULL before any events might fire. BUG=8712 Review URL: http://codereview.chromium.org/43135 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11628 0039d316-1c4b-4281-b951-d872f2087c98
* Call into the IM hooks from the Linux Omnibox keyboard handling.deanm@chromium.org2009-03-131-14/+28
| | | | | | | | | This should give input methods the proper chance to handle enter and escape. Review URL: http://codereview.chromium.org/43149 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11627 0039d316-1c4b-4281-b951-d872f2087c98
* Remove unneeded platform_thread.h includes. Reduces number of includes from ↵thestig@chromium.org2009-03-131-1/+0
| | | | | | | | 598 to 511. Review URL: http://codereview.chromium.org/42165 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11617 0039d316-1c4b-4281-b951-d872f2087c98
* Argh, incorrect usage of Intersect.jam@chromium.org2009-03-131-3/+1
| | | | | | | | BUG=6317 Review URL: http://codereview.chromium.org/46022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11616 0039d316-1c4b-4281-b951-d872f2087c98
* Don't leak visited site information from original profile to OTR profile.abarth@chromium.org2009-03-133-7/+7
| | | | | | | | | BUG=8388 R=brettw Review URL: http://codereview.chromium.org/42114 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11613 0039d316-1c4b-4281-b951-d872f2087c98
* Improve my last change about informing google update about eula.cpu@google.com2009-03-132-2/+3
| | | | | | | | | | | | - Feedback from ddorwin: 1- Use the right set of permisions for the reg key 2- Only touch the key if user acepted the eula BUG=1594565 Review URL: http://codereview.chromium.org/42168 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11610 0039d316-1c4b-4281-b951-d872f2087c98
* Add support for repositioning/resizing a tab window. This is needed as the ↵ananta@chromium.org2009-03-136-0/+113
| | | | | | | | | | SetWindowPos call can fail on Vista if the caller is running under low IL. Review URL: http://codereview.chromium.org/42150 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11604 0039d316-1c4b-4281-b951-d872f2087c98
* Get rid of the gears in renderer process code. This allows me to do some ↵jam@chromium.org2009-03-1318-828/+16
| | | | | | | | cleanup in how resource dispatching happens in a future cl. Review URL: http://codereview.chromium.org/42158 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11601 0039d316-1c4b-4281-b951-d872f2087c98
* Temp fix for reliablity crashes.jam@chromium.org2009-03-131-0/+3
| | | | | | Review URL: http://codereview.chromium.org/46017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11599 0039d316-1c4b-4281-b951-d872f2087c98
* Gtk dialogs, first cut.estade@chromium.org2009-03-128-11/+209
| | | | | | | | Only the Save As file selection dialog is implemented for now. Review URL: http://codereview.chromium.org/42152 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11594 0039d316-1c4b-4281-b951-d872f2087c98
* Remove logging.h from cc files that don't use it.thestig@chromium.org2009-03-1233-34/+2
| | | | | | Review URL: http://codereview.chromium.org/42155 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11593 0039d316-1c4b-4281-b951-d872f2087c98
* Some minor cleanup in WebDataSource and WebResponse.darin@chromium.org2009-03-121-4/+3
| | | | | | | | R=dglazkov Review URL: http://codereview.chromium.org/42156 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11591 0039d316-1c4b-4281-b951-d872f2087c98
* Remove unneeded uses of logging.h in header files.thestig@chromium.org2009-03-1215-14/+17
| | | | | | Review URL: http://codereview.chromium.org/43148 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11590 0039d316-1c4b-4281-b951-d872f2087c98
* Implement WebSandboxSupport.darin@chromium.org2009-03-125-33/+45
| | | | | | | | R=dglazkov Review URL: http://codereview.chromium.org/42146 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11588 0039d316-1c4b-4281-b951-d872f2087c98
* Fix 'inspect element' crash when hosted in external tabamit@chromium.org2009-03-121-5/+6
| | | | | | | | | | | | | | If chrome tab is hosted in an external tab and 'inspect element' is invoked via GUI (as opposed to sending an automation request for AutomationMsg_InspectElement), we get a crash in AutomationProvider::ReceivedInspectElementResponse BUG=1694650 Review URL: http://codereview.chromium.org/43102 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11587 0039d316-1c4b-4281-b951-d872f2087c98
* Switch to using one ResourceDispatcher per render process, and move it to ↵jam@chromium.org2009-03-1211-120/+81
| | | | | | | | ChildThread so that the same code is used by the plugin process (and soon, workers). Review URL: http://codereview.chromium.org/42108 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11581 0039d316-1c4b-4281-b951-d872f2087c98
* Add copies of *.pak files that need to be installed for execution.sgk@google.com2009-03-121-1/+24
| | | | | | Review URL: http://codereview.chromium.org/42131 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11580 0039d316-1c4b-4281-b951-d872f2087c98
* Don't rely on subview ordering to be equivalent to tab ordering. Allows us ↵pinkerton@chromium.org2009-03-125-52/+129
| | | | | | | | to correctly set z-order on tabs. Add animation to tabs closing. Fix issue where new tab button would not draw correctly by pulling it from the nib. Fix memory leak in TabController. Fix console output about missing image. Review URL: http://codereview.chromium.org/43144 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11575 0039d316-1c4b-4281-b951-d872f2087c98
* Cleaning up Website junk in sln files.bradnelson@google.com2009-03-121-704/+0
| | | | | | Review URL: http://codereview.chromium.org/42143 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11573 0039d316-1c4b-4281-b951-d872f2087c98
* Fix SessionRestoreUITest.TwoTabsSecondSelected in single process mode.jam@chromium.org2009-03-121-13/+12
| | | | | | | | This is admitedly a little hacky, but I don't care as much since it's single-process mode and I don't think there's another way to solve it. The problem is that SiteInstance::GetProcess should always reuse an existing renderer "process", but GetExistingProcessHost() won't return the in-process renderer until RenderProcessHost::Init is called, which is after the second GetProcess call. So since we generate the in-process 'pid', I do it in the constructor instead of in Init. Review URL: http://codereview.chromium.org/42144 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11571 0039d316-1c4b-4281-b951-d872f2087c98
* Run ExtensionViewTest in single-process mode to try to make it less flaky.mpcomplete@google.com2009-03-123-1/+25
| | | | | | | | Changed InProcessBrowserTest to restore the original CommandLine after it tears down. Review URL: http://codereview.chromium.org/42084 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11568 0039d316-1c4b-4281-b951-d872f2087c98
* WebKit resource requests now have a flag reportUploadProgress that tells us ↵jcampan@chromium.org2009-03-123-0/+8
| | | | | | | | | | | | | | | | whether we should turn on the reporting of upload progress updates. This CL adds plumbing in the SimpleResourceLoader for reporting upload progress updates, as is already done in ResourceDispatcherHost. This makes 3 layout tests (XMLHttpRequest related) pass. BUG=None TEST=Run the layout tests. Review URL: http://codereview.chromium.org/28341 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11567 0039d316-1c4b-4281-b951-d872f2087c98
* bustageben@chromium.org2009-03-121-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11566 0039d316-1c4b-4281-b951-d872f2087c98
* bustageben@chromium.org2009-03-121-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11565 0039d316-1c4b-4281-b951-d872f2087c98
* bustageben@chromium.org2009-03-121-253/+0
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11564 0039d316-1c4b-4281-b951-d872f2087c98
* Make Widget return a gfx::NativeView instead of a HWND.ben@chromium.org2009-03-1262-240/+499
| | | | | | Review URL: http://codereview.chromium.org/43124 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11562 0039d316-1c4b-4281-b951-d872f2087c98
* Refactors code for showing bookmarks menus into a standalone classsky@google.com2009-03-129-384/+570
| | | | | | | | | | | | | | | that isn't tied to the bookmark bar. Removes some dead code from the bookmark bar, and fixes a UMR in chrome_menu that I found when running under purify. There isn't any behavior change in this patch. BUG=none TEST=this is a large refactoring of how bookmark menus are shown. Please thoroughly test menus on the bookmark bar to make sure I didn't screw anything up. Review URL: http://codereview.chromium.org/42128 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11558 0039d316-1c4b-4281-b951-d872f2087c98
* Chrome-side changes to use registerURLSchemeNoAccess.darin@chromium.org2009-03-121-1/+7
| | | | | | | | R=dglazkov Review URL: http://codereview.chromium.org/42125 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11555 0039d316-1c4b-4281-b951-d872f2087c98
* Make toggling fullscreen mode on/off significantly less janky-looking by ↵pkasting@chromium.org2009-03-125-16/+69
| | | | | | | | means of various crazy hacks. Review URL: http://codereview.chromium.org/42106 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11550 0039d316-1c4b-4281-b951-d872f2087c98
* fix gyp file, quote mismatch.tc@google.com2009-03-121-3/+3
| | | | | | | | | TBR=nsylvain Review URL: http://codereview.chromium.org/42135 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11547 0039d316-1c4b-4281-b951-d872f2087c98
* fix linux build. we need to include basictypes.h to gettc@google.com2009-03-121-0/+1
| | | | | | | | | | | DISALLOW_COPY_AND_ASSIGN TBR=finnur Review URL: http://codereview.chromium.org/43140 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11545 0039d316-1c4b-4281-b951-d872f2087c98
* Some work in refactoring FindBarWin/FindBarView sotc@google.com2009-03-1215-216/+470
| | | | | | | | | | | we can share code across platforms. See http://code.google.com/p/chromium/wiki/FindBarRefactoring for more information about the design. Review URL: http://codereview.chromium.org/42057 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11544 0039d316-1c4b-4281-b951-d872f2087c98
* Add a TabController class to manage a TabView (with corresponding xib). ↵pinkerton@chromium.org2009-03-129-45/+653
| | | | | | | | Rewrite strip controller to create and manage TabControllers instead of NSButtons. Review URL: http://codereview.chromium.org/43137 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11541 0039d316-1c4b-4281-b951-d872f2087c98
* Update known crashes.patrick@chromium.org2009-03-121-2/+14
| | | | | | Review URL: http://codereview.chromium.org/42124 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11540 0039d316-1c4b-4281-b951-d872f2087c98
* Redisable the java test. Even though the machine wasnsylvain@chromium.org2009-03-121-1/+2
| | | | | | | | | trying to autoupdate, it looks like this was not the cause of the failure. Review URL: http://codereview.chromium.org/42126 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11538 0039d316-1c4b-4281-b951-d872f2087c98
* Have RenderWidgetHostViewGtk take ownership of its widget.deanm@chromium.org2009-03-121-0/+5
| | | | | | | | | | | We previously left the widget floating, the reference would be sunk by the first container it was added to, if removed from this container it would be destroyed. This was happening in WebContentsViewGtk, and then we were double-destroying the widget in RenderWidgetHostViewGtk::Destroy(). BUG=8707 Review URL: http://codereview.chromium.org/42119 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11530 0039d316-1c4b-4281-b951-d872f2087c98
* Hookup the escape key on Linux Omnibox to revert to the permanent text (like ↵deanm@chromium.org2009-03-121-2/+7
| | | | | | | | | | | Windows). BUG=8236 Review URL: http://codereview.chromium.org/42074 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11529 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a Linux Omnibox bug where a widget was used after it was destroyed.deanm@chromium.org2009-03-121-0/+4
| | | | | | | Review URL: http://codereview.chromium.org/42073 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11528 0039d316-1c4b-4281-b951-d872f2087c98
* Better keyboard and mouse handling in Omnibox:deanm@chromium.org2009-03-122-33/+64
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | - Grab enter key events before they get to GtkTextView. We need to do this, otherwise enter when text is selected will replace the text, and we won't get a chance to catch that happening. This might have problems with IME, but it should be straightforward to fix anything IME related. - Don't deselect when we lose focus. This sometimes looks a bit strange, but it's the GTK thing to do. This also unbreaks copy and paste via the context menu, since popping up the context menu makes the GtkTextView lose focus. - Rewrite the inefficent newline eater. This should now only be needed for newlines that didn't come from the keyboard (like when you paste text). Use the builtin iter support for finding line boundaries, hopefully more efficient than checking the characters one by one. Still might have some bad behavior when pasting a ton of newline characters, but that can be improved later. This fixes inline autocomplete, you can now hit the enter key on an inline autocompleted suggestion, and you will get the intented navigation, instead of the navigation with the selected completion removed. This also adds support for alt-enter in Omnibox to navigate in a new tab. BUG=8236 Review URL: http://codereview.chromium.org/43072 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11527 0039d316-1c4b-4281-b951-d872f2087c98
* Add a GDK_COLOR_RGB macro for constructing GdkColors.deanm@chromium.org2009-03-123-7/+10
| | | | | | | | | This does the simple math of * 257 to map from a 1 byte component to the gint16 GdkColor values, and initializes the pixel field to 0. Review URL: http://codereview.chromium.org/43077 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11526 0039d316-1c4b-4281-b951-d872f2087c98
* Ensure that a listener's OnChannelConnected is called before OnMessageReceived.jam@chromium.org2009-03-123-22/+20
| | | | | | | | | | | | A race condition existed since the listener thread could dispatch messages in two ways: a task being posted to it, or because the dispatch messages event is set. The latter is needed to avoid deadlock when multiple SyncChannels are used on the same listener thread. If the latter method was used to dispatch a message, it might occur before the task that calls OnChannelConnected gets run. The fix is to call OnChannelConnected manually if we notice a message is being dispatched before it's called. Note: I couldn't think of a way to test this since it depends on a race condition in the listener message looop (whether the task or objectwatcher gets run first). Review URL: http://codereview.chromium.org/42113 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11522 0039d316-1c4b-4281-b951-d872f2087c98
* Pointing slns at generated vcprojs from base.bradnelson@google.com2009-03-121-1291/+2002
| | | | | | Review URL: http://codereview.chromium.org/42047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11520 0039d316-1c4b-4281-b951-d872f2087c98
* Re-enable java plugin test (reverting 11510)jar@chromium.org2009-03-121-2/+1
| | | | | | | | | | | The bot was trying to auto-update... and no one was clicking "yes." bug=8690 tbr=brettw Review URL: http://codereview.chromium.org/42112 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11517 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-03-12 22:57:03 +0000