| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
| |
automated tab.
Review URL: http://codereview.chromium.org/20125
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9388 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
created at startup before the main runloop. Correct quit on Mac to let the
BrowserProcess shut down the event loop when its refcount goes to zero after
cleaning up all browser windows.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9386 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The goal of this checkin is to effectively roll-back our stats gathering
methodology for stability stats to ONLY use the initial log. This has
some negative consequences (time lag, and bias against data from happy
ongoing users). We're doing this because there appears to be a BIG
survivability differnce between initial and ongoing logs. Perhaps we
are even getting multiple recordings of data from initial logs.
Until this is corrected, it is not safe to send part of the stability
info (crashes) only in the initial logs, while we send pageloads in
part via ongoing logs.
To absolutely minimize risk, I decided to leave the inter-log delay
at 20 minutes, so that there is no chance of changing the log saving
resource utilization (i.e., going over the limits). It was at 5
when we started the process, but since it has no impact on the initial
log, it won't harm the stability stats, and it may reduce load on
the front end log saving servers.
bug=1564631
r=huanr,evanm
Review URL: http://codereview.chromium.org/21160
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9385 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=7061
Review URL: http://codereview.chromium.org/21155
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9376 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
of the disk cache, rather than in the profile directory. The command
line switch overrides the cache location regardless the chosen
profile.
In this implementation, the supplied directory name must should not
contain spaces.
BUG=6688
submitted by bekkra.
original code review http://codereview.chromium.org/21094/show
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9375 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
(Why isn't this a command line include?)
Review URL: http://codereview.chromium.org/20159
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9373 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/20158
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9372 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Linux: GCC warning appeared only in opt mode
Mac: CMSG macros appear to be non-constant somehow.
Bodge and fix later.
Review URL: http://codereview.chromium.org/21157
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9370 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
This patch introduces a FileDescriptor object which can be included in IPC messages and will perform the magic needed to pass file descriptors over IPC. After some consideration, Windows will continue to do the current DuplicateHandle tricks.
Review URL: http://codereview.chromium.org/20027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9369 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Broke the build
Review URL: http://codereview.chromium.org/20153
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9364 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=7061
Review URL: http://codereview.chromium.org/20149
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9362 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=nobody (feel free to volunteer if you actually want to see these reviews)
Review URL: http://codereview.chromium.org/20148
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9356 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/20147
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9355 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/20141
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9352 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
int in IPC messages to make things clearer.
Review URL: http://codereview.chromium.org/20140
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9351 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/21140
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9350 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
to explain that it is unit tested in site_instance_unittest.cc.
BUG=7371
BUG=7369
TEST=NavigationEntryTest.*
Review URL: http://codereview.chromium.org/21132
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9349 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
is failing to load.
Review URL: http://codereview.chromium.org/21138
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9348 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/24005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9347 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/20143
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9346 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
- Histogram is named Launch.Modes
- We have different buckets for : direct execution, webapp, shell, quicklaunch and desktop shortcuts
BUG=7216
Review URL: http://codereview.chromium.org/21109
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9344 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=sid
Review URL: http://codereview.chromium.org/20142
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9339 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
selected. Remove a NOTIMPLEMENTED that shouldn't be there.
Review URL: http://codereview.chromium.org/20138
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9338 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
option when the same-origin policy interferes with testing their web sites.
R=deanm
BUG=6449
Review URL: http://codereview.chromium.org/20101
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9337 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
checkbox is not selected. Before, the dialog would simply not modify the value already set.
BUG=7426
R=cpu
Review URL: http://codereview.chromium.org/21134
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9336 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
This initiates the landslide of linker hell in Chromium.app,
bringing in webkit, v8, and the kitchen sink.
Review URL: http://codereview.chromium.org/21123
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9335 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
the Browser.
Review URL: http://codereview.chromium.org/20136
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9334 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
header files it doesn't need and add the ones it does use.
Review URL: http://codereview.chromium.org/21135
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9332 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
together (kind of like the windows RES builder).
I also moved the GRIT builder into the chromium site_scons since we
import it in lots of places. This seems cleaner.
Review URL: http://codereview.chromium.org/21115
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9331 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/20124
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9330 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=ojan
Review URL: http://codereview.chromium.org/21136
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9328 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/20135
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9326 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This reverts commit r9312.
Revert "Fix HostResolver crash when MessageLoop is destroyed during"
This reverts commit r9317.
BUG=5687,6683
TBR=ph
Review URL: http://codereview.chromium.org/21133
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9325 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/21130
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9323 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
tbr=pinkerton
Review URL: http://codereview.chromium.org/20130
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9321 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Also start using the new render_widget_host_view_gtk
Review URL: http://codereview.chromium.org/21119
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9319 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/21128
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9318 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
doing nothing) when over our client edge graphics. Make resize corner behavior on XP more native. More cleanup.
BUG=5054
Review URL: http://codereview.chromium.org/21116
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9315 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- remove slave threads and use HostResolver in asynchronous mode instead (while still limiting number of concurrent lookups)
- make the implementation portable and make DnsMaster unit test compile and pass on Linux
- add more tests to DnsMaster unit test to simulate various shutdown scenarios, concurrent lookups, and to verify that we don't exceed our limit of concurrent lookup requests)
- remove some tests which relied on specifics of slaves' inner working
Bonus: shutdown is almost instant now, no need to have a timeout.
BUG=5687, 6683
Review URL: http://codereview.chromium.org/15076
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9312 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
for mac and linux.
Review URL: http://codereview.chromium.org/21118
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9304 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
specific code for the settings dialog and the table view are just copied from
the old dialog. I tried to change as little as possible. The only significant
change should be that I commented out saving the settings in the profile.
This is a re-land of my previous patch which didn't ifdef the code based on the
IPC logging preprocessor define.
Previous review URL: http://codereview.chromium.org/19741
Review URL: http://codereview.chromium.org/20033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9303 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/20119
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9301 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
With pinkerton and jeremy.
Review URL: http://codereview.chromium.org/20120
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9300 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=amit
Review URL: http://codereview.chromium.org/24002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9299 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
render process (browser-side).
Once the constraint is reached, subsequent requests will fail with net::ERR_INSUFFICIENT_RESOURCES.
The bound is defined as "25 MB", which represents the amount of private bytes we expect the pending requests to consume in the browser. This number translates into around 6000 typical requests.
Note that the upload data of a request is not currently considered part of the request's in-memory cost -- more data is needed on the average/maximum upload sizes of users before deciding what a compatible limit is.
BUG=5688
Review URL: http://codereview.chromium.org/18541
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9298 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/21112
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9297 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The problem was that the process shutdown_event_ was created in RenderProcess::GlobalInit() and then deleted in RenderProcess::GlobalCleanup() and was being accessed after it's deletion by the MessageLoop's destructor (which was trying to signal shutdown).
MessageLoop was still retaining a reference to it since there was still an IPCSyncChannel listening on it.
IPCSyncChannel hadn't stopped listening on it since it was being terminated via OnChannelError.
This fix adds code that terminates listening on a channel when a Channel error occurs.
Review URL: http://codereview.chromium.org/20114
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9295 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9292 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
the printing. It creates new base functions for converting PIDs to handles, and
then closing them (since Windows requires this). This also fixes the formatting
of image_util.
Review URL: http://codereview.chromium.org/20109
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9291 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/20117
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9290 0039d316-1c4b-4281-b951-d872f2087c98
|