| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/21185
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9432 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9429 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Quite a bit of TODOs in the code, but it displays and properly
enables/disables buttons and routes mouse clicks.
This also moves all the gtk files into the gtk/ folder, at Ben's request.
Review URL: http://codereview.chromium.org/21176
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9421 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
We now hit the TabContentsDelegate in temp_scaffolding_stubs.h.
Review URL: http://codereview.chromium.org/21178
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9419 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
I removed the flatten_html visual studio rule and just rolled the
functionality directly into GRIT.
The sln change is to have browser depend on browser_resources (now needed for browser_resources.h).
Review URL: http://codereview.chromium.org/21148
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9418 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
It doesn't seem to occur anywhere in the SCons code nor in ours(?).
Review URL: http://codereview.chromium.org/20174
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9416 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This reverts commit r9411.
Brett's revert requires this.
TBR=brettw
Review URL: http://codereview.chromium.org/20194
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9415 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/20190
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9414 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
and state are now tracked and configurable.
Review URL: http://codereview.chromium.org/21177
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9413 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
* Implement no-op sandbox functions.
* Fix up the --renderer-startup-dialog dialog.
Review URL: http://codereview.chromium.org/20186
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9412 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=mad
Review URL: http://codereview.chromium.org/20187
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9411 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/21143
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9409 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
To display a resize bitmap and handle the mouse interactions as requested in
http://code.google.com/p/chromium/issues/detail?id=458.
BUG=458
There are unfortunately two cases to handle and they must be handled separately.
The first one is when there are no bottom shelf like the download bar,
and the case where there is one.
For the case without, we must draw on top of what we receive from WebKit,
so we intercept the bitmap in RenderWidgetHostViewWin::OnPaint() so that we
can draw the resize corner bitmap on top of it (taking into account whether
we are in a right to left language or not).
For the case where we have a bottom shelf, we use a dedicated view that we
properly layout on top of the bottom shelf view (which takes care of handling
the RTL language case for us).
Same split for the mouse interactions. Without the bottom shelf, we must deal
with it in RenderWidgetHostViewWin::OnMouseEvent() by sending the root window
a WM_NCLBUTTONDOWN message with either HTBOTTOMRIGHT or HTBOTTOMLEFT (based on
the RTL setting) and let the OS take care of the resizing. IF we have a bottom
shelf, we must deal with the mouse interaction in
BrowserView::NonClientHitTest()
to either return HTBOTTOMRIGHT or HTBOTTOMLEFT (again, based on the RTL setting)
and, again, let the OS take care of the resizing.
More details here:
http://code.google.com/p/chromium/wiki/BrowserViewResizer
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9408 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/20171
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9405 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
corresponding (disabled) unit test.
Issue=1503
Review URL: http://codereview.chromium.org/23013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9403 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/20178
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9402 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
its registered commands.
Review URL: http://codereview.chromium.org/20180
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9401 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
not close the process handle that they do not own.
Review URL: http://codereview.chromium.org/24004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9400 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=tommi
Review URL: http://codereview.chromium.org/20179
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9392 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/21172
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9390 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/23012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9389 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
automated tab.
Review URL: http://codereview.chromium.org/20125
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9388 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
created at startup before the main runloop. Correct quit on Mac to let the
BrowserProcess shut down the event loop when its refcount goes to zero after
cleaning up all browser windows.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9386 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The goal of this checkin is to effectively roll-back our stats gathering
methodology for stability stats to ONLY use the initial log. This has
some negative consequences (time lag, and bias against data from happy
ongoing users). We're doing this because there appears to be a BIG
survivability differnce between initial and ongoing logs. Perhaps we
are even getting multiple recordings of data from initial logs.
Until this is corrected, it is not safe to send part of the stability
info (crashes) only in the initial logs, while we send pageloads in
part via ongoing logs.
To absolutely minimize risk, I decided to leave the inter-log delay
at 20 minutes, so that there is no chance of changing the log saving
resource utilization (i.e., going over the limits). It was at 5
when we started the process, but since it has no impact on the initial
log, it won't harm the stability stats, and it may reduce load on
the front end log saving servers.
bug=1564631
r=huanr,evanm
Review URL: http://codereview.chromium.org/21160
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9385 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=7061
Review URL: http://codereview.chromium.org/21155
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9376 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
of the disk cache, rather than in the profile directory. The command
line switch overrides the cache location regardless the chosen
profile.
In this implementation, the supplied directory name must should not
contain spaces.
BUG=6688
submitted by bekkra.
original code review http://codereview.chromium.org/21094/show
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9375 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
(Why isn't this a command line include?)
Review URL: http://codereview.chromium.org/20159
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9373 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/20158
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9372 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Linux: GCC warning appeared only in opt mode
Mac: CMSG macros appear to be non-constant somehow.
Bodge and fix later.
Review URL: http://codereview.chromium.org/21157
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9370 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
This patch introduces a FileDescriptor object which can be included in IPC messages and will perform the magic needed to pass file descriptors over IPC. After some consideration, Windows will continue to do the current DuplicateHandle tricks.
Review URL: http://codereview.chromium.org/20027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9369 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Broke the build
Review URL: http://codereview.chromium.org/20153
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9364 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=7061
Review URL: http://codereview.chromium.org/20149
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9362 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=nobody (feel free to volunteer if you actually want to see these reviews)
Review URL: http://codereview.chromium.org/20148
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9356 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/20147
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9355 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/20141
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9352 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
int in IPC messages to make things clearer.
Review URL: http://codereview.chromium.org/20140
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9351 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/21140
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9350 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
to explain that it is unit tested in site_instance_unittest.cc.
BUG=7371
BUG=7369
TEST=NavigationEntryTest.*
Review URL: http://codereview.chromium.org/21132
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9349 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
is failing to load.
Review URL: http://codereview.chromium.org/21138
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9348 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/24005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9347 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/20143
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9346 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
- Histogram is named Launch.Modes
- We have different buckets for : direct execution, webapp, shell, quicklaunch and desktop shortcuts
BUG=7216
Review URL: http://codereview.chromium.org/21109
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9344 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=sid
Review URL: http://codereview.chromium.org/20142
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9339 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
selected. Remove a NOTIMPLEMENTED that shouldn't be there.
Review URL: http://codereview.chromium.org/20138
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9338 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
option when the same-origin policy interferes with testing their web sites.
R=deanm
BUG=6449
Review URL: http://codereview.chromium.org/20101
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9337 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
checkbox is not selected. Before, the dialog would simply not modify the value already set.
BUG=7426
R=cpu
Review URL: http://codereview.chromium.org/21134
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9336 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
This initiates the landslide of linker hell in Chromium.app,
bringing in webkit, v8, and the kitchen sink.
Review URL: http://codereview.chromium.org/21123
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9335 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
the Browser.
Review URL: http://codereview.chromium.org/20136
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9334 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
header files it doesn't need and add the ones it does use.
Review URL: http://codereview.chromium.org/21135
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9332 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
together (kind of like the windows RES builder).
I also moved the GRIT builder into the chromium site_scons since we
import it in lots of places. This seems cleaner.
Review URL: http://codereview.chromium.org/21115
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9331 0039d316-1c4b-4281-b951-d872f2087c98
|