| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/9719
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5052 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/9503
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5050 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
chrome\browser\net\referrer.cc to the SCons build (on Windows).
Review URL: http://codereview.chromium.org/9710
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5048 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/10231
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5047 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5046 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Voodoo lesson: don't use the slow dsymutil utility; instead, make a "fake"
.dSYM that contains the original unstripped Mach-O file.
Review URL: http://codereview.chromium.org/9659
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5042 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/10224
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5038 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
to the SCons build.
Review URL: http://codereview.chromium.org/9705
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5037 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/10214
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5035 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/10219
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5031 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Everywhere else in this class we look to see
if view_ is NULL before dereferencing it, except
in this case.
This would fix a crash found in the distributed tests.
BUG: 1074508
Review URL: http://codereview.chromium.org/9674
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5030 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
- Zero sized chunks
- Redirect URL format changes
http://crbug.com/3418
Review URL: http://codereview.chromium.org/10222
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5028 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
that we only restore the page info window position, but not the size.
Plus some dead code removal in options_window_view.
BUG=3509
Review URL: http://codereview.chromium.org/10218
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5027 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
showing garbage in files types combobox.
BUG=4211
TEST=bring up bookmark manager, click on import, click on 'files of
type' and make sure you only see *.html.
Review URL: http://codereview.chromium.org/10225
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5026 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
ipc channel and sending the last message. Sometimes that last
write is cancelled so there will be a channel error at the other end.
Review URL: http://codereview.chromium.org/9629
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5022 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Cleanup the separation between MessagePumpForUI and
MessagePumpForIO, and convert the latter to use Completion
Ports instead of MsgWaitForMultipleobjects to sleep
when idle.
Remove all traces of Windows messages from MessagePumpForIO,
remove the transitional API of completion port notifications
and remove WatchObject API.
Modify all callers of RegisterIOHandler so that they are no
longer using RegisterIOContext, and also handle properly
the new semantics of completion ports (notifications even when
the IO completes immediately).
Add a new interface to allow proper cleanup of disk cache (to
replace code that was waiting for pending APCs from the destructor).
Add a way for the message pump to perform cleanup of abandoned IO.
BUG=B/1344358, 3497, 3630
TESt=unit tests
R=darin
Review URL: http://codereview.chromium.org/8156
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5021 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Will investigate on the bot.
TBR=nsylvain
Review URL: http://codereview.chromium.org/9700
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5018 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
graphics mode of a ADVANCED doesn't work with a RTL layout for this
code.
BUG=4175
TEST=bring up the bookmark manager in the hebrew locale, make sure the
text isn't mirrored.
Review URL: http://codereview.chromium.org/10216
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5017 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
messages directly to the targeted window.
http://crbug.com/4067
Review URL: http://codereview.chromium.org/9485
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5014 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This probably needs some bigger adjustments. Some things need to be decided,
like where to store profile files on Linux/Mac.
BUG=3649
Review URL: http://codereview.chromium.org/8059
Patch from Paweł Hajdan jr <phajdan.jr@gmail.com>.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5012 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/10206
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5005 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/10209
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5003 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
indexers which are interested in indexing Chrome's web history. These should
register their CLSID in HKCU\Software\Google\Google Chrome\IndexerPlugins and
this is be used by Chrome to publish its index.
Added code to publish the index too.
Checked in for Vijay Thadkal <veejay.t.s@gmail.com> (Google). Reitveld #9007.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5002 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
context menus.
BUG=4186
TEST=try cut/copy/paste from table/tree in the bookmark manager as
well as context menus in bookmark manager.
Review URL: http://codereview.chromium.org/9481
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4993 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
dereferenced in specific cases. We would have to create the failed icon twice,
so that it would think the icon was already in the cache, when in fact a NULL
value was being cached.
BUG=1259695
Review URL: http://codereview.chromium.org/9672
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4988 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4986 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=1649
TEST=bring up bookmark manager and try out import/export from the
tools menu. Note that import ALWAYS creates a new folder under
the 'Other bookmarks folder' with the name of Imported (x). This
is by design.
Review URL: http://codereview.chromium.org/9471
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4968 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Select the highest FF version, not just the the HCKU one.
- I don't have a repro case, it is a blind fix
Seems like leftovers of old FF installs in HCKU are tripping us, that
is my guess, now we would find FF3 in HKLM.
BUG=3109
Review URL: http://codereview.chromium.org/9675
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4960 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
while it is in use. This should work for per user as well as system level
installs (after some additional changes once Google Update changes are ready).
The following scenarios should work now:
- If Chromium is using two different profiles at the same time we do not switch
chrome executables until all of them are closed.
- The old version of Chromium can be run after a restart if the renaming of
executables fails.
- We will not use environment variable any more but we need to keep it until all
the users get this change on their machines.
- opv/rename registry keys and new_chrome.exe should always together. If one
exist all three should exist because they are created and deleted as one atomic
operation (as much as possible given laws of physics).
BUG=1463346
Review URL: http://codereview.chromium.org/9436
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4949 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/9479
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4946 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
by the time the download item is created, you have the download tab opened and you press on the discard button.
This is because such downloads gets added to a vector that is used to unregister the DownloadTabView as an observer.
We were deleting the download item before notifying the DownloadTabView, which would cause it to access the deleted download item.
BUG=4134
TEST=Open the download tab, start the download of a short exe. Click the discard button in the dangerous download prompt.
Review URL: http://codereview.chromium.org/9435
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4940 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
waterfall.
BUG=4173
TEST=look at page-cycler step on waterfall
Review URL: http://codereview.chromium.org/9658
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4936 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
in an unload handler (i.e. we have an infinite-ish alert loop).
Review URL: http://codereview.chromium.org/9477
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4935 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
notification exists. This is a copy of Firefox's behaviour.
BUG=crbug.com/4007
Review URL: http://codereview.chromium.org/9656
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4934 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Use the HTTP "referer" header to identify subresources used during a
page load. Store that info, and use it when next visiting the referenced
hosts to pre-resolve the (probably) needed subresources.
This set of changes will surely evolve as we see how it plays out
on broader distribution (via histogram measurments), but this should be
the foundation of the change.
In design specs, this was previously referred to as "adaptive correlated
DNS prefetching."
r=mbelshe
Review URL: http://codereview.chromium.org/9168
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4929 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/9662
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4926 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/9468
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4923 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
that the tree still flicker during a resize
on RTL locales but not on LTR.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4917 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=1442838
Review URL: http://codereview.chromium.org/9422
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4913 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
the display of the extension. This touches a lot of files because it renames url_elider to text_elider (as it already contained a bunch of text ellision functions), and so requires header file reference changes. BUG=1208
Review URL: http://codereview.chromium.org/9613
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4912 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=nsylvain
Review URL: http://codereview.chromium.org/9460
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4908 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/9464
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4906 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/9650
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4900 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
With V8 r648 (Review URL: http://codereview.chromium.org/8909) attaching the debugger to V8 will initialize V8 if not already initialized. This needs to be serialized with the initialization of V8 in the renderer thread.
This change does not require the changes in V8 r648, but will not have any effect without.
Added a few comments.
BUG=3723
Review URL: http://codereview.chromium.org/8735
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4875 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
IMEs.
Recent Japanese IMEs (ATOK2008 and MSIME 2007) display a suggestion window (a window which contains suggestions) above a composition string. To fix this issue, we do not only send the lower-left corner of a composition string but also send its upper-left corner and its upper-right corner. So, this change changes IPC parameters used by IME from a tuple of integers to gfx::Rect.
Also, this change fixes cursor positions for Japanese IMEs.
BUG=2770 "IME: Candidate window of Japanese IME follows the end of composition"
BUG=2771 "ATOK 2008 IME pop-ups are displayed below the main Chrome window."
BUG=2775 "IME: Caret is always displayed at the last of IME composition."
Review URL: http://codereview.chromium.org/7385
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4872 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
I tested on the buildbot
and this is the only one I could see leaks in. If it stays green, I'll narrow it more by modifying the
test.
TBR=erikkay
Review URL: http://codereview.chromium.org/9451
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4871 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/9432
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4870 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Implements the following features
1. Toolbar import always available after first run
2. Deduping of imported favorites
3. Removes attempt to import favicons (not supported through Toolbar UI atm)
4. Always the user to cancel from the UI safely
5. Unittests for parsing
(TODO Better UI for login)
Review URL: http://codereview.chromium.org/9414
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4867 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/9446
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4861 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
see how it could happen.
Just bullet-proofing the code so we don't crash.
BUG=981648
Review URL: http://codereview.chromium.org/9190
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4857 0039d316-1c4b-4281-b951-d872f2087c98
|