| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
| |
are needed by AutoFill.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/341042
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30674 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
I am splitting out the pepper-specific portions of npapi.h.
This is because his code currently relies on a version
of npapi.h different from third_party\npapi\bindings.
Review URL: http://codereview.chromium.org/343069
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30671 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30670 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
gcc-4.4 produces the warning "declaration does not declare anything", which becomes an error due to -Werror.
BUG=26413
Review URL: http://codereview.chromium.org/343072
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30669 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is a backout of r30647, but also resurrects the change from
http://codereview.chromium.org/341022 to work around the crash that r30647
solved much more elegantly.
We can't really leave things broken on 10.6, though. I killed most of a
perfectly good Friday evening trying to figure out how to salvage r30647,
but the DeferredAutoreleasePool approach seems doomed without making private
calls.
This makes me really sad.
BUG=25857, 26399, 26402
TEST=Does it launch on Snow Leopard now? Does it crash when you close windows?
Review URL: http://codereview.chromium.org/339095
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30668 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TEST=built chrome-os and non- binaries and made sure they worked as expected
Review URL: http://codereview.chromium.org/342069
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30667 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30666 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
shown for the first timeBUG=26312
TEST=DevToolsSanityTest.TestScriptsTabIsPopulatedOnInspectedPageRefresh
Review URL: http://codereview.chromium.org/341057
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30664 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We now always walk the last active list backwards rather than consulting the last active then walking the registered browser list forwards. I now also maintain a fallback to walk the entire registered list of browsers forward if the active scan fails. This is likely only in a testing environment where a Browser may never have been activated.
This ensures that when the last active browser is a popup or app frame the last active TYPE_NORMAL browser is located when opening a new tab.
http://crbug.com/17498
TEST=Open an app frame. Open a browser window (Ctrl+N) and load a page. Minimize it. Open another browser window and minimize it. Activate the app frame. Press Ctrl+T. The second browser window should be restored and have a new tab added to it rather than the first.
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30531
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30659
Review URL: http://codereview.chromium.org/330013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30662 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30661 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
code.
BUG=25318
TEST=none
Review URL: http://codereview.chromium.org/339093
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30660 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
this pass without crashing in browser_tests. It makes the code uglier, but I want to debug and figure out what's going on.
Rework the way the FindBrowserWithProfile/Type methods work.
We now always walk the last active list backwards rather than consulting the last active then walking the registered browser list forwards.
This ensures that when the last active browser is a popup or app frame the last active TYPE_NORMAL browser is located when opening a new tab.
http://crbug.com/17498
TEST=Open an app frame. Open a browser window (Ctrl+N) and load a page. Minimize it. Open another browser window and minimize it. Activate the app frame. Press Ctrl+T. The second browser window should be restored and have a new tab added to it rather than the first.
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30531
Review URL: http://codereview.chromium.org/330013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30659 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
failures.
BUG=none
TEST=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30658 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/342072
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30657 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
an options to navigate rather than searching. Original patch by Thiago Farina (see http://codereview.chromium.org/326026 ), r=me.
BUG=1978
TEST=Highlight "google.com" and right-click.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30656 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=atwilson
BUG=none
TEST=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30655 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
DesktopNotificationService layer into one common module.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/343066
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30652 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
I'm submitting this as a separate CL so that the binary file lands and
that I can get good try server results.
TBR=mpcomplete
Review URL: http://codereview.chromium.org/339091
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30650 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=26258
TEST=Border color of location bar matches the buttons on each side.
Review URL: http://codereview.chromium.org/348029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30648 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
autorelease pool in our run loop source if there is one already on the stack
above us. This allows Cocoa to clean up all the objects at the same time as it
expects to do. There may be more "interesting" code that can be removed now
that this is in. Initially we were going to implement it by checking the
nesting levels of the runloops, but it turns out by the time sendEvent is
called at the upper level we are already out of the "CFRunloopRun" call so
our nesting count isn't a valid indicator of our state.
TEST=1) See bug 25857. 2) Start up. Open 3+ windows. Quit.
BUG=25857
Review URL: http://codereview.chromium.org/343024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30647 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In theory this should result in a slightly faster app startup.
I will do a follow up change to merge it on Windows and get rid of
the code related to the extra file.
BUG=24035
Review URL: http://codereview.chromium.org/344038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30644 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This re-plumbs the existing "TooNew" codepath to handle arbitrary error messages.
BUG=25822
TEST=Make your history files non-readable, run Chrome (Release), make sure you get a warning dialog.
Review URL: http://codereview.chromium.org/342048
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30642 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
for messages recieved after the render view host has been NULLed, causing
crashers with select drop-downs.
BUG=25290
TEST=Make sure select drop-downs work and don't crash the browser.
Review URL: http://codereview.chromium.org/348022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30641 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
explicitly call Stop() in destructor (before the vtable is torn down) since we override CleanUp().
Filed bug to make this impossible in the future: http://code.google.com/p/chromium/issues/detail?id=26365
TEST=DOMStorageTests UI tests don't fail.
BUG=25413,25746
Review URL: http://codereview.chromium.org/345028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30638 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=25822
TEST=Make your History files non-readable, run Chrome (Release), Type in "test.com" and see that the selected action is navigation.
Review URL: http://codereview.chromium.org/343051
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30633 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fall abck to the system default font if the preferred font isn't available.
Also, only create the SkPaint struct once, not on every paint.
Also, make some more things const.
BUG=25693
TEST=badge still looks good, that crash goes away
Review URL: http://codereview.chromium.org/341045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30631 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I tried to just piggy-back off of existing chrome client calls (particularly focus()), but that didn't handle blurs.
webkit side is here: http://codereview.chromium.org/328034/show
BUG=453
original review: http://codereview.chromium.org/337032/show
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30629 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
NPP_Destroy.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/338050
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30628 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=arthropod
TEST=none
Review URL: http://codereview.chromium.org/340046
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30625 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=23993
TEST=Open incognito window. Click the bookmark sync button. Either the signin dialog
or the options panel should open.
Review URL: http://codereview.chromium.org/350005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30624 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=26274
TEST=grant notifications permissions and restart browser
Review URL: http://codereview.chromium.org/339077
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30623 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
is just cleanup.
Take 2 with a fix in sync code.
TBR=evanm
Review URL: http://codereview.chromium.org/350007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30622 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
file used to build the html documentation is unreadable or has a syntax error, gives a clear error message.
BUG=18717
TEST=Manualy tested a missing input file and a file with a syntax error.
Review URL: http://codereview.chromium.org/343052
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30620 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
of HtmlDialogView.
Added TODO to fix inaccurate font height metric for OS X font class (and maybe width).
Added the BrowserCommandExecutor protocol so that not just a
BrowserWindowController can be the window controller for a
ChromeEventProcessingWindow.
Added unittests. Also tested manually with the bookmark sync setup
wizard dialog.
BUG=23073
TEST=added unittests, trybot, and manual testing
Review URL: http://codereview.chromium.org/344008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30619 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=25620
TEST=Close all windows, try History->History (Cmd-Y); close window, try Window->Downloads (Shift-Cmd-J); close window, try Open Location... (Cmd-L).
Review URL: http://codereview.chromium.org/329004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30615 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Linux and OSX.
BUG=none
TEST=Enable bookmark sync, close and re-launch chrome, make sure there are no sync error message at the bottom of the NTP.
Original patch by albertb@chromium.org
Committed by davemoore@chromium.org
Review URL: http://codereview.chromium.org/341012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30611 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/339085
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30608 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
wasn't actually hooked to anything. Seems better to not have it than to have it look like it's doing something when it isn't.
BUG=25336
TEST=none
Review URL: http://codereview.chromium.org/347024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30607 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/340041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30606 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Don't fake the border with event boxes, but instead use the theme images.
BUG=26258
TEST=In default theme, make sure find bar border now looks like windows.
Review URL: http://codereview.chromium.org/341055
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30605 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/343044
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30603 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
This reverts commit r30594.
Review URL: http://codereview.chromium.org/342062
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30600 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Added initial interface hooks betweek WebKit code and renderer-side worker code.
The proper messages are generated to fire off a shared worker, but they are currently
ignored by the browser process.
BUG=26233
TEST=none (will enable layout tests when basic functionality available)
Review URL: http://codereview.chromium.org/340036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30599 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
permitting the tests to be run regardless of the underlying platform. Also some minor fixes and cleanup.
BUG=none
TEST=none
Original review at: http://codereview.chromium.org/329037
Review URL: http://codereview.chromium.org/345027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30598 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=25932
TEST=None
Review URL: http://codereview.chromium.org/347009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30597 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Singleton. This is just cleanup.
Review URL: http://codereview.chromium.org/339078
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30594 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
* It simply says it's not supported as ChromeOS wont launch external program.
Fixed resource files to use chromeos. Apparently I misunderstood how this works when I added 'toolkit_views' to grd files. It was never defined, and wasn't necessary.
BUG=23853
TEST=type in "apple.cm" in the omnibox and it should popup the external protocol dialog.
Review URL: http://codereview.chromium.org/342040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30593 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
build.
BUG=arthropod
TEST=build with mac_sdk=10.6
Review URL: http://codereview.chromium.org/345026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30591 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG= http://crbug.com/26325
TEST= none
Review URL: http://codereview.chromium.org/348024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30590 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
FilePath::FromWStringHack.
Patch by tfarina.
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/334017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30584 0039d316-1c4b-4281-b951-d872f2087c98
|