summaryrefslogtreecommitdiffstats
path: root/chrome
Commit message (Collapse)AuthorAgeFilesLines
* A small refactor of the toolbar background.tc@google.com2009-07-232-12/+2
| | | | | | | | | | I'm not sure in what cases SetProfile will be called to change the profile, but this seems to handle that possible case. Review URL: http://codereview.chromium.org/159282 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21457 0039d316-1c4b-4281-b951-d872f2087c98
* linux: generalize desktop environment guessing to encompass KDEevan@chromium.org2009-07-231-16/+26
| | | | | | | | BUG=17363 Review URL: http://codereview.chromium.org/159297 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21455 0039d316-1c4b-4281-b951-d872f2087c98
* Pass input string parameters by reference.jhawkins@chromium.org2009-07-231-6/+6
| | | | | | | | | CID=5116 BUG=none TEST=none Review URL: http://codereview.chromium.org/160052 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21454 0039d316-1c4b-4281-b951-d872f2087c98
* linux: show the manpage on -h or --helpevan@chromium.org2009-07-231-0/+10
| | | | | | Review URL: http://codereview.chromium.org/160026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21450 0039d316-1c4b-4281-b951-d872f2087c98
* Bookmark bar: Don't connect to the OnDragDrop signal since we can just use ↵estade@chromium.org2009-07-232-24/+0
| | | | | | | | | | | | | the default. Eventually we may want to allow dropping more different types, and we will need to implement an OnDragDrop handler so we can properly prioritize these types (preferring BOOKMARK_ITEM over TEXT_PLAIN and so forth). But for now we can just use the default handler. BUG=17501 TEST=drag an image onto the bookmark bar, note that there is only one link created Review URL: http://codereview.chromium.org/159256 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21448 0039d316-1c4b-4281-b951-d872f2087c98
* Close pop up notification when navigating to other site.erg@google.com2009-07-231-0/+6
| | | | | | | | | | | | | When BlockedPopupContainer stopped being a ConstrainedWindow, the notification stopped being cleared in TabContents::MaybeCloseChildWindows. http://crbug.com/8622 http://crbug.com/14150 TEST=See 8622 for repro steps. Review URL: http://codereview.chromium.org/159287 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21445 0039d316-1c4b-4281-b951-d872f2087c98
* Headers cleanup:phajdan.jr@chromium.org2009-07-2326-14/+43
| | | | | | | | | - reduce header dependencies by using bookmark_model_observer.h - replace #include <iostream> by #include <iosfwd> in headers Review URL: http://codereview.chromium.org/159280 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21444 0039d316-1c4b-4281-b951-d872f2087c98
* gtk: Fix the case where a user quickly moves the mouse away from a dragged tabjhawkins@chromium.org2009-07-236-3/+33
| | | | | | | | | | | | | causing gtk to stop generating motion-notify-event signals. In this case, a call to gtk_grab_add lets gtk clean up the drag for us. BUG=16509 TEST=Quickly move the mouse away from a dragged tab (up and left works best). The drag will end and a new window will open. The dragged tab window should not still exist. Review URL: http://codereview.chromium.org/159290 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21440 0039d316-1c4b-4281-b951-d872f2087c98
* Fixing the crash signature for masksuperblitter.huanr@chromium.org2009-07-231-1/+1
| | | | | | Review URL: http://codereview.chromium.org/159291 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21439 0039d316-1c4b-4281-b951-d872f2087c98
* This CL adds an infobar instructing users they can do search directly from ↵jcampan@chromium.org2009-07-2314-7/+355
| | | | | | | | the location bar when they navigate to their default search engine.The infobar is dismissed and not shown again if the user does a search from the omnibox or dismiss the infobar.This is part of a UX experiment and is behind a switch.BUG=NoneTEST=Start Chrome with a fresh profile. Navigate to www.google.com. An info bar should be shown. Click the 'show me' button, the location bar should display a message explaining search can be made from it. Review URL: http://codereview.chromium.org/159242 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21438 0039d316-1c4b-4281-b951-d872f2087c98
* CPAPI (0.11) for gears drag drop.mpcomplete@chromium.org2009-07-239-11/+92
| | | | | | | | | | | | Provide a method that allows the gears plugin to ask the browser process to verify that its renderer has permission to access the drop files. Update the copyright notices. BUG=7995 Review URL: http://codereview.chromium.org/159074 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21437 0039d316-1c4b-4281-b951-d872f2087c98
* Disables BookmarkHTMLWriterTest for now, since it is very flaky on Windows. ↵klink@chromium.org2009-07-231-1/+1
| | | | | | | | | | | Will talk to Scott when he comes back from vacation to get this re-enabled. BUG=None TEST=None Review URL: http://codereview.chromium.org/159225 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21435 0039d316-1c4b-4281-b951-d872f2087c98
* Make tabs go all the way to the right edge and stop using less of the strip ↵pinkerton@chromium.org2009-07-239-26/+218
| | | | | | | | | | as more tabs are added. Don't resize on selection when tabs are very small, except just enough to show a close box. Clip closebox and favicon as tab gets very small. Fix z-order to be consistent among all unselected tabs. Fix incognito man disappearing when dragging window via the tab. Tabs can now get about as small as they do on windows allowing many more to fit. BUG=14911, 14913, 17372 TEST=adding and removing lots of tabs and making sure nothing goes wrong. Review URL: http://codereview.chromium.org/159206 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21432 0039d316-1c4b-4281-b951-d872f2087c98
* Make chrome icon the same size as the chromium onepinkerton@chromium.org2009-07-231-0/+0
| | | | | | | BUG=13516 TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21431 0039d316-1c4b-4281-b951-d872f2087c98
* Allow two user level installs of Chrome to have default browser settings.kuchhal@chromium.org2009-07-239-402/+522
| | | | | | | | | | | | | | | | | | | | | | This change will allow two Windows users to install thier own copy of Chrome and set it as default browser. There is a bunch of refactoring in this change. - Divided the registry entries into three categories: * Entries that are only read from HKLM * Entries that actually tie file/protocol associations to Chrome. This will almost always be in HKCU (except when it is a OEM install). * Entries that we can create in HKCU if we fail to create them in HKLM. - For single user machine nothing should change. - For two users on the same machine (each with a different user level Chrome installed), the second user's default browser will get renamed to Chromium.<user> and the required registry entries will also be renamed so that they do not overwrite first users's registry entries. BUG=3641 TEST=Install and set Chromium as default browser from two different logins on the same machine for various combinations of XP/Vista, admin users/non admin user, user-level install/system-level install. Review URL: http://codereview.chromium.org/159172 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21428 0039d316-1c4b-4281-b951-d872f2087c98
* Put the new ZIP data file in a separate CL because "gcl try" does not supportcevans@chromium.org2009-07-231-0/+0
| | | | | | | | | | | data files, and I want a clean try of the actual code changes before I submit :) BUG=NONE TEST=NONE Review URL: http://codereview.chromium.org/159281 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21427 0039d316-1c4b-4281-b951-d872f2087c98
* Adds the --diagnostics switchcpu@google.com2009-07-232-0/+5
| | | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/159278 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21425 0039d316-1c4b-4281-b951-d872f2087c98
* Don't add the QuickLaunch shortcut by default in Windows7cpu@google.com2009-07-232-4/+10
| | | | | | | | | | BUG=17401 TEST=none Review URL: http://codereview.chromium.org/159244 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21424 0039d316-1c4b-4281-b951-d872f2087c98
* Trying to turn the reliability bots green.senorblanco@chromium.org2009-07-231-0/+2
| | | | | | | | | | | Put recent skia failures into known_crashes.txt. BUG=http://crbug.com/17569 TEST=Check that the reliability bot goes green. Review URL: http://codereview.chromium.org/160030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21422 0039d316-1c4b-4281-b951-d872f2087c98
* Fix issue where dragging window via a tab would incorrectly dim chrome when ↵pinkerton@chromium.org2009-07-232-0/+4
| | | | | | | | | | there were no other windows as drag targets, but only the first time. BUG=11125 TEST=dragging tabs in and out of windows should show consistent feedback. Review URL: http://codereview.chromium.org/160018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21421 0039d316-1c4b-4281-b951-d872f2087c98
* Fix bug 15795: make the capslock indicator in password fields (on Mac) work.avi@chromium.org2009-07-231-0/+4
| | | | | | | | | | | | | | | (Hook up WebKit's Frame::eventHandler()->capsLockStateMayHaveChanged() in WebViewImpl::KeyEvent() and -flagsChanged: to -keyEvent: in BaseView.) Patch from viettrungluu@gmail.com. BUG=http://crbug.com/15795 TEST=go to some password field (e.g., in gmail login), cycle capslock Review URL: http://codereview.chromium.org/159215 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21420 0039d316-1c4b-4281-b951-d872f2087c98
* Add support to URLRequest for deferring redirects.darin@chromium.org2009-07-236-13/+6
| | | | | | | | | | | | | | | | | | | | I chose to add an out parameter to OnReceivedRedirect because it allows for the default behavior to remain the same. I considered adding a ContinueAfterRedirect method that all OnReceivedRedirect implementations would need to call, but this caused one annoying problem: In the case of a ChromePlugin, it is possible for the URLRequest to get deleted inside the handler for the redirect. This would make it hard to subsequently call a method on the URLRequest since I would need to have a way to determine if the URLRequest had been deleted. TEST=covered by unit tests BUG=16413,6442 R=eroman,wtc Review URL: http://codereview.chromium.org/155897 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21417 0039d316-1c4b-4281-b951-d872f2087c98
* Disable worker tests for debug builds.darin@chromium.org2009-07-231-0/+11
| | | | | | | | | | BUG=17572 TEST=none TBR=levin Review URL: http://codereview.chromium.org/160029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21414 0039d316-1c4b-4281-b951-d872f2087c98
* Unrevert 21355 because the revert might be causing thensylvain@chromium.org2009-07-2326-353/+208
| | | | | | | | worker tests failures. Review URL: http://codereview.chromium.org/159276 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21412 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: Select omnibox text on button release instead of press.agl@chromium.org2009-07-232-26/+62
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We also don't select all of the text if the user dragged to highlight some text before releasing the button. Tested by repeating the scenarios from: http://codereview.chromium.org/151006 http://codereview.chromium.org/159185 plus checking that the following cases behave as expected: 1. Type some text into the omnibox. Click in Webkit to give it the focus. Click once in the omnibox. All of its text should be highlighted, and middle-clicking in another window should show that the primary selection was updated. 2. Click in the omnibox to clear its highlighted text and click in Webkit again. Click in the omnibox again, but this time drag to highlight some text before letting go of the button. The highlighted text should be preserved on button release, and the primary selection should be updated. 3. Repeat step 2. Click a few times in the omnibox and confirm that we don't select all of its text (that should only happen at the end of the initial click that focuses the omnibox). (Patch from Dan Erat) http://codereview.chromium.org/155971 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21410 0039d316-1c4b-4281-b951-d872f2087c98
* Have UtilityProcessHostTest wait until the utility process dies beforempcomplete@chromium.org2009-07-231-2/+37
| | | | | | | | | | | finishing. This is an attempt to fix a memory leak. BUG=17387 TEST=no Review URL: http://codereview.chromium.org/155895 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21409 0039d316-1c4b-4281-b951-d872f2087c98
* Squash the "Confirm Form Repost" dialog triggered via an external context ↵robertshield@chromium.org2009-07-233-2/+21
| | | | | | | | | | menu reload - the dialog is modal, but there may not be anything for it to be modal to. This is a shorter term fix - a longer term fix will be to change the way the dialog is displayed and allow it to be routed through automation. Review URL: http://codereview.chromium.org/160010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21400 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes a couple gyp configuration issues with ipc_tests.agl@chromium.org2009-07-231-3/+1
| | | | | | | | | | | | | | | | | Adds ipc/ipc.gyp:* to the windows-only 'pull_in_all' target in chrome.gyp so that it's built on the windows builders and removes the dependency from unit_tests onto ipc/ipc.gyp:ipc_tests. Renames file_descriptor_set_unittest.cc to file_descriptor_set_posix_unittest.cc to match the .h/.cc files and so that it gets picked up by the exclusion filter properly. (Patch from James Robinson) http://codereview.chromium.org/159272 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21399 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 21355 because it might be causing all the newnsylvain@chromium.org2009-07-2326-208/+353
| | | | | | | | | | | | crashes on reliability. It also seems to be causing valgrind error. Original change: Switch the first thread in a child process to be the main thread, and make theIO thread be the second thread. The change is needed for plugins on mac. Review URL: http://codereview.chromium.org/159274 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21398 0039d316-1c4b-4281-b951-d872f2087c98
* (Identical to 159254 which I had in a messed up client)cevans@chromium.org2009-07-231-1/+1
| | | | | | | | | | | | | | Fix an off-by-one in the zip filename reading code. It's pretty harmless, and caused by a fairly lousy minizip API. It could lead to an out-of-bounds read due to lack of null termination. No way to reliably test. BUG=NONE TEST=NONE Review URL: http://codereview.chromium.org/155984 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21397 0039d316-1c4b-4281-b951-d872f2087c98
* Adds the drag over animation.arv@google.com2009-07-232-39/+124
| | | | | | | | | | | | | | | When we drag over a thumbnail we move the drop target 15px towards the location it would be if we dropped the source. BUG=14961 TEST=Drag a thumbnail. When dragging over an item the item should move towards the location of where the source came from. Review URL: http://codereview.chromium.org/155978 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21396 0039d316-1c4b-4281-b951-d872f2087c98
* GTK Themes: Use the GTK close button in the download shelf and popup ↵erg@google.com2009-07-237-23/+29
| | | | | | | | notification. Review URL: http://codereview.chromium.org/155939 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21394 0039d316-1c4b-4281-b951-d872f2087c98
* Propagate theme changes to the tabstrip.avi@chromium.org2009-07-234-1/+12
| | | | | | | | | BUG=http://crbug.com/17519 TEST=change themes; tabs should theme too Review URL: http://codereview.chromium.org/159271 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21393 0039d316-1c4b-4281-b951-d872f2087c98
* Re-enable some focus UI tests. These failed for unknown reasons with a funnybrettw@chromium.org2009-07-231-4/+2
| | | | | | | | | | error from the notification service. This error seems to be fixed. BUG=15265 Test=This is a test Review URL: http://codereview.chromium.org/155858 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21392 0039d316-1c4b-4281-b951-d872f2087c98
* Add a correct include for the IPC switches.brettw@chromium.org2009-07-231-0/+1
| | | | | | | | TEST=none Review URL: http://codereview.chromium.org/160016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21391 0039d316-1c4b-4281-b951-d872f2087c98
* Fix liner errors due to duplicate symbols in the switches. These switchesbrettw@chromium.org2009-07-239-17/+7
| | | | | | | were moved to IPC, but the source ones in chrome/common were kept. Review URL: http://codereview.chromium.org/160014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21389 0039d316-1c4b-4281-b951-d872f2087c98
* Adding an image that will be used for the omnibox hint infobar.jcampan@chromium.org2009-07-232-0/+1
| | | | | | | | BUG=None TEST=None Review URL: http://codereview.chromium.org/159249 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21388 0039d316-1c4b-4281-b951-d872f2087c98
* Correctly account for windows of different sizes when snapping windows ↵pinkerton@chromium.org2009-07-231-2/+9
| | | | | | | | | | together during a drag. BUG=16386 TEST=dragging together windows of different sizes. Review URL: http://codereview.chromium.org/159270 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21386 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: Change js flags apply order: first ours, then from command line.mnaganov@chromium.org2009-07-231-6/+6
| | | | | | | | | | This allows to redefine flags (e.g. 'logfile') for debugging purposes. BUG=none TEST=none Review URL: http://codereview.chromium.org/160003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21385 0039d316-1c4b-4281-b951-d872f2087c98
* Increase the close button offset so the text doesn't overlap it.pinkerton@chromium.org2009-07-231-3/+1
| | | | | | | | BUG=13300 TEST=see bug. Review URL: http://codereview.chromium.org/159269 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21381 0039d316-1c4b-4281-b951-d872f2087c98
* Call setlocale(LC_ALL, "") in a renderer process for subsequent calls tojshin@chromium.org2009-07-231-0/+3
| | | | | | | | | | | | | | | SysNativeMBToWide and WideToSysNativeMB (that use mbstowcs and wcstombs) to work correctly. This is a clone of http://codereview.chromium.org/155913 BUG=16860 (http://crbug.com/16860 ) TEST=Run Chrome with LC_ALL=en_US.UTF-8 and try to upload a file whose name contains non-ASCII characters in UTF-8 (e.g. "café.txt" or "一二.txt" ) . The filename field in a form should be populated with the name (rather than empty). Review URL: http://codereview.chromium.org/159221 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21380 0039d316-1c4b-4281-b951-d872f2087c98
* Don't install the incognito badge in anything other than a normal browser ↵pinkerton@chromium.org2009-07-231-0/+3
| | | | | | | | | | window. BUG=17531 TEST=incognito man doesn't show up in popups, but does in main windows. Review URL: http://codereview.chromium.org/159267 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21379 0039d316-1c4b-4281-b951-d872f2087c98
* Unbreak extension installation. Cleanup accidentally reversedaa@chromium.org2009-07-231-1/+1
| | | | | | | | | boolean logic. Difficult to test because this is way up close to the UI. Review URL: http://codereview.chromium.org/160002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21376 0039d316-1c4b-4281-b951-d872f2087c98
* back out CLs 21367, 21366 - no idea why these keep breakingdpranke@google.com2009-07-232-0/+376
| | | | | | Review URL: http://codereview.chromium.org/155983 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21371 0039d316-1c4b-4281-b951-d872f2087c98
* Build fix: ipc_tests.exe is not getting built for Windows release.agl@chromium.org2009-07-231-0/+4
| | | | | | | | | | | | | | | | | | | | | | | | (Broke in r21342) <jamesr> agl: chromium XP release builder builds chrome.sln and then tries to run ipc_tests.exe. nothing in chrome.gyp depends on ipc_tests now so the executable doesn't exist on that builder <jamesr> agl/jrg: adding a dependency on ../ipc/ipc.gyp:ipc_tests to the 'coverage' target would solve both issues <jrg> jamesr: agl's change will only impact the coverage bots. Sounds like that't not what you want, right? <jamesr> jrg: i think it's correct but won't resolve the chromium XP issue. coverage should run for those tests either way <agl> jamesr: how about I tie it to unit_tests? <agl> jamesr: there's a long term solution and then there's getting the builder green. <jamesr> agl: yeah. trying to check super fast if getting that builder to not run ipc_tests.exe is easy http://codereview.chromium.org/155977 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21369 0039d316-1c4b-4281-b951-d872f2087c98
* re-do CL 21252 - move image_diff to tools, add deps to test_shelldpranke@google.com2009-07-232-376/+0
| | | | | | | | | | | | | | | CL 21252 seems to have had some svn brokenness (not sure why). I've recreated it and resubmitted it. The changes are to move image_diff from chrome/tools/test to tools/, and to make test_shell depend on image_diff and npapi_layout_test_plugin (and test_worker, where applicable) R=nsylvain@chromium.org TEST=none BUG=none Review URL: http://codereview.chromium.org/155959 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21366 0039d316-1c4b-4281-b951-d872f2087c98
* Tweak thumbnail sizes a bit so it the NNTP looks better side by side onarv@google.com2009-07-235-21/+23
| | | | | | | | | | | | | | | | | | a 1920x1200 screen. Also, tweak the default size of new windows slightly. In case we decide to use side by side windows size the window in such a way that 2 windows fit on the screen and have the kWindowTilePixels spacing between each other and the screen edges. BUG=None TEST=Show two windows side. On a 1920x1200 screen they should both be showing the thumbnails in normal size. Review URL: http://codereview.chromium.org/155930 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21364 0039d316-1c4b-4281-b951-d872f2087c98
* Fix undefined object properties showing up in reference pages.rafaelw@chromium.org2009-07-231-4/+7
| | | | | | Review URL: http://codereview.chromium.org/159231 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21362 0039d316-1c4b-4281-b951-d872f2087c98
* Switch the first thread in a child process to be the main thread, and make ↵jam@chromium.org2009-07-2326-353/+208
| | | | | | | | theIO thread be the second thread. The change is needed for plugins on mac. Review URL: http://codereview.chromium.org/155944 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21355 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the NOTIMPLEMENTED from IsDefaultPluginEnabled for Macstuartmorgan@google.com2009-07-231-1/+1
| | | | | | | | | BUG=17392 TEST=Less console spew on test bots. Review URL: http://codereview.chromium.org/155881 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21351 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-13 12:58:07 +0000