| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
| |
Handle registration events properly.
BUG=34647
TEST=new unittests
Review URL: http://codereview.chromium.org/2861034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51230 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
It seems we can use this function in other environments.
BUG=47277
TEST=none
Review URL: http://codereview.chromium.org/2807029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51227 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=32413
TEST=manual
Review URL: http://codereview.chromium.org/2833042
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51226 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
several tests to fail their SaveChanges()es. Add unit test for the DBS migrations.
BUG=47466
TEST=sync_unit_tests (and included new tests).
Review URL: http://codereview.chromium.org/2830027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51225 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
I'll use the function to implement crosbug.com/2619 (Implement input language selector on the log in page)
BUG=none
Review URL: http://codereview.chromium.org/2861022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51220 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/2817042
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51218 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
remoting/remoting.gyp.
BUG=none
TEST=compiles
Review URL: http://codereview.chromium.org/2885005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51216 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=47843,47863
TEST=unittests, valgrind
Review URL: http://codereview.chromium.org/2872024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51215 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
original review: http://codereview.chromium.org/2885006
----------
This is almost certainly caused by a start-up or shut-down race, but CreateWindowValue doesn't have much meaning without a window attached to the browser, so just return an error in those cases
BUG=47808
TEST=none.
TBR=asargent
Review URL: http://codereview.chromium.org/2858036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51213 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/2805047
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51206 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Depends on http://codereview.chromium.org/2815034
BUG=45546
TEST=Open content settings dialog. Should have a list on the left instead of tabs on top. Other than that, the dialog should work as before.
Review URL: http://codereview.chromium.org/2799042
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51205 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
new tab page.
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/2886002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51204 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Changed grit to support generic <!--include file="..."--> tag in html files to support the scenario above.
TEST=make sure chrome:options page still shows correctly
BUG=chromium-os:4429
Review URL: http://codereview.chromium.org/2835009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51203 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=46075
TEST=see bug
Review URL: http://codereview.chromium.org/2828014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51202 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Stops using buttons for menu items so that it doesn't conflict with the
button.css file. Added a BOOL_ATTR disabled property so the attribute is set on
the element. It was originally not being set and not being styled as disabled.
BUG=NONE
TEST=NONE
Review URL: http://codereview.chromium.org/2863031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51201 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
These changes make it so that individual fields are filled with the value selected from
the input element popup menu. AutoFill profile data is not queried in this case.
BUG=44618, 47917
TEST=RenderViewTest.SendForms, RenderViewTest.FillFormElement
Review URL: http://codereview.chromium.org/2808036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51200 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
show update link for out-of-date ones.
Tracking patch by mavrommatis, original review here:
<http://codereview.chromium.org/1991005>
Original description follows:
(1) Group plugins with the same name together. (2) Show a download link for
plugin versions with known security problems in about:plugins.
BUG=3910
TEST=Open "chrome://plugins", see that plugins are grouped, and that any vulnerable plugins are marked red. Try enabling and disabling plugin groups.
Review URL: http://codereview.chromium.org/2835018
TBR=bauerb@chromium.org
Review URL: http://codereview.chromium.org/2805048
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51191 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/2862037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51190 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
changed about:cache to redirect to chrome://view-http-cache instead
of chrome://about/cache.
TEST=Go to about:about and click on about:cache, check that it works
BUG=44699
Review URL: http://codereview.chromium.org/2860038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51182 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=Test printing from Chrome PDF plugin on Linux.
Review URL: http://codereview.chromium.org/2807027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51181 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Move Save, SaveLayerAlpha and Restore onto gfx::Canvas.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2846035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51179 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=34647
TEST=manual
Review URL: http://codereview.chromium.org/2817037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51178 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
end-to-end test later.
BUG=6787,47318
TEST=protocol_manager_unittest.cc
Review URL: http://codereview.chromium.org/2868030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51177 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=47781
TEST=enable sync. close chrome. open chrome. verify sync is working (e.g. by adding a bookmark and watching it sync to another client). sync_integration_tests also cover this.
Review URL: http://codereview.chromium.org/2824037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51175 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
can be loaded on the Mac without modifying the application bundle.
BUG=47305
TEST=Mac plugin tests still run. No PlugIns directory created in the app bundle.
Review URL: http://codereview.chromium.org/2814030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51174 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Green the tree while I work on fixing it.
BUG=none
TEST=tree goes green
TBR=stuartmorgan
Review URL: http://codereview.chromium.org/2825029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51170 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is almost certainly caused by a start-up or shut-down race, but CreateWindowValue doesn't have much meaning without a window attached to the browser, so just return an error in those cases
BUG=47808
TEST=none
Review URL: http://codereview.chromium.org/2885006
TBR=rafaelw@chromium.org
Review URL: http://codereview.chromium.org/2868039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51165 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Removes the addition of NonThreadSafe and DCHECKs to CookieMonster.
BUG=44083
Review URL: http://codereview.chromium.org/2845031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51164 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2842033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51163 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:4294 (http://code.google.com/p/chromium-os/issues/detail?id=4294)
TEST=unable to repro, likely an edge case
Review URL: http://codereview.chromium.org/2809043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51162 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This is almost certainly caused by a start-up or shut-down race, but CreateWindowValue doesn't have much meaning without a window attached to the browser, so just return an error in those cases
BUG=47808
TEST=none
Review URL: http://codereview.chromium.org/2885006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51161 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=33443
TEST=existing tests apply
Review URL: http://codereview.chromium.org/2833037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51160 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
take out the ability to access the clipboard since it's not exposed to HTML for security reasons.
Review URL: http://codereview.chromium.org/2841028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51159 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
syncer thread has not yet been started or it has been started and is waiting for a connection.
From an API standpoint, the caller of SyncerThread::Pause and SyncerThread::Resume should not need to consider if the thread is already running. The channel responses (PAUSED and RESUMED) should be the same regardless. Furthermore, edge cases like "pause before thread is started and resume after thread is started" should be handled correctly.
This change is supposed to be fixing various offline startup problems we've been having and it includes a new integration test for this. However, it is not yet complete but we might need to check this is before it is ready.
TEST=unit
BUG=45814
Review URL: http://codereview.chromium.org/2814014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51158 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Started out just trying to change PrefService::GetString and ::SetString. This snowballed a little bit. Had to change a bunch of url strings in search_engines/ from wstring to string (some of them may be better off as GURLs, but UTF-8 is a step in the right direction, since that's what GURL uses internally, as well as externally via its setters/getters).
TODO (later patch): things that ask for accepted languages should use std::string, not std::wstring.
BUG=none
TEST=try bots
Review URL: http://codereview.chromium.org/2854015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51157 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
if it exceeds its window's height.
Review URL: http://codereview.chromium.org/2834029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51156 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=47241
TEST=Navigate between a few folders and then click on the right pane. Now hit Cmd+A.
Review URL: http://codereview.chromium.org/2832034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51155 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
when pressed, leaving "standard" buttons (like used on the toolbar) to darken as expected.
BUG=44574
TEST=test bookmark buttons and toolbar buttons with different themes, make sure the appearance isn't crappy
Review URL: http://codereview.chromium.org/2866031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51154 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
upstream. This is guaranteed to work as the HTML5DocumentParser class has since
been renamed to HTMLDocumentParser.
BUG=47080
TEST=None
Review URL: http://codereview.chromium.org/2807030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51152 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
TBR=erikkay
BUG=47575
TEST=Greener bot
Review URL: http://codereview.chromium.org/2822037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51151 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Adding extra buttons on the translate infobar to let user easily set the "never/always translate this language" property when they declined/accepted translation for a language more than 3 times.
Original review:
http://codereview.chromium.org/2825015/show
BUG=NONE
TEST=Visit a page in a foreign language, translate the page. Repeat 4 times. On the fourth time, the "before translate" infobar should show a button that says "always translate".
Similarly when declining translations 4 times.
Review URL: http://codereview.chromium.org/2835025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51148 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
There's still discussion about the design for this, so to minimize breakage on the dev channel, I'm backing the check out temporarily.
BUG=47675,45542
Review URL: http://codereview.chromium.org/2815035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51146 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=47797
TEST=Open a new window, create 4 NTP tabs and 1 navigated tab. Close the window. The History menu has a "1 Tab" submenu with the navigated page.
Review URL: http://codereview.chromium.org/2800032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51145 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2821018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51144 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
when mouse is inside. Fix to gradient button to not show border on mouseover when disabled. Adjust "overlap" between the toolbar and bookmark bar to allow for larger buttons w/out clipping.
Nib change: All buttons changed to not bordered, button cell tags are 0. Buttons are 31x31 and spread out a bit more.
BUG=44574
TEST=toolbar and bookmark bar appearance, hidden, always showing, and detached on NTP.
Review URL: http://codereview.chromium.org/2806041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51143 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=34647
TEST=none
Review URL: http://codereview.chromium.org/2836032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51140 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
of its children.
I made the parent_ pointer a WeakPtr. It is correct to not free the offscreen texture ID if the parent is destroyed first. It is freed as part of the parent's destruction.
TEST=trybot
BUG=47594
Review URL: http://codereview.chromium.org/2882004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51139 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
are bad.
BUG=44797
TEST=make sure control-alt-b doesn't work.
Review URL: http://codereview.chromium.org/2885003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51138 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=47809
TEST=notifications on windows
Review URL: http://codereview.chromium.org/2861035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51137 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
TBR=erikkay
BUG=47575
TEST=Greener bots
Review URL: http://codereview.chromium.org/2887001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51136 0039d316-1c4b-4281-b951-d872f2087c98
|